Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215801 --- Ship it! Ship It! - Benjamin Bannier On June 7, 2019, 7:21 p

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-11 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215797 --- Ship it! Ship It! - Till Toenshoff On June 7, 2019, 5:21 p.m

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-11 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215793 --- src/slave/containerizer/mesos/launch.cpp Line 508 (original), 509

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-11 Thread Benjamin Bannier
> On June 7, 2019, 8:55 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/launch.cpp > > Line 508 (original), 509 (patched) > > > > > > For non-`__linux-_` cases this silently drops any configuration. W

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-11 Thread Andrei Budnik
> On Июнь 7, 2019, 6:55 п.п., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/launch.cpp > > Line 508 (original), 509 (patched) > > > > > > For non-`__linux-_` cases this silently drops any configuration. W

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215768 --- Patch looks great! Reviews applied: [70811] Passed command: expo

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215759 --- src/slave/containerizer/mesos/launch.cpp Line 508 (original), 509

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215755 --- Ship it! Ship It! - Gilbert Song On June 7, 2019, 10:21 a.m.

Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang