Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review219046 --- Ship it! Ship It! - Greg Mann On Dec. 16, 2019, 9:58 p.m.,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

> On Dec. 12, 2019, 4 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp > > Lines 439 (patched) > > > > > > Why not run these on the per-socket UPID also? The UPID is added next patch. And

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Dec. 16, 2019, 1:58 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review219020 --- 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 639-644

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review219009 --- 3rdparty/libprocess/src/ssl/openssl_socket.hpp Lines 60

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

> On Dec. 3, 2019, 7:23 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 506 (patched) > > > > > > What is the "configure callback"? Could you be more explicit/verbose > > here? >

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Dec. 10, 2019, 3:53 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

> On Dec. 2, 2019, 11:23 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 449 (patched) > > > > > > What do you mean "instead of in `accept`"? Aren't we in `accept` right > > now?

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review218881 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 449

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review218813 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 369

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Nov. 11, 2019, 11:40 a.m.) Review request for mesos, Benno Evers,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Nov. 5, 2019, 5:55 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Oct. 30, 2019, 6:33 p.m.) Review request for mesos, Benno Evers,