Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218986 --- Patch looks great! Reviews applied: [71878, 71879, 71880, 71881,

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/ --- (Updated Dec. 9, 2019, 5:48 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benjamin Bannier
> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 21 (patched) > > > > > > This doesn't seem to be necessary anymore? This is required for e.g., `CHECK_EQ` (now).

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-09 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218976 --- Fix it, then Ship it! 3rdparty/stout/include/stout/path.hpp

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218938 --- Bad patch! Reviews applied: [71878, 71879, 71880, 71881, 71882]

Review Request 71882: Added a stout function to compute relative paths.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062