Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

//reviews.apache.org/r/49225/#review139506 --- On June 25, 2016, 6:52 a.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139506 ------- On June 25, 2016, 6:52 a.m., Abhishek Dasgupta wrote: > > --

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49227: Updated proto files with comments.

/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49227/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.ReserveResources*" make -j4 check sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49226/#review139510 --- On June 27, 2016, 8:37 p.m., Abhishek Dasgupta wrote: > > ---

Review Request 49296: Added validation check on resources for reserve/unreserve call.

--- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*:*MasterAPITest.ReserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49206/diff/ Testing --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49296: Added validation check on resources for reserve/unreserve call.

://reviews.apache.org/r/49296/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*:*MasterAPITest.ReserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

or that : https://reviews.apache.org/r/49296/ - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139694 --- On June

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49206/diff/ Testing --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API.

="*MasterAPITest.RemoveQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49206/diff/ Testing --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API.

="*MasterAPITest.RemoveQuota*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

daf5672287bb6633f468c88632a561f5a01590df Diff: https://reviews.apache.org/r/49444/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

a5a1b86e14f63e5e3834a2900270252fbe16f586 src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49443: Include a function to construct FileInfo protobuf message.

040bdf82134289f0caf63e11c2ce8e7853a392b3 Diff: https://reviews.apache.org/r/49443/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

48f15173fe62b9ce7f648f6b54d74ec62f797c55 src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 Diff: https://reviews.apache.org/r/49447/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49448: Added testcases for LIST_FILES call.

="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 49446: Implemented LIST_FILES Call in v1 master API.

93157d57dcc53b54fed2ebbc4772c689ddba2119 src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe Diff: https://reviews.apache.org/r/49446/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

3dd03da3fea10a01aa4508f53c5d1ebcc3d6a2a4 src/common/protobuf_utils.cpp 040bdf82134289f0caf63e11c2ce8e7853a392b3 Diff: https://reviews.apache.org/r/49443/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49529: Remove jsonFileInfo implementation from files.hpp.

/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

55bd0ac81af80c656a4a80766a3e4b21db9cf0cf src/common/http.cpp daf5672287bb6633f468c88632a561f5a01590df Diff: https://reviews.apache.org/r/49444/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140238 ------- On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote: > >

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

ess::browse, this, lambda::_1, None())); - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140238 ---

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

b767d5bc5bee16e3bd98199773a6bc7d30c1c32d src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

538d12f71df1943f91bafb99650625aa910affaa include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 Diff: https://reviews.apache.org/r/49447/diff/ Testing --- Thanks, Abhishek

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

ail. To reply, visit: https://reviews.apache.org/r/49446/#review140242 ------- On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically genera

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

, Abhishek Dasgupta

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

b767d5bc5bee16e3bd98199773a6bc7d30c1c32d src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

, Abhishek Dasgupta

Review Request 49550: Added evolve function for `FileInfo`.

bb99cb29db84e5476a820b261ff24348c657bae0 Diff: https://reviews.apache.org/r/49550/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49551: Overloaded equality(==) operator for `FileInfo`.

30788dcc1dd744553ddd93d23b11fcce44502b46 Diff: https://reviews.apache.org/r/49551/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49529: Removed jsonFileInfo implementation from files.hpp.

. Diffs (updated) - src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d Diff: https://reviews.apache.org/r/49529/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

538d12f71df1943f91bafb99650625aa910affaa include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 Diff: https://reviews.apache.org/r/49447/diff/ Testing --- Thanks, Abhishek

Review Request 49600: Added authz to /files/debug endpoint.

://reviews.apache.org/r/49600/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49600: Added authz to /files/debug endpoint.

ve the 'this' capture for now. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140726 ---

Re: Review Request 49600: Added authz to /files/debug endpoint.

.apache.org/r/49600/#review140738 --- On July 4, 2016, 5:41 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49600/ >

Re: Review Request 49600: Added authz to /files/debug endpoint.

> > you can save the `defer()` call as well as the `this` capture. > > Abhishek Dasgupta wrote: > Alexander, but in the future if someone adds something in the lambda > accesses the this pointer. This would lead to a potential race condition. So > I thought it is sa

Re: Review Request 49600: Added authz to /files/debug endpoint.

ack it. What do you say?? - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140738 --- On July 4, 2

Re: Review Request 49600: Added authz to /files/debug endpoint.

84f3b0723fd3df02386c8072ded3cb42272cd065 src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49600/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check Thanks,

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > <https://reviews.apache.org/r/49600/diff/1/?file=1436468#file1436468line89> > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

cb020226a66bf9d7f6e1c171fdf9e189876dad03 src/common/protobuf_utils.cpp a2885d0cb515a4ecef782d3e255ccf91b30d0dbd Diff: https://reviews.apache.org/r/49443/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

ca44b114de386557b38903f5307852e072fa src/common/http.cpp 0060121674421e3da16f4e3fdb1b2496787544dc Diff: https://reviews.apache.org/r/49444/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49696: Used alias for the namespace 'process::http'.

49696/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49529: Removed jsonFileInfo implementation from files.hpp.

Diff: https://reviews.apache.org/r/49529/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

s comment on this review. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140534 --- On July 2, 20

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

b767d5bc5bee16e3bd98199773a6bc7d30c1c32d src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.hpp, line 65 > > <https://reviews.apache.org/r/49600/diff/1/?file=1436467#file1436467line65> > > > > Shame we have to perpetuate these naked pointers. Any chance we could > > use a `sh

Re: Review Request 49600: Added authz to /files/debug endpoint.

84f3b0723fd3df02386c8072ded3cb42272cd065 src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49600/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check Thanks,

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > <https://reviews.apache.org/r/49600/diff/1/?file=1436468#file1436468line89> > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was

Re: Review Request 49551: Overloaded equality(==) operator for `FileInfo`.

src/v1/mesos.cpp 30788dcc1dd744553ddd93d23b11fcce44502b46 Diff: https://reviews.apache.org/r/49551/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

, Abhishek Dasgupta

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

538d12f71df1943f91bafb99650625aa910affaa include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 src/slave/slave.hpp 484ba758b4c87935aabd2f76a0e654a3c6d09167 Diff: https://reviews.apache.org/r/49447/diff/ Testing --- Thanks, Abhishek

Re: Review Request 49600: Added authz to /files/debug endpoint.

src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f Diff: https://reviews.apache.org/r/49600/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49696: Used alias for the namespace 'process::http'.

f0a5b713bd Diff: https://reviews.apache.org/r/49696/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

06a91a53b62ba930afaf116b9b6e90cab9ecd515 src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd src/tests/files_tests.cpp a30e452536f395c6e6286e75cb267fcc213bac44 Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49696: Used alias for the namespace 'process::http'.

f0a5b713bd Diff: https://reviews.apache.org/r/49696/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

538d12f71df1943f91bafb99650625aa910affaa include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc Diff: https://reviews.apache.org/r/49447/diff/ Testing --- Thanks, Abhishek

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

, Abhishek Dasgupta

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

06a91a53b62ba930afaf116b9b6e90cab9ecd515 src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd src/tests/files_tests.cpp a30e452536f395c6e6286e75cb267fcc213bac44 Diff: https://reviews.apache.org/r/49445/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49696: Used alias for the namespace 'process::http'.

f0a5b713bd Diff: https://reviews.apache.org/r/49696/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

://reviews.apache.org/r/49448/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

> On July 7, 2016, 5:20 p.m., Zhitao Li wrote: > > src/slave/http.cpp, line 1032 > > > > > > nit: capture `[this, contentType]` Then we don't need defer(slave->self() as well.. - Abhishek --

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

> On July 7, 2016, 5:20 p.m., Zhitao Li wrote: > > src/slave/http.cpp, line 1032 > > <https://reviews.apache.org/r/49757/diff/1/?file=1438711#file1438711line1032> > > > > nit: capture `[this, contentType]` > > Abhishek Dasgupta wrote: > Then

Review Request 49794: Added texts for authorization in endpoint docs for '/files/debug'.

s/debug.md 9361ffecef4a1cab1138981c5ce302561505cfda Diff: https://reviews.apache.org/r/49794/diff/ Testing --- NA. Thanks, Abhishek Dasgupta

<    1   2   3   4