- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/#review98145
---
On Sept. 9, 2015, 6:04 a.m., Klaus
> > which you can use?
Yes, it's only for detector; let me try to use StartSlave with detector only.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38003/#r
arison?
Do you mean full comparison on metrics?
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review98880
---
On Sept.
_
Generate masterInfo.id by UUID instead of "date + ip + port + pid".
Diffs (updated)
-
src/master/master.cpp 1c4e7af
src/tests/master_tests.cpp 06d74c3
Diff: https://reviews.apache.org/r/38003/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
message.
Diffs (updated)
-
include/mesos/mesos.proto 899d52f
include/mesos/slave/oversubscription.proto fa69a95
src/slave/slave.cpp 93353a1
src/tests/oversubscription_tests.cpp 0c5edaf
Diff: https://reviews.apache.org/r/38253/diff/
Testing
---
make
make check
Thanks,
Klaus
_
Generate masterInfo.id by UUID instead of "date + ip + port + pid".
Diffs (updated)
-
src/master/master.cpp 1c4e7af
src/tests/master_tests.cpp 06d74c3
Diff: https://reviews.apache.org/r/38003/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
ttps://reviews.apache.org/r/38003/#review99442
---
On Sept. 18, 2015, 12:13 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
message.
Diffs (updated)
-
include/mesos/mesos.proto b1deed4
include/mesos/slave/oversubscription.proto fa69a95
src/slave/slave.cpp 44865bd
src/tests/oversubscription_tests.cpp 0c5edaf
Diff: https://reviews.apache.org/r/38253/diff/
Testing
---
make
make check
Thanks,
Klaus
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review98393
-------
On Sept. 15, 2015, 1:08 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically g
bcc1fab
src/tests/slave_tests.cpp 447c43c
src/usage/main.cpp 86fd796
Diff: https://reviews.apache.org/r/38335/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
---
cd 3rdparty/libprocess/3rdparty/stout
./boostrap
./configure
make
Thanks,
Klaus Ma
peated Item values = 1;
}
- Klaus
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100950
---
ature would change to
> > `inline Try protobuf(const google::protobuf::Message& message)`
>
> Klaus Ma wrote:
> Got your point :).
> Just one concern on how to use it? We did not handle its result if failed
> in `src`; personally, this's a kind of code practice
}
> > ```
> >
> > Then the snippet above could be rewritten as:
> > ```
> > object.values["network_infos"] =
> > std::move(JSON::protobuf(status.network_infos(), [](const NetworkInfo&
> > info) { return model(info); });
> >
eviews.apache.org/r/38342/#review100950
---
On Oct. 4, 2015, 11:29 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To re
}
> > ```
> >
> > Then the snippet above could be rewritten as:
> > ```
> > object.values["network_infos"] =
> > std::move(JSON::protobuf(status.network_infos(), [](const NetworkInfo&
> > info) { return model(info); });
> >
/libprocess/3rdparty/stout
./boostrap
./configure
make
Thanks,
Klaus Ma
ests/protobuf_tests.pb.cc 34eb6d0
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9
Diff: https://reviews.apache.org/r/38342/diff/
Testing
---
cd 3rdparty/libprocess/3rdparty/stout
./boostrap
./configure
make
Thanks,
Klaus Ma
obuf
field type. Anyway, I'll update accordingly if necessary.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100794
---------
://reviews.apache.org/r/38259/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/#review99588
---
On Sept. 13, 2015, 5:30 a.m., Klaus Ma wrote:
>
>
/3rdparty/stout
./boostrap
./configure
make
Thanks,
Klaus Ma
/tests/reservation_endpoints_tests.cpp 398a2e1
src/tests/resources_tests.cpp 6584fc6
src/tests/script.cpp bcc1fab
src/tests/slave_tests.cpp dccdbb0
src/usage/main.cpp 86fd796
Diff: https://reviews.apache.org/r/38335/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
g the conflict
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review99020
---
On Sept. 24, 2015, 2
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100575
-------
On Sept. 24, 2015, 3 p.m., Klaus Ma wrote:
>
>
//reviews.apache.org/r/37531/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99528
---
Ship it!
Ship It!
- Klaus Ma
On Sept. 18, 2015, 9:25 a.m
>
> >
> > This comment describes a behavior of the function and should be moved
> > to 608 (= above the function signature).
I'll address it :).
- Klaus
---
This is an automatically genera
ated)
-
src/slave/containerizer/fetcher.hpp 78e7d14
src/slave/containerizer/fetcher.cpp 26df3d5
src/tests/fetcher_cache_tests.cpp fb0b3ba
src/tests/mesos.hpp 8d2d919
src/tests/mesos.cpp d42dab5
Diff: https://reviews.apache.org/r/40631/diff/
Testing
---
make && m
sting
-------
only `make` passwd for now.
Thanks,
Klaus Ma
src/tests/monitor_tests.cpp a848d14
src/tests/reservation_endpoints_tests.cpp c3833d0
src/tests/slave_recovery_tests.cpp c0e4ff7
src/tests/slave_tests.cpp 4975bea
Diff: https://reviews.apache.org/r/40759/diff/
Testing
-------
only `make` passwd for now.
Thanks,
Klaus Ma
ew RR#41066 to address.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/#review109207
---
On Sept. 18
Description
---
Missed containerId in v1 API when fixing MESOS-2875.
Diffs
-
include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068
Diff: https://reviews.apache.org/r/41066/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40903/#review109672
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 3, 2015, 7:09 p.m., Bernd
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0
Diff: https://reviews.apache.org/r/41503/diff/
Testing
---
Thanks,
Klaus Ma
,
Klaus Ma
.cpp 5a7981744726a0544435cbbd5007487a43a01211
Diff: https://reviews.apache.org/r/41501/diff/
Testing
---
Thanks,
Klaus Ma
`
- Klaus Ma
On Dec. 17, 2015, 5:43 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41334/
> ---
&g
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110233
-------
On Dec. 12, 2015, 5:54 p.m., Klaus Ma wrote:
>
> ---
&g
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/#review110230
---
On Dec. 12, 2015, 5:52 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41306/#review110172
---
On Dec. 12, 2015, 5:55 p.m., Klaus Ma wrote:
>
> ---
)
-
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
g/r/41337/#comment169982>
For this one, I'm thinking your working on MESOS-3891, right? And I don't
think get total/used resources by REST API is a good way :).
- Klaus Ma
On Dec. 14, 2015, 5:25 p.m., Guangya Liu
> On Dec. 14, 2015, 10:14 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 431
> > <https://reviews.apache.org/r/40632/diff/6/?file=1161883#file1161883line431>
> >
> > Honestly, I'd like to separate optimistic resources into othe
CPU, how may tasks (~1 CPU per task) should framework run?
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110166
-------
On Dec. 12, 2015, 5:54 p.m., Klaus Ma wrote:
>
> -
ource if lots of executor in slave.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review110166
-------
utor's resources, right? But I think we should always add
> > DEFAULT_EXECUTOR_CPUS to executor's resources in this case.
>
> Klaus Ma wrote:
> The purpose of this code is not to overcommit resources; for example,
> only CPU or memory in cluster, master can not assign more re
9762f85
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 5211f54
Diff: https://reviews.apache.org/r/37168/diff/
Testing
---
make
make check
Thanks,
Klaus Ma
check is on-going)
Thanks,
Klaus Ma
: https://reviews.apache.org/r/41308/diff/
Testing
---
Thanks,
Klaus Ma
8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41302/diff/
Testing
---
Thanks,
Klaus Ma
, visit:
https://reviews.apache.org/r/40375/#review109993
-------
On Dec. 12, 2015, 11:19 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -
(updated)
-
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks
tps://reviews.apache.org/r/40632/#comment169923>
Honestly, I'd like to separate optimistic resources into other counter in
allocator; it's a litte different with oversubscription: here, one reserved
resources are counting twice in total.
- Klaus Ma
On Dec. 13, 2015, 7:35 p.m., Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/#review19
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 18, 2015, 1:38 p.m
offered, revocable resources.
Diffs (updated)
-
include/mesos/type_utils.hpp b370b51
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review109894
---
Ship it!
Ship It!
- Klaus Ma
On Dec. 10, 2015, 10:26 p.m
)
-
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
---
make && make check
Thanks,
Klaus Ma
/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
check is on-going)
Thanks,
Klaus Ma
9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
/
Testing
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41850/diff/
Testing
---
Thanks,
Klaus Ma
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41850/diff/
Testing
---
Thanks,
Klaus Ma
/diff/
Testing
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41858/diff/
Testing
---
Thanks,
Klaus Ma
/41856/diff/
Testing
---
Thanks,
Klaus Ma
/
Testing
---
Thanks,
Klaus Ma
g/r/41857/#comment172909>
It should use idle (total - pending - occupied) to check
- Klaus Ma
On Jan. 3, 2016, 10:23 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
evicting unreserved resources (allocationSlack -
stateless.reserved)
4. In Allocator::recoverResources, if total allocation slack is smaller than
stateless.reserved, shrink total allocation slack.
- Klaus Ma
On Jan. 3, 2016, 5:22 p.m., Guangya Liu wrote
launching, it's removed from
pendingExecutor list.
Diffs
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
pendingExecutor list.
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
.
include/mesos/v1/resources.hpp (line 243)
<https://reviews.apache.org/r/40529/#comment173562>
ditto
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mai
g/r/41333/#comment173564>
This's not necessary; the default value of `RevocableInfo::type` is
`USAGE_SLACK`, so return `type() == USAGE_SLACK` is OK.
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu
? If not, why should
we add that? I'd suggest to add this on demand.
- Klaus Ma
On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
pendingExecutor list.
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
---
Thanks,
Klaus Ma
/41850/diff/
Testing
---
Thanks,
Klaus Ma
/
Testing
---
Thanks,
Klaus Ma
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
Diffs (updated)
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
---
Thanks,
Klaus Ma
90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
---
Thanks,
Klaus Ma
---
make (make check is on-going)
Thanks,
Klaus Ma
8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review113188
---
Ship it!
Ship It!
- Klaus Ma
On Jan. 2, 2016, 9:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review113189
---
please help to rebase :).
- Klaus Ma
On Jan. 2, 2016, 9:17 a.m
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
org/r/41848/#comment173709>
Update error message to report `USAGE_SLACK` and `ALLOCATION_SLACK` mix
usage.
- Klaus Ma
On Jan. 3, 2016, 5:26 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail.
/resource_estimator.hpp 27612ca
src/slave/slave.cpp 9d80c96
Diff: https://reviews.apache.org/r/40379/diff/
Testing
---
make (make check is on-going)
Thanks,
Klaus Ma
tps://reviews.apache.org/r/40632/#comment173738>
Add `allocation slack resource` if any
- Klaus Ma
On Jan. 7, 2016, 7:27 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
://reviews.apache.org/r/41856/diff/
Testing
---
Thanks,
Klaus Ma
b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
---
Thanks,
Klaus Ma
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41858/diff/
Testing
---
Thanks,
Klaus Ma
> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1321
> > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1321>
> >
> > As framework can not use ALLOCATION_SLACK mixed with oth
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review112512
-------
On Jan. 8, 2016, 2:54 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41
> On Jan. 3, 2016, 6:43 p.m., Klaus Ma wrote:
> > I think it's too early to update total allocation slack here; my suggestion
> > to handle dynamic reservation:
> >
> > 1. Did not reduce total allocation slack in
> > updateAllocation/updateAvailable; but
g/r/41855/#comment174083>
If the executors exist, did not add it into pendingExecutors list. Will
update diff after dependencies rebased.
- Klaus Ma
On Jan. 8, 2016, 2:53 p.m., Klaus Ma wrote:
>
> ---
> This is an automatica
for evicting, it need to trace which
execuotor can be evicted.
Diffs
-
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41850/diff/
Testing
---
Thanks,
Klaus Ma
101 - 200 of 602 matches
Mail list logo
