[GitHub] spark pull request: [SPARK-2118] spark class should complaing if t...

2014-06-12 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/1068#issuecomment-45910048 Hey @pwendell this will only check for tools jar and fail if [this](https://github.com/apache/spark/pull/1068/files#diff-fdf4d3e600042c63ffa17b692c4372a3R149) check

[GitHub] spark pull request: SPARK-2058: Overriding config from SPARK_HOME ...

2014-06-12 Thread chu11
Github user chu11 commented on the pull request: https://github.com/apache/spark/pull/997#issuecomment-45910819 Modification to compute-classpath.sh similar to SPARK-1559, pull request #471 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-1946] Submit stage after (configured nu...

2014-06-12 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/900#discussion_r13709414 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -48,6 +48,10 @@ class CoarseGrainedSchedulerBack

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1069 Resolve sbt warnings during build You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark sbt_warnings Alternatively you can review and apply

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45912242 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45912227 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: document laziness of parallelize

2014-06-12 Thread asrabkin
GitHub user asrabkin opened a pull request: https://github.com/apache/spark/pull/1070 document laziness of parallelize Took me several hours to figure out this behavior. It would be good to highlight it in the documentation. You can merge this pull request into a Git repository by

[GitHub] spark pull request: SPARK-2058: Overriding config from SPARK_HOME ...

2014-06-12 Thread EugenCepoi
Github user EugenCepoi commented on a diff in the pull request: https://github.com/apache/spark/pull/997#discussion_r13710617 --- Diff: bin/compute-classpath.sh --- @@ -30,6 +30,11 @@ FWDIR="$(cd `dirname $0`/..; pwd)" # Build up classpath CLASSPATH="$SPARK_CLASSPATH:$SPAR

[GitHub] spark pull request: document laziness of parallelize

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1070#issuecomment-45914100 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45915331 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45915345 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1293 [SQL] [WIP] Parquet support for nes...

2014-06-12 Thread AndreSchumacher
Github user AndreSchumacher commented on a diff in the pull request: https://github.com/apache/spark/pull/360#discussion_r13711334 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13712333 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -28,46 +28,48 @@ import scala.util.Random import akka.actor.{ActorSyste

[GitHub] spark pull request: [SPARK-2109] Setting SPARK_MEM for bin/pyspark...

2014-06-12 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1050#issuecomment-45917646 @ScrapCodes there are alternatives if you're willing to write more code. e.g., write the port to a separate file, or write the port with some specific formatting and look

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45917827 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13712498 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -28,46 +28,48 @@ import scala.util.Random import akka.actor.{ActorSys

[GitHub] spark pull request: [SPARK-2080] Yarn: report HS URL in client mod...

2014-06-12 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1002#issuecomment-45918304 @tgravescs I have a (non-secured) yarn cluster (where daemons run as "yarn"), and I was launching processes from my own machine (not in the cluster). I'm using the event l

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45918415 The changes you are removing were put in place to resolve warnings from Scala 2.10. IIRC the code does not even compile without these in Scala 2.11. What is this resolving

[GitHub] spark pull request: [SPARK-2051]In yarn.ClientBase spark.yarn.dist...

2014-06-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/969#discussion_r13712776 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala --- @@ -220,10 +220,21 @@ trait ClientBase extends Logging { }

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45917828 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15711/ --- If your project

[GitHub] spark pull request: [SPARK-2109] Setting SPARK_MEM for bin/pyspark...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1050#issuecomment-45921222 Also, your latest fixes use the block EOF sometimes, and multiple lines of echo sometimes. It would be good if we could keep this consistent. --- If your project is s

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45925195 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15712/ --- If your project is set up for it, you can

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45925193 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2080] Yarn: report HS URL in client mod...

2014-06-12 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1002#issuecomment-45926094 (Ah, to clarify, I wasn't looking at the web ui, but at the history server ui. It should sort of show the same info, though, as far as I can tell.) --- If your project is

[GitHub] spark pull request: Testing something

2014-06-12 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926278 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926434 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926455 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926474 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15713/ --- If your project is set up for it, you can

[GitHub] spark pull request: Testing something

2014-06-12 Thread pwendell-api
Github user pwendell-api commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926465 QA results for PR 1008:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see https://amplab.cs.berke

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45926472 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-1516]Throw exception in yarn client ins...

2014-06-12 Thread codeboyyong
Github user codeboyyong commented on the pull request: https://github.com/apache/spark/pull/490#issuecomment-45928754 @mengxr, I made the change based on your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1028#issuecomment-45931451 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1028#issuecomment-45931463 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2079] Removing unnecessary wrapping in ...

2014-06-12 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1023#discussion_r13719733 --- Diff: python/pyspark/sql.py --- @@ -346,7 +347,7 @@ def _toPython(self): # TODO: This is inefficient, we should construct the Python Row objec

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45934657 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45934633 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-1939 Refactor takeSample method in RDD t...

2014-06-12 Thread dorx
Github user dorx commented on a diff in the pull request: https://github.com/apache/spark/pull/916#discussion_r13720492 --- Diff: python/pyspark/rdd.py --- @@ -365,27 +366,25 @@ def takeSample(self, withReplacement, num, seed=None): fraction = 0.0 tot

[GitHub] spark pull request: SPARK-1939 Refactor takeSample method in RDD t...

2014-06-12 Thread dorx
Github user dorx commented on a diff in the pull request: https://github.com/apache/spark/pull/916#discussion_r13720693 --- Diff: python/pyspark/rdd.py --- @@ -365,27 +366,25 @@ def takeSample(self, withReplacement, num, seed=None): fraction = 0.0 tot

[GitHub] spark pull request: [SPARK-2010] Support for nested data in PySpar...

2014-06-12 Thread kanzhang
Github user kanzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/1041#discussion_r13721122 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -296,16 +296,25 @@ class SQLContext(@transient val sparkContext: SparkContext)

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1028#issuecomment-45936730 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15714/ --- If your project

[GitHub] spark pull request: [SPARK-2080] Yarn: report HS URL in client mod...

2014-06-12 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/1002#issuecomment-45936763 Ah ok, that makes more sense. The history UI just displays what was recorded as the user on application start event from spark. In the case the daemons are running as

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1028#issuecomment-45936728 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-2080] Yarn: report HS URL in client mod...

2014-06-12 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/1002#issuecomment-45937328 Ok so looking more at it that is what is happening the postApplicationStart is just using sparkUser and since you changed it, it is properly logging the right thing now

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45938007 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45938024 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/1071 [SPARK-2094][SQL] Exactly once command ## Related JIRA issues - Main issue: - [SPARK-2094](https://issues.apache.org/jira/browse/SPARK-2094): Ensure exactly once semantics for

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45938938 @rxin @aarondav just a heads up, I'll probably merge this soon unless you guys have further comments. I added a warning message explaining the new mechanism if someone ru

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1071#issuecomment-45939138 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45939140 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45939158 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1071#issuecomment-45939156 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45939452 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15715/ --- If your project

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45939451 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: Testing something

2014-06-12 Thread pwendell-api
Github user pwendell-api commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45939419 QA results for PR 1008:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see https://amplab.cs.berke

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1028#issuecomment-45939821 LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-2088] fix NPE in toString

2014-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45940221 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45940238 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread concretevitamin
Github user concretevitamin commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13723141 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: E

[GitHub] spark pull request: Resolve sbt warnings during build

2014-06-12 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1069#issuecomment-45941553 @srowen @witgo - as far as I can tell, this _adds_ rather than removes build warnings. I also noticed that your patch #1032 actually caused new warnings because you remo

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13723527 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: Express

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45942352 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45942338 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread concretevitamin
Github user concretevitamin commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13723727 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: E

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45942356 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Testing something

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45942339 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1071#discussion_r13724208 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -22,45 +22,69 @@ import org.apache.spark.rdd.RDD import org.apach

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1071#discussion_r13724318 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -22,45 +22,69 @@ import org.apache.spark.rdd.RDD import org.apach

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1071#discussion_r13724382 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -22,45 +22,69 @@ import org.apache.spark.rdd.RDD import org.apac

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1071#issuecomment-45943727 This is looking really good! :) Can you make sure we have tests in hive for `show tables`, `describe`, and `explain`. I want to make sure we avoid regressions l

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1071#discussion_r13724480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -22,45 +22,69 @@ import org.apache.spark.rdd.RDD import org.apac

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13724505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: Expressi

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13724539 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: Expressi

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45944076 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45944084 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13724617 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: Expressi

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13724792 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -637,76 +633,63 @@ private[spark] class BlockManager( // If

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread concretevitamin
Github user concretevitamin commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13724773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: E

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45946152 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45946153 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15716/ --- If your project is set up for it, you can r

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13725473 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -329,15 +326,16 @@ private[spark] class BlockManager( * never delete

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13725590 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -353,7 +351,7 @@ private[spark] class BlockManager( case Some(b

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726015 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -750,19 +736,16 @@ private[spark] class BlockManager( bytes

[GitHub] spark pull request: Testing something

2014-06-12 Thread pwendell-api
Github user pwendell-api commented on the pull request: https://github.com/apache/spark/pull/1008#issuecomment-45947303 QA results for PR 1008:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see https://amplab.cs.berke

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726037 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -750,19 +736,16 @@ private[spark] class BlockManager( bytes

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726163 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -750,19 +736,16 @@ private[spark] class BlockManager( byt

[GitHub] spark pull request: SPARK-1939 Refactor takeSample method in RDD t...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/916#issuecomment-45947595 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1939 Refactor takeSample method in RDD t...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/916#issuecomment-45947583 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726187 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -329,15 +326,16 @@ private[spark] class BlockManager( * never dele

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726181 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -782,15 +765,16 @@ private[spark] class BlockManager( for (peer: Bl

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726230 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -353,7 +351,7 @@ private[spark] class BlockManager( case Some

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1071#issuecomment-45947916 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-2094][SQL] Exactly once command

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1071#issuecomment-45947919 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15717/ --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45947918 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15718/ --- If your project

[GitHub] spark pull request: SPARK-1843: Replace assemble-deps with env var...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/877#issuecomment-45947915 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726465 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -24,6 +24,8 @@ import scala.collection.mutable.ArrayBuffer import o

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45948845 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2053][SQL] Add Catalyst expressions for...

2014-06-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1055#discussion_r13726781 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,3 +203,139 @@ case class If(predicate: Expressi

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1058#discussion_r13726891 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -329,15 +326,16 @@ private[spark] class BlockManager( * never delete

[GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...

2014-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1058#issuecomment-45948846 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15719/ --- If your project is set up for it, you can

<    1   2   3   4   5   >