Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18010171
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2528#issuecomment-56760800
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010136
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010009
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009839
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009818
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009823
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user codedeft commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18009800
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DecisionTreeMetadata.scala
---
@@ -128,13 +139,34 @@ private[tree] object DecisionTreeMetada
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/2528
[SPARK-3476] Remove outdated memory checks in Yarn
See discussion in [JIRA](https://issues.apache.org/jira/browse/SPARK-3476).
You can merge this pull request into a Git repository by running:
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009684
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009632
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009575
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -394,8 +404,8 @@ object SparkSubmit {
* the user's driver program or to
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2527#issuecomment-56759639
It might be worth updating the README as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009416
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -340,7 +343,7 @@ object SparkSubmit {
private def addJarToClasspath(lo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56759309
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20771/consoleFull)
for PR 2351 at commit
[`2b0daf2`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1486#issuecomment-56759037
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20770/consoleFull)
for PR 1486 at commit
[`9c4933c`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1486#issuecomment-56759058
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/148/consoleFull)
for PR 1486 at commit
[`9c4933c`](https://github.com/a
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009318
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -288,11 +291,11 @@ object SparkSubmit {
}
private def lau
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56758906
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56758832
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20769/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56758830
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20769/consoleFull)
for PR 2351 at commit
[`2b0daf2`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56758654
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/147/consoleFull)
for PR 2351 at commit
[`2b0daf2`](https://github.com/
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009140
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -130,7 +135,7 @@ object SparkSubmit {
if (!Utils.classIsLoadable("
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009125
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -83,7 +88,7 @@ object SparkSubmit {
* (4) the main class fo
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1486#issuecomment-56758490
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009050
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009041
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18008890
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DecisionTreeMetadata.scala
---
@@ -128,13 +139,34 @@ private[tree] object DecisionTreeMetad
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008765
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008643
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark://host:
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008488
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark://h
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18008327
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18008291
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impl/BaggedPoint.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Found
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008077
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster egspark://h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56756072
Actually, I have one more question / thought:
Someone has discovered a similar issue in HistoryServer where the current
code erroneously assumes that applicatio
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2435#discussion_r18007872
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -582,42 +472,36 @@ object DecisionTree extends Serializable with Loggin
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-5676
This is awesome! Consistently naming things using the same applicationIds
will be helpful in a variety of contexts, so thanks for taking the time to work
on this appro
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007450
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -95,10 +93,27 @@ private[spark] class MetricsSystem private (val
instance
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007241
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -106,7 +106,8 @@ private[spark] object CoarseGrainedExecu
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18007213
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -144,16 +146,16 @@ private[spark] object CoarseGrainedExe
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-56754562
Do you mind copying some of the description from the old PR over here? The
PR description and title are incorporated into the commit message, which is why
it's helpful
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2527#issuecomment-56754113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20766/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-56754106
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20768/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2527#issuecomment-56754105
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20766/consoleFull)
for PR 2527 at commit
[`a0f9f1c`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56753858
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20769/consoleFull)
for PR 2351 at commit
[`2b0daf2`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56753750
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/147/consoleFull)
for PR 2351 at commit
[`2b0daf2`](https://github.com/a
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56753598
(I killed the test here so that I could re-run it with the newer commits).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56753544
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20767/
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18006638
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -207,6 +210,48 @@ private[spark] object JettyUtils extends Logging {
private def
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18006502
--- Diff: docs/configuration.md ---
@@ -207,6 +207,25 @@ Apart from these, the following properties are also
available, and may be useful
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18006482
--- Diff: python/pyspark/context.py ---
@@ -793,6 +796,40 @@ def runJob(self, rdd, partitionFunc, partitions=None,
allowLocal=False):
it = self
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18006453
--- Diff: python/pyspark/rdd.py ---
@@ -2025,6 +2025,7 @@ class PipelinedRDD(RDD):
>>> rdd.flatMap(lambda x: [x, x]).reduce(add)
20
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56752977
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20767/consoleFull)
for PR 2351 at commit
[`cba9463`](https://github.com/ap
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18006403
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -183,7 +185,8 @@ private[spark] object JettyUtils extends Logging {
// Bi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2351#issuecomment-56752778
@JoshRosen I had addressed your comments, plz take another look, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18005737
--- Diff: python/pyspark/rdd.py ---
@@ -2081,8 +2085,44 @@ def _jrdd(self):
self.ctx.pythonExec,
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18005654
--- Diff: python/pyspark/rdd.py ---
@@ -2081,8 +2085,44 @@ def _jrdd(self):
self.ctx.pythonExec,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1980#issuecomment-56750923
`spark.ui.https.enabled` is repeated in several places; maybe a helper
method somewhere to retrieve that property would be better?
---
If your project is set up for it, y
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18005569
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -92,6 +92,12 @@ private[spark] abstract class WebUI(
}
}
+ def a
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18005554
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -207,6 +210,48 @@ private[spark] object JettyUtils extends Logging {
private de
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18005297
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -137,6 +138,12 @@ private[spark] class Worker(
context.system.eventSt
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2526#issuecomment-56749234
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20765/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2526#issuecomment-56749226
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20765/consoleFull)
for PR 2526 at commit
[`2399ae5`](https://github.com/a
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-56748597
OK...I will make MIMA happy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2527#issuecomment-56747397
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20766/consoleFull)
for PR 2527 at commit
[`a0f9f1c`](https://github.com/ap
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2527
[SQL][DOCS] Clarify that the server is for JDBC and ODBC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark patch-1
Alternatively
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-56746157
Yay, and the test already found a bug before even being checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2516#issuecomment-56745901
Hi @tigerquoll ,
Overall I like the idea of making this code saner. But your patch currently
has a ton of style issues, several bugs (e.g. leaking open files in se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003366
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003337
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003325
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003201
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
---
@@ -50,71 +51,63 @@ private[spark] object SparkSubmitDriverBoots
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003150
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003122
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003024
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002945
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002864
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002822
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002724
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2351#discussion_r18002615
--- Diff: python/pyspark/rdd.py ---
@@ -2081,8 +2085,44 @@ def _jrdd(self):
self.ctx.pythonExec,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002585
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002495
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002504
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56743354
@witgo I made a few more comments on this patch. I believe the semantics
are now correct, but the documentation and style can be improved.
---
If your project is set
Github user cmccabe commented on the pull request:
https://github.com/apache/spark/pull/1486#issuecomment-56743271
Yes, let's file a follow-up JIRA to discuss a design that can take into
account any kind of different replica location. This patch doesn't expose any
new APIs-- it's all
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002334
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Se
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18002312
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -297,4 +300,21 @@ class UtilsSuite extends FunSuite {
}
}
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-56742910
Thanks! Just a minor thing -- it would be good to use the argument name as
follows:
```scala
val graph: Graph[Double, Int] =
GraphGenerators.logNorm
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002144
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002121
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18002009
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/2507#issuecomment-56742232
@weilan007 Thanks for the PR! I think this is the same as apache/spark#2486
(https://issues.apache.org/jira/browse/SPARK-3635).
---
If your project is set up for it, y
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001799
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001754
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001707
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001681
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001709
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001637
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2526#issuecomment-56741243
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20765/consoleFull)
for PR 2526 at commit
[`2399ae5`](https://github.com/ap
101 - 200 of 383 matches
Mail list logo
