Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57062345
Sorry for the delay, this week has been very busy! I'd like to merge this
soon, only one small question.
---
If your project is set up for it, you can reply to this
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57062370
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2547#issuecomment-57062442
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/171/consoleFull)
for PR 2547 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2517#issuecomment-57062523
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57062530
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20921/consoleFull)
for PR 2542 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2552#issuecomment-57062534
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2551#issuecomment-57062542
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -366,7 +366,7 @@ class SqlParser extends StandardTokenParsers
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2552#issuecomment-57062663
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20922/consoleFull)
for PR 2552 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -118,6 +119,19 @@ class Analyzer(catalog: Catalog,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2551#issuecomment-57062670
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20923/consoleFull)
for PR 2551 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child:
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-57062687
Thanks for working on this! A few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2526#issuecomment-57062871
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2547#issuecomment-57064275
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/171/consoleFull)
for PR 2547 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2559#issuecomment-57065586
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/170/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57065879
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20921/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57065881
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2552#issuecomment-57066007
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20922/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2551#issuecomment-57066017
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2552#issuecomment-57066008
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2551#issuecomment-57066016
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20923/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2557#issuecomment-57066786
@nchammas any idea why it says does not merge cleanly even though it does?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2557#issuecomment-57066811
Ok merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2557#issuecomment-57067407
@rxin The [block that sets this
message](https://github.com/apache/spark/blob/5b922bb458e863f5be0ae68167de882743f70b86/dev/run-tests-jenkins#L89)
is driven by an
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1486#issuecomment-57068065
Hm this exclusion might not work in the case that a class is changed to an
interface. Maybe just also add the specific recommended exclusion here:
```
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2552#issuecomment-57069344
@marmbrus , it seems all PR of SQL tests timed out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126499
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126510
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126545
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -104,13 +96,15 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126658
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126663
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -126,8 +120,8 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126665
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,14 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126667
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -297,6 +291,7 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126669
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +176,22 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126677
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126678
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57070772
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20924/consoleFull)
for PR 2416 at commit
Github user jimjh commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57070773
@rxin Thanks for your feedback. I agree with almost all of your comments
and made the appropriate changes. However, I don't think it should be an
abstract class. According
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18126726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,52 @@ trait HiveTypeCoercion {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18126738
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18126747
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user ezhulenev commented on the pull request:
https://github.com/apache/spark/pull/1717#issuecomment-57071591
@sjbrunst aargh, TwitterStreamSuite.scala:53 requred to add count parameter
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57071901
Hi, @marmbrus . The current codes still have some bugs to fix, I talked
@liancheng yesterday, I will push a update later.
---
If your project is set up for it, you can
Github user jameszhouyi commented on the pull request:
https://github.com/apache/spark/pull/2444#issuecomment-57071944
Hi @pwendell ,
After this commit, for spark-perf will complain 'not found slaves' when run
./bin/run... so have to modify from slaves.template to slaves manually
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18126862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,52 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57072022
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20924/consoleFull)
for PR 2416 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57072024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57072266
Are we going to use this in multiple unrelated classes? As far as I can
tell, this is only used for collections ...
---
If your project is set up for it, you can reply to
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57072352
BTW the reason why abstract classes are favored over traits is because
traits (as with many advanced scala features) with default impls complicate a
lot of things,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18126983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18127040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -366,7 +366,7 @@ class SqlParser extends StandardTokenParsers
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18127069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57072994
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20926/consoleFull)
for PR 2542 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57073055
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57073139
@liancheng Hmm..I don't have a hive environment for test...
CREATE TABLE t1(x INT);
CREATE TABLE t2(a STRUCTx: INT, k INT);
SELECT a.x FROM
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57073173
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/172/consoleFull)
for PR 2542 at commit
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-57074221
Let's not de-duplicate in shuffle stages please. That complicates the patch
a lot and I'm not sure why people would necessarily use it.
Also, why did you add a
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-57074233
Basically it would be great to get a really simple patch that *only* fixes
SPARK-3628 and adds no new data structures in DAGScheduler.
---
If your project is set up for
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57074276
@cloud-fan, I think it is reasonable for return ambiguous references in
the case you mentioned, because we can't make sure whether 'a' is a table alias
or column name. In
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-57074388
the drawbacks for us not to de-duplicate in shuffle stage is that, it makes
accumulator usage to be very tricky...
it sounds like you are not encouraged to use
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2524#issuecomment-57074398
I can simply monitor the accumulator update in TaskSetManager, just not
sure if that can maximumly resolve the problem.
---
If your project is set up for it, you
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57074476
@tianyi
CREATE TABLE t1(x INT);
CREATE TABLE t2(a STRUCTx: INT, k INT);
SELECT a.x FROM t1 a JOIN t2 b ON a.x = b.k;
But hive can
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2216#issuecomment-57074623
I really wish that we could convert JavaDStreamLike / JavaRDDLike into
abstract base classes instead of traits, since there's no particular reason why
they should be
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2256#issuecomment-57074954
Alright, merged it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57074970
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57074968
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20926/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2542#issuecomment-57075143
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/172/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57075299
Thanks. Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18127631
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/2560
[SPARK-3543] remaining cleanup work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark TaskContext
Alternatively you can review and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2560#issuecomment-57075980
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20927/consoleFull)
for PR 2560 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2514#issuecomment-57075989
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20928/consoleFull)
for PR 2514 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/2514#issuecomment-57076000
Hi Matei, thanks a lot for your suggestions. I've updated the code with
fixed seed. Would you mind taking a look at this? Thanks a lot.
---
If your project is set up
101 - 181 of 181 matches
Mail list logo
