[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3492#issuecomment-64755919 It's a good hot-fix for old releases, since it looks like this contains the desired artifact. But for master, @tdas 's PR at https://github.com/apache/spark/pull/3492 is p

[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3493#issuecomment-64755849 You opened this PR 3 times, first as https://github.com/apache/spark/pull/3492 Please close? --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-4632] version update

2014-11-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3494#issuecomment-64755857 You opened this PR 3 times, first as https://github.com/apache/spark/pull/3492 Please close? --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-4537][Streaming] Expand StreamingSource...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3466#issuecomment-64753870 [Test build #23913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23913/consoleFull) for PR 3466 at commit [`02dd44f`](https://gith

[GitHub] spark pull request: [SPARK-4537][Streaming] Expand StreamingSource...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3466#issuecomment-64753876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4599] [Build] [SQL] add hive profile in...

2014-11-26 Thread adrian-wang
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/3450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4599] [Build] [SQL] add hive profile in...

2014-11-26 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/3450#issuecomment-64753760 Thanks for the explanation, I'm closing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64753203 [Test build #23917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23917/consoleFull) for PR 3478 at commit [`9a54625`](https://githu

[GitHub] spark pull request: [SPARK-4632] version update

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3494#issuecomment-64753049 [Test build #23915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23915/consoleFull) for PR 3494 at commit [`4ccc7df`](https://gith

[GitHub] spark pull request: [SPARK-4632] version update

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3494#issuecomment-64753051 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4632] version update

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3494#issuecomment-64752572 [Test build #23915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23915/consoleFull) for PR 3494 at commit [`4ccc7df`](https://githu

[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3493#issuecomment-64752554 [Test build #23914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23914/consoleFull) for PR 3493 at commit [`a544b4b`](https://githu

[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3492#issuecomment-64752444 [Test build #23916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23916/consoleFull) for PR 3492 at commit [`dcf304c`](https://githu

[GitHub] spark pull request: [SPARK-4635][SQL] Delete the val that never us...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3491#issuecomment-64752397 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread prabeesh
GitHub user prabeesh opened a pull request: https://github.com/apache/spark/pull/3492 [SPARK-4632] changed resolver paho-releases -> paho You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabeesh/spark patch-4 Alternatively you c

[GitHub] spark pull request: [SPARK-4632] changed resolver paho-releases ->...

2014-11-26 Thread prabeesh
GitHub user prabeesh opened a pull request: https://github.com/apache/spark/pull/3493 [SPARK-4632] changed resolver paho-releases -> paho You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabeesh/spark patch-5 Alternatively you c

[GitHub] spark pull request: [SPARK-4632] version update

2014-11-26 Thread prabeesh
GitHub user prabeesh opened a pull request: https://github.com/apache/spark/pull/3494 [SPARK-4632] version update You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabeesh/spark patch-6 Alternatively you can review and apply thes

[GitHub] spark pull request: [SPARK-4635][SQL] Delete the val that never us...

2014-11-26 Thread DoingDone9
GitHub user DoingDone9 opened a pull request: https://github.com/apache/spark/pull/3491 [SPARK-4635][SQL] Delete the val that never used in execute() of HashOuterJoin. The val "boundCondition" is created in execute(),but it never be used in execute(); You can merge this pull reque

[GitHub] spark pull request: [SPARK-4599] [Build] [SQL] add hive profile in...

2014-11-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3450#issuecomment-64750619 We don't want to always build the thriftserver when hive support is enabled. Please see my e-mail to the dev list for more details. --- If your project is set up for it

[GitHub] spark pull request: [SPARK-4599] [Build] [SQL] add hive profile in...

2014-11-26 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3450#discussion_r20980682 --- Diff: pom.xml --- @@ -1394,7 +1394,7 @@ - hive-thriftserver + hive --- End diff -- In some

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64750295 @sryza the issue is that mqtt-client is not hosted in maven central, it's maintained in an external repository owned by the eclipse project and also (for some versions)

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64749497 Found the cause. `JdbcRDDSuite` deletes the temporary Derby database with `shutdown=true`, but didn't specify a database name. In this way, the whole Derby driver is sh

[GitHub] spark pull request: [SPARK-4537][Streaming] Expand StreamingSource...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3466#issuecomment-64749125 [Test build #23913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23913/consoleFull) for PR 3466 at commit [`02dd44f`](https://githu

[GitHub] spark pull request: [SPARK-4504][Examples] fix run-example failure...

2014-11-26 Thread gvramana
Github user gvramana commented on the pull request: https://github.com/apache/spark/pull/3377#issuecomment-64747692 Modified to support failing fast similar to assembly.jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64746870 [Test build #23912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23912/consoleFull) for PR 3478 at commit [`d4cedc5`](https://gith

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64746877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64745367 @mateiz The thing puzzles me is that Derby has already been added as a test dependency in Spark core, otherwise the Scala `JdbcRDDSuite` couldn't pass. --- If your pro

[GitHub] spark pull request: [SPARK-4613][Core] Java API for JdbcRDD

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3478#issuecomment-64744101 [Test build #23912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23912/consoleFull) for PR 3478 at commit [`d4cedc5`](https://githu

[GitHub] spark pull request: [SPARK-4634] Enable metrics for each applicati...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3489#issuecomment-64742854 [Test build #23911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23911/consoleFull) for PR 3489 at commit [`6c0171c`](https://gith

[GitHub] spark pull request: [SPARK-4634] Enable metrics for each applicati...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3489#issuecomment-64742858 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64740088 [Test build #23910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23910/consoleFull) for PR 3487 at commit [`4f5e53c`](https://gith

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64740092 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64739813 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64739809 [Test build #23909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23909/consoleFull) for PR 3487 at commit [`9b1afe0`](https://gith

[GitHub] spark pull request: [SPARK-4593] [SQL] return null when divider is...

2014-11-26 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/3443#discussion_r20976923 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -106,12 +106,17 @@ case class Multiply(left: Expressio

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-64739092 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-11-26 Thread lvsoft
GitHub user lvsoft opened a pull request: https://github.com/apache/spark/pull/3490 spark-submit with accept multiple properties-files and merge the values Current ```spark-submit``` accepts only one properties-file, and use ```spark-defaults.conf``` if unspecified. A more natur

[GitHub] spark pull request: [SPARK-4634] Enable metrics for each applicati...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3489#issuecomment-64738375 [Test build #23911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23911/consoleFull) for PR 3489 at commit [`6c0171c`](https://githu

[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...

2014-11-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64738171 @JoshRosen @srowen Any other comments? Is this ok to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-4634] Enable metrics for each applicati...

2014-11-26 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/3489#issuecomment-64737931 Please see https://issues.apache.org/jira/browse/SPARK-4634 for detail of this problem. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4634] Enable metrics for each applicati...

2014-11-26 Thread tsudukim
GitHub user tsudukim opened a pull request: https://github.com/apache/spark/pull/3489 [SPARK-4634] Enable metrics for each application to be gathered in one node Added configuration for adding top level name to the metrics name. You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-4633] Support GZIPOutputStream in spark...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3488#issuecomment-64737346 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-4633] Support GZIPOutputStream in spark...

2014-11-26 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/3488 [SPARK-4633] Support GZIPOutputStream in spark.io.compression.codec gzip is widely used in other frameworks such as hadoop mapreduce and tez, and also I think that gizip is more stable than other

[GitHub] spark pull request: [SparkSQL][SPARK-4528] add comment support for...

2014-11-26 Thread tsingfu
Github user tsingfu closed the pull request at: https://github.com/apache/spark/pull/3477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64735372 [Test build #23910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23910/consoleFull) for PR 3487 at commit [`4f5e53c`](https://githu

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3487#discussion_r20974560 --- Diff: external/mqtt/pom.xml --- @@ -43,8 +43,8 @@ org.eclipse.paho - mqtt-client - 0.4.0 + org.ecli

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/3487#discussion_r20974521 --- Diff: external/mqtt/pom.xml --- @@ -43,8 +43,8 @@ org.eclipse.paho - mqtt-client - 0.4.0 + org.ecl

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3487#issuecomment-64734257 [Test build #23909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23909/consoleFull) for PR 3487 at commit [`9b1afe0`](https://githu

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64734097 I have made an alternative approach to upgrade MQTT from 0.4.0 to 1.0.1. See https://github.com/apache/spark/pull/3487 --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-4632][Streaming] Upgrade MQTT dependenc...

2014-11-26 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/3487 [SPARK-4632][Streaming] Upgrade MQTT dependency to latest version MQTT client 0.4.0 was removed from the Eclipse Paho repository, and hence is breaking Spark build. This upgrades the version of MQTT cl

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64731986 Alright, thanks! I've merged this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64729788 @sryza I am trying to figure out the full extent of it on the current default build as well. The issue is the mqtt-client version 0.4.0 has been removed from certain reposit

[GitHub] spark pull request: [SPARK-4358][SQL] Let BigDecimal do checking t...

2014-11-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/3208#issuecomment-64729341 Hi @marmbrus Is this ok to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64728995 I missed the context for why we would just put mqtt behind the flag. Something in its dependency graph is breaking the build? --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64728943 [Test build #23908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23908/consoleFull) for PR 2524 at commit [`701a1e8`](https://gith

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64728951 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64728890 Don't worry about the other branches now, we can figure it out if we want to backport it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20970806 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64725132 On second thought, does the current build of Spark break right now? If it does it may be fine to release Spark 1.2 as is. --- If your project is set up for it, you can repl

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20970221 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64724819 @pwendell @sryza I agree with that as well. Lets just put mqtt behind the flag for now. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: [WIP][SPARK-2883][SQL]initial support ORC in s...

2014-11-26 Thread zhzhan
Github user zhzhan commented on a diff in the pull request: https://github.com/apache/spark/pull/2576#discussion_r20970019 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/orc.scala --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64723290 @mateiz sure, just rollback the changes...how about the question to apply the patch to other branches? --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64722162 [Test build #23908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23908/consoleFull) for PR 2524 at commit [`701a1e8`](https://githu

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3483#issuecomment-64721948 [Test build #23907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23907/consoleFull) for PR 3483 at commit [`aba9184`](https://gith

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3483#issuecomment-64721953 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-2624 add datanucleus jars to the contain...

2014-11-26 Thread jimjh
Github user jimjh commented on the pull request: https://github.com/apache/spark/pull/3238#issuecomment-64721913 Are we good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64721120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64721113 [Test build #23906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23906/consoleFull) for PR 3484 at commit [`21f2502`](https://gith

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20968353 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: [WIP] SPARK-2450 Adds exeuctor log links to We...

2014-11-26 Thread ksakellis
Github user ksakellis commented on the pull request: https://github.com/apache/spark/pull/3486#issuecomment-64718983 ![screen shot 2014-11-26 at 2 17 12 pm](https://cloud.githubusercontent.com/assets/6590087/5209741/1829e182-7577-11e4-9c88-555b0ca7b671.png) --- If your project is se

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20967444 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-26 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64717507 Can you just not change Accumulator.scala then? That change isn't fixing any kind of bug, it's just a small optimization. Just remove it from this patch. --- If your proj

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-11-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3319#issuecomment-64713893 I checked MATLAB's webpage, I didn't see any copyright mentions for the method names. It's best to triple check though. Since numPy and sciPy share method names with MATLA

[GitHub] spark pull request: [BRANCH-1.2][SPARK-4583][MLLIB] LogLoss for Gr...

2014-11-26 Thread mengxr
Github user mengxr closed the pull request at: https://github.com/apache/spark/pull/3474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [BRANCH-1.2][SPARK-4583][MLLIB] LogLoss for Gr...

2014-11-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3474#issuecomment-64713858 Merged into branch-1.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3483#issuecomment-64713023 [Test build #23907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23907/consoleFull) for PR 3483 at commit [`aba9184`](https://githu

[GitHub] spark pull request: [SPARK-4349] Checking if parallel collection p...

2014-11-26 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/3275#issuecomment-64712768 Hi @pwendell or anyone, is there an update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread roxchkplusony
Github user roxchkplusony commented on a diff in the pull request: https://github.com/apache/spark/pull/3483#discussion_r20964768 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -127,7 +127,14 @@ class CoarseGrainedSchedu

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64712202 [Test build #23906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23906/consoleFull) for PR 3484 at commit [`21f2502`](https://githu

[GitHub] spark pull request: [BRANCH-1.2][SPARK-4583][MLLIB] LogLoss for Gr...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3474#issuecomment-64712117 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [BRANCH-1.2][SPARK-4583][MLLIB] LogLoss for Gr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3474#issuecomment-64712109 [Test build #23904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23904/consoleFull) for PR 3474 at commit [`aca2abb`](https://gith

[GitHub] spark pull request: [SPARK-3398] [SPARK-4325] [EC2] Use EC2 status...

2014-11-26 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/3195#issuecomment-64711993 Yeah, I removed it specifically to be more aggressive and shave off some seconds from the launch time. Do you think that's OK? Or would you prefer the back off sta

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64711809 Ok, updated to match what was discussed. Tested with `System.exit(0)` and `System.exit(1)` (both result in SUCCEEDED app). --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64711395 @sryza yeah I think you're right. Maybe we should as a more surgical fix just put the mqtt project behind a flag and for 1.3 we can clean it up properly (and maybe you c

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64709917 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-4628: Put all external projects behind a...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3485#issuecomment-64709911 [Test build #23905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23905/consoleFull) for PR 3485 at commit [`f3a3f13`](https://gith

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64704937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64704750 Ok, until we figure out a way to avoid that I retract my earlier LGTM because this is currently a regression in a different way. Thanks for digging into this. --- If

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20961526 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-11-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3319#issuecomment-64706309 @brkyvz I didn't know MATLAB has `horzcat` and `vertcat` along with `[A, B]` or `[A; B]`. I'm okay with adapting method names from MATLAB. Hope there is no copyright issue

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64704929 [Test build #23901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23901/consoleFull) for PR 3484 at commit [`4198b3b`](https://gith

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20961460 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3483#issuecomment-64704467 [Test build #23902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23902/consoleFull) for PR 3483 at commit [`5e7fdea`](https://gith

[GitHub] spark pull request: [SPARK-4626] Kill a task only if the executorI...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3483#issuecomment-64704476 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64704472 Yeah, I'm not a fan of that behavior. Let me look at changing it, but also waiting to hear back from Tom. --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64704154 Wait, actually that's pretty bad right? If I run the same user code from 1.1 that calls `System.exit(0)` now it will be re-run many times. --- If your project is set

[GitHub] spark pull request: [SPARK-4611][MLlib] Implement the efficient ve...

2014-11-26 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/3462#discussion_r20961188 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -261,6 +261,57 @@ object Vectors { sys.error("Unsupported Breeze

[GitHub] spark pull request: [SPARK-4584] [yarn] Remove security manager fr...

2014-11-26 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/3484#issuecomment-64703510 Actually the current code will fail the app (not succeed) regardless of what System.exit() says, because of the check on L108... so this actually does what Sandy suggests.

  1   2   3   >