[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76481190 [Test build #28095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28095/consoleFull) for PR 4818 at commit [`8c9c346`](https://githu

[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...

2015-02-27 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4791#issuecomment-76480622 Interesting idea! Let me finish up the Spark 1.3 stuff and then lets discuss this. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4809#discussion_r25542453 --- Diff: python/pyspark/sql.py --- @@ -298,11 +294,11 @@ def __init__(self, keyType, valueType, valueContainsNull=True): :param valueContainsN

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4809#discussion_r25542387 --- Diff: python/pyspark/sql.py --- @@ -298,11 +294,11 @@ def __init__(self, keyType, valueType, valueContainsNull=True): :param valueContainsNull

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4809#issuecomment-76479332 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4810#issuecomment-76479426 LGTM, since the changes here are a subset of the changes in the PR opened against `master`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4809#issuecomment-76479394 LGTM, since the changes here are a subset of the changes in the PR opened against `master`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4809#issuecomment-76479318 [Test build #28086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28086/consoleFull) for PR 4809 at commit [`9b4dadc`](https://gith

[GitHub] spark pull request: [SQL][WIP] Visualizing query plans with graphv...

2015-02-27 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2354#issuecomment-76479135 It wasn't ready to be merged and I didn't have time to finish it. We have a policy to close issues that aren't making progress to keep the PR queue manageable, and to a

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4809#discussion_r25542228 --- Diff: python/pyspark/sql.py --- @@ -298,11 +294,11 @@ def __init__(self, keyType, valueType, valueContainsNull=True): :param valueContainsN

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76478827 Makes sense; LGTM. I'll take a look at the backport patches, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76478760 [Test build #28094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28094/consoleFull) for PR 4808 at commit [`6a322a4`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76478450 @JoshRosen Because we serialized the objects in batch, and pickle memorize the multiple occurrences of same object in the batch, finally we will get single DataType objec

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4809#issuecomment-76478011 [Test build #28093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28093/consoleFull) for PR 4809 at commit [`65c222f`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25541695 --- Diff: python/pyspark/sql/types.py --- @@ -64,6 +64,8 @@ def json(self): sort_keys=True) +# This singleton pat

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4810#issuecomment-76478030 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28092/consoleFull) for PR 4810 at commit [`48d643d`](https://github.com/ap

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25541610 --- Diff: python/pyspark/sql/types.py --- @@ -786,8 +792,24 @@ def _merge_type(a, b): return a +def _need_converter(dataType):

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25541539 --- Diff: python/pyspark/sql/types.py --- @@ -786,8 +792,24 @@ def _merge_type(a, b): return a +def _need_converter(dataType):

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76477158 It looks like `_restore_object` still tries to use DataType instance `id`s as `_cached_cls` dictionary keys during unpickling; is this still necessary if the DataTypes

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25541056 --- Diff: python/pyspark/sql/types.py --- @@ -64,6 +64,8 @@ def json(self): sort_keys=True) +# This singleton

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4818#discussion_r25540656 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator( location:

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4818#discussion_r25540573 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator( location:

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4810#issuecomment-76475192 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/4818#discussion_r25540529 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator( locati

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4810#issuecomment-76475175 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28085/consoleFull) for PR 4810 at commit [`968a28c`](https://github.com/a

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76474820 [Test build #28091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28091/consoleFull) for PR 4815 at commit [`bcd7de1`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25540375 --- Diff: python/pyspark/sql/types.py --- @@ -786,8 +792,24 @@ def _merge_type(a, b): return a +def _need_converter(dataType):

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/4818#discussion_r25540303 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator( locati

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76474436 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76474129 [Test build #28090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28090/consoleFull) for PR 4818 at commit [`3359692`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25540054 --- Diff: python/pyspark/sql/types.py --- @@ -505,6 +508,9 @@ def __eq__(self, other): def _parse_datatype_json_string(json_string): """Pars

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25539993 --- Diff: python/pyspark/sql/types.py --- @@ -505,6 +508,9 @@ def __eq__(self, other): def _parse_datatype_json_string(json_string): """P

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25539940 --- Diff: python/pyspark/sql/types.py --- @@ -505,6 +508,9 @@ def __eq__(self, other): def _parse_datatype_json_string(json_string): """P

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25539749 --- Diff: python/pyspark/sql/types.py --- @@ -242,11 +240,12 @@ def __init__(self, elementType, containsNull=True): :param elementType: the data ty

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76473277 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76473405 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25539648 --- Diff: python/pyspark/sql/types.py --- @@ -242,11 +240,12 @@ def __init__(self, elementType, containsNull=True): :param elementType: the data

[GitHub] spark pull request: [SPARK-6025] Add helper method to efficiently ...

2015-02-27 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/4819#issuecomment-76472686 @jkbradley Is this similar to what you had in mind? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76472673 [Test build #28084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28084/consoleFull) for PR 4808 at commit [`3da44fc`](https://gith

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76472679 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76472636 [Test build #623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/623/consoleFull) for PR 4815 at commit [`bcd7de1`](https://githu

[GitHub] spark pull request: [SPARK-6025] Add helper method to efficiently ...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4819#issuecomment-76472607 [Test build #28089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28089/consoleFull) for PR 4819 at commit [`fa215cc`](https://githu

[GitHub] spark pull request: [SPARK-6025] Add helper method to efficiently ...

2015-02-27 Thread MechCoder
GitHub user MechCoder opened a pull request: https://github.com/apache/spark/pull/4819 [SPARK-6025] Add helper method to efficiently compute error in GBT's While computing the error, with and without validation, for every iteration, the feature prediction of the previous trees was n

[GitHub] spark pull request: [SPARK-5991][MLLIB] support save/load in PySpa...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76471927 [Test build #28088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28088/consoleFull) for PR 4811 at commit [`06140a4`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4808#discussion_r25538900 --- Diff: python/pyspark/sql/context.py --- @@ -620,93 +619,6 @@ def _get_hive_ctx(self): return self._jvm.HiveContext(self._jsc.sc())

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76471641 We don't really lose anything, as far as I can tell. That information is only used to make sure that the allocated containers match those that were requested, not to do an

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25538854 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHadoopUt

[GitHub] spark pull request: [SPARK-5991][MLLIB] support save/load in PySpa...

2015-02-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76471611 If we have couple days before RC2, this would be nice to have. We use the same API as in Scala/Java and there is no real implementation in this PR. Having save/load would

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4817 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76471465 This is specific to vcores and not mem iirc. A solution might be to check vcores returned and modify it to what we requested if found to be 1 when flag is set (we l

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76471031 LGTM. Merged into master and branch-1.3. Thanks! I left the JIRA open because it is a umbrella JIRA. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4816 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76470593 @tgravescs @mridulm Tested: - --executor-cores 1, no conf = passed - --executor-cores 2, no conf = cannot allocate resources, job waits forever ---exec

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-02-27 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/4818 [SPARK-6050] [yarn] Add config option to do lax resource matching. Some YARN configurations return a resource structure for allocated containers that does not match the requested resource. That me

[GitHub] spark pull request: [SPARK-4226][SQL] SparkSQL - Add support for s...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3249#issuecomment-76467964 [Test build #28083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28083/consoleFull) for PR 3249 at commit [`7653eee`](https://gith

[GitHub] spark pull request: [SPARK-4226][SQL] SparkSQL - Add support for s...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3249#issuecomment-76467971 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4817#issuecomment-76467004 Very good catch!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4817#issuecomment-76466788 [Test build #28082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28082/consoleFull) for PR 4817 at commit [`eebfaac`](https://gith

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4817#issuecomment-76466799 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4809#issuecomment-76466659 [Test build #28086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28086/consoleFull) for PR 4809 at commit [`9b4dadc`](https://githu

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect DataType....

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4810#issuecomment-76465859 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28085/consoleFull) for PR 4810 at commit [`968a28c`](https://github.com/ap

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76464338 [Test build #28084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28084/consoleFull) for PR 4808 at commit [`3da44fc`](https://githu

[GitHub] spark pull request: [SPARK-5259][CORE]Make sure mapStage.pendingta...

2015-02-27 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/4055#issuecomment-76464316 I'll take a look over the weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76463812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76463803 [Test build #28081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28081/consoleFull) for PR 4816 at commit [`83d369d`](https://gith

[GitHub] spark pull request: [SPARK-5259][CORE]Make sure mapStage.pendingta...

2015-02-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4055#issuecomment-76462511 cc @markhamstra and @kayousterhout also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76462160 [Test build #28080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28080/consoleFull) for PR 4816 at commit [`2841170`](https://gith

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76462171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5775] [SQL] BugFix: GenericRow cannot b...

2015-02-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4792#discussion_r25533656 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala --- @@ -143,19 +146,47 @@ private[sql] case class ParquetTableScan(

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76459710 [Test build #623 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/623/consoleFull) for PR 4815 at commit [`bcd7de1`](https://github

[GitHub] spark pull request: [SPARK-5775] [SQL] BugFix: GenericRow cannot b...

2015-02-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4792#discussion_r25533640 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala --- @@ -483,16 +487,42 @@ private[sql] case class ParquetRelation2(

[GitHub] spark pull request: [SPARK-5775] [SQL] BugFix: GenericRow cannot b...

2015-02-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4792#discussion_r25533533 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala --- @@ -476,6 +476,10 @@ private[sql] case class ParquetRelation2( // W

[GitHub] spark pull request: [SPARK-5775] [SQL] BugFix: GenericRow cannot b...

2015-02-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4792#discussion_r25533517 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala --- @@ -126,6 +126,9 @@ private[sql] case class ParquetTableScan(

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76459611 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-76458198 [Test build #28078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28078/consoleFull) for PR 4805 at commit [`526e343`](https://gith

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25532849 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHa

[GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4805#issuecomment-76458212 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76456876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76456868 [Test build #28077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28077/consoleFull) for PR 4758 at commit [`252fa0f`](https://gith

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25532214 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHadoopUtil

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76456279 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25532115 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHa

[GitHub] spark pull request: [SPARK-6055] [PySpark] fix incorrect __eq__ of...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4808#issuecomment-76456268 [Test build #28079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28079/consoleFull) for PR 4808 at commit [`534ac90`](https://gith

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25531850 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +93,102 @@ class YarnSparkHadoopUtil extends SparkHa

[GitHub] spark pull request: [SPARK-5847] Allow for namespacing metrics by ...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4632#issuecomment-76455746 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5847] Allow for namespacing metrics by ...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4632#issuecomment-76455726 [Test build #28076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28076/consoleFull) for PR 4632 at commit [`64a7eee`](https://gith

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25531547 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -222,6 +224,14 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25531484 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -540,6 +561,29 @@ private[spark] class Client( amContainer

[GitHub] spark pull request: [SPARK-4226][SQL] SparkSQL - Add support for s...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3249#issuecomment-76455136 [Test build #28083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28083/consoleFull) for PR 3249 at commit [`7653eee`](https://githu

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25531385 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,6 +256,12 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4226] [SQL] Add Exists support for wher...

2015-02-27 Thread ravipesala
Github user ravipesala commented on the pull request: https://github.com/apache/spark/pull/4812#issuecomment-76454856 @chenghao-intel Thank you for your implementation, following are my observations Implementation seems simple but it comes with lot of limitations. The query like b

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4817#issuecomment-76453373 [Test build #28082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28082/consoleFull) for PR 4817 at commit [`eebfaac`](https://githu

[GitHub] spark pull request: [Streaming][Minor] Remove useless type signatu...

2015-02-27 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/4817 [Streaming][Minor] Remove useless type signature of Java Kafka direct stream API You can merge this pull request into a Git repository by running: $ git pull https://github.com/jerryshao/a

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-02-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25530015 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -0,0 +1,343 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] spark pull request: SPARK-6063

2015-02-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4815#issuecomment-76450569 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76450030 [Test build #28081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28081/consoleFull) for PR 4816 at commit [`83d369d`](https://githu

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4816#issuecomment-76448297 [Test build #28080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28080/consoleFull) for PR 4816 at commit [`2841170`](https://githu

[GitHub] spark pull request: SPARK-1965 [WEBUI] Spark UI throws NPE on tryi...

2015-02-27 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/4777#issuecomment-76448316 I don't think it's worth it to return a 404, and this is more consistent with how we treat stages/jobs that don't exist. I might say "No running application with I

[GitHub] spark pull request: [SPARK-4587] [mllib] [docs] Fixed save,load ca...

2015-02-27 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/4816 [SPARK-4587] [mllib] [docs] Fixed save,load calls in ML guide examples Should pass spark context to save/load CC: @mengxr You can merge this pull request into a Git repository by running:

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-02-27 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25527424 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,6 +256,12 @@ private[spark] class ApplicationMaster(

<    1   2   3   4   5   >