[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5634#issuecomment-95252215 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5634#issuecomment-95252203 [Test build #30761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30761/consoleFull) for PR 5634 at commit

[GitHub] spark pull request: [SPARK-6113] [ml] Tree ensembles for Pipelines...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5626#issuecomment-95254646 [Test build #30764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30764/consoleFull) for PR 5626 at commit

[GitHub] spark pull request: Spark-5854 personalized page rank

2015-04-22 Thread dwmclary
Github user dwmclary commented on the pull request: https://github.com/apache/spark/pull/4774#issuecomment-95256308 @jegonzal does this algorithm look correct to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-5932][CORE] Use consistent naming for s...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5574#issuecomment-95258228 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5932][CORE] Use consistent naming for s...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5574#issuecomment-95258108 [Test build #30762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30762/consoleFull) for PR 5574 at commit

[GitHub] spark pull request: [SPARK-7046] Remove InputMetrics from BlockRes...

2015-04-22 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/5627#issuecomment-95261461 3 tiny nits -- thanks for looking at this @sryza! Fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5932][CORE] Use consistent naming for s...

2015-04-22 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/5574#issuecomment-95261583 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5473#issuecomment-95249371 [Test build #30759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30759/consoleFull) for PR 5473 at commit

[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5634#issuecomment-95255538 [Test build #30765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30765/consoleFull) for PR 5634 at commit

[GitHub] spark pull request: [SPARK-5155] [PySpark] [Streaming] Mqtt stream...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4229#issuecomment-95159892 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...

2015-04-22 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/4537#issuecomment-95180356 Glad to hear it works for you. Fixing the default arguments for mima was straightforward, but there's a lot that has changed in the test code. Work's been busy,

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95174344 The changes look OK; Jenkins will double-check. I am still not sure what you mean about SPARK-7056, which is about the streaming write-ahead log. Typo? --- If your

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95182753 Normally we do make JIRAs for changes unless it would be pretty redundant with a simple, self-evident pull request. This is borderline. But SPARK-7056 is a real,

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5473#issuecomment-95249397 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/5634#issuecomment-95255197 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4943][SPARK-5251][SQL] Allow table name...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4062#issuecomment-95255813 [Test build #30766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30766/consoleFull) for PR 4062 at commit

[GitHub] spark pull request: [SPARK-4902][CORE] gap-sampling performance op...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3744#issuecomment-95255789 [Test build #30767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30767/consoleFull) for PR 3744 at commit

[GitHub] spark pull request: [SPARK-6602][Core] Update Master, Worker, Clie...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5392#issuecomment-95257197 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6602][Core] Update Master, Worker, Clie...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5392#issuecomment-95257184 [Test build #30763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30763/consoleFull) for PR 5392 at commit

[GitHub] spark pull request: [SPARK-4943][SPARK-5251][SQL] Allow table name...

2015-04-22 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/4062#issuecomment-95257041 Updated and added test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7046] Remove InputMetrics from BlockRes...

2015-04-22 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5627#issuecomment-95259018 LGTM. One tiny nit is that `import org.apache.spark.executor._` could go to `import org.apache.spark.executor.{DataReadMethod, ShuffleWriteMetrics}` --- If your

[GitHub] spark pull request: [SPARK-7046] Remove InputMetrics from BlockRes...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5627#issuecomment-95262798 [Test build #30768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30768/consoleFull) for PR 5627 at commit

[GitHub] spark pull request: [SPARK-5932][CORE] Use consistent naming for s...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5574#issuecomment-95262778 [Test build #30769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30769/consoleFull) for PR 5574 at commit

[GitHub] spark pull request: [SPARK-5894][ML] Add polynomial mapper

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5245#issuecomment-95216302 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5894][ML] Add polynomial mapper

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5245#issuecomment-95216288 [Test build #30760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30760/consoleFull) for PR 5245 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95216642 [Test build #30756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30756/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95216688 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Common interfaces between RDD, DStream, and Da...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5565#issuecomment-95221846 OK, mark it `[WIP]` in the title, but does it help you much to have it as an open PR? you can always test things locally. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5634#issuecomment-95223869 [Test build #30761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30761/consoleFull) for PR 5634 at commit

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4450#issuecomment-95237844 Hey @sryza - two higher level questions as I'm doing a deeper review of this. 1. This seems predicated on the idea that serialization streams can safely be

[GitHub] spark pull request: [SPARK-7037] [CORE] Inconsistent behavior for ...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5617#issuecomment-95237261 Got it, that makes sense. So this will in all cases ignore, but warn, about non-Spark properties, for spark-submit and spark-shell alike. OK, if that's the intent, this

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4450#discussion_r28884412 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala --- @@ -113,11 +114,21 @@ private[spark] class ExternalSorter[K, V, C](

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95184603 It makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4943][SPARK-5251][SQL] Allow table name...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4062#issuecomment-95191552 [Test build #30755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30755/consoleFull) for PR 4062 at commit

[GitHub] spark pull request: [SPARK-4943][SPARK-5251][SQL] Allow table name...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4062#issuecomment-95191585 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/5473#issuecomment-95204897 All comments addressed. Thanks a lot for reviewing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/5473#discussion_r28876750 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/Job.scala --- @@ -25,15 +25,43 @@ import scala.util.Try */

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95160977 [Test build #30756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30756/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95164649 I think that's fine, since this is an example, though this is not related to SPARK-7056? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-7050][build] Keep maven build consisten...

2015-04-22 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/5632#issuecomment-95169843 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95175701 It means nothing, first I intend to update the pom.xml file and give it a new name [spark-7056], while it is a part of this pull request. --- If your project is set up

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/5596#issuecomment-95189684 @jkbradley I add stepSize as a sharedParam in the codegen file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5596#issuecomment-95190631 [Test build #30758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30758/consoleFull) for PR 5596 at commit

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5596#issuecomment-95190641 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5428#issuecomment-95206224 [Test build #693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/693/consoleFull) for PR 5428 at commit

[GitHub] spark pull request: [SPARK-6862][Streaming][WebUI] Add BatchPage t...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5473#issuecomment-95206269 [Test build #30759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30759/consoleFull) for PR 5473 at commit

[GitHub] spark pull request: [SPARK-7050][build] Keep maven build consisten...

2015-04-22 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/5632#issuecomment-95161122 I have no specific inclination, either changing sbt or maven is OK for me, since `dev/run-tests` using sbt as a default tool, so I can change here to keep the same

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95169296 SPARK-7056 is just a new commit, after updating the pom.xml file, the CMSHasherImplicits compatibility problem can be solved as well. --- If your project is set up for

[GitHub] spark pull request: [SPARK-7050][build] Keep maven build consisten...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5632#issuecomment-95173052 [Test build #30757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30757/consoleFull) for PR 5632 at commit

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/5596#discussion_r28873658 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/5596#issuecomment-95189512 @mengxr As we talked, I average all vectors of words in a sentence as the output column. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5428#issuecomment-95174821 [Test build #693 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/693/consoleFull) for PR 5428 at commit

[GitHub] spark pull request: JDBCRDD: Add to support on type NVARCHAR

2015-04-22 Thread szheng79
Github user szheng79 commented on a diff in the pull request: https://github.com/apache/spark/pull/5618#discussion_r28876804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala --- @@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging {

[GitHub] spark pull request: Common interfaces between RDD, DStream, and Da...

2015-04-22 Thread nkronenfeld
Github user nkronenfeld commented on the pull request: https://github.com/apache/spark/pull/5565#issuecomment-95221601 Could you leave it open a little bit longer? I want to see if I can shorten the list of differences, and having it active here makes it a little easier to see if

[GitHub] spark pull request: [SPARK-5894][ML] Add polynomial mapper

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5245#issuecomment-95212258 [Test build #30760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30760/consoleFull) for PR 5245 at commit

[GitHub] spark pull request: [SPARK-6231][SQL][workaround] Add alias functi...

2015-04-22 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/5634 [SPARK-6231][SQL][workaround] Add alias function to python dataframe This pr tries to provide a way to let python users workaround https://issues.apache.org/jira/browse/SPARK-6231. You can merge

[GitHub] spark pull request: [SPARK-7050][build] Keep maven build consisten...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5632#issuecomment-95229658 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7050][build] Keep maven build consisten...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5632#issuecomment-95229580 [Test build #30757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30757/consoleFull) for PR 5632 at commit

[GitHub] spark pull request: [SPARK-6602][Core] Update Master, Worker, Clie...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5392#issuecomment-95237267 [Test build #30763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30763/consoleFull) for PR 5392 at commit

[GitHub] spark pull request: [SPARK-5932][CORE] Use consistent naming for s...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5574#issuecomment-95237301 [Test build #30762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30762/consoleFull) for PR 5574 at commit

[GitHub] spark pull request: [SPARK-6418] Add simple per-stage visualizatio...

2015-04-22 Thread punya
Github user punya commented on the pull request: https://github.com/apache/spark/pull/5547#issuecomment-95223629 Given the increasing complexity of the status pages' UI logic, does it make sense to move from manually toggling CSS classes using jQuery, to a modern single page

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4450#discussion_r28882363 --- Diff: core/src/main/scala/org/apache/spark/util/collection/PartitionedSerializedPairBuffer.scala --- @@ -0,0 +1,254 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-6746B] Refactor large functions in DAGS...

2015-04-22 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/5396#issuecomment-95245649 All - I assume the lack of response indicates that folks aren't interested in this patch. I'll close this unless I get some further comments. --- If your project is

[GitHub] spark pull request: [SPARK-5894][ML] Add polynomial mapper

2015-04-22 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/5245#issuecomment-95213639 @mengxr As we discussed, I fix test suite and left other pieces untouched. I will refine all of them after you verify the correctness. --- If your project is set up

[GitHub] spark pull request: Spark 5659 Flaky test: o.a.s.streaming.Receive...

2015-04-22 Thread kevinpetersavage
Github user kevinpetersavage commented on the pull request: https://github.com/apache/spark/pull/4957#issuecomment-95219959 Sorry @tdas, crossed wires, didn't see your comment before I'd already looked at this. I see your point, but I think that the underlying problem with

[GitHub] spark pull request: [SPARK-7037] [CORE] Inconsistent behavior for ...

2015-04-22 Thread piaozhexiu
Github user piaozhexiu commented on a diff in the pull request: https://github.com/apache/spark/pull/5617#discussion_r28883339 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -77,12 +77,8 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark pull request: [SPARK-6827] [mllib] Wrap FPGrowthModel.freqIt...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5614#issuecomment-95042909 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5894][ML] Add polynomial mapper

2015-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5245#discussion_r28846979 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/PolynomialMapperSuite.scala --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-6827] [mllib] Wrap FPGrowthModel.freqIt...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5614#issuecomment-95042898 [Test build #30726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30726/consoleFull) for PR 5614 at commit

[GitHub] spark pull request: [SPARK-6201] [SQL] promote string and do widen...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4945#issuecomment-95043939 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6201] [SQL] promote string and do widen...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4945#issuecomment-95042053 [Test build #30732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30732/consoleFull) for PR 4945 at commit

[GitHub] spark pull request: [SPARK-1406] Mllib pmml model export

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3062#issuecomment-95042057 [Test build #30733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30733/consoleFull) for PR 3062 at commit

[GitHub] spark pull request: [SPARK-6201] [SQL] promote string and do widen...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4945#issuecomment-95043931 [Test build #30732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30732/consoleFull) for PR 4945 at commit

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5428#discussion_r28847268 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -107,6 +107,15 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-6967] [SQL] fix date type convertion in...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5590#issuecomment-95044123 [Test build #30727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30727/consoleFull) for PR 5590 at commit

[GitHub] spark pull request: [SPARK-6967] [SQL] fix date type convertion in...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5590#issuecomment-95044129 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6443][Spark Submit]Could not submit app...

2015-04-22 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/5116#issuecomment-95044838 @andrewor14 I've changed and made some rebase. If everything is ok i'd like to merge it ASAP. Please take a look. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-7044] [SQL] Fix the deadlock in script ...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5625#issuecomment-95044410 [Test build #30728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30728/consoleFull) for PR 5625 at commit

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5428#discussion_r28847514 --- Diff: streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java --- @@ -1707,6 +1708,71 @@ public Integer call(String s) throws Exception {

[GitHub] spark pull request: [SPARK-6201] [SQL] promote string and do widen...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4945#issuecomment-95047309 [Test build #30734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30734/consoleFull) for PR 4945 at commit

[GitHub] spark pull request: [SPARK-6939][Streaming][WebUI] Add timeline an...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5533#issuecomment-95050102 [Test build #30735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30735/consoleFull) for PR 5533 at commit

[GitHub] spark pull request: [SPARK-7044] [SQL] Fix the deadlock in script ...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5625#issuecomment-95044427 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5428#discussion_r28847303 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala --- @@ -328,6 +330,138 @@ class StreamingContextSuite extends

[GitHub] spark pull request: [SPARK-6889] [DOCS] CONTRIBUTING.md updates to...

2015-04-22 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/5623#issuecomment-95045467 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6568] spark-shell.cmd --jars option doe...

2015-04-22 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/5447#issuecomment-95045723 I tested only on Windows, but I noticed I get different results on Linux. This is because... On Windows: ``` scala new File(C:\\path\\to\\file.txt).toURI

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5596#discussion_r28847697 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [ML][SPARK-6529] Add Word2Vec transformer

2015-04-22 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5596#issuecomment-95263894 @yinxusen Run dev/scalastyle It's not the generated sharedParams since style checking skips that file. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/4450#discussion_r28892668 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala --- @@ -113,11 +114,21 @@ private[spark] class ExternalSorter[K, V, C](

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/4450#discussion_r28892612 --- Diff: core/src/main/scala/org/apache/spark/util/collection/PartitionedSerializedPairBuffer.scala --- @@ -0,0 +1,254 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-4902][CORE] gap-sampling performance op...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3744#issuecomment-95278287 [Test build #30767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30767/consoleFull) for PR 3744 at commit

[GitHub] spark pull request: [SPARK-4902][CORE] gap-sampling performance op...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3744#issuecomment-95278322 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-1537 [WiP] Application Timeline Server i...

2015-04-22 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/5423#issuecomment-95282650 This iteration has a simpler service flush/shutdown logic, with specific messages for each action queued, and no attempt to trigger the yarn service stop when a

[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...

2015-04-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5618#issuecomment-95285974 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7058] Include RDD deserialization time ...

2015-04-22 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/5635 [SPARK-7058] Include RDD deserialization time in task deserialization time metric The web UI's task deserialization time metric is slightly misleading because it does not capture the time taken

[GitHub] spark pull request: [SPARK-7051] [SQL] Configuration for parquet d...

2015-04-22 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/5630#discussion_r28892756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -36,6 +36,8 @@ private[spark] object SQLConf { val PARQUET_INT96_AS_TIMESTAMP

[GitHub] spark pull request: SPARK-1537 [WiP] Application Timeline Server i...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5423#issuecomment-95281268 [Test build #30770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30770/consoleFull) for PR 5423 at commit

[GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...

2015-04-22 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/4450#issuecomment-95272806 Thanks for the review Patrick. Regarding Kryo: I would be really really surprised if Kryo were to change its serialization format in such a drastic way without

[GitHub] spark pull request: [SPARK-6113] [ml] Tree ensembles for Pipelines...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5626#issuecomment-95285321 [Test build #30764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30764/consoleFull) for PR 5626 at commit

[GitHub] spark pull request: [SPARK-6113] [ml] Tree ensembles for Pipelines...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5626#issuecomment-95285348 Test PASSed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   >