[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6724#discussion_r32092473 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -294,3 +294,35 @@ object Substring { appl

[GitHub] spark pull request: [SPARK-8282][SparkR] Make number of threads us...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6730#issuecomment-110620173 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8282][SparkR] Make number of threads us...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6730#issuecomment-110620121 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6724#discussion_r32092396 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -230,12 +230,24 @@ abstract class UnaryExpression extend

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6724#issuecomment-110618824 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8018][MLlib]KMeans should accept initia...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6737#issuecomment-110618628 [Test build #34569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34569/consoleFull) for PR 6737 at commit [`6959861`](https://gith

[GitHub] spark pull request: [SPARK-4118] [MLlib] [PySpark] Python bindings...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6499#issuecomment-110618870 [Test build #34570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34570/consoleFull) for PR 6499 at commit [`bb431b4`](https://gith

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6724#issuecomment-110618788 [Test build #34561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34561/console) for PR 6724 at commit [`3c729aa`](https://github.

[GitHub] spark pull request: [SPARK-4118] [MLlib] [PySpark] Python bindings...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6499#issuecomment-110617828 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4118] [MLlib] [PySpark] Python bindings...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6499#issuecomment-110617856 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6712#discussion_r32092163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala --- @@ -71,43 +71,49 @@ private[spark] case class PythonUDF( private[spark

[GitHub] spark pull request: [SPARK-8018][MLlib]KMeans should accept initia...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6737#issuecomment-110617839 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8018][MLlib]KMeans should accept initia...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6737#issuecomment-110617819 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8018][MLlib]KMeans should accept initia...

2015-06-09 Thread FlytxtRnD
GitHub user FlytxtRnD opened a pull request: https://github.com/apache/spark/pull/6737 [SPARK-8018][MLlib]KMeans should accept initial cluster centers as param This allows Kmeans to be initialized using an existing set of cluster centers provided as a KMeansModel object. This mode

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6712#discussion_r32092137 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala --- @@ -71,43 +71,49 @@ private[spark] case class PythonUDF( private[spark

[GitHub] spark pull request: [SPARK-4118] [MLlib] [PySpark] Python bindings...

2015-06-09 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/6499#issuecomment-110616969 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/6712#discussion_r32092072 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala --- @@ -71,43 +71,49 @@ private[spark] case class PythonUDF( private[

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32092034 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -145,6 +145,17 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110616487 [Test build #34568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34568/consoleFull) for PR 6718 at commit [`801c91d`](https://gith

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110616394 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2015-06-09 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-110616280 It does send all keys to all partitions, because `ksByPartition` is referenced in the closure passed to `context.runJob` and so is shipped in full to all partitions. O

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110616386 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6726#discussion_r32091890 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -164,13 +164,28 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6726#discussion_r32091897 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -164,13 +164,28 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-8189] [SQL] use Long for TimestampType ...

2015-06-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6733#discussion_r32091823 --- Diff: sql/hive/src/test/resources/golden/timestamp cast #5-0-dbd7bcd167d322d6617b884c02c7f247 --- @@ -1 +1 @@ --0.0010009 +-0.001 -

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110616118 [Test build #34567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34567/consoleFull) for PR 6716 at commit [`11b351c`](https://gith

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-110615991 [Test build #34566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34566/consoleFull) for PR 6726 at commit [`44573a3`](https://gith

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-110615802 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110615775 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110615798 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2015-06-09 Thread josephlijia
Github user josephlijia commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-110615752 Look at the code below: def multiget(ks: Array[Id]): Map[Id, V] = { val ksByPartition = ks.groupBy(k => self.partitioner.get.getPartition(k)) val r

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-110615768 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8189] [SQL] use Long for TimestampType ...

2015-06-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6733#discussion_r32091705 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -155,6 +156,7 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-7261][Core] Change default log level to...

2015-06-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6734#issuecomment-110613004 This looks good, but will wait until #6735 is merged for final sign off. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-8273]Driver hangs up when yarn shutdown...

2015-06-09 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/6717#issuecomment-110612334 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32091043 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -122,7 +122,7 @@ object functions { * @group agg_funcs * @sin

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2015-06-09 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-110610103 @josephlijia Right, getting should generally be faster than putting. However, for large batches of keys, multiget might be slower than multiput because it currently br

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32090941 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -122,7 +122,7 @@ object functions { * @group agg_funcs * @since 1.3.

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32090916 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -163,6 +163,12 @@ class MathFunctionsSuit

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110607377 [Test build #34565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34565/consoleFull) for PR 6718 at commit [`bce0191`](https://gith

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110605446 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110605527 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2015-06-09 Thread josephlijia
Github user josephlijia commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-110605232 Well, I found that getting is slower than putting by using IndexedRDD. But getting should be faster than putting, is it right? I am expecting your reply. Thanks a lo

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110604704 [Test build #34564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34564/consoleFull) for PR 6735 at commit [`5f92dc1`](https://gith

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110604637 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110604629 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110604597 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110602923 [Test build #34563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34563/consoleFull) for PR 6718 at commit [`29ec6c9`](https://gith

[GitHub] spark pull request: [SPARK-8285] [SQL] CombineSum should be calcul...

2015-06-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6736#issuecomment-110602698 Jenkins, add to whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110601783 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110601842 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8285] [SQL] CombineSum should be calcul...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6736#issuecomment-110596738 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8285] [SQL] CombineSum should be calcul...

2015-06-09 Thread navis
GitHub user navis opened a pull request: https://github.com/apache/spark/pull/6736 [SPARK-8285] [SQL] CombineSum should be calculated as unlimited decimal first case cs @ CombineSum(expr) => val calcType = expr.dataType expr.dataType match {

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6712#discussion_r32089187 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala --- @@ -71,43 +71,49 @@ private[spark] case class PythonUDF( private[spark

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32089147 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -163,6 +163,12 @@ class MathFunctionsS

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6712#discussion_r32089158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -460,7 +460,7 @@ class Analyzer( def apply(plan: Log

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32089027 --- Diff: python/pyspark/sql/functions.py --- @@ -138,6 +138,13 @@ def _(): 'bitwiseNOT': 'Computes bitwise not.', } +_functions_1_5 = {

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32089009 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -100,6 +125,16 @@ abstract class BinaryMathExpression(f: (Doub

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088989 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e():

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088982 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e():

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088958 --- Diff: python/pyspark/sql/functions.py --- @@ -188,11 +195,14 @@ def _(): globals()[_name] = since(1.4)(_create_binary_mathfunction(_name, _doc))

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088977 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e():

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592407 [Test build #34562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34562/consoleFull) for PR 6716 at commit [`db331c9`](https://gith

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592227 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592215 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110592027 And also add `sql` query for unittest, just be sure the UDF registration works. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6724#issuecomment-110591190 [Test build #34561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34561/consoleFull) for PR 6724 at commit [`3c729aa`](https://gith

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088624 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -163,6 +163,12 @@ class MathFunctionsS

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1106,6 +1106,22 @@ object functions { def log1p(columnName: String

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6724#issuecomment-110590517 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6724#issuecomment-110590532 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6718#issuecomment-110589965 Please also add unit tests to DataFrameFunctionSuite. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088344 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1106,6 +1106,22 @@ object functions { def log1p(columnName: String): Column

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088336 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1106,6 +1106,22 @@ object functions { def log1p(columnName: String): Column

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110589471 [Test build #34560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34560/console) for PR 6716 at commit [`599ddd8`](https://github.

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110589481 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1106,6 +1106,22 @@ object functions { def log1p(columnName: String):

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588870 [Test build #34560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34560/consoleFull) for PR 6716 at commit [`599ddd8`](https://gith

[GitHub] spark pull request: [SPARK-8217] [SQL] math function log2

2015-06-09 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6718#discussion_r32088206 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1106,6 +1106,22 @@ object functions { def log1p(columnName: String):

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588564 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588606 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7261][Core] Change default log level to...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6734#issuecomment-110588411 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7261][Core] Change default log level to...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6734#issuecomment-110588405 [Test build #34558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34558/console) for PR 6734 at commit [`3835eff`](https://github.

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6712#issuecomment-110588254 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7886] Use FunctionRegistry for built-in...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6712#issuecomment-110588248 [Test build #34559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34559/console) for PR 6712 at commit [`f4c2df0`](https://github.

[GitHub] spark pull request: [SPARK-8202] [PYSPARK] fix infinite loop durin...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6714#issuecomment-110586044 [Test build #893 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/893/consoleFull) for PR 6714 at commit [`b170dfb`](https://githu

[GitHub] spark pull request: [SPARK-7984][Graphx]Complex Operators between ...

2015-06-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6685#issuecomment-110583555 cc @ankurdave --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110583416 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7527][Core]Fix createNullValue to retur...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6735#issuecomment-110583405 [Test build #34557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34557/console) for PR 6735 at commit [`5f92dc1`](https://github.

[GitHub] spark pull request: [SPARK-8129] [CORE] [SECURITY] Securely pass a...

2015-06-09 Thread kanzhang
Github user kanzhang commented on the pull request: https://github.com/apache/spark/pull/6676#issuecomment-110579838 > Nothing else in the rest of the code should need to change. Yes, if you are extending the current model where there is a single secret key for the whole clust

[GitHub] spark pull request: [SPARK-8202] [PYSPARK] fix infinite loop durin...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6714#issuecomment-110578345 **[Test build #892 timed out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/892/console)** for PR 6714 at commit [`5c21777`](https://github.

[GitHub] spark pull request: [SPARK-8129] [CORE] [SECURITY] Securely pass a...

2015-06-09 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/6676#issuecomment-110578274 BTW, using an env variable is mostly a trivial change. You just change the non-YARN path in `SecurityManager::generateSecretKey`; basically, on the driver side, generate

[GitHub] spark pull request: [SPARK-8075][SQL] apply type check interface t...

2015-06-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6723#discussion_r32086331 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala --- @@ -81,6 +82,8 @@ private[hive] case class HiveSimpleUdf(funcWrapper: HiveFu

[GitHub] spark pull request: [SPARK-7824][SQL]Collapsing operator reorderin...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6351#issuecomment-110578051 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-6976][SQL] "drop table if exists src" p...

2015-06-09 Thread DoingDone9
Github user DoingDone9 closed the pull request at: https://github.com/apache/spark/pull/5553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7824][SQL]Collapsing operator reorderin...

2015-06-09 Thread DoingDone9
GitHub user DoingDone9 reopened a pull request: https://github.com/apache/spark/pull/6351 [SPARK-7824][SQL]Collapsing operator reordering and constant folding into a single batch to push down the single side. SQL ``` select * from tableA join tableB on (a > 3 and b = d) or

[GitHub] spark pull request: [SPARK-8129] [CORE] [SECURITY] Securely pass a...

2015-06-09 Thread kanzhang
Github user kanzhang commented on the pull request: https://github.com/apache/spark/pull/6676#issuecomment-110574239 Ok, that's exactly the kind of opinion I want to hear about. Do others feel the same way? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-7261][Core] Change default log level to...

2015-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6734#issuecomment-110574078 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7261][Core] Change default log level to...

2015-06-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6734#issuecomment-110574068 [Test build #34553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34553/console) for PR 6734 at commit [`2cb5bbc`](https://github.

[GitHub] spark pull request: [SPARK-8248][SQL] string function: length

2015-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6724#discussion_r32085774 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringFunctionsSuite.scala --- @@ -215,4 +215,15 @@ class StringFunctionsSuite e

  1   2   3   4   5   6   7   8   >