Github user nishkamravi2 commented on the pull request:
https://github.com/apache/spark/pull/6607#issuecomment-117527403
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7148#issuecomment-117529583
[Test build #36234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36234/console)
for PR 7148 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7148#issuecomment-117529830
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6756#issuecomment-117540334
[Test build #36240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36240/consoleFull)
for PR 6756 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117542146
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7064#issuecomment-117543547
[Test build #990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/990/consoleFull)
for PR 7064 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117544824
LGTM. I will merge tomorrow morning after the current run passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117544780
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117544724
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6756#issuecomment-117546393
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6756#issuecomment-117546351
[Test build #36240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36240/console)
for PR 6756 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7151#issuecomment-117549366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4229#issuecomment-117550718
Sure. I think I can add test. But help to implement MQTTUtilsPythonHelper
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4229#issuecomment-117530565
@tdas I think we should add test for this and MQTTUtilsPythonHelper.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6672#discussion_r33658277
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockStatusListenerSuite.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6756#issuecomment-117539815
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6672#issuecomment-117539747
Can you put a final screenshot of what it looks like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6756#issuecomment-117539794
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7140#issuecomment-117541003
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6672#issuecomment-117540863
Other than these small comments, LGTM as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4229#issuecomment-117540680
Yes, you have to add tests. Take a look at the Flume Python API patch #6830
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7146#issuecomment-117542621
At best, this exchanges one number for another, so does that help anything?
This changes semantics a bit if there are any subclasses. I don't think this is
something to
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6939#issuecomment-117544502
I will wait for the #6830 to be merged which is more contentious. Some
things may need to be updated in this PR if there are conflicts. And then we
will be able to run
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117545192
[Test build #36241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36241/consoleFull)
for PR 6830 at commit
Github user lianhuiwang commented on the pull request:
https://github.com/apache/spark/pull/6875#issuecomment-117548581
@davies yes,i get it. at first, i think we can have a flag to do sort based
aggregation on reduce stage that replace with hash based aggregation. and then
based on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7151#issuecomment-117548977
[Test build #36237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36237/console)
for PR 7151 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7149#issuecomment-117552516
[Test build #36239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36239/console)
for PR 7149 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7149#issuecomment-117552967
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7064#issuecomment-117556606
[Test build #990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/990/console)
for PR 7064 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33705725
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -59,9 +62,24 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33705759
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -59,9 +62,24 @@ private[spark] class
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33706009
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -208,20 +239,61 @@ class LinearRegression(override val uid:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6648#issuecomment-117775665
[Test build #36289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36289/consoleFull)
for PR 6648 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5707#issuecomment-11874
LGTM merging with master
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6760#issuecomment-117780258
LGTM merging into master
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33707474
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -206,8 +228,7 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33707677
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -264,17 +286,33 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6750#discussion_r33707944
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -547,6 +554,136 @@ class DAGSchedulerSuite
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33707899
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -142,8 +154,8 @@ private[spark] class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33709641
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-117791564
Actually, maybe @pwendell or @zsxwing can comment on the Avro dependency
concerns (@zsxwing, because you mentioned Avro dependency issues in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7132#issuecomment-117792509
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33710731
--- Diff: core/pom.xml ---
@@ -398,6 +398,40 @@
artifactIdpy4j/artifactId
version0.8.2.1/version
/dependency
+dependency
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-117793431
I guess the real concern is over whether adding this dependency would
create JAR hell for our users.
I don't think it really changes anything. `avro` is
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-117794987
I am merging this to master. Thanks @zsxwing !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7159#issuecomment-117737815
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7057#issuecomment-117739502
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7130#issuecomment-117744398
[Test build #36281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36281/consoleFull)
for PR 7130 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r33698111
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java ---
@@ -307,7 +313,7 @@ void forceSorterToSpill() throws IOException {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6743#discussion_r33700035
--- Diff: core/src/main/scala/org/apache/spark/api/r/RUtils.scala ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7158#issuecomment-117757054
**[Test build #36266 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36266/console)**
for PR 7158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7158#issuecomment-117757082
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7149#issuecomment-117758924
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7162#issuecomment-117759250
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r33703131
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -220,6 +222,404 @@ case class EndsWith(left:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7162#issuecomment-117761268
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7162#discussion_r33703139
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala ---
@@ -68,15 +99,45 @@ class SparkPlanTest extends SparkFunSuite {
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7132#issuecomment-117763077
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7132#discussion_r33703705
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/JavaUtils.java ---
@@ -25,13 +32,6 @@
import java.util.regex.Matcher;
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7132#issuecomment-117763120
LGTM. Thanks for abstracting it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704993
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -113,8 +113,9 @@ private[sql] class ParquetRelation2(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704979
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704974
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33705062
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -286,4 +324,40 @@ private[spark] class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704967
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -227,6 +227,13 @@ private[spark] object SQLConf {
defaultValue =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33705001
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704981
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704964
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -227,6 +227,13 @@ private[spark] object SQLConf {
defaultValue =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704987
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-117771696
**[Test build #992 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/992/console)**
for PR 6205 at commit
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33706024
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -208,20 +239,61 @@ class LinearRegression(override val uid:
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/6904#issuecomment-117772123
Have I done it correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33705995
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -208,20 +239,61 @@ class LinearRegression(override val uid:
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33706140
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,7 +143,10 @@ class LinearRegression(override val uid:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33706732
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -169,14 +190,15 @@ private[spark] class
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7153#issuecomment-117776545
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33707814
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -286,4 +324,40 @@ private[spark] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7132#issuecomment-117786168
@pwendell This is a major change. Where should we document it for the 1.5
release?
---
If your project is set up for it, you can reply to this email and have your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6750#discussion_r33708206
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -128,4 +128,20 @@ class TaskSchedulerImplSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33709017
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -264,17 +286,33 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33709279
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -264,17 +286,33 @@ private[spark] class
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/spark/pull/7132#discussion_r33709898
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/JavaUtils.java ---
@@ -25,13 +32,6 @@
import java.util.regex.Matcher;
import
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7132#issuecomment-117791011
Maybe we can create a release notes Google Doc or a page on the Apache
CWiki for holding a list of things which need to go into the release notes?
---
If your
Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/7160#issuecomment-117792531
@mengxr @jkbradley Initially reported this, perhaps he should weigh in here?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33710179
--- Diff: core/pom.xml ---
@@ -398,6 +398,41 @@
artifactIdpy4j/artifactId
version0.8.2.1/version
/dependency
+dependency
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7013#discussion_r33710275
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -37,6 +37,17 @@ private[sql] class DefaultSource
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33710516
--- Diff: core/pom.xml ---
@@ -398,6 +398,40 @@
artifactIdpy4j/artifactId
version0.8.2.1/version
/dependency
+dependency
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7130#issuecomment-117793286
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7146#issuecomment-117793085
I think @aloknsingh 's points are valid. Both `1994` and `7919` are magic
numbers, which we should avoid in the code.
---
If your project is set up for it, you can
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7146#discussion_r33710483
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -193,7 +193,8 @@ private[spark] class MatrixUDT extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7130#issuecomment-117793176
[Test build #36281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36281/console)
for PR 7130 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33710870
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -286,4 +324,40 @@ private[spark] class
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7146#issuecomment-117795327
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33711743
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -286,4 +324,40 @@ private[spark] class
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6904#issuecomment-117769874
MiMa doesn't know it. So we still need to add the exclusion rules
explicitly, otherwise it won't pass Jenkins.
---
If your project is set up for it, you can reply to
1 - 100 of 1082 matches
Mail list logo
