[GitHub] spark pull request: [SPARK-9954] [MLLIB] use first 64 nonzeros to ...

2015-08-17 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8182#issuecomment-132095487 Great. But is there any reason why 64 is chosen in particular? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: SPARK-8918 Add @since tags to mllib.clustering

2015-08-17 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8256#issuecomment-132095154 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: SPARK-8918 Add @since tags to mllib.clustering

2015-08-17 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8256#issuecomment-132095254 ping @yu-iskw to make another pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-10076] [ML] make MultilayerPerceptronCl...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10076] [ML] make MultilayerPerceptronCl...

2015-08-17 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8263#issuecomment-132094839 Merged into master and branch-1.5. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8264#discussion_r37268547 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -682,6 +682,14 @@ object functions { * Generate a random column with i.i

[GitHub] spark pull request: [SPARK-9780][Streaming][Kafka] prevent NPE if ...

2015-08-17 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/8133#issuecomment-132091090 This PR has already been merged to suppress the NPE when someone messes up instantiation On Aug 18, 2015 1:13 AM, "Shyam S Kumar" wrote: > Yes... I

[GitHub] spark pull request: [SPARK-10031][SQL] Join two UnsafeRows in Sort...

2015-08-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/8226#issuecomment-132090343 @chenghao-intel Currently we will do an `UnsafeProjection` for two `UnsafeRow`s. I think it will also create a new `UnsafeRow`? This patch replaces it with a `Gen

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132089194 Thank you for reviewing and merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088707 [Test build #41096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41096/consoleFull) for PR 8197 at commit [`1dfe7f6`](https://gith

[GitHub] spark pull request: [SPARK-10038] [SQL] fix bug in generated unsaf...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088561 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10038] [SQL] fix bug in generated unsaf...

2015-08-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8250#issuecomment-132088508 I've merged this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088562 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132088418 I'm going to merge this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088488 [Test build #41094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41094/console) for PR 8197 at commit [`1dfe7f6`](https://github.

[GitHub] spark pull request: KafKaDirectDstream should filter empty partiti...

2015-08-17 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8237#issuecomment-132087668 I understand and I have debated about this before. This is one of those grey areas where there is no golden solution. In such cases, I think it is better to err towards hav

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132087134 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132087124 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132086966 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132086964 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132086852 [Test build #41092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41092/console) for PR 8265 at commit [`08ed8cc`](https://github.

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086638 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132086677 [Test build #41095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41095/consoleFull) for PR 8178 at commit [`6e5fdc2`](https://gith

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132086570 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086612 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086610 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132086559 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10072][STREAMING] BlockGenerator can de...

2015-08-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/8257#discussion_r37267126 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala --- @@ -227,16 +227,21 @@ private[streaming] class BlockGenerator(

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132086031 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132085620 [Test build #41094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41094/consoleFull) for PR 8197 at commit [`1dfe7f6`](https://gith

[GitHub] spark pull request: [SPARK-9780][Streaming][Kafka] prevent NPE if ...

2015-08-17 Thread shyamsalimkumar
Github user shyamsalimkumar commented on the pull request: https://github.com/apache/spark/pull/8133#issuecomment-132085442 Yes... I know. :smile: I had forgotten to accept `props: VerifiableProperties` in it. Silly me. But I still think that the error thrown is misleading (unless of

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132084903 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132084922 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132084887 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132084886 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132084853 [Test build #41091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41091/console) for PR 8264 at commit [`28e63fc`](https://github.

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083744 @feynmanliang I have moved the guide to `ml-linear-models`. Can you give another pass? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083259 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083150 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8264#discussion_r37266434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -682,6 +682,14 @@ object functions { * Generate a random column with i.i.

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-08-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5358#issuecomment-132077017 @cloud-fan can you take this over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132076982 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132076956 **[Test build #41089 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41089/console)** for PR 8258 at commit [`d8831a2`](https://github

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132076981 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10031][SQL] Join two UnsafeRows in Sort...

2015-08-17 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8226#issuecomment-132076896 As we cannot tell what downstream operator is inside of the spark plan operator, it's hard to tell if it's really an optimization. JoinedRow is used here for redu

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37265276 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); +## Examples: Summaries for LogisticRegression. + +Once [`Log

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8264#discussion_r37265212 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -682,6 +682,14 @@ object functions { * Generate a random column with i.i.d.

[GitHub] spark pull request: [MINOR] fix the comments in IndexShuffleBlockR...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8238#issuecomment-132074474 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR] fix the comments in IndexShuffleBlockR...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8238#issuecomment-132074479 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [MINOR] fix the comments in IndexShuffleBlockR...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8238#issuecomment-132074290 [Test build #41090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41090/console) for PR 8238 at commit [`1aea5c4`](https://github.

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132070297 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-8505][SparkR] Add settings to kick `lin...

2015-08-17 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/7883#issuecomment-132070168 On Mon, Aug 17, 2015 at 10:11 AM, Shivaram Venkataraman < notificati...@github.com> wrote: > @JoshRosen There seems to be so

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132070173 @feynmanliang All right, I shall reorganize the code right now. Could you wait for the LinearRegressionSummary till this is merged? It would make things simpler. (reba

[GitHub] spark pull request: [SPARK-9431][SQL]TimeIntervalType for for time...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8224#issuecomment-132069382 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9431][SQL]TimeIntervalType for for time...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8224#issuecomment-132069384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9431][SQL]TimeIntervalType for for time...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8224#issuecomment-132069348 [Test build #41088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41088/console) for PR 8224 at commit [`23bc693`](https://github.

[GitHub] spark pull request: [SPARK-7289] [SPARK-9949] [SQL] Backport SPARK...

2015-08-17 Thread yhuai
Github user yhuai closed the pull request at: https://github.com/apache/spark/pull/8252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [SPARK-7289] [SPARK-9949] [SQL] Backport SPARK...

2015-08-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8252#issuecomment-132069066 OK. Merged. I am closing this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7289] [SPARK-9949] [SQL] Backport SPARK...

2015-08-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8252#issuecomment-132068944 Thanks. I am merging it to branch 1.4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10001] [CORE] Allow Ctrl-C in spark-she...

2015-08-17 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/8216#issuecomment-132068722 Hmm, not sure why a test case fails in YarnClusterSuite, but it seems failing constantly. I'll investigate it. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132067484 [Test build #41092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41092/consoleFull) for PR 8265 at commit [`08ed8cc`](https://gith

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-132066171 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-132066174 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-132066059 [Test build #41082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41082/console) for PR 8007 at commit [`70d6a15`](https://github.

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132065943 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8265#issuecomment-132065952 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10001] [CORE] Allow Ctrl-C in spark-she...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8216#issuecomment-132065891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10001] [CORE] Allow Ctrl-C in spark-she...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8216#issuecomment-132065892 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10001] [CORE] Allow Ctrl-C in spark-she...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8216#issuecomment-132065858 [Test build #41083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41083/console) for PR 8216 at commit [`c03bf07`](https://github.

[GitHub] spark pull request: [SPARK-10053] Export lapply and lapplyPartitio...

2015-08-17 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8240#issuecomment-132065626 RDD API is deliberatly hidden in spark 1.4. For discussion of exposing subset of RDD API and high level parallel computation API, please refer to https://issues.apache.

[GitHub] spark pull request: [Minor] Format the comment of `translate` at `...

2015-08-17 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/8265 [Minor] Format the comment of `translate` at `functions.scala` You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark minor-translate-com

[GitHub] spark pull request: SPARK-8918 Add @since tags to mllib.clustering

2015-08-17 Thread XiaoqingWang
Github user XiaoqingWang closed the pull request at: https://github.com/apache/spark/pull/7662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132064057 Thanks @yu-iskw -- Change looks pretty good to me and the test cases are especially good. Thanks for adding that. Lets see if @rxin or @davies have any thought

[GitHub] spark pull request: SPARK-8918 Add @since tags to mllib.clustering

2015-08-17 Thread XiaoqingWang
Github user XiaoqingWang commented on the pull request: https://github.com/apache/spark/pull/8229#issuecomment-132064089 thanks, https://github.com/apache/spark/pull/8256,based on master pull to master,please help to review,7662 has been closed --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132064071 [Test build #41091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41091/consoleFull) for PR 8264 at commit [`28e63fc`](https://gith

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132063884 @shivaram Yeah, I have checked it with {{lint-r}} before sending a PR. There was no warning. Thanks! --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: SPARK-10074 Include Float in @specialized anno...

2015-08-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/8259#issuecomment-132063810 Test failures don't seem to be related to the PR. Not sure whether the following is a test or not: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132063779 @yu-iskw could you also check if `lint-r` is happy on your machine ? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8264#discussion_r37262119 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -682,6 +682,14 @@ object functions { * Generate a random column with i.i

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132063550 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8264#issuecomment-132063539 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9856][SparkR] Add expression functions ...

2015-08-17 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/8264 [SPARK-9856][SparkR] Add expression functions into SparkR whose params are complicated I added lots of Column functinos into SparkR. And I also added `rand(seed: Int)` and `randn(seed: Int)` in Sca

[GitHub] spark pull request: SPARK-10074 Include Float in @specialized anno...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8259#issuecomment-132063340 [Test build #41080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41080/console) for PR 8259 at commit [`cc2021a`](https://github.

[GitHub] spark pull request: SPARK-10074 Include Float in @specialized anno...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8259#issuecomment-132063371 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: SPARK-10074 Include Float in @specialized anno...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8259#issuecomment-132063369 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132063076 Ah got it! Thanks for the explanation :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-10038] [SQL] fix bug in generated unsaf...

2015-08-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8250#issuecomment-132062762 Ah good catch! The change LGTM. Not related to this PR, but as we have more and more hack(equals, hashCode, etc.) for binary type, should we create a wrapper c

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132057171 **[Test build #1639 timed out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1639/console)** for PR 8178 at commit [`6e5fdc2`](https://githu

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132056582 **[Test build #1637 timed out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1637/console)** for PR 8178 at commit [`6e5fdc2`](https://githu

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132056044 @cloud-fan Conjunctions (`And` predicates) are more friendlier to filter push-down optimization. Because it doesn't require both branches to be convertible. Take predi

[GitHub] spark pull request: KafKaDirectDstream should filter empty partiti...

2015-08-17 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/8237#issuecomment-132054268 @tdas, yean, I agree with it will be confused in semantics, and for a batch streaming system, it will not blocked the next batch as long as it will finished quickly, e

[GitHub] spark pull request: [SPARK-10072][STREAMING] BlockGenerator can de...

2015-08-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/8257#discussion_r37260735 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala --- @@ -227,16 +227,21 @@ private[streaming] class BlockGenerator

[GitHub] spark pull request: [SPARK-10072][STREAMING] BlockGenerator can de...

2015-08-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/8257#discussion_r37260487 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala --- @@ -227,16 +227,21 @@ private[streaming] class BlockGenerator

[GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8178#issuecomment-132047283 [Test build #1638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1638/console) for PR 8178 at commit [`6e5fdc2`](https://github

[GitHub] spark pull request: [MINOR] fix the comments in IndexShuffleBlockR...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8238#issuecomment-132047727 [Test build #41090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41090/consoleFull) for PR 8238 at commit [`1aea5c4`](https://gith

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132046684 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132046490 [Test build #41077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41077/console) for PR 8258 at commit [`cfef35d`](https://github.

[GitHub] spark pull request: [SPARK-7736] [core] Fix a race introduced in P...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8258#issuecomment-132046688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

  1   2   3   4   5   6   7   8   9   >