[GitHub] spark pull request: [SPARK-10381] Fix mixup of taskAttemptNumber &...

2015-09-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-136799235 I ended up having to add some MiMa excludes. These only impact internal classes but they are RPCs that are sent over the wire. Would be good to get confirmation that

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136808541 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread frodeso
Github user frodeso commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136813226 @cloud-fan @yhuai I just did the same and came to the same conclusion. We are not actually involved in the connector, just a user of it so no guarantees though.

[GitHub] spark pull request: [SPARK-10381] Fix mixup of taskAttemptNumber &...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8544#discussion_r38452084 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -29,7 +29,7 @@ import org.apache.spark.annotation.DeveloperApi class

[GitHub] spark pull request: [SPARK-10288][Yarn] Add REST client for Spark ...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8504#issuecomment-136821267 @jerryshao doesn't YARN already come with a stable REST API [1] for submitting applications? The main reason why we did it for standalone mode is because the Master

[GitHub] spark pull request: [SPARK-10398] [DOCS] Migrate Spark download pa...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8557#issuecomment-136826504 [Test build #41872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41872/console) for PR 8557 at commit

[GitHub] spark pull request: [SPARK-10398] [DOCS] Migrate Spark download pa...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8557#issuecomment-136826631 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-136826444 I'll have a close look at this later today, but at a quick glance the high level approach seems reasonable. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136828857 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458069 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -565,12 +603,25 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136828901 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458023 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -103,13 +105,46 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136831122 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread 0x0FFF
Github user 0x0FFF commented on a diff in the pull request: https://github.com/apache/spark/pull/8556#discussion_r38460209 --- Diff: python/pyspark/sql/types.py --- @@ -168,10 +168,12 @@ def needConversion(self): return True def toInternal(self, d):

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread 0x0FFF
Github user 0x0FFF commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136836673 Added regression test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8506#issuecomment-136838302 @vanzin could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136800416 [Test build #41877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41877/consoleFull) for PR 8559 at commit

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136806464 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136806465 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136813686 @frodeso This one has been merged. When we release 1.4.2, the name of that strategy will be the same. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8358#issuecomment-136817295 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136817048 @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [DO NOT MERGE] remove the messageScheduler sin...

2015-09-01 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/8560 [DO NOT MERGE] remove the messageScheduler since its not neeeded just testing You can merge this pull request into a Git repository by running: $ git pull https://github.com/squito/spark

[GitHub] spark pull request: [SPARK-10398] [DOCS] Migrate Spark download pa...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8556#discussion_r38460758 --- Diff: python/pyspark/sql/types.py --- @@ -168,10 +168,12 @@ def needConversion(self): return True def toInternal(self, d):

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136834539 [Test build #41885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41885/consoleFull) for PR 8555 at commit

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-01 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-136836260 Sure man - I'll do this shortly. Thanks. Thank you, Ilya Ganelin -Original Message- From: Imran Rashid

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136801581 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136801584 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10394] [ML] Make GBTParams use shared s...

2015-09-01 Thread rotationsymmetry
Github user rotationsymmetry commented on a diff in the pull request: https://github.com/apache/spark/pull/8552#discussion_r38449179 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -337,7 +337,7 @@ private[ml] trait HasStepSize extends

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136810409 [Test build #41878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41878/consoleFull) for PR 8559 at commit

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8559#discussion_r38451269 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1242,7 +1259,7 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread frodeso
Github user frodeso commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136814280 @yhuai Thanks, much appreciated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8358#issuecomment-136820689 [Test build #41879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41879/consoleFull) for PR 8358 at commit

[GitHub] spark pull request: [SPARK-10379] preserve first page in UnsafeShu...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8543#issuecomment-136822521 @davies looks like the test needs to be modified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8556#discussion_r38456406 --- Diff: python/pyspark/sql/types.py --- @@ -168,10 +168,12 @@ def needConversion(self): return True def toInternal(self, d):

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458893 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -565,12 +603,25 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136840750 [Test build #41887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41887/consoleFull) for PR 7976 at commit

[GitHub] spark pull request: SPARK-10314 [CORE]RDD persist to OFF_HEAP tach...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8482#issuecomment-136840774 @romansew please submit this patch against the master branch instead. It would be good to have a consistent fix in both newer and older branches. --- If your

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8437#issuecomment-136842836 @JoshRosen should look at this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10394] [ML] Make GBTParams use shared s...

2015-09-01 Thread rotationsymmetry
Github user rotationsymmetry commented on a diff in the pull request: https://github.com/apache/spark/pull/8552#discussion_r38443083 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -337,7 +337,7 @@ private[ml] trait HasStepSize extends

[GitHub] spark pull request: [SPARK-10199][MLlib]Avoid using reflections fo...

2015-09-01 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8507#discussion_r38446219 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala --- @@ -159,19 +159,25 @@ object GaussianMixtureModel

[GitHub] spark pull request: [SPARK-10264][Documentation, ML] Added Since a...

2015-09-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8532#discussion_r38448746 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -178,6 +178,7 @@ private[recommendation] trait ALSParams extends

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136812635 @cloud-fan I did a quick of their repo. Looks like they have their own SQLContext and refer to the `TakeOrdered` strategy at there. Looks like it is fine that we do not

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136825789 @0x0FFF Thanks for working on this, could you add a regression test for it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458197 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -103,13 +105,46 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [DO NOT MERGE] remove the messageScheduler sin...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8560#issuecomment-136829302 [Test build #41882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41882/consoleFull) for PR 8560 at commit

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458330 --- Diff: core/src/test/scala/org/apache/spark/DependencySuite.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458368 --- Diff: core/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala --- @@ -75,7 +76,8 @@ private[spark] class CoGroupPartition( * @param part

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136831124 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136798504 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136798398 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136798868 I believe that we've also made other strategy renames in recent patches, including a rename of the join selection strategy (it's no longer called HashJoinStrategy).

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136800201 Is that in branch 1.4? Looks like we still have `HashJoin` in 1.4 branch. This PR changes the name of `TakeOrderedAndProject` back `TakeOrdered` for 1.4 branch. So, users

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136800148 [Test build #41875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41875/consoleFull) for PR 8556 at commit

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136806928 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10023] [ML] [PySpark] Unified DecisionT...

2015-09-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8528#discussion_r38449868 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala --- @@ -56,7 +56,8 @@ private[shared] object SharedParamsCodeGen {

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136816836 @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10299][ML] word2vec should allow users ...

2015-09-01 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/8513#discussion_r38454541 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136821873 [Test build #41880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41880/consoleFull) for PR 8555 at commit

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8555#discussion_r38456059 --- Diff: python/pyspark/sql/types.py --- @@ -1290,8 +1290,9 @@ def can_convert(self, obj): def convert(self, obj, gateway_client):

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-136832067 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136840867 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136840864 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136840860 [Test build #41887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41887/console) for PR 7976 at commit

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8559#discussion_r38451212 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1123,8 +1133,15 @@ class DAGScheduler( // TODO: Cancel

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136820437 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136820479 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [DO NOT MERGE] remove the messageScheduler sin...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8560#issuecomment-13682 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136827809 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136827786 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [DO NOT MERGE] remove the messageScheduler sin...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8560#issuecomment-136827811 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-01 Thread eracah
Github user eracah commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-136832080 @andrewor14 Fixed. Tested locally with [scalastyle](http://www.scalastyle.org/) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136832134 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7976#issuecomment-136832132 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-136832030 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136837439 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136837411 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136837583 [Test build #41886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41886/consoleFull) for PR 8556 at commit

[GitHub] spark pull request: SPARK-10314 [CORE]RDD persist to OFF_HEAP tach...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8482#issuecomment-136841179 Also, I looked at the definition of `BlockStatus#isCached`. Looks like it already takes into account external block store size? Is Tachyon somehow not caching your

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread massie
Github user massie commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38463750 --- Diff: core/src/main/scala/org/apache/spark/Dependency.scala --- @@ -76,6 +78,15 @@ class ShuffleDependency[K, V, C]( override def rdd:

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136808491 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9679][ML][PYSPARK] Add Python API for S...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6157][CORE]Unroll unsuccessful memory_a...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4887#issuecomment-136819519 Sure, I'll have a look later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-136823930 @eracah can you fix the style errors? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10116] [core] XORShiftRandom.hashSeed i...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8314#discussion_r38457605 --- Diff: core/src/test/scala/org/apache/spark/util/random/XORShiftRandomSuite.scala --- @@ -65,4 +65,19 @@ class XORShiftRandomSuite extends

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread yhuai
Github user yhuai closed the pull request at: https://github.com/apache/spark/pull/8545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136828311 [Test build #41880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41880/console) for PR 8555 at commit

[GitHub] spark pull request: [SPARK-10116] [core] XORShiftRandom.hashSeed i...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8314#discussion_r38457631 --- Diff: core/src/test/scala/org/apache/spark/util/random/XORShiftRandomSuite.scala --- @@ -65,4 +65,19 @@ class XORShiftRandomSuite extends

[GitHub] spark pull request: [SPARK-10398] [DOCS] Migrate Spark download pa...

2015-09-01 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8557#issuecomment-136829325 The failures must be spurious. One is a doc-only change; the other affects a docker script that isn't involved in the tests here. (Actually I'm not sure that download

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458787 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -565,12 +603,25 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458836 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -103,13 +105,46 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-9043] Serialize key, value and combiner...

2015-09-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7403#discussion_r38458181 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -565,12 +603,25 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-136832825 [Test build #41884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41884/consoleFull) for PR 8514 at commit

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8555#issuecomment-136833119 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10162] [SQL] Fix the timezone omitting ...

2015-09-01 Thread 0x0FFF
Github user 0x0FFF commented on a diff in the pull request: https://github.com/apache/spark/pull/8555#discussion_r38461951 --- Diff: python/pyspark/sql/types.py --- @@ -1290,8 +1290,9 @@ def can_convert(self, obj): def convert(self, obj, gateway_client):

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136798468 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10392] [SQL] Pyspark - Wrong DateType s...

2015-09-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8556#issuecomment-136798336 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

2015-09-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8545#issuecomment-136800812 Ah, gotcha. They're still going to have to update for 1.5, though, and will need to use reflection if they want to be compatible across 1.4.x and 1.5.x (or ship

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2015-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8559#issuecomment-136806155 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   3   4   5   6   7   >