[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41569134 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -507,16 +500,17 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146685224 Overall looks good! Left a few clarification questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146692581 @cloud-fan Hi Wenchen, Can you please review the update to the test case ? Thank you. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-10863][SPARKR] Method coltypes() to get...

2015-10-08 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8984#issuecomment-146695587 There are a number of ways to do this, so this is just the way I do it personally. In my case I have two remotes in my git setup. So my .git/config looks something

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread rerngvit
Github user rerngvit commented on the pull request: https://github.com/apache/spark/pull/8962#issuecomment-146695490 The errors seem not related to the PR. There might be an issue with Jenkins. "ERROR: Timeout after 15 minutes ERROR: Error fetching remote repo 'origin'" ---

[GitHub] spark pull request: [SPARK-8029][core] shuffleoutput per attempt

2015-10-08 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/6648#discussion_r41575081 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -163,12 +163,12 @@ public void

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146701665 [Test build #43433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43433/consoleFull) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146701450 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581748 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala --- @@ -187,72 +266,124 @@ class

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581661 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala --- @@ -170,10 +232,27 @@ class

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41582484 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146714538 [Test build #43439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43439/consoleFull) for PR 9016 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41583538 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10337][SQL][1.5] fix hive views on non-...

2015-10-08 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/9032 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146683991 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146683971 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10858] YARN: archives/jar/files rename ...

2015-10-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9035#issuecomment-146683862 Pretty sure this is right, yeah --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41569596 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -507,16 +500,17 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146686989 [Test build #43429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43429/consoleFull) for PR 9016 at commit

[GitHub] spark pull request: [SPARK-10988] [SQL] Reduce duplication in Aggr...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9015#discussion_r41570443 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala --- @@ -280,17 +286,25 @@ class

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146690958 Since this is the infrastructural work of encoder/decoder, let's merge this and use a follow-up pr to address the comments. So, other people can start to play with it.

[GitHub] spark pull request: [SPARK-8848] [SQL] Refactors Parquet write pat...

2015-10-08 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8988#issuecomment-14671 @davies Although Hive doesn't write using standard Parquet format, it can read standard LIST and MAP. It just doesn't recognize compact decimals. So even if we turn

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146702398 [Test build #43434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43434/consoleFull) for PR 9030 at commit

[GitHub] spark pull request: [SPARK-10855] [SQL] Add a JDBC dialect for Apa...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8982#issuecomment-146709463 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8973#discussion_r41579471 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -95,98 +92,192 @@ private[sql] case

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41579375 --- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41579542 --- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-08 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-146709745 cc @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10337][SQL][1.5] fix hive views on non-...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9032#issuecomment-146712072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10337][SQL][1.5] fix hive views on non-...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9032#issuecomment-146712073 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41582280 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146714531 [Test build #1862 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1862/consoleFull) for PR 9009 at commit

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146714417 Thanks! I'll merge this with master once tests pass. Would you be able to send PRs against branch-1.3, branch-1.4, branch-1.5 in order to backport this to

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41583297 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41583336 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146715641 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146715628 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146718346 [Test build #43441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43441/consoleFull) for PR 9016 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41584460 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoOutputStream.scala --- @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146718362 [Test build #43442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43442/consoleFull) for PR 9039 at commit

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146718419 [Test build #43442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43442/console) for PR 9039 at commit

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-146672326 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41562417 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-8848] [SQL] Refactors Parquet write pat...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8988#issuecomment-146675252 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41563670 --- Diff: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala --- @@ -1040,17 +1044,23 @@ class BlockManagerSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41565813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */

[GitHub] spark pull request: Revert [SPARK-8654] [SQL] Fix Analysis excepti...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9034#issuecomment-146680688 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146680629 [Test build #43414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43414/console) for PR 9030 at commit

[GitHub] spark pull request: [SPARK-8170][Python]Add signal handler to trap...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9033#issuecomment-146680651 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Revert [SPARK-8654] [SQL] Fix Analysis excepti...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9034#issuecomment-146680646 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Revert "[SPARK-8654] [SQL] Fix Analysis except...

2015-10-08 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9034 Revert "[SPARK-8654] [SQL] Fix Analysis exception when using NULL IN This reverts commit dcbd58a929be0058b1cfa59b14898c4c428a7680 from #8983 You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-10858] YARN: archives/jar/files rename ...

2015-10-08 Thread tgravescs
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/9035 [SPARK-10858] YARN: archives/jar/files rename with # doesn't work unl https://issues.apache.org/jira/browse/SPARK-10858 The issue here is that in resolveURI we default to calling new

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41568609 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -489,17 +478,21 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41568528 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41568645 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-8170][Python]Add signal handler to trap...

2015-10-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9033#issuecomment-146692696 Jenkins, OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146694615 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8962#issuecomment-146695915 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8962#issuecomment-146696093 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8962#issuecomment-146696116 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146697635 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146703685 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/8973#discussion_r41579349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -95,98 +92,192 @@ private[sql] case

[GitHub] spark pull request: [SPARK-10855] [SQL] Add a JDBC dialect for Apa...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8982#issuecomment-146709482 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10990] [SQL] improve unrolling of compl...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146712971 [Test build #43426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43426/console) for PR 9016 at commit

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581219 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala --- @@ -546,6 +546,9 @@ case class

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581336 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala --- @@ -367,7 +368,7 @@ abstract class

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala --- @@ -321,7 +321,7 @@ abstract class

[GitHub] spark pull request: Revert [SPARK-8654] [SQL] Fix Analysis excepti...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9034#issuecomment-146714788 [Test build #43424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43424/console) for PR 9034 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41582706 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: Revert [SPARK-8654] [SQL] Fix Analysis excepti...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9034#issuecomment-146714882 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Revert [SPARK-8654] [SQL] Fix Analysis excepti...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9034#issuecomment-146714884 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41583434 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARKR] [SPARK-10981] SparkR Join improvement...

2015-10-08 Thread mfliu
Github user mfliu commented on the pull request: https://github.com/apache/spark/pull/9029#issuecomment-146672272 The errors in the log file don't seem to be related to the changes I made? They are primarily in PythonRDD.scala: java.net.SocketException: Socket is closed

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146672235 [Test build #1861 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1861/consoleFull) for PR 9030 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41563377 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41567674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */

[GitHub] spark pull request: [SPARK-8654][SQL] Fix Analysis exception when ...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8983#issuecomment-146682761 just reopen this PR and we will trigger a test on our jenkin for it. For local test, you can do `./build/sbt catalyst/test` --- If your project is set up for

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-08 Thread adrian555
Github user adrian555 commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-146682793 Tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10858] YARN: archives/jar/files rename ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9035#issuecomment-146684626 [Test build #43425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43425/consoleFull) for PR 9035 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41568778 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -507,16 +500,17 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/9036 [SPARK-8654] [SQL] Analysis exception when using NULL IN (...) : invalid cast In the analysis phase , while processing the rules for IN predicate, we compare the in-list types to the lhs

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146694010 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146694130 [Test build #43430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43430/consoleFull) for PR 9036 at commit

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8962#issuecomment-146697127 [Test build #43431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43431/consoleFull) for PR 8962 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41575231 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -525,22 +519,40 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-8029][core] shuffleoutput per attempt

2015-10-08 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/6648#discussion_r41575239 --- Diff: core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java --- @@ -125,6 +129,7 @@ public UnsafeShuffleWriter(

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/9037 [SPARK-10991][ML] logistic regression training summary handle empty prediction col LogisticRegression training summary should still function if the predictionCol is set to an empty string or

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146701946 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702024 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702021 [Test build #43433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43433/console) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702025 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8848] [SQL] Refactors Parquet write pat...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8988#issuecomment-146708775 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8848] [SQL] Refactors Parquet write pat...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8988#issuecomment-146708774 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10863][SPARKR] Method coltypes() to get...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8984#issuecomment-146709030 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10863][SPARKR] Method coltypes() to get...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8984#issuecomment-146708953 [Test build #43418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43418/console) for PR 8984 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41581586 --- Diff: core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41581609 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala --- @@ -170,10 +232,27 @@ class

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41581657 --- Diff: core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11017] Support ImperativeAggregates in ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9038#issuecomment-146715340 [Test build #43438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43438/console) for PR 9038 at commit

<    1   2   3   4   5   6   7   8   9   10   >