Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9000#discussion_r41562570
--- Diff:
core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala ---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on the pull request:
https://github.com/apache/spark/pull/8438#issuecomment-146674050
I get the feeling that the spilling tests I wrote are really really slow,
so I may need to adjust them.
---
If your project is set up for it, you can reply to this
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9000#discussion_r41562951
--- Diff:
core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala ---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user mccheah commented on the pull request:
https://github.com/apache/spark/pull/8438#issuecomment-146673974
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9019#discussion_r41565489
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/8983#issuecomment-146682265
@marmbrus .. sorry about it. Is there a way i can look at the list of
failures ?
I had run :
build/mvn -Pyarn -Phadoop-2.6 -Phive -Phive-thriftserver
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146691810
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8988#issuecomment-146691882
Since we already have an option for being compatible with Hive (the legacy
mode), then we should not worry that (do not need to change anything in this
PR).
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146691960
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146693831
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146693992
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8318#discussion_r41572924
--- Diff: python/pyspark/__init__.py ---
@@ -36,6 +36,31 @@
Finer-grained cache persistence levels.
"""
+import os
+import sys
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9008#discussion_r41573997
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1211,4 +1212,34 @@ private[ml] object RandomForest extends Logging {
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146699044
@marmbrus @yhuai @andrewor14 I should have addressed all of your comments
(except lack of more docs), could you take another pass? The failed test is not
related to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9037#issuecomment-146701173
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146705900
[Test build #43435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43435/consoleFull)
for PR 9036 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8988#issuecomment-146708650
[Test build #43427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43427/console)
for PR 8988 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9000#issuecomment-146713347
[Test build #43437 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43437/consoleFull)
for PR 9000 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41581491
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41583189
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala ---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41583245
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala ---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146715405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41584178
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala ---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/9040
[SPARK-11007] [SQL] Adds dictionary aware Parquet decimal converters
For Parquet decimal columns that are encoded using plain-dictionary
encoding, we can make the upper level converter aware of
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9016#discussion_r41584197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -34,7 +34,8 @@ import org.apache.spark.unsafe.types.UTF8String
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8757#issuecomment-146717274
[Test build #1864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1864/consoleFull)
for PR 8757 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8438#issuecomment-146675573
[Test build #43422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43422/consoleFull)
for PR 8438 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8931#issuecomment-146675441
This is blocked by https://issues.apache.org/jira/browse/SPARK-11013
Will work on that first.
---
If your project is set up for it, you can reply to this email
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8983#issuecomment-146679919
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ashwinshankar77 commented on the pull request:
https://github.com/apache/spark/pull/9033#issuecomment-146679774
@davies
@JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/8988#issuecomment-146681921
The last build failure was caused by #8983, which broke master and has just
been reverted.
---
If your project is set up for it, you can reply to this email and have
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146681852
@mfliu I think thats just a flaky test, but irrespective of that your
changes should be against the current `master` branch. Right now it looks like
there are a lot
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/8988#issuecomment-146681939
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9016#issuecomment-146683593
[Test build #43426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43426/consoleFull)
for PR 9016 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8983#issuecomment-146688197
open a new one is also OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9015#discussion_r41571056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/utils.scala ---
@@ -204,10 +144,13 @@ object Utils {
}
def
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/8984#issuecomment-146693478
@shivaram Could you share the best practices to merge the changes from the
master branch into the PR branch? This looks like a very common thing and the
team
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9015
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146697687
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8962#issuecomment-146701389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9037#issuecomment-146701153
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146701214
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146701216
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8962#issuecomment-146701289
[Test build #43431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43431/console)
for PR 8962 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8962#issuecomment-146701388
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146703956
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9036#issuecomment-146704000
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41579905
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41580011
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8982#issuecomment-146710467
[Test build #43436 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43436/consoleFull)
for PR 8982 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41581062
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146712508
/cc @yhuai for review. There are a few specific questions that I'd like to
clarify and I will comment on them inline.
---
If your project is set up for it, you can
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41581826
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41581767
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9019#discussion_r41583796
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/9039
[SPARK-10665][SQL] Query planner infra for local physical operators - WIP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark local-iter
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9039#issuecomment-146718422
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41585744
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8757#issuecomment-146723162
Minor comments only. Other than that, it looks fine to me.
@avulanov In your "Block-diagonal matrix multiplication" tests, do you know
if data were shuffled
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9000#issuecomment-146725522
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9000#issuecomment-146725531
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9000#discussion_r41587742
--- Diff:
core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala ---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9000#discussion_r41588487
--- Diff: core/src/main/scala/org/apache/spark/MemoryManager.scala ---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146729145
YAY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9039#issuecomment-146729855
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9039#issuecomment-146729845
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/9041#issuecomment-146729797
Why is this needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin closed the pull request at:
https://github.com/apache/spark/pull/9039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9041#issuecomment-146730487
[Test build #43452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43452/consoleFull)
for PR 9041 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9041#issuecomment-146730942
LGTM. I'd rephrase the description to say "up to a minute" since I was a
little scared when reading the original one. "OMG all my apps are going to wait
a minute before
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9041#discussion_r41589229
--- Diff:
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumePollingInputDStream.scala
---
@@ -93,7 +93,11 @@ private[streaming] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8945#issuecomment-146730978
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9016#issuecomment-146732511
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9042#issuecomment-146732536
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9042#issuecomment-146732607
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/8962#discussion_r41593057
--- Diff: R/pkg/R/stats.R ---
@@ -100,3 +100,30 @@ setMethod("corr",
statFunctions <- callJMethod(x@sdf, "stat")
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8857#discussion_r41593135
--- Diff: docs/running-on-yarn.md ---
@@ -304,6 +304,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8857#discussion_r41593098
--- Diff: docs/running-on-yarn.md ---
@@ -304,6 +304,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/8962#discussion_r41593053
--- Diff: R/pkg/R/stats.R ---
@@ -100,3 +100,30 @@ setMethod("corr",
statFunctions <- callJMethod(x@sdf, "stat")
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9016#issuecomment-146743581
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8984#issuecomment-146744455
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8984#issuecomment-146744379
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/8984#issuecomment-146743755
@shivaram Yes, that was helpful. Thank you! I have done the merge already.
Jenkins, could you run tests?
---
If your project is set up for it, you can reply to this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9036#discussion_r41595318
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -304,7 +304,10 @@ object HiveTypeCoercion {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41596018
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41596083
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9039#issuecomment-146718423
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41584604
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CryptoOutputStream.scala ---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41585923
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala ---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user harishreedharan opened a pull request:
https://github.com/apache/spark/pull/9041
[SPARK-11019][streaming][flume] Gracefully shutdown Flume receiver thâ¦
â¦reads.
Wait for a minute for the receiver threads to shutdown before interrupting
them.
You can merge
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41586007
--- Diff: core/src/main/scala/org/apache/spark/crypto/Decryptor.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9030#issuecomment-146724781
Merging this in master & branch-1.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41586546
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala ---
@@ -48,14 +53,29 @@ private[spark] class BlockStoreShuffleReader[K,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8757#issuecomment-146724888
[Test build #1864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1864/console)
for PR 8757 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41586581
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala ---
@@ -48,14 +53,29 @@ private[spark] class BlockStoreShuffleReader[K,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8880#issuecomment-146726420
Hi @winningsix,
I need to read the buffer handling code again, but it could use some
cleanup to make it easier to follow. Also, just pointing out style
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9017#issuecomment-146726586
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9016#issuecomment-146726579
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9000#discussion_r41587949
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -409,40 +397,42 @@ private[spark] class MemoryStore(blockManager:
501 - 600 of 910 matches
Mail list logo
