[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-160001167 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-12018][SQL] Refactor common subexpressi...

2015-11-26 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/10009 [SPARK-12018][SQL] Refactor common subexpression elimination code JIRA: https://issues.apache.org/jira/browse/SPARK-12018 The code of common subexpression elimination can be factored and si

[GitHub] spark pull request: doc typo: "classificaion" -> "classification"

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10008#issuecomment-16899 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-11990][SQL] Don't collapse projections ...

2015-11-26 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/9993 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: doc typo: "classificaion" -> "classification"

2015-11-26 Thread muxator
GitHub user muxator opened a pull request: https://github.com/apache/spark/pull/10008 doc typo: "classificaion" -> "classification" You can merge this pull request into a Git repository by running: $ git pull https://github.com/muxator/spark patch-1 Alternatively you can revi

[GitHub] spark pull request: [SPARK-11990][SQL] Don't collapse projections ...

2015-11-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9993#issuecomment-16806 @marmbrus.Agreed. Thanks. I've not noticed there is introduced common subexpression elimination in codegen recently. Close this now. --- If your project is set up for it

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2015-11-26 Thread radekg
Github user radekg commented on the pull request: https://github.com/apache/spark/pull/9608#issuecomment-16247 Regarding the `TorrentBroadcast`. I think there is to be some magic done around `blockManager.port`. --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-16264 (Note that the POMs changed to pull in some more of the codahale servlets, though only the health checks & thread dump are being registered. Hooking up those servl

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2015-11-26 Thread radekg
Github user radekg commented on the pull request: https://github.com/apache/spark/pull/9608#issuecomment-16205 I've added the code for 1.6. It works (tasks are successfully finishing). However, I am not 100% sure what is the impact of this change. Would be great if somebody accus

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.0] When down...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9979#issuecomment-16105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.0] When down...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9979#issuecomment-16106 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.0] When down...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9979#issuecomment-16056 **[Test build #46778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46778/consoleFull)** for PR 9979 at commit [`1f4605e`](https://git

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-15341 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-15342 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-15278 **[Test build #46777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46777/consoleFull)** for PR 10001 at commit [`af508de`](https://g

[GitHub] spark pull request: PR10000?

2015-11-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-159998606 Now I gotta think hard about what I should submit using this branch when I reopen the pull request. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: PR10000?

2015-11-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-159998570 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159998497 **[Test build #46782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46782/consoleFull)** for PR 9571 at commit [`25e77bd`](https://gith

[GitHub] spark pull request: [SPARK-11206] (Followup) Fix SQLListenerMemory...

2015-11-26 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9991#discussion_r46008320 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLListenerSuite.scala --- @@ -343,6 +343,8 @@ class SQLListenerMemoryLeakSuite ext

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-159998104 @yhuai Hi Yin, in the discoverPartitions method, we are trying to create the partition spec and are trying to cast a partition value to the corresponding user speci

[GitHub] spark pull request: PR10000?

2015-11-26 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-159997959 Reynold is just claiming all the good numbers for himself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159997461 **[Test build #46781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46781/consoleFull)** for PR 9571 at commit [`1dcbb5f`](https://gith

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159997153 **[Test build #46780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46780/consoleFull)** for PR 9571 at commit [`1dcbb5f`](https://gith

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996648 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996634 Added reworked design * all metrics go through the `MetricsSystem`; the providers return an optional `Source` from the `start()` call. * `FsHistoryProv

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996343 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996339 **[Test build #46779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46779/consoleFull)** for PR 9571 at commit [`f6bf558`](https://git

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996342 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11700] [SQL] use weak reference in Spar...

2015-11-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9990#discussion_r46007594 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -401,7 +402,7 @@ class SQLContext private[sql]( */ @Experimental

[GitHub] spark pull request: [SPARK-11373] [CORE] WiP Add metrics to the Hi...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-159996173 **[Test build #46779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46779/consoleFull)** for PR 9571 at commit [`f6bf558`](https://gith

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995282 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995281 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995211 **[Test build #46775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46775/consoleFull)** for PR 9995 at commit [`95b2e0d`](https://git

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.0] When down...

2015-11-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9979#issuecomment-159991328 https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46778/consoleFull is for hadoop 2.0 test. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.0] When down...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9979#issuecomment-159991288 **[Test build #46778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46778/consoleFull)** for PR 9979 at commit [`1f4605e`](https://gith

[GitHub] spark pull request: [SPARK-11998] [SQL] [test-hadoop2.2] When down...

2015-11-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9979#discussion_r46005696 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -34,23 +34,54 @@ import org.apache.spark.sql.hive.HiveCont

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10003#discussion_r46005296 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/ProgressCassandraDialect.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-159988308 @dilipbiswal Do you know why it is broken? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-159987537 **[Test build #46777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46777/consoleFull)** for PR 10001 at commit [`af508de`](https://gi

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-159986618 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread CK50
Github user CK50 commented on a diff in the pull request: https://github.com/apache/spark/pull/10003#discussion_r46004220 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/ProgressCassandraDialect.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11863][SQL] Unable to resolve order by ...

2015-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11996][Core]Make the executor thread du...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9976#issuecomment-159982559 **[Test build #46776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46776/consoleFull)** for PR 9976 at commit [`d626bfc`](https://gith

[GitHub] spark pull request: [SPARK-11700] [SQL] use weak reference in Spar...

2015-11-26 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9990#issuecomment-159982550 > @zsxwing The one in SQLContext have a clearActive APIs, so I think don't need WeakRef there. Sorry. I meant the compilation failed. --- If your project is se

[GitHub] spark pull request: [SPARK-11996][Core]Make the executor thread du...

2015-11-26 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9976#issuecomment-159979553 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10003#issuecomment-159978454 @CK50 this needs some style cleanup - you can run dev/lint-scala to check styles locally. Can you please also attach the generated query before / after this change

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159978503 **[Test build #46775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46775/consoleFull)** for PR 9995 at commit [`95b2e0d`](https://gith

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10003#discussion_r46002799 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/ProgressCassandraDialect.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11863][SQL] Unable to resolve order by ...

2015-11-26 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9961#issuecomment-159977873 Thanks, I'm going to merge this to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-11-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-159977685 I wouldn't have the top level name be "PhysicalRDD" - that term just makes no sense to users. I'd consider just putting "Orc" there. If it is a Hive table, just sa

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9840#discussion_r46002594 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -235,12 +236,13 @@ case class ExpressionEncoder[

[GitHub] spark pull request: [SPARK-11878][SQL]: Eliminate distribute by in...

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9858#discussion_r46002572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -488,6 +488,12 @@ private[sql] case class EnsureRequirements(sqlContex

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9840#discussion_r46002504 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -235,12 +236,13 @@ case class ExpressionEncoder[T](

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9995#discussion_r46002446 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,34 +675,34 @@ object PushPredicateThroughGenerate exte

[GitHub] spark pull request: [SPARK-11997][SQL] NPE when save a DataFrame a...

2015-11-26 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10001#issuecomment-159976397 @dilipbiswal , yours is the first PR after PR #1 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9840#discussion_r46002027 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -235,12 +236,13 @@ case class ExpressionEncoder[

[GitHub] spark pull request: PR10000?

2015-11-26 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-159975380 wow, What an amazing achievement! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9840#discussion_r46001855 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala --- @@ -0,0 +1,179 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-11954][SQL] Encoder for JavaBeans

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9937#discussion_r46001738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -215,7 +215,7 @@ case class ExpressionEncoder[T]

[GitHub] spark pull request: [SPARK-11954][SQL] Encoder for JavaBeans

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9937#discussion_r46001641 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -617,3 +617,31 @@ case class DecodeUsingSerializer[T](c

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159973804 **[Test build #46774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46774/consoleFull)** for PR 8610 at commit [`8232a80`](https://gith

[GitHub] spark pull request: [SPARK-11954][SQL] Encoder for JavaBeans

2015-11-26 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9937#issuecomment-159973463 Thanks for working on this. I'm not sure that this is the right tactic though. I don't think that we want to make java bean the default fall back in our scala reflect

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159972730 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159972613 **[Test build #46768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46768/consoleFull)** for PR 8610 at commit [`8232a80`](https://git

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159972642 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159972641 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11905] [SQL] Support Persist/Cache and ...

2015-11-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9889#discussion_r46000945 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -579,11 +580,50 @@ class Dataset[T] private[sql]( */ def takeAsList

[GitHub] spark pull request: [SPARK-7857][MLLIB] Prevent IDFModel from retu...

2015-11-26 Thread karlhigley
Github user karlhigley commented on a diff in the pull request: https://github.com/apache/spark/pull/9843#discussion_r46000917 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala --- @@ -218,7 +218,7 @@ private object IDFModel { newValues(k) = valu

[GitHub] spark pull request: [SPARK-11867] Add save/load for kmeans and nai...

2015-11-26 Thread jleaniz
Github user jleaniz commented on the pull request: https://github.com/apache/spark/pull/9849#issuecomment-159971670 Can these functions be called from PySpark somehow? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-7889] [CORE] WiP HistoryServer to refre...

2015-11-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-159970929 The test failing is the web UI one; after hitting the web UI there's a check on the cache metrics. The fact that `lookup.count == 1` means the 2nd GET didn't trigg

[GitHub] spark pull request: [SPARK-11821] Propagate Kerberos keytab for al...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9859#issuecomment-159970309 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11821] Propagate Kerberos keytab for al...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9859#issuecomment-159970290 **[Test build #46766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46766/consoleFull)** for PR 9859 at commit [`449cbbb`](https://git

[GitHub] spark pull request: [SPARK-11821] Propagate Kerberos keytab for al...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9859#issuecomment-159970308 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11905] [SQL] Support Persist/Cache and ...

2015-11-26 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9889#issuecomment-159969380 @marmbrus Not sure if the latest code changes resolve all your concerns. Please let me know if you have any suggestion. Thank you! Have a good Thanksgiving D

[GitHub] spark pull request: [SPARK-11990][SQL] Don't collapse projections ...

2015-11-26 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9993#issuecomment-159968877 I agree with @hvanhovell, this is already taken care of by common subexpression elimination in codegen (i.e. even though the udf appears twice we reuse the answer when

[GitHub] spark pull request: [SPARK-11700] [SQL] use weak reference in Spar...

2015-11-26 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9990#issuecomment-159967811 @zsxwing The one in SQLContext have a `clearActive` APIs, so I think don't need WeakRef there. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11700] [SQL] use weak reference to avoi...

2015-11-26 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9990#discussion_r45999453 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -45,9 +45,10 @@ import org.apache.spark.sql.execution.datasources._ import o

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966824 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966822 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159966602 **[Test build #46773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46773/consoleFull)** for PR 9939 at commit [`3fb1cda`](https://git

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10003#issuecomment-159965856 **[Test build #2119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2119/consoleFull)** for PR 10003 at commit [`f2bf6ee`](https://

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10003#issuecomment-159965340 **[Test build #2119 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2119/consoleFull)** for PR 10003 at commit [`f2bf6ee`](https://g

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159959748 **[Test build #46773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46773/consoleFull)** for PR 9939 at commit [`3fb1cda`](https://gith

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-159958910 This should be all for visibility review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45995982 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -407,7 +407,7 @@ private object BisectingKMeans extends Serializa

[GitHub] spark pull request: [SPARK-11987] Python API update for ChiSqSelec...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10007#issuecomment-159952604 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-11987] Python API update for ChiSqSelec...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10007#issuecomment-159952607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11987] Python API update for ChiSqSelec...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10007#issuecomment-159952571 **[Test build #46772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46772/consoleFull)** for PR 10007 at commit [`05f3edd`](https://g

[GitHub] spark pull request: [SPARK-11987] Python API update for ChiSqSelec...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10007#issuecomment-159950237 **[Test build #46772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46772/consoleFull)** for PR 10007 at commit [`05f3edd`](https://gi

[GitHub] spark pull request: [SPARK-11987] Python API update for ChiSqSelec...

2015-11-26 Thread yinxusen
GitHub user yinxusen opened a pull request: https://github.com/apache/spark/pull/10007 [SPARK-11987] Python API update for ChiSqSelector and QuantileDiscretizer https://issues.apache.org/jira/browse/SPARK-11987 For `QuantileDiscretizer`, I add a `QuantileDiscretizerModel` in

[GitHub] spark pull request: [https://issues.apache.org/jira/browse/SPARK-4...

2015-11-26 Thread mnd999
Github user mnd999 commented on the pull request: https://github.com/apache/spark/pull/2633#issuecomment-159947391 Did this ever make it to spark-packages.org? If not, it's a shame, but would not be entirely surprising given how this PR was handled. --- If your project is set up for

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159942623 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159942628 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159942288 **[Test build #46771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46771/consoleFull)** for PR 10006 at commit [`4c4049d`](https://g

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-26 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45989271 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala --- @@ -105,7 +105,7 @@ object PCA extends DefaultParamsReadable[PCA] { @Experimental

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159936534 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159936530 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159936394 **[Test build #46770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46770/consoleFull)** for PR 10006 at commit [`4c4049d`](https://g

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159931962 **[Test build #46771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46771/consoleFull)** for PR 10006 at commit [`4c4049d`](https://gi

[GitHub] spark pull request: [SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTran...

2015-11-26 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10006#issuecomment-159929474 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

<    1   2   3   4   5   >