[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183066436 We could add a unit test for this specific case. But I am also looking for a way to treat these warnings as compile errors; which would be a lot better. --- If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066743 I reverted this since it hasn't passed tests yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066629 I just merged this but then realized Jenkins hadn't run yet... reverted the pushed version but will re-merge when Jenkins passes --- If your project is set up fo

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183067115 Yup that's a great idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069508 **[Test build #51127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51127/consoleFull)** for PR 9893 at commit [`a03da4a`](https://git

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069760 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183071483 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183071484 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183072553 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/11174 SPARK-13277][BUILD] Follow-up ANTLR warnings are treated as build errors It is possible to create faulty but legal ANTLR grammars. ANTLR will produce warnings but also a valid compileable parser

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183075517 I tested this on my local machine by introducing a warning in ANTLR. It would be great if someone has a suggestion on how we should test this in Jenkins. --- If yo

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183079473 **[Test build #51130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51130/consoleFull)** for PR 10838 at commit [`c70e76f`](https://gi

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675400 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check i

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675406 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check i

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675418 --- Diff: python/docs/Makefile --- @@ -2,7 +2,7 @@ # # You can set these variables from the command line. -SPHINXOPTS= +#SPHINXOPTS

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18308 You can introduce a warning and see if the build fails as part of this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183080442 **[Test build #51131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51131/consoleFull)** for PR 11174 at commit [`51ad797`](https://gi

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52675759 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,14 +216,36 @@ class Analyzer( GroupingSe

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183081536 @sitalkedia can you re-open this? (It was closed automatically when inadventently merged) I don't think we can test it unless it's open --- If your project is s

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11109#issuecomment-183081880 @holdenk I made one pass. I think it is not necessary to verify the links because the PR author might not be responsible for dead links. Only minor comments other than t

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082733 @gatorsmile Thanks for work on this. The secret column name `GROUPING__ID` is only introduced by Hive, unfortunately the implementation is wrong, we don't follow

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082905 @gatorsmile checked that your two tests could pass with these two tiny changes. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183082872 @kayousterhout I am not seeing an option to reopen this pull request. Should I create a new pull request? --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183083118 Ok I have added the warning. The next merge build should fail. Build #51131 should pass. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52677518 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183083738 That would be great thanks!! Sorry for the trouble caused by my rushed merging! --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183084115 **[Test build #51132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51132/consoleFull)** for PR 10705 at commit [`a0c5bb3`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183085926 I've updated this to disable the optimizer rule for now (it's still tested in the LimitPushdownSuite, though). --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
GitHub user sitalkedia opened a pull request: https://github.com/apache/spark/pull/11175 [SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu… …nction You can merge this pull request into a Git repository by running: $ git pull https://github.com/sitalkedia

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183087250 **[Test build #51133 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51133/consoleFull)** for PR 11174 at commit [`5de416b`](https://gi

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183087398 No problem. Created a new pull request https://github.com/apache/spark/pull/11175 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183087696 Need to fix the test. Multiple executors per slave need different handling. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087801 Jenkins this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087708 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088642 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088637 **[Test build #51133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51133/consoleFull)** for PR 11174 at commit [`5de416b`](https://g

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088638 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183088846 **[Test build #51134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51134/consoleFull)** for PR 11140 at commit [`837252a`](https://gi

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52680824 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/11086#issuecomment-183090608 I did not notice that method and it should work fine for double type. My question is one absTol may not be enough for all the value types, for example, float and double

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng closed the pull request at: https://github.com/apache/spark/pull/11086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681082 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681156 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -270,19 +260,11 @@ private[spark] class TaskSetManager( taskAttem

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681359 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11174#discussion_r52681432 --- Diff: project/SparkBuild.scala --- @@ -434,8 +434,11 @@ object Catalyst { // Generate the parser. antlr.process --- End diff

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681503 --- Diff: R/pkg/R/mllib.R --- @@ -126,3 +126,27 @@ setMethod("summary", signature(object = "PipelineModel"), return(list(coefficients = coe

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681510 --- Diff: R/pkg/R/mllib.R --- @@ -126,3 +126,27 @@ setMethod("summary", signature(object = "PipelineModel"), return(list(coefficients = coe

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681513 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -51,6 +52,22 @@ private[r] object SparkRWrappers { pipeline.fit(df)

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52681587 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183091973 cc @cloud-fan for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183092021 @yinxusen I made one pass. Could you update the PR and implement both `summary` and `fitted`? Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18309 **[Test build #51135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51135/consoleFull)** for PR 11174 at commit [`5d37cad`](https://gi

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183092452 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183092811 @mengxr I am on my way implementing `summary`. The summary of `stats:kmeans` contains "cluster" "centers" "totss""withinss" "tot.withinss" "betwe

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183093478 **[Test build #51136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51136/consoleFull)** for PR 11174 at commit [`e55fc66`](https://gi

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11151#issuecomment-183093512 LGTM. Merged into master and branch-1.6. Thanks! Btw, this happens when the default file system is not the same as the file system of the output path. I don't know wheth

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52682469 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -21,6 +21,7 @@ import java.util.Collections import java.util.concurr

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183093869 **[Test build #51137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51137/consoleFull)** for PR 9710 at commit [`1c4e070`](https://gith

[GitHub] spark pull request: [SPARK-12247] [ML] [DOC] Documentation for spa...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10411#issuecomment-183093903 @srowen @coderxiang Do you have time to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-183094892 LGTM. Merged into master. Thanks! @yu-iskw I created https://issues.apache.org/jira/browse/SPARK-13292 for the Python API and assigned to you. --- If your project is se

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183097126 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183097131 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684381 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684370 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684369 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -38,8 +45,12 @@ def parseLine(line): sc = SparkContext(appName="PythonNai

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684376 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684378 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11125#issuecomment-183098615 @movelikeriver Thanks for improving the example code! We want to keep the example code simple because they are included in the user guide. So there are some special trad

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183098721 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183098771 @yinxusen Could you help review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-183099445 @yinxusen Could you help review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-183099286 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183100078 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183100479 @mengxr Don't worry, I'll review all of the replace code PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183101335 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183101195 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183101257 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52685053 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-183102012 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13013][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/6#issuecomment-183101545 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-183101942 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13013][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/6#issuecomment-183101600 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183102624 **[Test build #51140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51140/consoleFull)** for PR 11142 at commit [`19ad929`](https://gi

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics of numOutp...

2016-02-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11170#discussion_r52685127 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -43,6 +43,17 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13014][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11123#issuecomment-183102881 @keypointt Please update the PR description (and JIRA as well) since it is no longer accurate. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-13014][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11123#issuecomment-183102913 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics of numOutp...

2016-02-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11170#discussion_r52685297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -316,6 +327,10 @@ case class WholeStageCodegen(plan: CodegenSup

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183103687 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183103668 **[Test build #51140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51140/consoleFull)** for PR 11142 at commit [`19ad929`](https://g

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183103708 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183103682 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183103714 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13013][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6#issuecomment-183104514 **[Test build #51144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51144/consoleFull)** for PR 6 at commit [`898b437`](https://gi

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183104472 **[Test build #51142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51142/consoleFull)** for PR 11128 at commit [`d580fe7`](https://gi

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183105525 @keypointt @yinxusen Could you start from this PR first and then other longer ones? @keypointt is new to Spark development. Starting from small ones could avoid unnecess

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics of numOutp...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-183105465 Sorry I'm still not getting the picture. Can you just paste a screenshot for the metrics? --- If your project is set up for it, you can reply to this email and have your

<    1   2   3   4   5   6   7   >