[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183092452 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18309 **[Test build #51135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51135/consoleFull)** for PR 11174 at commit [`5d37cad`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183091973 cc @cloud-fan for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183092021 @yinxusen I made one pass. Could you update the PR and implement both `summary` and `fitted`? Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52681587 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681510 --- Diff: R/pkg/R/mllib.R --- @@ -126,3 +126,27 @@ setMethod("summary", signature(object = "PipelineModel"), return(list(coefficients = coe

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681513 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -51,6 +52,22 @@ private[r] object SparkRWrappers { pipeline.fit(df)

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681503 --- Diff: R/pkg/R/mllib.R --- @@ -126,3 +126,27 @@ setMethod("summary", signature(object = "PipelineModel"), return(list(coefficients = coe

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11174#discussion_r52681432 --- Diff: project/SparkBuild.scala --- @@ -434,8 +434,11 @@ object Catalyst { // Generate the parser. antlr.process --- End diff

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681359 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681156 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -270,19 +260,11 @@ private[spark] class TaskSetManager( taskAttem

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681082 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng closed the pull request at: https://github.com/apache/spark/pull/11086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52680824 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/11086#issuecomment-183090608 I did not notice that method and it should work fine for double type. My question is one absTol may not be enough for all the value types, for example, float and double

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183088846 **[Test build #51134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51134/consoleFull)** for PR 11140 at commit [`837252a`](https://gi

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088638 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088642 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088637 **[Test build #51133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51133/consoleFull)** for PR 11174 at commit [`5de416b`](https://g

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087708 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183087696 Need to fix the test. Multiple executors per slave need different handling. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087801 Jenkins this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183087398 No problem. Created a new pull request https://github.com/apache/spark/pull/11175 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183087250 **[Test build #51133 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51133/consoleFull)** for PR 11174 at commit [`5de416b`](https://gi

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
GitHub user sitalkedia opened a pull request: https://github.com/apache/spark/pull/11175 [SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu… …nction You can merge this pull request into a Git repository by running: $ git pull https://github.com/sitalkedia

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183085926 I've updated this to disable the optimizer rule for now (it's still tested in the LimitPushdownSuite, though). --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183084115 **[Test build #51132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51132/consoleFull)** for PR 10705 at commit [`a0c5bb3`](https://gi

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183083738 That would be great thanks!! Sorry for the trouble caused by my rushed merging! --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52677518 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183083118 Ok I have added the warning. The next merge build should fail. Build #51131 should pass. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183082872 @kayousterhout I am not seeing an option to reopen this pull request. Should I create a new pull request? --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082905 @gatorsmile checked that your two tests could pass with these two tiny changes. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082733 @gatorsmile Thanks for work on this. The secret column name `GROUPING__ID` is only introduced by Hive, unfortunately the implementation is wrong, we don't follow

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11109#issuecomment-183081880 @holdenk I made one pass. I think it is not necessary to verify the links because the PR author might not be responsible for dead links. Only minor comments other than t

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183081536 @sitalkedia can you re-open this? (It was closed automatically when inadventently merged) I don't think we can test it unless it's open --- If your project is s

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52675759 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,14 +216,36 @@ class Analyzer( GroupingSe

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183080442 **[Test build #51131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51131/consoleFull)** for PR 11174 at commit [`51ad797`](https://gi

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18308 You can introduce a warning and see if the build fails as part of this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675418 --- Diff: python/docs/Makefile --- @@ -2,7 +2,7 @@ # # You can set these variables from the command line. -SPHINXOPTS= +#SPHINXOPTS

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675406 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check i

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675400 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check i

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183079473 **[Test build #51130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51130/consoleFull)** for PR 10838 at commit [`c70e76f`](https://gi

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183075517 I tested this on my local machine by introducing a warning in ANTLR. It would be great if someone has a suggestion on how we should test this in Jenkins. --- If yo

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/11174 SPARK-13277][BUILD] Follow-up ANTLR warnings are treated as build errors It is possible to create faulty but legal ANTLR grammars. ANTLR will produce warnings but also a valid compileable parser

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183072553 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183071484 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183071483 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069760 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069508 **[Test build #51127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51127/consoleFull)** for PR 9893 at commit [`a03da4a`](https://git

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183067115 Yup that's a great idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066629 I just merged this but then realized Jenkins hadn't run yet... reverted the pushed version but will re-merge when Jenkins passes --- If your project is set up fo

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066743 I reverted this since it hasn't passed tests yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183066436 We could add a unit test for this specific case. But I am also looking for a way to treat these warnings as compile errors; which would be a lot better. --- If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066243 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183065989 LGTM. will merge this one once the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183065836 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183063914 @zsxwing addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183061509 Can we add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183061297 There are flaky tests also due to the merge those public classes should not be shown anyway... i only changed 5 files... --- If your project is set up for it, you c

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058649 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058644 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058638 **[Test build #51128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51128/consoleFull)** for PR 10705 at commit [`77939c2`](https://g

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058138 **[Test build #51128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51128/consoleFull)** for PR 10705 at commit [`77939c2`](https://gi

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183058010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183058007 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183057571 **[Test build #51124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51124/consoleFull)** for PR 11153 at commit [`dce3857`](https://g

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183056361 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52665152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,14 +216,36 @@ class Analyzer( GroupingSe

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183056362 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183056161 **[Test build #51123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51123/consoleFull)** for PR 11157 at commit [`a4e575d`](https://g

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11051 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183047747 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52660909 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183047397 @shaneknapp Thanks for checking... The GHPRB just works in mysterious ways... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11173#issuecomment-183046223 @spektom the title is not really informative. Could you improve the title, and prepend it with the relevant JIRA ticket (please create one if you haven't done that y

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11173#issuecomment-183044967 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044614 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183044450 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread spektom
GitHub user spektom opened a pull request: https://github.com/apache/spark/pull/11173 Added missing utility method Without this method it's impossible to create Kafka direct stream without offsets but with custom message handler function. You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044250 **[Test build #51122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51122/consoleFull)** for PR 11162 at commit [`26e9ad1`](https://g

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183043137 **[Test build #51127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51127/consoleFull)** for PR 9893 at commit [`a03da4a`](https://gith

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183040357 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183040354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183039809 **[Test build #51121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51121/consoleFull)** for PR 8880 at commit [`e92bb20`](https://git

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183034983 argh git timeout. jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183034458 Thanks @kayousterhout. I updated the comment accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52656379 --- Diff: core/src/test/scala/org/apache/spark/crypto/ShuffleEncryptionSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183033924 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183033927 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] Subquery in e...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-183033654 @davies sure, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52656157 --- Diff: core/src/test/scala/org/apache/spark/crypto/ShuffleEncryptionSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032500 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032489 **[Test build #51125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51125/consoleFull)** for PR 10953 at commit [`9983e7d`](https://g

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032502 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52653442 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -169,7 +176,10 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52653512 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -47,6 +47,7 @@ import org.apache.spark.util.Utils *

<    1   2   3   4   5   6   7   >