[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...

2016-02-13 Thread amitdev
Github user amitdev commented on the pull request: https://github.com/apache/spark/pull/11180#issuecomment-183843493 Thanks @srowen. I've mentioned dependencies on Ruby, Python and cleaned up the doc a little. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838911 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveCompa

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838817 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838805 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -184,36 +240,106 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838778 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838770 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -184,36 +240,106 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838767 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838740 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveCompariso

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838687 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveCompa

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838672 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -184,36 +240,106 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11195#discussion_r52838626 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -105,6 +105,18 @@ class LogicalPlanToSQLSuite extends SQLBuilder

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11195#discussion_r52838622 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -105,6 +105,18 @@ class LogicalPlanToSQLSuite extends SQLBuilder

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838613 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveCompa

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838614 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,6 +216,8 @@ class Analyzer( Grouping

[GitHub] spark pull request: [SPARK-13263] [SQL] SQL Generation Support for...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11148#issuecomment-183833450 Thanks for your reviews! @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11195#discussion_r52838596 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -105,6 +105,18 @@ class LogicalPlanToSQLSuite extends SQLB

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838552 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -184,36 +240,106 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52838489 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala --- @@ -132,4 +132,69 @@ class MiscFunctionsSuite

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838460 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838383 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838317 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-13 Thread winningsix
Github user winningsix commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52838315 --- Diff: core/src/test/scala/org/apache/spark/crypto/ShuffleEncryptionSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13237] [SQL] generated broadcast outer ...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11130#discussion_r52838281 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -105,75 +107,129 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11195#discussion_r52838020 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -105,6 +105,18 @@ class LogicalPlanToSQLSuite extends SQLBuilder

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13172] [CORE] [SQL] Stop using RichExce...

2016-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183821787 I've merged this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13172] [CORE] [SQL] Stop using RichExce...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11182#issuecomment-183821765 I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-13172] [CORE] [SQL] Stop using RichExce...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11182#issuecomment-183820066 **[Test build #2540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2540/consoleFull)** for PR 11182 at commit [`a18092b`](https://

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183818591 **[Test build #2539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2539/consoleFull)** for PR 11181 at commit [`913bf1b`](https://

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-13 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52837685 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions { new Mu

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183814813 @keypointt I recommend adding the following code to the example, too. Then delete previous code from line 55-67. Meanwhile, we should move the line 53 ahead and rephra

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183811352 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183811355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183811320 **[Test build #51254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51254/consoleFull)** for PR 11126 at commit [`5315350`](https://g

[GitHub] spark pull request: SPARK-13312 [MLlib]

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11199#issuecomment-183811299 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-13312 [MLlib]

2016-02-13 Thread JeremyNixon
GitHub user JeremyNixon opened a pull request: https://github.com/apache/spark/pull/11199 SPARK-13312 [MLlib] Response to JIRA https://issues.apache.org/jira/browse/SPARK-13312. This contribution is my original work and I license the work to this project. You can merge thi

[GitHub] spark pull request: [SPARK-11624][SPARK-11972][SQL]fix commands th...

2016-02-13 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/9589#issuecomment-183811059 @marmbrus We have instantiated and started a instance of `CliSessionState`, and when we init `SparkSQLEnv`, we will create a `SessionState`. --- If your project is

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-13 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183810965 Looks like this hung in `BlockManagerReplicationSuite`. I'll investigate. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183810148 **[Test build #51254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51254/consoleFull)** for PR 11126 at commit [`5315350`](https://gi

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183809601 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183809615 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183809476 **[Test build #51248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51248/consoleFull)** for PR 10705 at commit [`27e98a3`](https://g

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-183808318 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-183808315 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-183807835 **[Test build #51251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51251/consoleFull)** for PR 11198 at commit [`c74e7b9`](https://g

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/11126#discussion_r52836953 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PMMLModelExportExample.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183805907 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183805908 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183805607 **[Test build #51253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51253/consoleFull)** for PR 11124 at commit [`ecb2850`](https://g

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183802069 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183802066 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183801528 **[Test build #51250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51250/consoleFull)** for PR 11193 at commit [`e5cf48d`](https://g

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11126#discussion_r52836783 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PMMLModelExportExample.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13185][SQL] Reuse Calendar object in Da...

2016-02-13 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/11090#issuecomment-183801352 @srowen The 20 seconds improvements is the difference of the stage time. i.e. before the patch, the stage runs 1.6 min. With this path it runs 1.2 min. It takes abou

[GitHub] spark pull request: [SPARK-13250][SQL] Update PhysicallRDD to conv...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11141#discussion_r52836757 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala --- @@ -118,6 +120,30 @@ private[sql] case class PhysicalRDD( val

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11126#discussion_r52836750 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PMMLModelExportExample.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13069][STREAMING]. Adds synchronous sto...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11176#issuecomment-183800793 **[Test build #2541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2541/consoleFull)** for PR 11176 at commit [`970e3c8`](https://

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11126#discussion_r52836734 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PMMLModelExportExample.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-13 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183800752 retest it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-13069][STREAMING]. Adds synchronous sto...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11176#issuecomment-183798913 **[Test build #2541 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2541/consoleFull)** for PR 11176 at commit [`970e3c8`](https://g

[GitHub] spark pull request: [SPARK-13069][STREAMING]. Adds synchronous sto...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11176#issuecomment-183798240 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-13172] [CORE] [SQL] Stop using RichExce...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11182#issuecomment-183796595 **[Test build #2540 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2540/consoleFull)** for PR 11182 at commit [`a18092b`](https://g

[GitHub] spark pull request: [SPARK-13222][Streaming][WIP]make sure latest ...

2016-02-13 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/11101#issuecomment-183796117 @zsxwing, we have real use case that data integrity is important, but at the same time, we can not afford extra time cost of WAL with limited data processing power/host. (

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183796248 BTW, these movement will make us harder to find out the history of the changes, i'd like to not do that if it's not too bad. --- If your project is set up for it, you c

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183795869 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: Branch 1.6

2016-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183795538 **[Test build #2539 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2539/consoleFull)** for PR 11181 at commit [`913bf1b`](https://g

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183795605 We could consider adding a partition local limit or some hint at some point in the parser. cc @hvanhovell --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183794873 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183794878 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183792181 **[Test build #51253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51253/consoleFull)** for PR 11124 at commit [`ecb2850`](https://gi

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

2016-02-13 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10539#issuecomment-183792263 @mengxr ok. I will do the backports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183791953 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-13027][STREAMING] Added batch time as a...

2016-02-13 Thread aramesh117
Github user aramesh117 commented on the pull request: https://github.com/apache/spark/pull/11122#issuecomment-183791928 @zsxwing Any more issues that you can see? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183791574 @mengxr I add two summary variables `cluster` and `size` in `KMeansModel` to resemble counterparts in R's kmeans. IMHO even though `summary(kmeans.model)` looks incomp

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183791464 @davies this did pass tests - just some lingering thing that made the timeout. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-13263] [SQL] SQL Generation Support for...

2016-02-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11148#issuecomment-183791443 Looks more robust this way. I will let @liancheng do the final reviews and merge. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-13185][SQL] Improve the performance of ...

2016-02-13 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/11071#issuecomment-183791219 @srowen you are right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52836307 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -113,3 +113,18 @@ test_that("summary works on base GLM models", { baseSummary <- summary(baseMo

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52836278 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions { new Murmu

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52836274 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions { new Murmu

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183790347 @gatorsmile I think you can check `GROUPING__ID` in ResolveGroupingAnalytics, then raise an error --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52836225 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveCompariso

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52836219 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,6 +216,8 @@ class Analyzer( GroupingSets

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183783291 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183783288 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183783032 **[Test build #51249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51249/consoleFull)** for PR 11124 at commit [`44c7595`](https://g

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-183782726 **[Test build #51251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51251/consoleFull)** for PR 11198 at commit [`c74e7b9`](https://gi

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-13 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/11198 [SPARK-13310] [SQL] Resolve Missing Sorting Columns in Generate ```scala // case 1: missing sort columns are resolvable if join is true sql("SELECT explode(a) AS val, b FROM data WHERE b

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-13 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r52835896 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183779544 **[Test build #51250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51250/consoleFull)** for PR 11193 at commit [`e5cf48d`](https://gi

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183779219 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183779253 **[Test build #51249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51249/consoleFull)** for PR 11124 at commit [`44c7595`](https://gi

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

2016-02-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10539#issuecomment-183776074 @viirya If it doesn't take you much time, could you prepare backports for branch-1.4 and branch-1.3? I guess we only need to remove the Python changes. This is not high-

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183775021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183775017 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

  1   2   3   >