[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-21 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186973326 @dbtsai I have copied tests from ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186971819 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186971820 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186971303 **[Test build #51648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51648/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [SPARK-12792][SPARKR] Refactor RRDD to support...

2016-02-21 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10947#issuecomment-186970941 @NarineK, yes it is assumed that R has been installed in each worker node. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186969215 **[Test build #51651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51651/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186967397 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186967084 **[Test build #51650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51650/consoleFull)** for PR 11229 at commit

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-21 Thread zhonghaihua
Github user zhonghaihua commented on a diff in the pull request: https://github.com/apache/spark/pull/10794#discussion_r53579600 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -169,6 +172,24 @@ private[yarn] class YarnAllocator( }

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-21 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186961739 Thanks @andrewor14 for your comments, I've updated the codes accordingly, please review. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186960032 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186960034 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3650][GraphX] Triangle Count handles re...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186957557 **[Test build #2563 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2563/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [SPARK-3650][GraphX] Triangle Count handles re...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11290#issuecomment-186957610 I'm going to merge this in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3650][GraphX] Triangle Count handles re...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11290#issuecomment-186957539 This is great timing given the next version is 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186957384 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186956637 Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186955852 Going to merge this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186955298 **[Test build #2562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2562/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186954558 **[Test build #51648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51648/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186954500 Can you also update the pr description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11262#discussion_r53578002 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -345,6 +346,46 @@ class DataFrameReader private[sql](sqlContext:

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186954337 **[Test build #2561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2561/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186953780 **[Test build #2560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2560/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/11262#discussion_r53577852 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -345,6 +346,46 @@ class DataFrameReader private[sql](sqlContext:

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186953261 @dongjoon-hyun if you are doing a few of these, can you merge them into a single bigger patch? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3650][GraphX] Triangle Count handles re...

2016-02-21 Thread jegonzal
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/11290#issuecomment-186951853 This looks good to me. @insidedctm thanks for reviving the PR and @srowen thanks for taking a look at this! My only minor concern is that it will change the results

[GitHub] spark pull request: [SPARK-13424][SQL] Improve test coverage of En...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11294#issuecomment-186947742 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13424][SQL] Improve test coverage of En...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11294#issuecomment-186947741 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13424][SQL] Improve test coverage of En...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11294#issuecomment-186947661 **[Test build #51645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51645/consoleFull)** for PR 11294 at commit

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186945280 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11295 [MINOR][DOCS] Fix typos in ML doc ## What changes were proposed in this pull request? This PR fixes some typos in ML and MLLib markdown document files. ## How was the this

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186944373 > because we might have many "tables". Yeah that's why I renamed it in the first place. As of this patch though there are no more classes that are called

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186944315 I will merge it once tests pass 3 times in a row. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13271][SQL]Better error message if 'pat...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13405][Streaming][Tests]Make sure no me...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13271][SQL]Better error message if 'pat...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11154#issuecomment-186944104 LGTM. Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13405][Streaming][Tests]Make sure no me...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11275#issuecomment-186943998 LGTM. Going to merge this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `configuration.md` ...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186943912 Thank you for merging, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186943609 @maropu mind closing this for now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `configuration.md` ...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `configuration.md` ...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186943514 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186943382 Thank you, @rxin. I remove the change on NOTICE file and rebased it now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186943312 **[Test build #2562 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2562/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186942883 Yes only notice. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186942753 Oh, sure. No problem. Only for `NOTICE`, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186942409 **[Test build #2561 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2561/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [SPARK-13410][SQL] Support unionAll for DataFr...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11279#issuecomment-186941497 **[Test build #2560 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2560/consoleFull)** for PR 11279 at commit

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in `NOTICE`, `configur...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11289#issuecomment-186941205 I don't think we should change the NOTICE file. Can you reset the change for that? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186940230 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186940231 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186940162 **[Test build #51644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51644/consoleFull)** for PR 11293 at commit

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186939416 Going to merge this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13399][STREAMING] Fix checkpointsuite t...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11286#issuecomment-186939363 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186939374 Alright let's discuss the renaming. I initially just used Table, but I think both could work (Table or CatalogTable), because we might have many "tables". --- If your

[GitHub] spark pull request: [SPARK-13399][STREAMING] Fix checkpointsuite t...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11286#issuecomment-186939366 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13399][STREAMING] Fix checkpointsuite t...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11286#issuecomment-186939000 **[Test build #51643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51643/consoleFull)** for PR 11286 at commit

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186938837 **[Test build #2559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2559/consoleFull)** for PR 11293 at commit

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-186938240 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-186938239 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-186938138 **[Test build #51647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51647/consoleFull)** for PR 11128 at commit

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-186935322 **[Test build #51647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51647/consoleFull)** for PR 11128 at commit

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-186935010 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-186935006 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-186934904 **[Test build #51646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51646/consoleFull)** for PR 11108 at commit

[GitHub] spark pull request: [SPARK-13424][SQL] Improve test coverage of En...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11294#issuecomment-186934695 **[Test build #51645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51645/consoleFull)** for PR 11294 at commit

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53574661 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-186930988 **[Test build #51646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51646/consoleFull)** for PR 11108 at commit

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread andrewor14
Github user andrewor14 closed the pull request at: https://github.com/apache/spark/pull/11189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-186930674 Closing in favor of #11293. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186930661 Thanks, @davies also suggested offline to rename all `CatalogTable` and related classes to just `Table`. We can do that separately after this patch gets merged.

[GitHub] spark pull request: [SPARK-13424][SQL] Improve test coverage of En...

2016-02-21 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/11294 [SPARK-13424][SQL] Improve test coverage of EnsureRequirements [WIP] ### What changes were proposed in this pull request? Improve the testing of the `EnsureRequirements` planner rule. This

[GitHub] spark pull request: [SPARK-13137][SQL] NullPoingException in schem...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13137][SQL] NullPoingException in schem...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11023#issuecomment-186921039 Thanks. Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13422][SQL] Use HashedRelation instead ...

2016-02-21 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/11291#issuecomment-186923232 @hvanhovell I just rebased with your new PR, do you mind reviewing again? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13327][SPARKR] Added parameter validati...

2016-02-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11220#discussion_r53573498 --- Diff: R/pkg/R/DataFrame.R --- @@ -303,8 +303,28 @@ setMethod("colnames", #' @rdname columns #' @name colnames<-

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186918335 **[Test build #51644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51644/consoleFull)** for PR 11293 at commit

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11267#discussion_r53573356 --- Diff: R/pkg/R/functions.R --- @@ -536,15 +536,27 @@ setMethod("factorial", #' #' Aggregate function: returns the first value in a group.

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186915642 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186914838 **[Test build #2559 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2559/consoleFull)** for PR 11293 at commit

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186914774 I simply brought https://github.com/apache/spark/pull/11189 up to date and resolved some code review issues so we can merge this quickly and unblock some other work.

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-186914590 FYI I took most of Herman and Davies' comments and created a rebased pr here: https://github.com/apache/spark/pull/11293 --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/11293 [SPARK-13080] [SQL] Implement new Catalog API using Hive ## What changes were proposed in this pull request? This is a step towards merging `SQLContext` and `HiveContext`. A new internal

[GitHub] spark pull request: [SPARK-13422][SQL] Use HashedRelation instead ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11291#issuecomment-186909702 @xguo27 you'll need rebase this. We just merged a PR that changes broadcast joins. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13399][STREAMING] Fix checkpointsuite t...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11286#issuecomment-186909589 **[Test build #51643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51643/consoleFull)** for PR 11286 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11083 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13422][SQL] Use HashedRelation instead ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11291#issuecomment-186909052 **[Test build #2558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2558/consoleFull)** for PR 11291 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186908861 Thanks. I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-186908709 @andrewor14 This is pretty solid, couldn't find anything except for some trivial stuff. LGTM pending an update to the latest master and a succesfull test

[GitHub] spark pull request: [SPARK-13306][SQL] Addendum to uncorrelated sc...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13306][SQL] Addendum to uncorrelated sc...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11285#issuecomment-186907761 Merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r53572493 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -18,24 +18,26 @@ package

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r53572447 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -765,9 +771,14 @@ private[hive] case class

[GitHub] spark pull request: [SPARK-13398][STREAMING] Change FileWriteAhead...

2016-02-21 Thread holdenk
Github user holdenk closed the pull request at: https://github.com/apache/spark/pull/11287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13398][STREAMING] Change FileWriteAhead...

2016-02-21 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11287#issuecomment-186900836 I did some digging into why its 32 in jenkins and 4 on my machine - digging into the Scala internals it seems that the (private) FutureTasks doesn't actually look at

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r53572202 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -174,40 +207,65 @@ case class TablePartition( *

[GitHub] spark pull request: [SPARK-13422][SQL] Use HashedRelation instead ...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11291#issuecomment-186896296 @xguo27 how expensive is the no-op? I'd rather avoid a pointless iteration in a hot code section. --- If your project is set up for it, you can reply to this email

<    1   2   3   4   5   >