[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11945#discussion_r57630777 --- Diff: python/pyspark/ml/tests.py --- @@ -655,6 +656,20 @@ def test_nested_pipeline_persistence(self): except OSError:

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57630288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -39,7 +39,7 @@ abstract class ExternalCatalog {

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202572945 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202572755 **[Test build #54341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54341/consoleFull)** for PR 11972 at commit

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57629952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -104,6 +104,13 @@ class

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202572941 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202570790 Thanks! My local test looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202570826 (one response to an outdated diff above: "I did mean to move the implementation of feature importances to TreeEnsembleModel, just for organization.") Thanks

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57628686 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala --- @@ -274,4 +276,24 @@ private[ml] object GradientBoostedTrees

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202570593 **[Test build #54356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54356/consoleFull)** for PR 12010 at commit

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57628659 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala --- @@ -222,19 +222,15 @@ final class

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-03-28 Thread falaki
Github user falaki commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-202570253 @cloud-fan would you take a look at this if you have time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202568655 I think we also need to add an entry to `catalyst/pom.xml`. Something like this: org.antlr antlr4-maven-plugin

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202567799 **[Test build #2702 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2702/consoleFull)** for PR 11792 at commit

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202566737 **[Test build #54355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54355/consoleFull)** for PR 9971 at commit

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202566736 **[Test build #54354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54354/consoleFull)** for PR 12011 at commit

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202566479 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202566288 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202566481 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202566071 **[Test build #54342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54342/consoleFull)** for PR 11792 at commit

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202565845 Merged! @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202565447 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202565448 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202565441 **[Test build #54352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54352/consoleFull)** for PR 12010 at commit

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/12011 [SPARK-14086][SQL] Add DDL commands to ANTLR4 parser What changes were proposed in this pull request? This PR adds all the current Spark SQL DDL commands to the new ANTLR 4 based

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11326#issuecomment-202564894 **[Test build #54353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54353/consoleFull)** for PR 11326 at commit

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-202564833 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-202564837 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-202564146 **[Test build #54332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54332/consoleFull)** for PR 11941 at commit

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202563276 **[Test build #54352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54352/consoleFull)** for PR 12010 at commit

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-28 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/11326#discussion_r57625677 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala --- @@ -69,6 +69,8 @@ private[spark] object

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12009#issuecomment-202562807 **[Test build #54348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54348/consoleFull)** for PR 12009 at commit

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12009#issuecomment-202562851 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12009#issuecomment-202562845 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202562489 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/12010 [SPARK-13713] [SQL] [test-maven] Add Antlr4 maven plugin. Seems https://github.com/apache/spark/commit/600c0b69cab4767e8e5a6f4284777d8b9d4bd40e is missing the antlr4 maven plugin. This pr adds it.

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202562672 https://github.com/apache/spark/pull/12010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202562493 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202562324 **[Test build #54349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54349/consoleFull)** for PR 11475 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202562101 Merging this into master (since the last commit is trivial) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202561979 **[Test build #54350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54350/consoleFull)** for PR 11948 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202561977 **[Test build #54351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54351/consoleFull)** for PR 11870 at commit

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11984#discussion_r57624829 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala --- @@ -114,6 +123,57 @@ object

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202561204 I just sent a PR: [https://github.com/yinxusen/spark/pull/5] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202561149 lower case Dataset --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57624415 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala --- @@ -184,11 +184,29 @@ class BenchmarkWholeStageCodegen

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57624324 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -39,7 +39,7 @@ abstract class ExternalCatalog {

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57624245 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -104,6 +104,13 @@ class

[GitHub] spark pull request: [SPARK-12299][CORE][WIP] Remove history servin...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10991#issuecomment-202560511 @BryanCutler Actually, for simplicity I would recommend simply removing the REST API related to the Master serving history UIs. Then you can just remove the actual

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202559495 let me try to fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57623687 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -657,26 +682,23 @@ public int getValueLength() { * @return

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-28 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-202559168 @davies , would it be possible to have a chance to look this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202559116 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202559122 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57623602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202558782 **[Test build #54338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54338/consoleFull)** for PR 11948 at commit

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202558809 looks like we are missing antlr4 maven plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202556824 **[Test build #54349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54349/consoleFull)** for PR 11475 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202556888 LGTM, just few minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57622786 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala --- @@ -347,29 +293,53 @@ private[joins] object

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread ashangit
Github user ashangit commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202556680 @vanzin thanks for the feedback. The code has been updated as commented. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-28 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11987#issuecomment-202556372 @yhuai @andrewor14 @viirya Could you please review the code changes for this PR? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57622346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala --- @@ -347,29 +293,53 @@ private[joins] object

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-202556003 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-202556008 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202555774 Seems maven stuff is not set correctly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-202555772 **[Test build #54333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54333/consoleFull)** for PR 12004 at commit

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12009#issuecomment-202555613 **[Test build #54348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54348/consoleFull)** for PR 12009 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57622146 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala --- @@ -184,11 +184,29 @@ class

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202555657 https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.3/956/consoleFull ``` [error]

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202555073 @hvanhovell Seems it breaks the build... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57621843 --- Diff: core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java --- @@ -587,6 +587,44 @@ public void spillInIterator()

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57621657 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -657,26 +682,23 @@ public int getValueLength() { *

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12009 [SPARK-14124] [SQL] Implement Database-related DDL Commands What changes were proposed in this pull request? This PR is to implement the following four Database-related DDL commands:

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11870#discussion_r57621283 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -560,6 +572,20 @@ private Location with(Object base, long offset,

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57621079 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -394,4 +394,72 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57620915 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -394,4 +394,72 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-202549516 **[Test build #54347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54347/consoleFull)** for PR 9229 at commit

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-28 Thread avulanov
Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-202549016 @mengxr Rebased to accomodate https://github.com/apache/spark/pull/9854 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57620239 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1585,3 +1586,110 @@ object ResolveUpCast extends

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14170] [infra] Simplify the PR template...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11973#issuecomment-202547708 Sure, but as I said, that still leaves the annoying (for me) noise - the headings - in every commit message; given that people generally remove the other lines, there's

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-202547496 Merging this in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57619678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1585,3 +1586,110 @@ object ResolveUpCast extends

[GitHub] spark pull request: [SPARK-14170] [infra] Simplify the PR template...

2016-03-28 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/11973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57619252 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -0,0 +1,92 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202545836 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202545832 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202544872 **[Test build #54330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54330/consoleFull)** for PR 12002 at commit

[GitHub] spark pull request: [SPARK-13923][SPARK-14014][SQL] Session catalo...

2016-03-28 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12006#issuecomment-202544366 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread mtustin-handy
Github user mtustin-handy commented on the pull request: https://github.com/apache/spark/pull/11982#issuecomment-202543675 I hit this with `countApprox`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57618519 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2551,6 +2551,134 @@ object functions { ToUTCTimestamp(ts.expr,

[GitHub] spark pull request: [SPARK-14210][SQL] Add a metric for time spent...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12007#issuecomment-202541200 **[Test build #54346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54346/consoleFull)** for PR 12007 at commit

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11982#issuecomment-202541304 Yea fixing them is fine. I'm asking because this is the 1st time I've seen people using this api in public and want to get some feedback here. --- If your project is

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202541169 **[Test build #54345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54345/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57618262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57618209 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2551,6 +2551,134 @@ object functions { ToUTCTimestamp(ts.expr,

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57617913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1585,3 +1586,110 @@ object ResolveUpCast extends

[GitHub] spark pull request: [SPARK-14021][SQL] custom context support for ...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11843#issuecomment-202537620 HiveContext is going to be deprecated in Spark 2.0. Please see https://issues.apache.org/jira/browse/SPARK-13485 I don't think it makes sense to merge this at

<    1   2   3   4   5   6   7   8   9   10   >