[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/12082#discussion_r58590060 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1444,4 +1444,19 @@ object Client extends Logging { uri.startsW

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205930613 **[Test build #54999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54999/consoleFull)** for PR 12136 at commit [`1bd7563`](https://g

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205931003 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205931010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58590239 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -200,6 +204,11 @@ class CrossValidatorModel private[ml] ( @S

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205931435 **[Test build #55000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55000/consoleFull)** for PR 12175 at commit [`69c6e1c`](https://g

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58590434 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala --- @@ -17,6 +17,10 @@ package org.apache.spark.ml.tuning

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205931912 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205931904 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13681][SQL][WIP] Add back once removed ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-205932659 **[Test build #55005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55005/consoleFull)** for PR 12179 at commit [`3b78450`](https://gi

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12082#issuecomment-205932665 **[Test build #55007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55007/consoleFull)** for PR 12082 at commit [`49ac38c`](https://gi

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205932661 **[Test build #55006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55006/consoleFull)** for PR 12175 at commit [`e6258aa`](https://gi

[GitHub] spark pull request: [SPARK-13681][SQL][WIP] Add back once removed ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-205933601 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13681][SQL][WIP] Add back once removed ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-205933580 **[Test build #55005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55005/consoleFull)** for PR 12179 at commit [`3b78450`](https://g

[GitHub] spark pull request: [SPARK-13681][SQL][WIP] Add back once removed ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-205933615 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205935744 **[Test build #55008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55008/consoleFull)** for PR 12136 at commit [`68b9de2`](https://gi

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205939424 **[Test build #55009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55009/consoleFull)** for PR 12175 at commit [`003ab98`](https://gi

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-05 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/11989#discussion_r58592767 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -329,6 +329,8 @@ private[ml] trait HasFeatureSubsetStrategy extends Params {

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-205940285 **[Test build #54996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54996/consoleFull)** for PR 12081 at commit [`16ac0b1`](https://g

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-205941005 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-205940995 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-05 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/11989#discussion_r58593340 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala --- @@ -55,10 +55,16 @@ import org.apache.spark.util.Utils * @param numTre

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12082#issuecomment-205943380 **[Test build #55007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55007/consoleFull)** for PR 12082 at commit [`49ac38c`](https://g

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12082#issuecomment-205943775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12082#issuecomment-205943772 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-04-05 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11947#discussion_r58596297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -177,35 +177,57 @@ private[csv] object CSVTypeCa

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596564 --- Diff: python/pyspark/ml/tuning.py --- @@ -91,7 +94,90 @@ def build(self): return [dict(zip(keys, prod)) for prod in itertools.product(*gri

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596611 --- Diff: python/pyspark/ml/tuning.py --- @@ -91,7 +94,90 @@ def build(self): return [dict(zip(keys, prod)) for prod in itertools.product(*gri

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596633 --- Diff: python/pyspark/ml/tuning.py --- @@ -112,15 +198,24 @@ class CrossValidator(Estimator, HasSeed): >>> cvModel = cv.fit(dataset) >>

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596618 --- Diff: python/pyspark/ml/tuning.py --- @@ -91,7 +94,90 @@ def build(self): return [dict(zip(keys, prod)) for prod in itertools.product(*gri

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596552 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -932,6 +932,11 @@ final class ParamMap private[ml] (private val map: mutable.M

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596647 --- Diff: python/pyspark/ml/tuning.py --- @@ -236,7 +286,10 @@ def _fit(self, dataset): else: bestIndex = np.argmin(metrics)

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596691 --- Diff: python/pyspark/ml/wrapper.py --- @@ -88,6 +99,18 @@ def _transfer_params_from_java(self): value = _java2py(sc, self._jav

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596676 --- Diff: python/pyspark/ml/wrapper.py --- @@ -73,8 +73,19 @@ def _transfer_params_to_java(self): paramMap = self.extractParamMap()

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596688 --- Diff: python/pyspark/ml/wrapper.py --- @@ -88,6 +99,18 @@ def _transfer_params_from_java(self): value = _java2py(sc, self._jav

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-205951008 **[Test build #55010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55010/consoleFull)** for PR 11947 at commit [`180a900`](https://gi

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596570 --- Diff: python/pyspark/ml/tuning.py --- @@ -91,7 +94,90 @@ def build(self): return [dict(zip(keys, prod)) for prod in itertools.product(*gri

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596684 --- Diff: python/pyspark/ml/wrapper.py --- @@ -73,8 +73,19 @@ def _transfer_params_to_java(self): paramMap = self.extractParamMap()

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596672 --- Diff: python/pyspark/ml/wrapper.py --- @@ -64,7 +64,7 @@ def _make_java_param_pair(self, param, value): param = self._resolveParam(param)

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596628 --- Diff: python/pyspark/ml/tuning.py --- @@ -91,7 +94,90 @@ def build(self): return [dict(zip(keys, prod)) for prod in itertools.product(*gri

[GitHub] spark pull request: [SPARK-14370][MLLIB]removed duplicate generati...

2016-04-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12176#issuecomment-205952381 Ha fair enough. From poking around the internet I'm pretty sure the first is an estimate of gamma, the topic distribution (as the comments say) and the second are suffic

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/12082#issuecomment-205952583 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12020#issuecomment-205950097 I sent most of my comments but am not quite done yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13063] [YARN] Make the SPARK YARN STAGI...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205954120 **[Test build #55001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55001/consoleFull)** for PR 12166 at commit [`59904c4`](https://g

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205954395 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58596659 --- Diff: python/pyspark/ml/tuning.py --- @@ -289,8 +392,60 @@ def copy(self, extra=None): extra = dict() return CrossValidato

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205954399 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-205955740 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-205955742 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-205955671 **[Test build #55010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55010/consoleFull)** for PR 11947 at commit [`180a900`](https://g

[GitHub] spark pull request: [SPARK-14123] [SPARK-14384] [SQL] Handle Creat...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58600078 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -85,24 +91,23 @@ case class DropFunction( extends

[GitHub] spark pull request: [SPARK-14123] [SPARK-14384] [SQL] Handle Creat...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12117#issuecomment-205957877 Thanks @yhuai @viirya I'm merging this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-14123] [SPARK-14384] [SQL] Handle Creat...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58600702 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends AstBuilder

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205959612 Looks pretty good, just a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-14243][CORE][BACKPORT-1.6]update task m...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12150#issuecomment-205959893 Merging into 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-14243][CORE][BACKPORT-1.6]update task m...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12150#issuecomment-205960129 @jeanlyn can you close this PR now that it's merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14123] [SPARK-14384] [SQL] Handle Creat...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58601677 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -85,24 +91,23 @@ case class DropFunction( extends Runna

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58601918 --- Diff: pom.xml --- @@ -840,14 +827,13 @@ org.apache.avro avro-mapred ${avro.version} +

[GitHub] spark pull request: [SPARK-14123] [SPARK-14384] [SQL] Handle Creat...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58602203 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -85,24 +91,23 @@ case class DropFunction( extends Runna

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58602325 --- Diff: python/pyspark/ml/tuning.py --- @@ -289,8 +392,60 @@ def copy(self, extra=None): extra = dict() return CrossValidato

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205962789 **[Test build #55006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55006/consoleFull)** for PR 12175 at commit [`e6258aa`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58602465 --- Diff: tools/pom.xml --- @@ -71,6 +71,16 @@ org.apache.maven.plugins maven-source-plugin + --- End diff

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205962888 LGTM if sbt and maven tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205962995 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205962992 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58602540 --- Diff: python/pyspark/ml/tuning.py --- @@ -480,19 +653,87 @@ def copy(self, extra=None): extra = dict() return TrainValidat

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205963079 **[Test build #55011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55011/consoleFull)** for PR 12121 at commit [`79c86aa`](https://gi

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12020#issuecomment-205963330 Done with my review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

2016-04-05 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r58604142 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -620,6 +620,14 @@ private[spark] class TaskSetManager( // Not

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

2016-04-05 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/11996#issuecomment-205967941 I've been looking into this and running some tests but at this point I haven't actually had the kill triggered. I always end up with things getting Marked failed as

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205971890 **[Test build #55008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55008/consoleFull)** for PR 12136 at commit [`68b9de2`](https://g

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205972257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205972258 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-10931][PYSPARK][ML] PySpark ML Models s...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10270#issuecomment-205972464 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/12180 [SPARK-14411][SQL]Add a note to warn that onQueryProgress is asynchronous ## What changes were proposed in this pull request? onQueryProgress is asynchronous so the user may see some future

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205973298 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205973667 **[Test build #55009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55009/consoleFull)** for PR 12175 at commit [`003ab98`](https://g

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205973983 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205974236 **[Test build #55013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55013/consoleFull)** for PR 12166 at commit [`7e4e96e`](https://gi

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205973979 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205974181 **[Test build #55012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55012/consoleFull)** for PR 12180 at commit [`cb5c149`](https://gi

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205974356 LGTM, merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread ericl
Github user ericl commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205974560 @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread ericl
GitHub user ericl opened a pull request: https://github.com/apache/spark/pull/12181 [SPARK-14359] Unit tests for java 8 lambda syntax with typed aggregates ## What changes were proposed in this pull request? Adds unit tests for java 8 lambda syntax with typed aggregates as a

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205975113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-205975808 **[Test build #55017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55017/consoleFull)** for PR 9207 at commit [`a99880d`](https://gith

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205975784 **[Test build #55014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55014/consoleFull)** for PR 12181 at commit [`cc745c5`](https://gi

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-205975829 **[Test build #55016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55016/consoleFull)** for PR 9524 at commit [`da55aa0`](https://gith

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205975799 **[Test build #55015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55015/consoleFull)** for PR 12156 at commit [`d9eaed5`](https://gi

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11219#issuecomment-205975994 I don't think this should be public. If this is needed for the DataFrame-based API, then we should discuss providing the evaluation metric classes within the spark.m

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976978 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976944 **[Test build #55012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55012/consoleFull)** for PR 12180 at commit [`cb5c149`](https://g

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976976 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977250 **[Test build #55003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55003/consoleFull)** for PR 11570 at commit [`7bad3f9`](https://g

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977671 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread infynyxx
GitHub user infynyxx opened a pull request: https://github.com/apache/spark/pull/12182 use https while downloading binaries ## What changes were proposed in this pull request? `./build/mvn` file was downloading binaries in non HTTPS mode. This PR tends to fix it.

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205977980 Finally, I passed the Jenkins with the updated code. Please let me know if there is something I missed. Thank you, @marmbrus and @srowen . --- If your pro

<    1   2   3   4   5   6   7   8   9   10   >