[GitHub] spark pull request: [SPARK-14432][SQL] Add API to calculate the ap...

2016-04-10 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12207#discussion_r59160367 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1181,18 +1181,26 @@ def approxQuantile(self, col, probabilities, relativeError): Space-efficien

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208187631 **[Test build #55511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55511/consoleFull)** for PR 12267 at commit [`4e9096d`](https://gi

[GitHub] spark pull request: [SPARK-14298] [ML] [MLlib] Add unit test for E...

2016-04-10 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12286#issuecomment-208187383 We could maybe make this a more complete test and actually check that their are no checkpoint files generated? Although that might be over kill. --- If your project is

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208183704 `BinaryComparisonSimplification` LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14290][CORE][Network] avoid significant...

2016-04-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12083#issuecomment-208183683 @liyezhang556520 Could you send a patch for 1.6 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-04-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-208183606 cherry-picked into 1.6 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12292#issuecomment-208183377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12292#issuecomment-208183380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12292#issuecomment-208183259 **[Test build #55504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55504/consoleFull)** for PR 12292 at commit [`961f117`](https://g

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12081#discussion_r59158513 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -74,9 +74,9 @@ private[sql] class HiveSessionCatalog( /

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208181978 @cloud-fan . Thank you so much for improving this PR. Overall, this PR starts to include one Non-Null case (`EqualNullSafe`) now. May I change the classname

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208182022 **[Test build #55510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55510/consoleFull)** for PR 12081 at commit [`9cf48e1`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59158077 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208181263 This is a good idea, but in 2.0 we are going to hide UserDefinedFunction for now and re-design this API in 2.1. We should revisit it together. --- If your project i

[GitHub] spark pull request: [SPARK-14354][SQL] Let Expand take name expres...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12138#issuecomment-208179970 @cloud-fan yea. this solution looks complicated due to that I need to fit it into current usage of `Expand`... I will try your proposal and see if it works. Thanks! --

[GitHub] spark pull request: [SPARK-14354][SQL] Let Expand take name expres...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12138#issuecomment-208179409 I just get noticed that this PR can also solve another JIRA ticket: https://issues.apache.org/jira/browse/SPARK-14495. --- If your project is set up for it, you can rep

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208178674 **[Test build #55509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55509/consoleFull)** for PR 12067 at commit [`4ee5ac1`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59157332 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,95 @@

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208176286 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59157076 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,95 @@

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208176285 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-14387. [SQL] Exceptions thrown when quer...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12293#issuecomment-208176244 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208176150 **[Test build #55503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55503/consoleFull)** for PR 12259 at commit [`eafdd58`](https://g

[GitHub] spark pull request: SPARK-14387. [SQL] Exceptions thrown when quer...

2016-04-10 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/12293 SPARK-14387. [SQL] Exceptions thrown when querying ORC tables stored … ## What changes were proposed in this pull request? Physical files stored in Hive as ORC would have internal colu

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59156961 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification extend

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208175823 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208175822 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208175816 **[Test build #55508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55508/consoleFull)** for PR 12067 at commit [`050e942`](https://g

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208175668 **[Test build #55508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55508/consoleFull)** for PR 12067 at commit [`050e942`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208173217 **[Test build #55507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55507/consoleFull)** for PR 12267 at commit [`86380de`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59156009 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59155908 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208171753 **[Test build #55506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55506/consoleFull)** for PR 12067 at commit [`9e9be45`](https://g

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208171754 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208171756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208171517 **[Test build #55506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55506/consoleFull)** for PR 12067 at commit [`9e9be45`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59155788 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208170041 Thank you for *deep review*, @cloud-fan . :) I changed PR according to the one comment first. For the others, I asked some questions to understand more corr

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59155584 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @@

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12267#issuecomment-208169438 **[Test build #55505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55505/consoleFull)** for PR 12267 at commit [`7ea4e29`](https://gi

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59155488 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification extend

[GitHub] spark pull request: [SPARK-14354][SQL] Let Expand take name expres...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12138#issuecomment-208168423 Yea, and in this PR we use `NamedExpression` to avoid re-using child's output, which should work. My proposal is that, we can use placeholders(maybe `BoundReference`)

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59155308 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59154875 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12292#issuecomment-208165851 **[Test build #55504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55504/consoleFull)** for PR 12292 at commit [`961f117`](https://gi

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/12292 [SPARK-14520][SQL] Use correct return type in VectorizedParquetInputFormat ## What changes were proposed in this pull request? JIRA: https://issues.apache.org/jira/browse/SPARK-14520 `Ve

[GitHub] spark pull request: [SPARK-14520][SQL] Use correct return type in ...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12292#issuecomment-208164442 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59154150 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59154120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -787,6 +788,28 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208160483 **[Test build #55503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55503/consoleFull)** for PR 12259 at commit [`eafdd58`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-208159753 cc @marmbrus @yhuai @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14354][SQL] Let Expand take name expres...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12138#issuecomment-208158392 @cloud-fan Thanks for comment. The problem is we re-use child's output as `Expand`s output. We will create new attributes in `Expand` because `Expand` actually

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208152087 I can reproduce it now. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208151820 hmm. We can't remove non code-generated version of ScalaUDF as any InterpretedProjection with udf will fail... --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208151740 Thank you for your investigation! Sorry, just came back. Will follow your idea to fix the issue. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...

2016-04-10 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12279#discussion_r59152083 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java --- @@ -200,8 +150,26 @@ void readBatch(int to

[GitHub] spark pull request: [SPARK-14491][SQL] refactor object operator fr...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12260#issuecomment-208151177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14491][SQL] refactor object operator fr...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12260#issuecomment-208151178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14491][SQL] refactor object operator fr...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12260#issuecomment-208151080 **[Test build #55498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55498/consoleFull)** for PR 12260 at commit [`856ad74`](https://g

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208150854 For now, we can avoid of dropping `current_database` in `SessionCatalog.reset`. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-14362][SPARK-14406][SQL][Follow-up] DDL...

2016-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14362][SPARK-14406][SQL][Follow-up] DDL...

2016-04-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12284#issuecomment-208148952 Thanks. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208148091 You can reproduce it by calling `test-only *HiveDDLSuite *HiveQuerySuite`. Yea, it is indeed the problem of reset. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208147970 `current_database` is special because it is registered in HiveContext. So, it is not tracked FunctionRegistry.builtIn. I think `HiveDDLSuite` drops this function by calli

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147682 **[Test build #55502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55502/consoleFull)** for PR 9565 at commit [`30a867e`](https://git

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147724 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147721 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-208147504 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-208147505 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-208147395 **[Test build #55497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55497/consoleFull)** for PR 11301 at commit [`02d75c7`](https://g

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147148 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147147 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208147121 **[Test build #55501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55501/consoleFull)** for PR 9565 at commit [`884a176`](https://git

[GitHub] spark pull request: [SPARK-13667][SQL] Support for specifying cust...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11550#issuecomment-208145793 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13667][SQL] Support for specifying cust...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11550#issuecomment-208145794 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13667][SQL] Support for specifying cust...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11550#issuecomment-208145667 **[Test build #55496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55496/consoleFull)** for PR 11550 at commit [`c197d52`](https://g

[GitHub] spark pull request: [SPARK-14432][SQL] Add API to calculate the ap...

2016-04-10 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12207#issuecomment-208142363 ping @jkbradley @MLnick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208138899 **[Test build #55502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55502/consoleFull)** for PR 9565 at commit [`30a867e`](https://gith

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-208136271 **[Test build #55501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55501/consoleFull)** for PR 9565 at commit [`884a176`](https://gith

[GitHub] spark pull request: [SPARK-14362][SPARK-14406][SQL][Follow-up] DDL...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12284#issuecomment-208131830 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14362][SPARK-14406][SQL][Follow-up] DDL...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12284#issuecomment-208131833 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208131549 **[Test build #55499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55499/consoleFull)** for PR 12067 at commit [`045a9be`](https://g

[GitHub] spark pull request: [SPARK-14362][SPARK-14406][SQL][Follow-up] DDL...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12284#issuecomment-208131432 **[Test build #55495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55495/consoleFull)** for PR 12284 at commit [`9271a03`](https://g

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208131587 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208131584 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13600] [MLlib] Use approxQuantile from ...

2016-04-10 Thread oliverpierson
Github user oliverpierson commented on the pull request: https://github.com/apache/spark/pull/11553#issuecomment-208130852 scalastyle check is failing because the `@see` link on [line 54](https://github.com/apache/spark/pull/11553/commits/c365da039f239e03f21fa927f8fa1ccaa9ca9ba8#diff-b

[GitHub] spark pull request: [SPARK-13600] [MLlib] Use approxQuantile from ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11553#issuecomment-208130405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13600] [MLlib] Use approxQuantile from ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11553#issuecomment-208130400 **[Test build #55500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55500/consoleFull)** for PR 11553 at commit [`c365da0`](https://g

[GitHub] spark pull request: [SPARK-13600] [MLlib] Use approxQuantile from ...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11553#issuecomment-208130403 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13600] [MLlib] Use approxQuantile from ...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11553#issuecomment-208129954 **[Test build #55500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55500/consoleFull)** for PR 11553 at commit [`c365da0`](https://gi

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-208129959 **[Test build #55499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55499/consoleFull)** for PR 12067 at commit [`045a9be`](https://gi

[GitHub] spark pull request: [SPARK-14491][SQL] refactor object operator fr...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12260#issuecomment-208122361 **[Test build #55498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55498/consoleFull)** for PR 12260 at commit [`856ad74`](https://gi

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12268#discussion_r59148216 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVParserSuite.scala --- @@ -1,125 +0,0 @@ -/* - * Licensed to th

[GitHub] spark pull request: [SPARK-14502][SQL] Add optimization for Non-Nu...

2016-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12267#discussion_r59147914 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala --- @@ -0,0 +1,99 @@

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-208119382 **[Test build #55497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55497/consoleFull)** for PR 11301 at commit [`02d75c7`](https://gi

[GitHub] spark pull request: [SPARK-13667][SQL] Support for specifying cust...

2016-04-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11550#issuecomment-208119378 **[Test build #55496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55496/consoleFull)** for PR 11550 at commit [`c197d52`](https://gi

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208119322 Unable to find it. : ( Still unable to reproduce it in my local environment. Will upload a code change to print out a message when we adding Hive UDF `curren

[GitHub] spark pull request: [SPARK-14051][SQL] Implement `Double.NaN==Floa...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11868#issuecomment-208118258 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-208118294 Is there any chance that the original current_database is not in the function registry when we call current_database? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14051][SQL] Implement `Double.NaN==Floa...

2016-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11868#issuecomment-208118250 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

  1   2   3   >