[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60008476 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60008271 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60008194 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-14453]Remove the support of SPARK_JAVA_...

2016-04-17 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/12465 [SPARK-14453]Remove the support of SPARK_JAVA_OPTS env variable ## What changes were proposed in this pull request? `SPARK_JAVA_OPTS` is deprecated since Spark 1.0, it is recommended to

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60007877 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211213074 Merging this failed on my laptop. Can you try merge this yourself? I think we are good to go since the failed tests are unrelated. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211212763 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14398] [SQL] Audit non-reserved keyword...

2016-04-17 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12191#issuecomment-211212703 @bomeng sorry for not getting back to you sooner. Is sorting the list only for asthetics and ease of searching? It seems like it is not really worth effort if it

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60007659 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-12810][PySpark] PySpark CrossValidatorM...

2016-04-17 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/spark/pull/12464#issuecomment-211210916 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...

2016-04-17 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211209966 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60007367 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12306#discussion_r60007268 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -110,6 +110,31 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-211207173 Hello @yhuai , I tested the scenario you mentioned & it works fine for me without any errors. However, as you rightly mentioned, the following statement

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211205660 **[Test build #2804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2804/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-12810][PySpark] PySpark CrossValidatorM...

2016-04-17 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/spark/pull/12464#issuecomment-211205576 cc @feynmanliang @jkbradley @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211205635 **[Test build #2805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2805/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-12810][PySpark] PySpark CrossValidatorM...

2016-04-17 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/spark/pull/12464 [SPARK-12810][PySpark] PySpark CrossValidatorModel should support avgMetrics ## What changes were proposed in this pull request? support avgMetrics in CrossValidatorModel with Python ##

[GitHub] spark pull request: [SPARK-14127][SQL][WIP] Describe table

2016-04-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12460#discussion_r60006341 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -254,6 +251,21 @@ class SparkSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12462#discussion_r60006203 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -172,10 +172,10 @@ class TaskMetrics private[spark]( val

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12306#issuecomment-211199893 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14603] [SQL] [WIP] Verification of Meta...

2016-04-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12385#issuecomment-211195724 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14691] [SQL] Simplify and Unify Error G...

2016-04-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12459#issuecomment-211195477 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211188821 **[Test build #2805 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2805/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211189391 **[Test build #2807 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2807/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211189182 **[Test build #2806 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2806/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12463#issuecomment-211188665 **[Test build #2804 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2804/consoleFull)** for PR 12463 at commit

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-17 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/12463 [SPARK-14647][SQL] Group SQLContext/HiveContext state into SharedState ## What changes were proposed in this pull request? This patch adds a SharedState that groups state shared across

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12458#discussion_r60003678 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/typed.scala --- @@ -46,8 +46,6 @@ object typed { override protected def

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-211181637 Can you try ``` import org.apache.spark.sql._ import org.apache.spark.sql.functions._ import org.apache.spark.sql.expressions._ import

[GitHub] spark pull request: [SPARK-14139][SQL] RowEncoder should preserve ...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12364#issuecomment-211179912 OK please label it as a todo for future pr; otherwise it is difficult to tell if it is meant to be done as the current one. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-14139][SQL] RowEncoder should preserve ...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12364#issuecomment-211178558 yea, it's still valid, but I'd like to do it in follow-ups, as this PR is taken over from other people, I don't want to enlarge the scope too much. --- If your

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12462#issuecomment-211176510 **[Test build #2803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2803/consoleFull)** for PR 12462 at commit

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-17 Thread kasjain
Github user kasjain commented on the pull request: https://github.com/apache/spark/pull/12356#issuecomment-211176212 Can any of the admin verify the above fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-04-17 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-211175800 @srowen - As per andrew's comment, I thought it was fine to make the change given that HadoopRDD is marked as DeveloperAPI. Please let me know if any

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12462#issuecomment-211173829 **[Test build #2803 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2803/consoleFull)** for PR 12462 at commit

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12462#issuecomment-211173368 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-211169780 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14127][SQL][WIP] Describe table

2016-04-17 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/12460#issuecomment-211169665 @gatorsmile Thank you. I have resolved the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12462#discussion_r60001921 --- Diff: core/src/test/resources/HistoryServerExpectations/application_list_json_expectation.json --- @@ -2,108 +2,108 @@ "id" :

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/12462 [SPARK-14628][CORE][folllow-up] Always tracking read/write metrics ## What changes were proposed in this pull request? This PR is a follow up for

[GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12462#issuecomment-211167735 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14409][ML][WIP] Adding a RankingEvaluat...

2016-04-17 Thread yongtang
GitHub user yongtang opened a pull request: https://github.com/apache/spark/pull/12461 [SPARK-14409][ML][WIP] Adding a RankingEvaluator to ML ## What changes were proposed in this pull request? This patch tries to add the implementation of Mean Rreciprocal Rank (MRR) in

[GitHub] spark pull request: SPARK-14321. [SQL] Reduce date format cost and...

2016-04-17 Thread rajeshbalamohan
Github user rajeshbalamohan commented on a diff in the pull request: https://github.com/apache/spark/pull/12105#discussion_r60001514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -368,7 +369,10 @@ abstract class

[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...

2016-04-17 Thread marcintustin
Github user marcintustin commented on the pull request: https://github.com/apache/spark/pull/12455#issuecomment-211164186 The test failures are probably bogus, as per

[GitHub] spark pull request: [SPARK-14127][SQL][WIP] Describe table

2016-04-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12460#issuecomment-211163664 Please resolve the conflicts. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14127][SQL][WIP] Describe table

2016-04-17 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/12460#issuecomment-211163482 @andrewor14 Looking for some early feedback on this as i was thinking to do the same for show table extended. I did have a brief discussion with @gatorsmile on

[GitHub] spark pull request: [SPARK-14127] Describe table

2016-04-17 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/12460 [SPARK-14127] Describe table ## What changes were proposed in this pull request? This PR adds .support for describing partitions and columns. Support for describing tables were already

[GitHub] spark pull request: [SPARK-13382][DOCS][PYSPARK] Update pyspark te...

2016-04-17 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11278#issuecomment-211162111 re-ping @JoshRosen thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14635] [ML] Documentation and Examples ...

2016-04-17 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12454#discussion_r6837 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/TfIdfExample.scala --- @@ -20,7 +20,7 @@ package org.apache.spark.examples.ml

[GitHub] spark pull request: [SPARK-14635] [ML] Documentation and Examples ...

2016-04-17 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12454#discussion_r6631 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/TfIdfExample.scala --- @@ -20,7 +20,7 @@ package org.apache.spark.examples.ml

[GitHub] spark pull request: [Spark-14564] [ML] [MLlib] [PySpark] Python Wo...

2016-04-17 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12428#issuecomment-211156441 Thanks for taking the initiative to do this. A few minor comments from the first pass through, but in the meantime maybe one the admins (possibly @jkbradley) could

[GitHub] spark pull request: [Spark-14564] [ML] [MLlib] [PySpark] Python Wo...

2016-04-17 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12428#discussion_r5886 --- Diff: python/pyspark/ml/feature.py --- @@ -2245,6 +2248,21 @@ def getMinCount(self): """ return

[GitHub] spark pull request: [Spark-14564] [ML] [MLlib] [PySpark] Python Wo...

2016-04-17 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12428#discussion_r5797 --- Diff: python/pyspark/ml/feature.py --- @@ -2173,28 +2173,31 @@ class Word2Vec(JavaEstimator, HasStepSize, HasMaxIter, HasSeed, HasInputCol, Has

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-211148808 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211148786 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14691] [SQL] Simplify and Unify Error G...

2016-04-17 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12459 [SPARK-14691] [SQL] Simplify and Unify Error Generation for Unsupported Alter Table DDL What changes were proposed in this pull request? So far, we are capturing each unsupported Alter

[GitHub] spark pull request: [SPARK-14423][YARN] Avoid same name files adde...

2016-04-17 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12203#issuecomment-211141690 @vanzin , please help to review again, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-211140805 Hi @rxin , I updated the title & description. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-14609][SQL] Native support for LOAD DAT...

2016-04-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12412#issuecomment-211140325 cc @andrewor14 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-211140342 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MINOR] Revert removing explicit typing (chang...

2016-04-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12452#issuecomment-211139508 (The tests `org.apache.spark.sql.hive.HiveSparkSubmitSuite.SPARK-8020: set sql conf in spark conf ` and

[GitHub] spark pull request: [MINOR] Revert removing explicit typing (chang...

2016-04-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12452#issuecomment-211139260 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-211138452 Can you update the pull request to have the full title and alos fix the description to elaborate the problem? Thanks. --- If your project is set up for it, you can

[GitHub] spark pull request: [DO_NOT_MERGE][Test] Investigate MemorySinkSui...

2016-04-17 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12306#issuecomment-211136525 **[Test build #2802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2802/consoleFull)** for PR 12306 at commit

[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12455#issuecomment-211135488 **[Test build #2801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2801/consoleFull)** for PR 12455 at commit

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-04-17 Thread sbcd90
GitHub user sbcd90 opened a pull request: https://github.com/apache/spark/pull/12458 [SPARK-14642][SQL] import org.apache.spark.sql.expressions._ breaks u… ## What changes were proposed in this pull request? PR fixes the import issue which breaks udf functions.

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-211127633 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12306#issuecomment-211126406 **[Test build #2802 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2802/consoleFull)** for PR 12306 at commit

[GitHub] spark pull request: [MINOR] Revert removing explicit typing (chang...

2016-04-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12452#issuecomment-211125032 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-211124797 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12455#issuecomment-211124248 **[Test build #2801 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2801/consoleFull)** for PR 12455 at commit

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211123492 @sbcd90 can you also create a backport for branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211123166 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4226][SQL] Support Correlated Sub-queri...

2016-04-17 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12306#issuecomment-211122925 @rxin / @davies this one is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13904] Add exit code parameter to exitE...

2016-04-17 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/12457#issuecomment-211121052 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211120299 **[Test build #2800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2800/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211107493 **[Test build #2800 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2800/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-17 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59991684 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -140,6 +140,13 @@ private[spark] class

[GitHub] spark pull request: [SPARK-13904] Add exit code parameter to exitE...

2016-04-17 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/12457 [SPARK-13904] Add exit code parameter to exitExecutor() ## What changes were proposed in this pull request? This PR adds exit code parameter to exitExecutor() so that caller can specify

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211098368 **[Test build #2798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2798/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211098676 **[Test build #2799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2799/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: [SPARK-11834][ML] Ignore Thresholds in Logisti...

2016-04-17 Thread JeremyNixon
Github user JeremyNixon commented on a diff in the pull request: https://github.com/apache/spark/pull/12400#discussion_r59990906 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -104,8 +107,8 @@ private[classification] trait

[GitHub] spark pull request: [SPARK-14504][SQL] Enable Oracle docker tests

2016-04-17 Thread lresende
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/12270#issuecomment-211084045 Jenkins, retest this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-14283][SQL] Add a option to avoid local...

2016-04-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12453#issuecomment-211083868 Shouldn't the user-facing documentation explain the consequences of omitting this sort, especially its impact on correctness? --- If your project is set up for it,

[GitHub] spark pull request: [Spark-14686][CORE,SQL,STREAMING]

2016-04-17 Thread marcintustin
Github user marcintustin commented on the pull request: https://github.com/apache/spark/pull/12456#issuecomment-211080503 @rxin Derp on my part. Of course this needs a better title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [Spark-14686][CORE,SQL,STREAMING]

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12456#issuecomment-211079561 The title should probably just be "[SPARK-14686] Allow setting local properties that are not inheritable" --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [Spark-14686][CORE,SQL,STREAMING]

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12456#issuecomment-211079376 Can you add a more descriptive title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-14686][CORE,SQL,STREAMING]

2016-04-17 Thread marcintustin
Github user marcintustin commented on the pull request: https://github.com/apache/spark/pull/12456#issuecomment-211078297 I should add that this will also need new tests. I haven't added any, again pending overall agreement on design. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211078003 **[Test build #2798 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2798/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: [Spark-14686][CORE,SQL,STREAMING]

2016-04-17 Thread marcintustin
GitHub user marcintustin opened a pull request: https://github.com/apache/spark/pull/12456 [Spark-14686][CORE,SQL,STREAMING] ## What changes were proposed in this pull request? This PR adds a uninheritableLocalPropertyFacility and ports sql.execution.id to be set with that

[GitHub] spark pull request: SPARK-14632 randomSplit method fails on datafr...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12438#issuecomment-211077993 **[Test build #2799 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2799/consoleFull)** for PR 12438 at commit

[GitHub] spark pull request: [SPARK-14505] [Core] Fix bug : creating two Sp...

2016-04-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12273#issuecomment-211075866 OK, so the changes are to pull the check for the active context out of the block checking for context being created (which looks like a simple bug), and you also put

[GitHub] spark pull request: [SPARK-14679] [UI] Fix UI DAG visualization OO...

2016-04-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12437#discussion_r59989555 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -72,6 +72,22 @@ private[ui] class RDDOperationCluster(val id: String,

[GitHub] spark pull request: [SPARK-14684] [SQL] Verification of Partition ...

2016-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12446#issuecomment-211074915 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14684] [SQL] Verification of Partition ...

2016-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12446#issuecomment-211074913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14684] [SQL] Verification of Partition ...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12446#issuecomment-211074843 **[Test build #56063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56063/consoleFull)** for PR 12446 at commit

[GitHub] spark pull request: [SPARK-14504][SQL] Enable Oracle docker tests

2016-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12270#issuecomment-211074807 Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   >