Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12927#discussion_r62799764
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaLDAExample.java ---
@@ -17,80 +17,53 @@
package org.apache.spark.examples.ml;
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12945#discussion_r62799642
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala ---
@@ -175,13 +175,37 @@ abstract class Catalog {
options: Map[Str
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12974#issuecomment-218377742
**[Test build #58341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58341/consoleFull)**
for PR 12974 at commit
[`3782cda`](https://gi
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12935#discussion_r62799542
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2480,4 +2480,20 @@ class SQLQuerySuite extends QueryTest with
SharedSQLCont
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13013
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12945#discussion_r62799493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala ---
@@ -175,13 +175,37 @@ abstract class Catalog {
options: Map[Str
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13013#issuecomment-218376924
Thanks. Merging to master and branch 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12627#issuecomment-218376899
**[Test build #58340 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58340/consoleFull)**
for PR 12627 at commit
[`9b59411`](https://gi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62799243
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12974#issuecomment-218376822
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62799170
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62799116
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12974#issuecomment-218376819
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12974#issuecomment-218376708
**[Test build #58327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58327/consoleFull)**
for PR 12974 at commit
[`e0eeb7d`](https://g
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12925#issuecomment-218376754
LGTM. I'll merge this once #11844 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13042#issuecomment-218376555
Seems fairly reasonable; is the speedup measurable? wouldn't have thought
so, but maybe for tens of thousands of files, sure.
---
If your project is set up for it, you
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62798961
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -79,14 +80,32 @@ public static String bytesToString(ByteBuf
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11844#discussion_r62798957
--- Diff: examples/src/main/python/ml/bisecting_k_means_example.py ---
@@ -36,21 +35,20 @@
.getOrCreate()
# $example on$
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11844#issuecomment-218376385
@zhengruifeng just a couple last comments to make these examples consistent
with the KMeans examples. Then I think this is ready.
---
If your project is set up for it,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218376269
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218376272
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218376081
**[Test build #58328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58328/consoleFull)**
for PR 12719 at commit
[`a73deaf`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13019#issuecomment-218376167
**[Test build #58339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58339/consoleFull)**
for PR 13019 at commit
[`a2c77ca`](https://gi
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11844#discussion_r62798757
--- Diff: examples/src/main/python/ml/bisecting_k_means_example.py ---
@@ -36,21 +35,20 @@
.getOrCreate()
# $example on$
-d
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11844#discussion_r62798712
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBisectingKMeansExample.java
---
@@ -48,26 +43,19 @@ public static void main(String[]
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62798600
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -930,6 +930,69 @@ abstract class AggregationQuerySu
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11844#discussion_r62798474
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBisectingKMeansExample.java
---
@@ -48,26 +43,19 @@ public static void main(String[] args)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12935#issuecomment-218375374
**[Test build #58338 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58338/consoleFull)**
for PR 12935 at commit
[`98cea9a`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62798315
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -930,6 +930,69 @@ abstract class AggregationQuery
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12935#discussion_r62798256
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2480,4 +2480,20 @@ class SQLQuerySuite extends QueryTest with
SharedSQL
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12996#issuecomment-218375184
@holdenk Ok, I will update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12935#discussion_r62798178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -492,33 +493,28 @@ private[sql] object DDLUtils {
tabl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12945#issuecomment-218374585
**[Test build #58337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58337/consoleFull)**
for PR 12945 at commit
[`e01b3e8`](https://gi
Github user clockfly commented on the pull request:
https://github.com/apache/spark/pull/12945#issuecomment-218374422
Rebased on latest trunk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12964
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12964#issuecomment-218374316
Thanks! Merged to master and branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12936#issuecomment-218373784
**[Test build #58336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58336/consoleFull)**
for PR 12936 at commit
[`d83a004`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12945#issuecomment-218373779
**[Test build #58335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58335/consoleFull)**
for PR 12945 at commit
[`72d7103`](https://gi
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62797100
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -930,6 +930,69 @@ abstract class AggregationQuerySu
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/13019#issuecomment-218372841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62796649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, in
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62796474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12927#issuecomment-218371414
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12926#issuecomment-218371339
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12927#issuecomment-218371413
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12927#issuecomment-218371340
**[Test build #58329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58329/consoleFull)**
for PR 12927 at commit
[`eab9511`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371327
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12926#issuecomment-218371338
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12926#issuecomment-218371230
**[Test build #58326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58326/consoleFull)**
for PR 12926 at commit
[`29a0c70`](https://g
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62796179
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -930,6 +930,69 @@ abstract class AggregationQuery
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371154
**[Test build #58325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58325/consoleFull)**
for PR 12618 at commit
[`3788e86`](https://g
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13019#discussion_r62796071
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
---
@@ -143,21 +143,35 @@ class RowEncoderSuite extends Spa
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218370929
**[Test build #58334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58334/consoleFull)**
for PR 13045 at commit
[`65375b4`](https://gi
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/13045
[SPARK-15114][SQL] Column name generated by typed aggregate is super verbose
## What changes were proposed in this pull request?
Generate a shorter default alias for `AggregateExpressio
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13019#issuecomment-218369792
actually cc @davies also
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12939#issuecomment-218368915
**[Test build #58333 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58333/consoleFull)**
for PR 12939 at commit
[`7106f23`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13042#issuecomment-218368903
**[Test build #58332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58332/consoleFull)**
for PR 13042 at commit
[`1877ad4`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13044#issuecomment-218368867
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13044#issuecomment-218368852
**[Test build #58330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58330/consoleFull)**
for PR 13044 at commit
[`d7361d8`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13044#issuecomment-218368868
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62794873
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -79,14 +80,27 @@ public static String bytesToString(By
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62794845
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -79,14 +80,27 @@ public static String bytesToString(By
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218368305
**[Test build #58331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58331/consoleFull)**
for PR 12719 at commit
[`a6b1cbc`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12946#issuecomment-218368063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12946#issuecomment-218368062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12946#issuecomment-218367940
**[Test build #58323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58323/consoleFull)**
for PR 12946 at commit
[`ab2bd63`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13044#issuecomment-218367680
**[Test build #58330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58330/consoleFull)**
for PR 13044 at commit
[`d7361d8`](https://gi
GitHub user techaddict opened a pull request:
https://github.com/apache/spark/pull/13044
[SPARK-15037][SQL][MLLIB] Part2 Use SparkSession instead of SQLContext in
Python TestSuites
## What changes were proposed in this pull request?
Use SparkSession instead of SQLContext in Pyth
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12927#issuecomment-218366438
**[Test build #58329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58329/consoleFull)**
for PR 12927 at commit
[`eab9511`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218366226
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218366224
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218366088
**[Test build #58324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58324/consoleFull)**
for PR 12719 at commit
[`b8ddf0c`](https://g
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62793802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends F
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13035#issuecomment-218365971
Why shouldn't we include the time it takes for record insertion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13016#issuecomment-218365775
Thanks - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13033
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13020#issuecomment-218365539
Merging in master/2.0. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13043#issuecomment-218365410
Thank you, @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62793571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends Fil
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13043
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13033#issuecomment-218365388
Thanks - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13043#issuecomment-218365133
LGTM - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218364963
Anyway, I made a long detour for this PR. Sorry for that, @cloud-fan , and
thank you again.
---
If your project is set up for it, you can reply to this email an
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62793386
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -79,14 +80,27 @@ public static String bytesToString(ByteBuffe
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62793337
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -79,14 +80,27 @@ public static String bytesToString(ByteBuffe
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62793285
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -44,10 +44,12 @@ class PlannerSuite extends SharedSQLContext {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12974#issuecomment-218364589
**[Test build #58327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58327/consoleFull)**
for PR 12974 at commit
[`e0eeb7d`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218364599
**[Test build #58328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58328/consoleFull)**
for PR 12719 at commit
[`a73deaf`](https://gi
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62793263
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, i
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13040#issuecomment-218364416
LGTM - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13040#issuecomment-218364439
Yes please submit another pr for those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r62793156
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -650,15 +646,15 @@ object FoldablePropagation ext
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12926#issuecomment-218364032
**[Test build #58326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58326/consoleFull)**
for PR 12926 at commit
[`29a0c70`](https://gi
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62792987
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -291,12 +291,23 @@ private[spark] object TaskMetrics extends Logging {
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13040#issuecomment-218363946
cc @rxin
(I see doc tests and test in Python is still using `SqlContext`. Do you
mind if I correct this in another PR?)
---
If your project is set up for
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62792794
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, in
1 - 100 of 957 matches
Mail list logo
