[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-12 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/12996#issuecomment-218965538 LGTM, merged to master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-12 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r63139168 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15188] Add missing thresholds param to ...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15188] Add missing thresholds param to ...

2016-05-12 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/12963#issuecomment-218963890 Merged to master and branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-12 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r63138800 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-12 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r63138686 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15305][ML][DOC]:spark.ml document Bisec...

2016-05-12 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13083#issuecomment-218962997 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-218962173 uh,,, my understanding is wrong. We still allow data source tables. Then, I need to reduce the scope. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218961437 **[Test build #58548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58548/consoleFull)** for PR 13048 at commit [`f538d75`](https://gi

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218960842 **[Test build #58547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58547/consoleFull)** for PR 13048 at commit [`ebd3273`](https://gi

[GitHub] spark pull request: [SPARK-14434][ML]:User guide doc and examples ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12788#issuecomment-218960679 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14434][ML]:User guide doc and examples ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12788#issuecomment-218960680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218960526 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14434][ML]:User guide doc and examples ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12788#issuecomment-218960609 **[Test build #58546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58546/consoleFull)** for PR 12788 at commit [`eb9469e`](https://g

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218960523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218960405 **[Test build #58542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58542/consoleFull)** for PR 13091 at commit [`7424af4`](https://g

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-12 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r63137161 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala --- @@ -98,6 +98,7 @@ class StopWordsRemoverSuite .setInp

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-218959598 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14434][ML]:User guide doc and examples ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12788#issuecomment-218959613 **[Test build #58546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58546/consoleFull)** for PR 12788 at commit [`eb9469e`](https://gi

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-218959631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-218959599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-218959627 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-218959520 **[Test build #58543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58543/consoleFull)** for PR 13093 at commit [`5c3b116`](https://g

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-218959501 **[Test build #58540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58540/consoleFull)** for PR 12719 at commit [`2d56bc2`](https://g

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-218958319 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-218958318 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-218958212 **[Test build #58539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58539/consoleFull)** for PR 13090 at commit [`ddb9ce6`](https://g

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13084#discussion_r63136060 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -222,6 +222,33 @@ trait Unevaluable extends Expressio

[GitHub] spark pull request: [spark-15212][SQL]CSV file reader when read fi...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12987#issuecomment-218958088 @WeichenXu123 I tried that with `ignoreLeadingWhiteSpace` and `ignoreTrailingWhiteSpace` and it seems working fine. I am careful of saying this because I am not a c

[GitHub] spark pull request: [SPARK-15253] [SQL] Support old table schema c...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13073#issuecomment-218957944 **[Test build #58545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58545/consoleFull)** for PR 13073 at commit [`f82f7c6`](https://gi

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218956881 **[Test build #58544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58544/consoleFull)** for PR 13091 at commit [`06aa4ae`](https://gi

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-218956629 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63135350 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-218956628 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-218956508 **[Test build #58538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58538/consoleFull)** for PR 12268 at commit [`cbb1674`](https://g

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63135275 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-15305][ML][DOC]:spark.ml document Bisec...

2016-05-12 Thread wangmiao1981
Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/13083#issuecomment-218955997 cc @zhengruifeng @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13866][SQL] Handle decimal type in CSV ...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13866][SQL] Handle decimal type in CSV ...

2016-05-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11724#issuecomment-218955594 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-13866][SQL] Handle decimal type in CSV ...

2016-05-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11724#issuecomment-218955604 Merging this into master and 2.0, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15236][SQL][SPARK SHELL] Add spark-defa...

2016-05-12 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13088#discussion_r63134583 --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala --- @@ -88,7 +88,8 @@ object Main extends Logging { } val b

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63134568 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14541] [SQL] SQL function: IFNULL, NULL...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12373 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13084#issuecomment-218953966 Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13084#issuecomment-218953875 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63134045 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63133864 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63133871 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63133772 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread lresende
Github user lresende closed the pull request at: https://github.com/apache/spark/pull/13092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-218952559 **[Test build #58543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58543/consoleFull)** for PR 13093 at commit [`5c3b116`](https://gi

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13084#discussion_r63133598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -222,6 +222,33 @@ trait Unevaluable extends Expression

[GitHub] spark pull request: [SPARK-15236][SQL][SPARK SHELL] Add spark-defa...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13088#discussion_r63133610 --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala --- @@ -88,7 +88,8 @@ object Main extends Logging { } val buil

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218952186 It's better to do this once we have a 2.0 maven artifact published I think. Otherwise Mima is going to have duplicates and as we do api tweaks during qa period we will hav

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218952073 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Non-tempor...

2016-05-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13093 [SPARK-15311] [SQL] Disallow DML on Non-temporary Tables when Using In-Memory Catalog What changes were proposed in this pull request? So far, when using In-Memory Catalog, we allow DDL

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218952070 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218952061 **[Test build #58541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58541/consoleFull)** for PR 13092 at commit [`92dddf5`](https://g

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218952009 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-13866][SQL] Handle decimal type in CSV ...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11724#issuecomment-218951716 cc @davies can you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread lresende
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218951567 @srowen Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218951119 **[Test build #58542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58542/consoleFull)** for PR 13091 at commit [`7424af4`](https://gi

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-218951117 **[Test build #58541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58541/consoleFull)** for PR 13092 at commit [`92dddf5`](https://gi

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-12 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/spark/pull/13092 [SPARK-15309] Bump master to version 2.1.0-SNAPSHOT ## What changes were proposed in this pull request? Update pom artifact version to 2.1.0-SNAPSHOT to avoid any conflicts with 2.0.0-SNA

[GitHub] spark pull request: [TRIVIAL][Doc] SparkSession class doc example ...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13086#issuecomment-218950905 Maybe we should add () to the builder function instead? In that case this code will work in Java too. --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13091#issuecomment-218950766 cc @yhuai for review; talked with @marmbrus offline already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-15310][SQL] Rename HiveTypeCoercion -> ...

2016-05-12 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/13091 [SPARK-15310][SQL] Rename HiveTypeCoercion -> TypeCoercion ## What changes were proposed in this pull request? We originally designed the type coercion rules to match Hive, but over time we have d

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-218950690 **[Test build #58540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58540/consoleFull)** for PR 12719 at commit [`2d56bc2`](https://gi

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13078#issuecomment-218950522 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13078#issuecomment-218950521 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-218950477 Rebase to resolve conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63132718 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13078#issuecomment-218950439 **[Test build #58537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58537/consoleFull)** for PR 13078 at commit [`9b2a5aa`](https://g

[GitHub] spark pull request: [SPARK-15306][SQL] Move object expressions int...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13084#issuecomment-218949992 cc @hvanhovell wanna review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15306][SQL] Move object expressions int...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13085#issuecomment-218950017 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-218949812 **[Test build #58539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58539/consoleFull)** for PR 13090 at commit [`ddb9ce6`](https://gi

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-12 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/13090 [SPARK-15308][SQL] RowEncoder should preserve nested column name. ## What changes were proposed in this pull request? The following code generates wrong schema: ``` val schema =

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218949638 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218949640 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218949541 **[Test build #58536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58536/consoleFull)** for PR 13048 at commit [`6fd5f0d`](https://g

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-12 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218949085 @viirya Can you try to merge my code with yours, and see if the python tests pass? Thanks. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-218949073 Hi, @liancheng and @cloud-fan . This PR is similar with your commit, `[SPARK-13473][SQL] Don't push predicate through project with nondeterministic field(s)`.

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-218948867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-218948865 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-218948774 **[Test build #58535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58535/consoleFull)** for PR 13087 at commit [`ab5bc4b`](https://g

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-218948489 **[Test build #58538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58538/consoleFull)** for PR 12268 at commit [`cbb1674`](https://gi

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-218948335 The reported error scenario is the following. ```scala scala> val df = sc.parallelize(Seq(("a", "b"), ("a1", "b1"))).toDF("old","old1") scala> val udfF

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

2016-05-12 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-218947787 @markhamstra , thanks for your explaintion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-13866][SQL] Handle decimal type in CSV ...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11724#issuecomment-218946776 @rxin Do you mind if I ask a quick look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-218946730 ping @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-15198][SQL] Support for pushing down fi...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12972#issuecomment-218946661 Please excuse my ping, @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

2016-05-12 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-218945792 @zzcclp Not likely. This PR shouldn't produce any different results, but rather produces the same results faster. We're typically very conservative with patch-lev

[GitHub] spark pull request: [SPARK-15143][SPARK-15144][SQL] Add CSV tests ...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12921#issuecomment-218945091 Please excuse my ping @rxin @falaki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218943216 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218943213 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor options for JDBC a...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218943100 **[Test build #58534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58534/consoleFull)** for PR 13048 at commit [`0f86ce6`](https://g

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13078#issuecomment-218942530 **[Test build #58537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58537/consoleFull)** for PR 13078 at commit [`9b2a5aa`](https://gi

  1   2   3   4   5   6   7   >