[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13076#issuecomment-219626509 **[Test build #58668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58668/consoleFull)** for PR 13076 at commit

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-219626498 **[Test build #58667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58667/consoleFull)** for PR 13095 at commit

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13076#issuecomment-219626330 Yeah I agree - let's add that for next release. On Tue, 17 May 2016 at 07:37, Yanbo Liang wrote: > @avulanov

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-219626090 @mchalek @JoshRosen Is there any progress yet? I got the same error with spark-1.6.1. But if I add "driver=com.mysql.jdbc.Driver" property to write.jdbc's properties

[GitHub] spark pull request: [SPARK-14906][ML] Copy linalg in PySpark to ne...

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13099#issuecomment-219624730 @viirya I made one pass and sent you a PR at https://github.com/viirya/spark-1/pull/5. Please take a look and merge it if it looks good to you. Thanks! --- If your

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219624016 **[Test build #58666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58666/consoleFull)** for PR 12855 at commit

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13076#issuecomment-219623827 @avulanov Thanks for your comments. To provide ```rawPredictions``` is make sense, but I think it's a new feature and we should do it in the next release cycle. I

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12855#discussion_r63466408 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala --- @@ -216,6 +215,33 @@ class InsertIntoHiveTableSuite

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-219621230 @felixcheung, could you demonstrate your thought more clearly? I am not sure If I understand it. this PR aims to allow applying an R function on groups, while agg is

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219620522 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219620521 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219620469 **[Test build #58665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58665/consoleFull)** for PR 13134 at commit

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/12939#discussion_r63464908 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala --- @@ -162,7 +162,18 @@ package object util { def

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-219619796 My apologies if this was discussed (this was a long PR!) - isn't it rather constricting to allow grouping by list of columns only? Is it more useful or flexible to

[GitHub] spark pull request: [SPARK-14603] [SQL] [FOLLOWUP] Verification of...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13126#issuecomment-219619023 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14603] [SQL] [FOLLOWUP] Verification of...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13126#issuecomment-219619025 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14603] [SQL] [FOLLOWUP] Verification of...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13126#issuecomment-219618912 **[Test build #58661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58661/consoleFull)** for PR 13126 at commit

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219618868 **[Test build #58665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58665/consoleFull)** for PR 13134 at commit

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219618619 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219618620 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219618589 **[Test build #58663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58663/consoleFull)** for PR 13128 at commit

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13134#discussion_r63464031 --- Diff: python/pyspark/sql/tests.py --- @@ -1036,8 +1036,15 @@ def test_access_column(self): self.assertRaises(TypeError, lambda: df[{}])

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-219618421 **[Test build #58664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58664/consoleFull)** for PR 13121 at commit

[GitHub] spark pull request: [SPARK-14434][ML]:User guide doc and examples ...

Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/12788#issuecomment-219617189 @MLnick I made changes accordingly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219616350 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219616331 **[Test build #58662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58662/consoleFull)** for PR 12855 at commit

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219616349 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219615459 **[Test build #58663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58663/consoleFull)** for PR 13128 at commit

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12855#discussion_r63462283 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala --- @@ -879,6 +879,24 @@ abstract class HadoopFsRelationTest

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12855#discussion_r63462262 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala --- @@ -216,6 +215,33 @@ class InsertIntoHiveTableSuite extends

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219614959 **[Test build #58662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58662/consoleFull)** for PR 12855 at commit

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-219614807 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/13076#issuecomment-219613838 @yanboliang Changing `weights` to `initialWeights` makes a perfect sense, thank you. There were few requests for MLP to provide `rawPredictions`. Since you are

[GitHub] spark pull request: [SPARK-13850] Force the sorter to Spill when n...

Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13107#issuecomment-219612852 What is the root cause? Can you also add a regression test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14603] [SQL] [FOLLOWUP] Verification of...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13126#issuecomment-219610450 **[Test build #58661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58661/consoleFull)** for PR 13126 at commit

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219609218 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219609183 **[Test build #58660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58660/consoleFull)** for PR 13128 at commit

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219609216 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15290] [BUILD] Move annotations, like @...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13074#issuecomment-219608475 Actually josh is on vacation. Definitely go ahead. I looked at it and it seemed ok. I'm not a build expert though. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219608365 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219608366 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219608257 **[Test build #58659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58659/consoleFull)** for PR 12060 at commit

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219606817 I have finished my review. Thank you for working on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63458236 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63458112 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63458151 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-t...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13128#issuecomment-219605418 **[Test build #58660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58660/consoleFull)** for PR 13128 at commit

[GitHub] spark pull request: [SPARK-15247][SQL] Set the default number of p...

Github user maropu commented on the pull request: https://github.com/apache/spark/pull/13137#issuecomment-219603543 @liancheng Trivial fix and could you fix this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15340][SQL]Limit the size of the map us...

Github user DoingDone9 commented on a diff in the pull request: https://github.com/apache/spark/pull/13130#discussion_r63453073 --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala --- @@ -363,7 +363,7 @@ private[spark] object HadoopRDD extends Logging {

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13076#issuecomment-219595234 Thanks for these fixes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13076#discussion_r63452937 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -65,22 +63,23 @@ private[ml] trait

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13076#discussion_r63452941 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -204,16 +238,26 @@ class

[GitHub] spark pull request: [SPARK-15292] [ML] ML 2.0 QA: Scala APIs audit...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13076#discussion_r63452938 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -181,12 +206,21 @@ class

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13141#issuecomment-219594712 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13141#issuecomment-219594710 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13141#issuecomment-219594613 **[Test build #58658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58658/consoleFull)** for PR 13141 at commit

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219594426 **[Test build #58659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58659/consoleFull)** for PR 12060 at commit

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219594429 @kayousterhout Thank you for your review. I updated the comments and pushed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15351][SQL] RowEncoder should support a...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/13138#issuecomment-219593532 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63451732 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends

[GitHub] spark pull request: [SPARK-15247][SQL] Set the default number of p...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13137#issuecomment-219592753 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15247][SQL] Set the default number of p...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13137#issuecomment-219592752 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15247][SQL] Set the default number of p...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13137#issuecomment-219592621 **[Test build #58657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58657/consoleFull)** for PR 13137 at commit

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63451609 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -265,6 +343,47 @@ private[client] class Shim_v0_12 extends Shim

[GitHub] spark pull request: [SPARK-15351][SQL] RowEncoder should support a...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13138#discussion_r63451076 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -185,6 +185,20 @@ class RowEncoderSuite extends

[GitHub] spark pull request: [SPARK-15351][SQL] RowEncoder should support a...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13138#discussion_r63450908 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala --- @@ -37,6 +37,11 @@ class GenericArrayData(val array:

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63450897 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13105#discussion_r63450323 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -172,4 +173,15 @@ class DefaultSource

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13105#issuecomment-219588474 Just for a note, JSON data source is doing this in via

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63449411 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -789,6 +791,51 @@ class TaskSetManagerSuite extends

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63448950 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -789,6 +791,51 @@ class TaskSetManagerSuite extends

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/13105#discussion_r63448886 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -172,4 +173,15 @@ class DefaultSource

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63448866 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -789,6 +791,51 @@ class TaskSetManagerSuite extends

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63448080 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -620,6 +620,14 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13105#discussion_r63447722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -172,4 +173,15 @@ class DefaultSource

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63447725 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -337,6 +337,16 @@ private[spark] object UIUtils extends Logging {

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63447507 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -71,11 +73,16 @@ class TaskInfo( failed = true }

[GitHub] spark pull request: [SPARK-15315][SQL] Adding error check to the C...

Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/13105#discussion_r63447396 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -172,4 +173,13 @@ class DefaultSource

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63446802 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -620,6 +620,14 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-14906][ML] Move VectorUDT and MatrixUDT...

Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12870#issuecomment-219583049 Ping @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11996#discussion_r63446363 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -620,6 +620,14 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-14752][SQL] LazilyGenerateOrdering thro...

Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12661#issuecomment-219582450 Since this one has been here for more than 10 days, I've provided another approach with new test case. Please take a look. Thanks. [PR for

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/12060#issuecomment-219582446 This LGTM with the small comment changes I suggested. @markhamstra any objections to this? Mark / @rxin thoughts on merging it into the 2.0 branch? --- If your

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13141#issuecomment-219582225 **[Test build #58658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58658/consoleFull)** for PR 13141 at commit

[GitHub] spark pull request: [SPARK-15247][SQL] Set the default number of p...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13137#issuecomment-219580597 **[Test build #58657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58657/consoleFull)** for PR 13137 at commit

[GitHub] spark pull request: [SPARK-14752] [SQL] fix kryo ordering serializ...

GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/13141 [SPARK-14752] [SQL] fix kryo ordering serialization ## What changes were proposed in this pull request? When using Kryo as serializer and we will get `NullPointerException` exception for

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

Github user seyfe commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-219581242 Hi @liancheng and @yhuai, Would you mind looking at this pull request? I would appreciate that. Thanks, Ergin --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63445044 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63444035 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-15319][SPARKR][DOCS] Fix SparkR doc lay...

Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/13109#issuecomment-219578322 that's fine, I don't know the history of putting stats column function into one rd page though. I agree it is fine to group function by the name `corr`

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/12060#discussion_r63443356 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -752,23 +751,20 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/12060#discussion_r63443272 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -752,23 +751,20 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/12060#discussion_r63443044 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1357,7 +1345,6 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-14269][SCHEDULER] Eliminate unnecessary...

Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/12060#discussion_r63442702 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1357,7 +1345,6 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-14906][ML] Copy linalg in PySpark to ne...

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13099#issuecomment-219575757 I'm making a pass now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7424] [ML] ML ClassificationModel shoul...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12066#discussion_r63440571 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala --- @@ -179,7 +230,7 @@ abstract class

[GitHub] spark pull request: [SPARK-15112][SQL] Allows query plan schema an...

Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12952#discussion_r63439615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -163,15 +164,17 @@ object EliminateSerialization extends

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63438981 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -265,6 +343,47 @@ private[client] class Shim_v0_12 extends Shim with

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13127#discussion_r63438911 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -208,7 +286,7 @@ private[client] class Shim_v0_12 extends Shim with

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219569749 @yanboliang Thank you so much for taking a close look and a detailed explanation! --- If your project is set up for it, you can reply to this email and have your

  1   2   3   4   5   >