[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220532067 **[Test build #58955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58955/consoleFull)** for PR 13095 at commit [`d7c2420`](https://g

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13192#issuecomment-220531788 **[Test build #58960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58960/consoleFull)** for PR 13192 at commit [`5ffb249`](https://gi

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-220531881 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-220531880 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-220531858 **[Test build #58953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58953/consoleFull)** for PR 9207 at commit [`344d5a0`](https://git

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63998812 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala --- @@ -46,3 +51,56 @@ case class AddFile(path: String) extends R

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-220531762 **[Test build #58961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58961/consoleFull)** for PR 13090 at commit [`cc8acea`](https://gi

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63998655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -713,13 +713,40 @@ class SparkSqlAstBuilder(conf: SQLConf) ext

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220531101 **[Test build #58959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58959/consoleFull)** for PR 13169 at commit [`193a2f1`](https://gi

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread wangyang1992
Github user wangyang1992 commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220531075 Fixed scala style, retest it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15400][SQL] CreateNamedStruct and Creat...

2016-05-19 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/13193#issuecomment-220531069 I see, I'll try it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220531077 **[Test build #58958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58958/consoleFull)** for PR 13212 at commit [`238843e`](https://gi

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-220531062 @ueshin unfortunately this no longer merges cleanly ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220530579 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-15400][SQL] CreateNamedStruct and Creat...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13193#issuecomment-220530565 +1 on adding a test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220530546 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220530382 **[Test build #58954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58954/consoleFull)** for PR 13211 at commit [`4d97bf0`](https://gi

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13045#issuecomment-220530378 **[Test build #58957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58957/consoleFull)** for PR 13045 at commit [`f410999`](https://gi

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220530387 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-220530407 **[Test build #58956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58956/consoleFull)** for PR 13090 at commit [`0346efe`](https://gi

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220530398 **[Test build #58955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58955/consoleFull)** for PR 13095 at commit [`d7c2420`](https://gi

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13000#issuecomment-220530103 Not part of this PR, we can use `@include_example` in the user guide, though it might require tags support. cc @yinxusen --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-15057][GRAPHX] Remove stale TODO commen...

2016-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12839#issuecomment-220530065 Thank you, @rxin . :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-15417][SQL][Python] PySpark shell alway...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13215#issuecomment-220530034 LGTM2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13215#discussion_r63997717 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -459,7 +459,7 @@ case class AlterTableSetLocation( }

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529900 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15421][SQL] Validate DDL property value...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529898 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529866 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15417][SQL][Python] PySpark shell alway...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13203#issuecomment-220529824 OK I'm merging this into master 2.0 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220529713 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13087#discussion_r63997574 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1025,7 +1025,8 @@ object PushDownPredicate exten

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/13000#discussion_r63997601 --- Diff: examples/src/main/r/ml.R --- @@ -25,30 +25,102 @@ library(SparkR) sc <- sparkR.init(appName="SparkR-ML-example") sqlContext <- sparkRSQL.in

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529743 **[Test build #58938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58938/consoleFull)** for PR 13211 at commit [`4d97bf0`](https://g

[GitHub] spark pull request: [SPARK-15222] [SparkR] [ML] SparkR ML examples...

2016-05-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/13000#discussion_r63997572 --- Diff: examples/src/main/r/ml.R --- @@ -25,30 +25,102 @@ library(SparkR) sc <- sparkR.init(appName="SparkR-ML-example") sqlContext <- sparkRSQL.in

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-220529667 **[Test build #58953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58953/consoleFull)** for PR 9207 at commit [`344d5a0`](https://gith

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220529704 Is this ready to merge? @hvanhovell @rxin Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15421][SQL] Validate DDL property value...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13205#issuecomment-220529662 Merging into master 2.0 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15400][SQL] CreateNamedStruct and Creat...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13193#issuecomment-220529563 LGTM, is it possible to write a test for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220529523 **[Test build #58951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58951/consoleFull)** for PR 13169 at commit [`30d2d0c`](https://g

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220529529 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220529510 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220529531 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15438] [SQL] improve explain of whole s...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220529369 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13590] [ML] [Doc] Document spark.ml LiR...

2016-05-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12731#discussion_r63997411 --- Diff: docs/ml-classification-regression.md --- @@ -62,6 +62,8 @@ For more background and more details about the implementation, refer to the docu

[GitHub] spark pull request: [SPARK-15438] [SQL] improve explain of whole s...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220529370 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15438] [SQL] improve explain of whole s...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220529341 **[Test build #58949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58949/consoleFull)** for PR 13204 at commit [`bc2aed4`](https://g

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220529183 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15153] [ML] [SparkR] Fix SparkR spark.n...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12930#issuecomment-220529140 Is it okay to always cast the target label column to string? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12984#issuecomment-220528927 **[Test build #58952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58952/consoleFull)** for PR 12984 at commit [`5445805`](https://gi

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220528941 **[Test build #58951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58951/consoleFull)** for PR 13169 at commit [`30d2d0c`](https://gi

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-8603][SPARKR] Incorrect file separator ...

2016-05-19 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/13165#issuecomment-220528702 I checked the source code of system2. Since a batch file with .cmd extension is to be launched on Windows, I think it is more formal to use shell() instead of system2()

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12984#issuecomment-220528625 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-220528642 Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12984#issuecomment-220528537 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220528429 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220528363 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220528428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220528269 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220528231 **[Test build #58950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58950/consoleFull)** for PR 13216 at commit [`bc0d10a`](https://gi

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63996737 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -37,6 +38,14 @@ private[sql] object Column { def apply(expr: Expression):

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13215#discussion_r63996748 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -459,7 +459,7 @@ case class AlterTableSetLocation( }

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220528241 **[Test build #58940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58940/consoleFull)** for PR 13156 at commit [`20d5055`](https://g

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220528129 cc @davies @liancheng @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15394][ML][DOCS] User guide typos and g...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15438] [SQL] improve explain of whole s...

2016-05-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220527920 @yhuai @marmbrus Updated to #3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/13215#issuecomment-220527990 One minor comment. LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-15394][ML][DOCS] User guide typos and g...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13180#issuecomment-220527824 Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13215#discussion_r63996513 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -459,7 +459,7 @@ case class AlterTableSetLocation( }

[GitHub] spark pull request: [SPARK-15424][SPARK-15437][SQL] Revert SPARK-1...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13207#issuecomment-220527560 added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-15398][ML] Update the warning message t...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13215#issuecomment-220527518 **[Test build #58948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58948/consoleFull)** for PR 13215 at commit [`2827ca5`](https://gi

[GitHub] spark pull request: [SPARK-15438] [SQL] improve explain of whole s...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220527528 **[Test build #58949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58949/consoleFull)** for PR 13204 at commit [`bc2aed4`](https://gi

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220527492 **[Test build #58947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58947/consoleFull)** for PR 13216 at commit [`313c3b9`](https://gi

[GitHub] spark pull request: [SPARK-15398][ML] Update the warning message t...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13190#issuecomment-220527358 Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-19 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13216 [SPARK-15434][SQL] improve EmbedSerializerInFilter rule ## What changes were proposed in this pull request? There is a TODO in `EmbedSerializerInFilter`, saying that we should enable thi

[GitHub] spark pull request: Revert "[SPARK-10216][SQL] Avoid creating empt...

2016-05-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13181#issuecomment-220527118 @jurriaan Maybe I am doing this wrong. I will tell you after testing that. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-15435][SQL] Append Command to all comma...

2016-05-19 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/13215 [SPARK-15435][SQL] Append Command to all commands ## What changes were proposed in this pull request? We started this convention to append Command suffix to all SQL commands. However, not all comm

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220526877 **[Test build #58946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58946/consoleFull)** for PR 12979 at commit [`6ebfa10`](https://gi

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: Revert "[SPARK-10216][SQL] Avoid creating empt...

2016-05-19 Thread jurriaan
Github user jurriaan commented on the pull request: https://github.com/apache/spark/pull/13181#issuecomment-220526725 Interesting, I'm currently working with a custom build where I've reverted the PR manually to work around the issue. Will add an testcase to the JIRA --- If your proj

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/13213#issuecomment-220526674 LGTM. Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15424][SQL] Revert SPARK-14807 Create a...

2016-05-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13207#issuecomment-220526732 @rxin Could you also add the JIRA number SPARK-15437 in this PR? With this fix, we are able to create `HiveContext` in SparkR. https://issues.apache.org/ji

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220526612 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220526609 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220526448 **[Test build #58939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58939/consoleFull)** for PR 13200 at commit [`e4a4bc1`](https://g

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220526335 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [DOC][MINOR] ml.feature Scala and Python API s...

2016-05-19 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13159#issuecomment-220526350 @rxin I thought I had but must have missed it by mistake. Thanks for picking to 2.0 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-220526389 Merged into branch-2.0 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220526078 **[Test build #58944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58944/consoleFull)** for PR 12979 at commit [`3c49567`](https://g

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220526124 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220526125 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14998][SQL]fix ArrayIndexOutOfBoundsExc...

2016-05-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12772#issuecomment-220525633 At here, `A\tB\tC\t\t` represents 5 fields and `A\tB\tC\t` represents 4 fields, right? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-14998][SQL]fix ArrayIndexOutOfBoundsExc...

2016-05-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12772#issuecomment-220525398 can you add a regression test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: explain of whole stage codegen

2016-05-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13204#issuecomment-220525308 I like 3. We can tell what operators are in a single WholeStageCodeGen operator and we can also know what are input operators of a WholeStageCodeGen. --- If your project

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220524558 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

  1   2   3   4   5   6   7   8   9   >