Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14195
Hi, @felixcheung
LGTM. I tested it locally, too.
By the way, could you add the original reporter's testcase, too?
```
SparkR::sql("")
```
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14112
**[Test build #62298 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62298/consoleFull)**
for PR 14112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14192
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14192
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62297/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14192
**[Test build #62297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62297/consoleFull)**
for PR 14192 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/14181
yea, the solution is also okay. Is it okay to fix in that way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14165
Merging in master/2.0. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14181
should we just enforce sampling ratio <= 1.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14190
Thank you, @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14190
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/14112#discussion_r70749752
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -566,26 +565,52 @@ object LocalLDAModel extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14195
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62296/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14195
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14195
**[Test build #62296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62296/consoleFull)**
for PR 14195 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14192
**[Test build #62297 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62297/consoleFull)**
for PR 14192 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14173
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14192
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14191
Hi, @wuxianxingkong .
Although I'm just a contributor like you, I left a few comments for you
because I like your PR.
I hope your PR will be merged soon.
---
If your project is set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14195
**[Test build #62296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62296/consoleFull)**
for PR 14195 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14191#discussion_r70748362
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1755,4 +1755,97 @@ class SQLQuerySuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14112
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62295/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14112
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14112
**[Test build #62295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62295/consoleFull)**
for PR 14112 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14191#discussion_r70748266
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1755,4 +1755,97 @@ class SQLQuerySuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14191#discussion_r70748215
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1755,4 +1755,97 @@ class SQLQuerySuite extends
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/14195
[SPARK-16538][SPARKR] fix R call with namespace operator SparkSession
functions
## What changes were proposed in this pull request?
Fix function routing to work with and without
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14191#discussion_r70748124
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1755,4 +1755,97 @@ class SQLQuerySuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14191#discussion_r70747940
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -338,7 +338,7 @@ querySpecification
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14112
**[Test build #62295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62295/consoleFull)**
for PR 14112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14194
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user lins05 opened a pull request:
https://github.com/apache/spark/pull/14194
[SPARK-16485][DOC][ML] Fixed several inline formatting in ml features doc
## What changes were proposed in this pull request?
Fixed several inline formatting in ml features doc.
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r70746279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -234,6 +234,7 @@ object FunctionRegistry {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14193
**[Test build #62294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62294/consoleFull)**
for PR 14193 at commit
GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/14193
[Minor][Build] Remove empty tags in parent pom.xml
## What changes were proposed in this pull request?
Remove empty tags in parent pom.xml
When I was working on another ticket
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14181
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62291/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14181
**[Test build #62291 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62291/consoleFull)**
for PR 14181 at commit
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14192#discussion_r70744731
--- Diff: R/pkg/R/window.R ---
@@ -17,23 +17,23 @@
# window.R - Utility functions for defining window in DataFrames
-#'
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14192
Thanks @sun-rui for the PR. LGTM. I had a minor comment inline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14112
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62293/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14112
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14112
**[Test build #62293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62293/consoleFull)**
for PR 14112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14192
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14192
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62292/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14192
**[Test build #62292 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62292/consoleFull)**
for PR 14192 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14112
**[Test build #62293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62293/consoleFull)**
for PR 14112 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14192
**[Test build #62292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62292/consoleFull)**
for PR 14192 at commit
GitHub user sun-rui opened a pull request:
https://github.com/apache/spark/pull/14192
[SPARK-16509][SPARKR] Rename window.partitionBy and window.orderBy to
windowPartitionBy and windowOrderBy.
## What changes were proposed in this pull request?
Rename window.partitionBy and
Github user jameszhouyi commented on the issue:
https://github.com/apache/spark/pull/14169
Hi,
Cool ! All of my cases relative to transformation script PASSED after
applying this PR . Could Spark guys please review this codes to merge this PR ?
Thanks a lots !
Best
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14191
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user wuxianxingkong opened a pull request:
https://github.com/apache/spark/pull/14191
[SPARK-16217][SQL] Support SELECT INTO statement
## What changes were proposed in this pull request?
This PR implements the *SELECT INTO* statement.
The *SELECT INTO*
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14185
I tried playing a little bit with what this API would look like, and I'm
starting to question my previous idea that exposing the ProcessBuilder is the
way to go here...
The above issue with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62290/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62290/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14181
**[Test build #62291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62291/consoleFull)**
for PR 14181 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14185
**[Test build #62289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62289/consoleFull)**
for PR 14185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62289/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14185
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14189
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14189
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62285/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14189
**[Test build #62285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62285/consoleFull)**
for PR 14189 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62288/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62284/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14173
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14139
**[Test build #62288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62288/consoleFull)**
for PR 14139 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14173
**[Test build #62284 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62284/consoleFull)**
for PR 14173 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62290/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62287/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14139
**[Test build #62287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62287/consoleFull)**
for PR 14139 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14177
I'd hit these errors fairly randomly if hive = T, even when stop is called
```
java.sql.SQLException: Failed to start database 'metastore_db' with class
loader
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13758
@cloud-fan , would it be possible to review this? If I have to prepare
additional benchmark results or etc., could you please let me know?
---
If your project is set up for it, you can reply to this
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14022
IMO `${sparkconf:spark.master}` is more clear to the unfamiliar reader, but
it also seems ok to go with `${spark.master}`. Thought there might also be an
issue if someone adds a spark conf that
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14190
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14190
**[Test build #62286 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62286/consoleFull)**
for PR 14190 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14190
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62286/
Test PASSed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14022
That's mostly how it works; I would like to avoid an explicit `sparkconf:`
prefix to avoid things like `sparkconf:spark.master`, but I can enforce that
only variables starting with `spark.` are
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14185
**[Test build #62289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62289/consoleFull)**
for PR 14185 at commit
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14022
To reduce the risk, how about changing the semantics to
```
* - spark/sparkconf/hiveconf: looks for the value in the spark config
* - system: looks for the value in the system
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14185
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14185#discussion_r70731128
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -418,14 +414,26 @@ public SparkAppHandle
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14185
This PR should really be referencing SPARK-14702, which is the older bug.
SPARK-16511 should be closed as a duplicate of it.
---
If your project is set up for it, you can reply to this email and
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14185#discussion_r70730228
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -418,14 +414,26 @@ public SparkAppHandle
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14022
> Wouldn't enabling it by default break backwards compatibility?
Yes, maybe. But having a flag to disable everything would also potentially
break features that rely on it... although you
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14190
Hi, @rxin .
Could you review this trivial PR exposing `sql()` in PySpark Shell for
consistency?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14185#discussion_r70729812
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -418,14 +414,26 @@ public SparkAppHandle
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14184
Hi, @liancheng .
Could you review this PR?
It was made by you at
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14185#discussion_r70729733
--- Diff:
core/src/test/scala/org/apache/spark/launcher/LauncherBackendSuite.scala ---
@@ -17,15 +17,16 @@
package org.apache.spark.launcher
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14185#discussion_r70729726
--- Diff:
core/src/test/scala/org/apache/spark/launcher/LauncherBackendSuite.scala ---
@@ -17,15 +17,16 @@
package org.apache.spark.launcher
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14022
Wouldn't enabling it by default break backwards compatibility? I agree that
would be better, but it seems likely that '${...}' may be used in existing
configs.
---
If your project is set up for it,
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14177
Does the hive metastore not shutdown properly even if we do
`sparkSession.stop()` in all the test files ? The reason I'm trying to avoid
having `enableHiveMetastore=F` in most test files is that
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14022
> how about a global flag for enabling config expansion
I think that would be more confusing. Why would someone disable expansion?
My only concern with enabling it for all options is
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14022#discussion_r70728894
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ---
@@ -99,13 +118,83 @@ private class FallbackConfigEntry[T] (
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14022
Instead of selectively enabling this for certain confs / config builders,
how about a global flag for enabling config expansion? I think that would be
less likely to be confusing. Also, perhaps a
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14079
Just some minor stuff, I'll let people more familiar with the scheduler
comment further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
1 - 100 of 681 matches
Mail list logo
