Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14116
Thank you so much, @gatorsmile . And, sorry for late response. Definitely,
I have many things to do. Now, it's my turn. Let's see how much I can handle
them. :)
---
If your project is set up
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62448/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62450/consoleFull)**
for PR 14235 at commit
[`a9a1b00`](https://github.com/apache/spark/commit/a
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14098
Please be careful with case sensitivity. It broke the release candidate
last time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62448 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62448/consoleFull)**
for PR 14235 at commit
[`38f52ce`](https://github.com/apache/spark/commit/
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14179
LGTM.
btw, for future references, you could either
```
# sep defaults to " "
paste("sparkPackages has no effect when using spark-submit or sparkR
shell,",
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71104553
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -390,8 +393,22 @@ private[spark] class Client(
// Upload Spark and t
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/14207
Does it mean that if users do not issue refresh when the table location is
changed, the schema will be wrong when the Spark is re-starting?
---
If your project is set up for it, you can reply to thi
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14243
Looks good, interesting approach - this won't run in CRAN since this is
part of Scala tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14244
cc @hvanhovell Is this test included in the other suite?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14245
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14245
**[Test build #62449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62449/consoleFull)**
for PR 14245 at commit
[`e797c30`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14245
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62449/
Test PASSed.
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14243#discussion_r71104052
--- Diff: R/pkg/inst/tests/testthat/jarTest.R ---
@@ -16,17 +16,17 @@
#
library(SparkR)
-sparkR.session()
+sc <- sparkR.session()
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14207
@viirya The problem it tries to resolve is from the comment of @rxin in
another PR: https://github.com/apache/spark/pull/14148#issuecomment-232273833
---
If your project is set up for it, you ca
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14116
Finished my first pass. The major concern is handling of
`INFORMATION_SCHEMA` is not clean to me. It looks hacky. Many holes are caused
by it. More test cases are needed.
---
If your project is
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
@wangmiao1981 I guess it's not ready yet. You may put a `[WIP]` tag in the
PR title when it's in WIP status and remove it when it is ready for review.
---
If your project is set up for it, you ca
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14098#discussion_r71103329
--- Diff: docs/sql-programming-guide.md ---
@@ -79,7 +79,7 @@ The entry point into all functionality in Spark is the
[`SparkSession`](api/java
T
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14150
@srowen I found no obvious compatibility issues after reading the release
notes. If this looks good, please let it get in, since
[SPARK-3181](https://issues.apache.org/jira/browse/SPARK-3181) dep
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71103250
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala
---
@@ -0,0 +1,312 @@
+/*
+ * Licensed to
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
@wangmiao1981 Is this ready for review now? Also, please update the PR
title to:
```
[SPARK-16380][SQL][EXAMPLE] Update SQL examples and programming guide for
Python language binding
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14098#discussion_r71103044
--- Diff: docs/sql-programming-guide.md ---
@@ -79,7 +79,7 @@ The entry point into all functionality in Spark is the
[`SparkSession`](api/java
T
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71103029
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/14207
I think it is not clear what the problem this PR tries to solve is. It just
says it proposes to save the inferred schema in external catalog.
---
If your project is set up for it, you can reply to t
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14245
LGTM. Can we reuse a existing jira number?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14245
**[Test build #62449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62449/consoleFull)**
for PR 14245 at commit
[`e797c30`](https://github.com/apache/spark/commit/e
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14169#discussion_r71102534
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1340,10 +1340,17 @@ class SparkSqlAstBuilder(conf: SQLConf) exten
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/14245
[MINOR][DOCS][EXAMPLES] Minor Scala example update
## What changes were proposed in this pull request?
This PR moves one and the last hard-coded Scala example snippet from the
SQL progra
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71102449
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71102423
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala
---
@@ -0,0 +1,312 @@
+/*
+ * Licensed to
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71102254
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14235
Can you also remove "[TEST]" from the title? TEST isn't a module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71102195
--- Diff: dev/.rat-excludes ---
@@ -99,3 +99,4 @@ spark-deps-.*
.*tsv
org.apache.spark.scheduler.ExternalClusterManager
.*\.sql
+org.apac
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71102174
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends SQLBuil
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71102142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala
---
@@ -0,0 +1,312 @@
+/*
+ * Licensed to
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71102107
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends SQLBuil
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Now, the remaining issue is using `getResource` to save the golden files. I
left a comment about that.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62448 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62448/consoleFull)**
for PR 14235 at commit
[`38f52ce`](https://github.com/apache/spark/commit/3
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14236
@rxin Sure, Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14116
```Scala
val catalog = spark.sessionState.catalog
catalog.setCurrentDatabase(SessionCatalog.INFORMATION_SCHEMA_DATABASE)
sql("CREATE TABLE my_tab (age INT, name
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101786
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14236
Since it is a small change I will just push a commit myself. Thanks for
noticing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14236#discussion_r71101740
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -977,7 +977,10 @@ object functions {
*
* @group normal_funcs
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101535
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101452
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71101399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -484,8 +521,11 @@ class SessionCatalog(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101198
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite ext
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101205
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends SQLBuil
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101173
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +88,58 @@ class LogicalPlanToSQLSuite extend
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14244
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62447/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14244
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14244
**[Test build #62447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62447/consoleFull)**
for PR 14244 at commit
[`871d358`](https://github.com/apache/spark/commit/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71101023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71100937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100950
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends SQLB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100943
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends SQLB
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100930
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extend
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14116
General question 1: Should we disallow users to do most DDLs against
`INFORMATION_SCHEMA`? For example, create functions, create tables, ...
---
If your project is set up for it, you can reply t
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100872
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends SQLB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100858
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +88,58 @@ class LogicalPlanToSQLSuite extends SQLBuil
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100846
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends SQLBuil
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71100512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user deanchen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13988#discussion_r71100480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityGenerator.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to
Github user deanchen commented on the issue:
https://github.com/apache/spark/pull/13912
@srowen @rxin Would love to see this get merged as this has been a pain
point for us. Not a fan of timezoneless dates as an engineer but the need to
passthrough or write timezoneless dates to csv's
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14132
I finished my third pass. Will review it again when your new version is
ready. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71100213
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -755,4 +755,243 @@ class LogicalPlanToSQLSuite extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14102
@yhuai Thank you for your review! I will try to address all your comments
first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import org.apache.spark.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62446/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62446/consoleFull)**
for PR 14235 at commit
[`e2a7ac4`](https://github.com/apache/spark/commit/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099344
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import org.apache.spark.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71099153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71099090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala
---
@@ -51,7 +53,8 @@ private[sql] class JSONOptions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098985
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14028
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14028
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62445/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14028
**[Test build #62445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62445/consoleFull)**
for PR 14028 at commit
[`6570a98`](https://github.com/apache/spark/commit/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098603
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098299
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098109
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14244
**[Test build #62447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62447/consoleFull)**
for PR 14244 at commit
[`871d358`](https://github.com/apache/spark/commit/8
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098026
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
EliminateUni
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13988#discussion_r71097989
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityGenerator.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14244
[SPARK-16598] [SQL] [TEST] Added a test case for verifying the table
identifier parsing
What changes were proposed in this pull request?
So far, the test cases of `TableIdentifierParser
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097771
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user ooq commented on the issue:
https://github.com/apache/spark/pull/14174
hey @sameeragarwal, the diff of the generated code can be found here (with
the left side for vectorized hashmap and right side for the new, row-based
one):
https://gist.github.com/ooq/d25d4de4c445752c6
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
Eliminate
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097256
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71097210
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import org.apache.spark.util.U
1 - 100 of 318 matches
Mail list logo
