Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r71232039
--- Diff: docs/configuration.md ---
@@ -1149,6 +1149,20 @@ Apart from these, the following properties are also
available, and may be useful
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r71232011
--- Diff: docs/configuration.md ---
@@ -1149,6 +1149,20 @@ Apart from these, the following properties are also
available, and may be useful
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14250
**[Test build #62492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62492/consoleFull)**
for PR 14250 at commit
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/14250
[SPARKR][DOCS] minor code sample update in R programming guide
## What changes were proposed in this pull request?
Fix code style from ad hoc review of RC4 doc
## How was
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62486 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62486/consoleFull)**
for PR 14235 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62486/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/12836
@NarineK Not as far as I know
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #62480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62480/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62480/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14132
**[Test build #62491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62491/consoleFull)**
for PR 14132 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14174
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14174
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62483/
Test PASSed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14174
**[Test build #62483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62483/consoleFull)**
for PR 14174 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62481/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14201
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9207
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62478/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14201
**[Test build #62481 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62481/consoleFull)**
for PR 14201 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #62478 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62478/consoleFull)**
for PR 9207 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14249
I am merging this PR to master and branch 2.0.
Thanks @adrian-wang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14176
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62482/
Test PASSed.
---
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14249#discussion_r71227856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,7 +1332,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14132
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62490/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14176
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71227811
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -988,9 +988,88 @@ class LogicalPlanToSQLSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14132
**[Test build #62490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62490/consoleFull)**
for PR 14132 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14132
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14176
**[Test build #62482 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62482/consoleFull)**
for PR 14176 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71227405
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -988,9 +988,88 @@ class LogicalPlanToSQLSuite
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r71227377
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14132
**[Test build #62490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62490/consoleFull)**
for PR 14132 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Now, `window/rollup/groupingset` testcases are added. For `GlobalLimit`, I
added that but I'm not sure about the testcase for it.
---
If your project is set up for it, you can reply to this
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r71226362
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62479/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14249
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14249
**[Test build #62479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62479/consoleFull)**
for PR 14249 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14022
**[Test build #62489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62489/consoleFull)**
for PR 14022 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14022
> I really think you should keep the "spark." requirement.
I reverted my last change since I forgot to change the test code anyway.
I'll spend some time to see if it's easy to
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14022
It looks good to me, except I really think you should keep the "spark."
requirement. It seems plausible that some reason a string like '${x}' can show
up in spark confs, perhaps things like
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14022
**[Test build #62488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62488/consoleFull)**
for PR 14022 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62487/consoleFull)**
for PR 14235 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62486/consoleFull)**
for PR 14235 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71216783
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -45,7 +46,12 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Hi, @rxin and @liancheng .
I will update this PR one more time. Please wait a moment.
I can use stable identifiers for `gen_attr`, too.
---
If your project is set up for it, you can
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14022
**[Test build #62485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62485/consoleFull)**
for PR 14022 at commit
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r71215223
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -97,6 +97,49 @@ package object config {
.toSequence
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13704#discussion_r71215193
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14225
**[Test build #62484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62484/consoleFull)**
for PR 14225 at commit
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14225#discussion_r71214583
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -146,10 +153,8 @@ void
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14054#discussion_r71213696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -158,25 +159,41 @@ object JdbcUtils extends Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62477/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14248
**[Test build #62477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62477/consoleFull)**
for PR 14248 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14243
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62474/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14243
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14243
**[Test build #62474 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62474/consoleFull)**
for PR 14243 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14028
Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14176
**[Test build #62482 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62482/consoleFull)**
for PR 14176 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14201
**[Test build #62481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62481/consoleFull)**
for PR 14201 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14174
**[Test build #62483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62483/consoleFull)**
for PR 14174 at commit
Github user andreweduffy commented on the issue:
https://github.com/apache/spark/pull/14201
Yuck, sorry, switching between projects my style settings were being
carried over, that should be it for indentation fixes
---
If your project is set up for it, you can reply to this email
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14065
sorry I haven't had time to review fully, taking a quick look I think it
would be nice to add at least a blurb to the docs (running on yarn) about how
to use this and pointer to scaladocs for
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #62478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62478/consoleFull)**
for PR 9207 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14249
**[Test build #62479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62479/consoleFull)**
for PR 14249 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #62480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62480/consoleFull)**
for PR 11105 at commit
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/14249
[SPARK-16515][SQL]set default record reader and writer for script
transformation
## What changes were proposed in this pull request?
In ScriptInputOutputSchema, we read default RecordReader and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12914
So I'll circle back up with everyone after 2.0 is shipped - I think we
should try and one the approaches (either this or @MLnick's solution) for 2.1+
because not having it in the docs just really
Github user NarineK commented on the issue:
https://github.com/apache/spark/pull/12836
@shivaram, @sun-rui , I was wondering if someone created a jira for the
issue described here:
https://github.com/apache/spark/pull/12836#issuecomment-225403054
---
If your project is set up
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13320
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62473/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13320
**[Test build #62473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62473/consoleFull)**
for PR 13320 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14248
**[Test build #62477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62477/consoleFull)**
for PR 14248 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71203247
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -755,4 +755,243 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71203038
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71202999
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71202822
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62476/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14248
**[Test build #62476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62476/consoleFull)**
for PR 14248 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14248
**[Test build #62476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62476/consoleFull)**
for PR 14248 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71202124
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71201300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71200265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
Github user markgrover commented on the issue:
https://github.com/apache/spark/pull/14223
Thanks @vanzin Yeah, I noticed that too. Will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14022#discussion_r71197993
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ---
@@ -99,13 +133,66 @@ private class FallbackConfigEntry[T] (
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14022#discussion_r71197308
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala ---
@@ -99,13 +133,66 @@ private class FallbackConfigEntry[T] (
key:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62475/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14248
**[Test build #62475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62475/consoleFull)**
for PR 14248 at commit
Github user mgummelt commented on the issue:
https://github.com/apache/spark/pull/13051
@andrewor14 This LGTM. Can you take a look and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13051#discussion_r71193952
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -119,21 +122,25 @@ private[mesos] object
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13051#discussion_r71193899
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -105,11 +105,14 @@ private[mesos] object
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14169#discussion_r71192358
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1306,7 +1306,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13670
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62472/
Test PASSed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14201
LGTM pending a few remaining style issues.
@andreweduffy our merge scripts squash PRs into a single commit, so history
stays clean regardless of how you update the PR.
---
If your project
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14201#discussion_r71189179
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -85,14 +91,67 @@ public void testSparkArgumentHandling() throws
201 - 300 of 513 matches
Mail list logo
