[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

2016-08-09 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74027475 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark issue #14561: [SPARK-16972][CORE] Move DriverEndpoint out of CoarseGra...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14561 **[Test build #63435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63435/consoleFull)** for PR 14561 at commit

[GitHub] spark issue #14561: [SPARK-16972][CORE] Move DriverEndpoint out of CoarseGra...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14561 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

2016-08-09 Thread GraceH
Github user GraceH commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74026903 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14557 **[Test build #63434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63434/consoleFull)** for PR 14557 at commit

[GitHub] spark issue #14561: [SPARK-16972][CORE] Move DriverEndpoint out of CoarseGra...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14561 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14561: SPARK-16972: Move DriverEndpoint out of CoarseGra...

2016-08-09 Thread lshmouse
GitHub user lshmouse opened a pull request: https://github.com/apache/spark/pull/14561 SPARK-16972: Move DriverEndpoint out of CoarseGrainedSchedulerBackend ## What changes were proposed in this pull request? Move DriverEndpoint out of CoarseGrainedSchedulerBackend and make the

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63426/ Test FAILed. ---

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14552 **[Test build #63426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63426/consoleFull)** for PR 14552 at commit

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63424/ Test PASSed. ---

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14557 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14557 **[Test build #63424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63424/consoleFull)** for PR 14557 at commit

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14558 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14558 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63423/ Test PASSed. ---

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14558 **[Test build #63423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63423/consoleFull)** for PR 14558 at commit

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14534#discussion_r74024410 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala --- @@ -39,15 +38,19 @@

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13988 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63425/ Test PASSed. ---

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13988 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13988 **[Test build #63425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63425/consoleFull)** for PR 13988 at commit

[GitHub] spark issue #14534: [SPARK-16941]Use concurrentHashMap instead of scala Map ...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14534 **[Test build #63433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63433/consoleFull)** for PR 14534 at commit

[GitHub] spark issue #14560: [SPARK-16971][SQL] Strip trailing zeros for decimal's st...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14560 **[Test build #63432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63432/consoleFull)** for PR 14560 at commit

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-09 Thread SaintBacchus
Github user SaintBacchus commented on a diff in the pull request: https://github.com/apache/spark/pull/14534#discussion_r74023262 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala --- @@ -39,15 +38,19 @@

[GitHub] spark issue #14560: [SPARK-16971][SQL] Strip trailing zeros for decimals whe...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14560 **[Test build #63431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63431/consoleFull)** for PR 14560 at commit

[GitHub] spark pull request #14560: [SPARK-16971][SQL] Strip trailing zeros for decim...

2016-08-09 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14560 [SPARK-16971][SQL] Strip trailing zeros for decimals when using show() API in Dataset ## What changes were proposed in this pull request? Currently, `Dataset.show()` prints all the

[GitHub] spark pull request #14555: [SPARK-16965][MLLIB][PYSPARK] Fix bound checking ...

2016-08-09 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14555#discussion_r74022257 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74022313 --- Diff: R/pkg/R/functions.R --- @@ -1273,12 +1267,14 @@ setMethod("round", #' bround #' #' Returns the value of the column `e` rounded

[GitHub] spark issue #13868: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13868 OK will merge soonish if there are no further comments. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13868: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-09 Thread avulanov
Github user avulanov commented on the issue: https://github.com/apache/spark/pull/13868 @srowen Sure. I've addressed @vanzin 's comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13868: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13868 **[Test build #63430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63430/consoleFull)** for PR 13868 at commit

[GitHub] spark pull request #14555: [SPARK-16965][MLLIB][PYSPARK] Fix bound checking ...

2016-08-09 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14555#discussion_r74021856 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (

[GitHub] spark pull request #14557: [SPARK-16709][CORE] Kill the running task if stag...

2016-08-09 Thread shenh062326
Github user shenh062326 commented on a diff in the pull request: https://github.com/apache/spark/pull/14557#discussion_r74021599 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1564,6 +1564,14 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request #14555: [SPARK-16965][MLLIB][PYSPARK] Fix bound checking ...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14555#discussion_r74021332 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74021040 --- Diff: R/pkg/R/functions.R --- @@ -1560,7 +1556,8 @@ setMethod("stddev_samp", #' #' Creates a new struct column that composes multiple input

[GitHub] spark pull request #14555: [SPARK-16965][MLLIB][PYSPARK] Fix bound checking ...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14555#discussion_r74021092 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74020775 --- Diff: R/pkg/R/functions.R --- @@ -2654,6 +2647,9 @@ setMethod("expr", signature(x = "character"), #' #' Formats the arguments in

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14534#discussion_r74020655 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala --- @@ -39,15 +38,19 @@

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14534#discussion_r74020589 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala --- @@ -39,15 +38,19 @@

[GitHub] spark issue #14525: [SPARK-16324] [SQL] regexp_extract should doc that it re...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14525 **[Test build #63429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63429/consoleFull)** for PR 14525 at commit

[GitHub] spark pull request #14528: [SPARK-16940][SQL] `checkAnswer` should raise `Te...

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14528: [SPARK-16940][SQL] `checkAnswer` should raise `TestFaile...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14528 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14534#discussion_r74020482 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala --- @@ -206,15 +206,16 @@

[GitHub] spark issue #14540: [SPARK-16950] [PySpark] fromOffsets parameter support in...

2016-08-09 Thread szczeles
Github user szczeles commented on the issue: https://github.com/apache/spark/pull/14540 @holdenk I've checked setSeed methods in MLlib and it seems py4j handles them well. If function gets simple arguments (strings, numerric, bool), py4j applies conversion between types (see

[GitHub] spark issue #14175: [SPARK-16522][MESOS] Spark application throws exception ...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14175 Merged to master, but it doesn't pick cleanly into 2.0, and the conflict in the tests wasn't entirely trivial. You can open another PR if it's important. --- If your project is set up for it, you

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14533: [SPARK-16606] [CORE] Misleading warning for Spark...

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14533: [SPARK-16606] [CORE] Misleading warning for SparkContext...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14533 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #14539: [SPARK-16947][SQL] Improve type coercion for inli...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14539#discussion_r74018815 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1192,8 +1192,8 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #13868: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13868 @avulanov can you have one more look at Marcelo's last small comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74017865 --- Diff: R/pkg/R/functions.R --- @@ -3033,6 +3033,9 @@ setMethod("when", signature(condition = "Column", value = "ANY"), #' Evaluates a list of

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 @ganeshchand could you address his last comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14557: [SPARK-16709][CORE] Kill the running task if stag...

2016-08-09 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14557#discussion_r74017373 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1564,6 +1564,14 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74017287 --- Diff: R/pkg/R/generics.R --- @@ -1022,6 +1059,7 @@ setGeneric("month", function(x) { standardGeneric("month") }) #' @export

[GitHub] spark issue #14556: [SPARK-16966][Core] Make App Name to the valid name inst...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14556 Just so it's not missed, I have a slightly different proposal in the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016459 --- Diff: R/pkg/R/generics.R --- @@ -1091,8 +1129,8 @@ setGeneric("reverse", function(x) { standardGeneric("reverse") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016421 --- Diff: R/pkg/R/generics.R --- @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { standardGeneric("ntile") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016338 --- Diff: R/pkg/R/mllib.R --- @@ -57,6 +57,9 @@ setClass("KMeansModel", representation(jobj = "jobj")) #' #' Saves the MLlib model to the input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016268 --- Diff: R/pkg/R/mllib.R --- @@ -69,6 +72,8 @@ NULL #' #' Makes predictions from a MLlib model. For more information, see the specific

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016085 --- Diff: R/pkg/R/mllib.R --- @@ -82,15 +87,16 @@ NULL #' Users can call \code{summary} to print a summary of the fitted model, \code{predict} to

[GitHub] spark issue #14180: Wheelhouse and VirtualEnv support

2016-08-09 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14180 Yes I am back from vacation! Can work on it now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74015938 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark issue #14556: [SPARK-16966][Core] Make App Name to the valid name inst...

2016-08-09 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/14556 Would you please add a unit test to verify the changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74015800 --- Diff: R/pkg/R/mllib.R --- @@ -346,8 +353,11 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" #' Get fitted

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74015718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14559#discussion_r74015696 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -447,7 +447,16 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #14539: [SPARK-16947][SQL] Improve type coercion for inli...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14539#discussion_r74015279 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -756,16 +756,20 @@ case class

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost [WIP]

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14547 **[Test build #63428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63428/consoleFull)** for PR 14547 at commit

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014809 --- Diff: R/pkg/R/mllib.R --- @@ -563,11 +574,12 @@ read.ml <- function(path) { #' \code{predict} to make predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014676 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +425,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014544 --- Diff: R/pkg/R/mllib.R --- @@ -563,11 +574,12 @@ read.ml <- function(path) { #' \code{predict} to make predictions on new data, and

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63427/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13146 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63420/ Test PASSed. ---

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13146 **[Test build #63420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63420/consoleFull)** for PR 13146 at commit

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013650 --- Diff: R/pkg/R/sparkR.R --- @@ -328,6 +328,7 @@ sparkRHive.init <- function(jsc = NULL) { #' @param sparkPackages Character vector of packages

[GitHub] spark pull request #14559: [SPARK-16968]Add additional options in jdbc when ...

2016-08-09 Thread GraceH
GitHub user GraceH opened a pull request: https://github.com/apache/spark/pull/14559 [SPARK-16968]Add additional options in jdbc when creating a new table ## What changes were proposed in this pull request? In the PR, we just allow the user to add additional options when

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013042 --- Diff: R/pkg/R/generics.R --- @@ -465,10 +477,14 @@ setGeneric("dapply", function(x, func, schema) { standardGeneric("dapply") }) #' @export

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14552 **[Test build #63426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63426/consoleFull)** for PR 14552 at commit

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013005 --- Diff: R/pkg/R/generics.R --- @@ -465,10 +477,14 @@ setGeneric("dapply", function(x, func, schema) { standardGeneric("dapply") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74012847 --- Diff: R/pkg/R/generics.R --- @@ -395,6 +396,9 @@ setGeneric("value", function(bcast) { standardGeneric("value") })

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14552 Seems OK to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14552 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63419/ Test PASSed. ---

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14546 **[Test build #63419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63419/consoleFull)** for PR 14546 at commit

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13146 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63417/ Test PASSed. ---

[GitHub] spark issue #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set pythonEx...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13146 **[Test build #63417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63417/consoleFull)** for PR 13146 at commit

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63418/ Test PASSed. ---

[GitHub] spark pull request #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurviv...

2016-08-09 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14519#discussion_r74011434 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala --- @@ -478,21 +482,23 @@ object AFTSurvivalRegressionModel

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14546 **[Test build #63418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63418/consoleFull)** for PR 14546 at commit

[GitHub] spark issue #14558: [SPARK-16508][SparkR] Fix warnings on undocumented/dupli...

2016-08-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14558 Ah, I'm actually about half way though this as well, but let's review yours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63422/ Test FAILed. ---

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14517 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14517: [SPARK-16931][PYTHON] PySpark APIS for bucketBy and sort...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14517 **[Test build #63422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63422/consoleFull)** for PR 14517 at commit

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13988 **[Test build #63425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63425/consoleFull)** for PR 13988 at commit

[GitHub] spark pull request #14384: [Spark-16443][SparkR] Alternating Least Squares (...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14384#discussion_r74009550 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +642,147 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"), function(object,

[GitHub] spark pull request #14555: [SPARK-16965][MLLIB][PYSPARK] Fix bound checking ...

2016-08-09 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14555#discussion_r74009150 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14557 **[Test build #63424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63424/consoleFull)** for PR 14557 at commit

<    2   3   4   5   6   7   8   >