[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74832879 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -930,10 +942,8 @@ class BinaryLogisticRegressionSummary pr

[GitHub] spark issue #14542: [SPARK-16930][yarn] Fix a couple of races in cluster app...

2016-08-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14542 Ping, I'll push this tomorrow unless someone complains. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13796 **[Test build #63799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63799/consoleFull)** for PR 13796 at commit [`0d72c6f`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74832288 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74832305 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74832263 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -944,13 +955,140 @@ class BinaryLogisticRegressionSummary

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/14580 This problem can be viewed in SQL language like this: ``` val a = Seq((1),(2)).toDF("a").createOrReplaceTempView("A") val b = Seq((2),(3)).toDF("a").createOrReplaceTempView("B") sca

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74831972 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74831888 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #14151: [SPARK-16496][SQL] Add wholetext as option for re...

2016-08-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14151#discussion_r74831276 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -533,6 +533,12 @@ object SQLConf { .timeConf(TimeUnit.MILLISECON

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74829219 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark issue #14649: [SPARK-17059][SQL] Allow FileFormat to specify partition...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14649 **[Test build #3223 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3223/consoleFull)** for PR 14649 at commit [`1a00d1f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13796 **[Test build #63798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63798/consoleFull)** for PR 13796 at commit [`2f11bd7`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63794/ Test FAILed. ---

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63794/consoleFull)** for PR 14607 at commit [`f30e387`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63791/ Test PASSed. ---

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63793/ Test FAILed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63791/consoleFull)** for PR 14568 at commit [`5bdb3ab`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63793/consoleFull)** for PR 14607 at commit [`e2ca4e5`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14182 This looks fine to me - @felixcheung feel free to merge this when you think its good to go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14650 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14182 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14650 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63790/ Test PASSed. ---

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14182 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63795/ Test PASSed. ---

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14182 **[Test build #63795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63795/consoleFull)** for PR 14182 at commit [`18a9e9e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14650 **[Test build #63790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63790/consoleFull)** for PR 14650 at commit [`db42e31`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame fr...

2016-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14557: [SPARK-16709][CORE] Kill the running task if stage faile...

2016-08-15 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/14557 There are multiple issues with this PR. Some are at a more stylistic level, but some include deeper issues -- e.g. see SPARK-17064. Most fundamentally, this PR is the wrong solution at least i

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14469 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14469 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63796/ Test PASSed. ---

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14469 **[Test build #63796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63796/consoleFull)** for PR 14469 at commit [`b37e6a8`](https://github.com/apache/spark/commit/

[GitHub] spark issue #12436: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2016-08-15 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/12436 See https://issues.apache.org/jira/browse/SPARK-17064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14580 @gatorsmile I am trying to understand you comment. Why shouldn't we use `full outer` in combination with `using`? I am under the impression that using is just a bit of syntactic sugar. For instan

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14580 **[Test build #63797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63797/consoleFull)** for PR 14580 at commit [`af189d6`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #14371: [SPARK-16736] Core+ SQL superfluous fs calls

2016-08-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14371#discussion_r74814338 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLog.scala --- @@ -231,13 +232,17 @@ private[streaming] class FileBasedW

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14469 **[Test build #63796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63796/consoleFull)** for PR 14469 at commit [`b37e6a8`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14469 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-15 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14469 LGTM, so I'll merge this to master. Thanks @davies! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/ca...

2016-08-15 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14579#discussion_r74813935 --- Diff: python/pyspark/rdd.py --- @@ -188,6 +188,12 @@ def __init__(self, jrdd, ctx, jrdd_deserializer=AutoBatchedSerializer(PickleSeri self

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14182 **[Test build #63795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63795/consoleFull)** for PR 14182 at commit [`18a9e9e`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-15 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/11157 woot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] spark issue #14634: [SPARK-17051][SQL] we should use hadoopConf in InsertInt...

2016-08-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14634 Based on my understanding, after this PR, we will respect the conf values of `hive.exec.dynamic.partition`, `hive.exec.dynamic.partition.mode` and `hive.exec.compress.output` that are specified i

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63794/consoleFull)** for PR 14607 at commit [`f30e387`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12004 **[Test build #63789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63789/consoleFull)** for PR 12004 at commit [`2001dd0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63789/ Test FAILed. ---

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-08-15 Thread tnachen
Github user tnachen commented on the issue: https://github.com/apache/spark/pull/14644 @srowen Mesos also supports node labels as well (which is how constraints is implemented in Spark framework). However GPUs are implemented as a resource (as we want to account for # of GPUs instead

[GitHub] spark pull request #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/ca...

2016-08-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/14579#discussion_r74811837 --- Diff: python/pyspark/rdd.py --- @@ -188,6 +188,12 @@ def __init__(self, jrdd, ctx, jrdd_deserializer=AutoBatchedSerializer(PickleSeri self._i

[GitHub] spark issue #14607: [SPARK-17063] [SQL] Improve performance of MSCK REPAIR T...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14607 **[Test build #63793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63793/consoleFull)** for PR 14607 at commit [`e2ca4e5`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/ca...

2016-08-15 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/14579#discussion_r74811199 --- Diff: python/pyspark/rdd.py --- @@ -188,6 +188,12 @@ def __init__(self, jrdd, ctx, jrdd_deserializer=AutoBatchedSerializer(PickleSeri self

[GitHub] spark pull request #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optim...

2016-08-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14580#discussion_r74811155 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1334,12 +1334,19 @@ object EliminateOuterJoin ex

[GitHub] spark issue #11956: [SPARK-14098][SQL] Generate Java code that gets a float/...

2016-08-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/11956 @davies, thank you for your comment. I hope that you will have bandwidth soon since Spark 2.0 was released. [this PR](https://github.com/apache/spark/pull/13899/files) does the same thing. In par

[GitHub] spark pull request #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optim...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14580#discussion_r74808006 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1334,12 +1334,19 @@ object EliminateOuterJoin exten

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14644 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63792/ Test FAILed. ---

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14644 **[Test build #63792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63792/consoleFull)** for PR 14644 at commit [`2f658b4`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14644 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14644: [MESOS] Enable GPU support with Mesos

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14644 **[Test build #63792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63792/consoleFull)** for PR 14644 at commit [`2f658b4`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #14468: [SPARK-16671][core][sql] Consolidate code to do v...

2016-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14568 @tedyu the scala code is shaping up nicely. I do have a question regarding usage. How will this be used? The thing is that the `monotonically_increasing_id` returns an id based on the num

[GitHub] spark pull request #14151: [SPARK-16496][SQL] Add wholetext as option for re...

2016-08-15 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/14151#discussion_r74805700 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala --- @@ -39,6 +39,11 @@ class TextSuite extends QueryTest w

[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...

2016-08-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14468 Given the overwhelming amount of feedback, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74805503 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -945,13 +955,139 @@ class BinaryLogisticRegressionSummary

[GitHub] spark pull request #14522: [Spark-16508][SparkR] Split docs for arrange and ...

2016-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14151: [SPARK-16496][SQL] Add wholetext as option for re...

2016-08-15 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/14151#discussion_r74804217 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -533,6 +533,12 @@ object SQLConf { .timeConf(TimeUnit.MILLISE

[GitHub] spark issue #14522: [Spark-16508][SparkR] Split docs for arrange and orderBy...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14522 Yeah LGTM. Merging this to master, branch-2.0 -- Thanks @junyangq --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics that cr...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14626 I had one minor question about partitionBy -- otherwise change LGTM. Thanks @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics ...

2016-08-15 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14626#discussion_r74803446 --- Diff: R/pkg/R/generics.R --- @@ -152,9 +146,9 @@ setGeneric("getNumPartitions", function(x) { standardGeneric("getNumPartitions") # @export se

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63791/consoleFull)** for PR 14568 at commit [`5bdb3ab`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74801826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +91,12 @@ case class Monoton

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-08-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13758 Thank you for your comment. We are on the same page to address the problem. In this case, you are right. This is because we finally would like to write an primitive int array `mapelements_valu

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63787/ Test PASSed. ---

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12004 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12004 **[Test build #63787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63787/consoleFull)** for PR 12004 at commit [`2feade0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14650 **[Test build #63790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63790/consoleFull)** for PR 14650 at commit [`db42e31`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #11956: [SPARK-14098][SQL] Generate Java code that gets a float/...

2016-08-15 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/11956 @kiszk I'm sorry that I do not have the bandwidth to review this, https://github.com/apache/spark/pull/13899/files sounds like an easier approach (have not looked into the details), how do you think

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-15 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74798929 --- Diff: R/pkg/R/generics.R --- @@ -1279,6 +1279,11 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #' @export

[GitHub] spark issue #14634: [SPARK-17051][SQL] we should use hadoopConf in InsertInt...

2016-08-15 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14634 Sorry. What's the necessity to make this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #14648: [SPARK-16995][SQL] TreeNodeException when flat mapping R...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14648 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63786/ Test PASSed. ---

[GitHub] spark issue #14648: [SPARK-16995][SQL] TreeNodeException when flat mapping R...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14648 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-08-15 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14650 @mgummelt pls review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-08-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r74798477 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -25,55 +25,57 @@ import org.apache.spark.sql.

[GitHub] spark issue #14648: [SPARK-16995][SQL] TreeNodeException when flat mapping R...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14648 **[Test build #63786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63786/consoleFull)** for PR 14648 at commit [`2e0d7d6`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14447 Yep, this looks good @felixcheung -- Feel free to merge once you think its good to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request #14650: [SPARK-17062][MESOS] add conf option to mesos dis...

2016-08-15 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/14650 [SPARK-17062][MESOS] add conf option to mesos dispatcher ## What changes were proposed in this pull request? Adds --conf option to set spark configuration properties in mesos dispacther. Pro

[GitHub] spark issue #14639: [SPARK-18054][SPARKR] SparkR can not run in yarn-cluster...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14639 @zjffdu Lets discuss why this was introduced more in the JIRA. Regd. the code change, on my Mac `$HOME` is set without any custom changes on my side. Any ideas when this will not be the case ? -

[GitHub] spark issue #14392: [SPARK-16446] [SparkR] [ML] Gaussian Mixture Model wrapp...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14392 `spark.gaussianMixture` sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark issue #14628: [SPARK-17050][ML][MLLib] Improve kmean rdd.aggregate to ...

2016-08-15 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14628 Awesome thanks for taking the time to do this. A few follow up questions: 1) So this is happening with the default tree depth (2) did you try it with other depths? 2) Have you had a chance to

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14641 Thanks @yanboliang - Do you know how the existing tests were passing ? Should we add a new test case for this ? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63785/ Test PASSed. ---

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14580 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14580 **[Test build #63785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63785/consoleFull)** for PR 14580 at commit [`7db83bc`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14640: [SPARK-17055] [MLLIB] add labelKFold to CrossValidator

2016-08-15 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14640 Thanks for making this issue and PR :) The first thing before people are likely to have the bandwith to review this is we are switching all new ML development to Spark ML from MLlib so it might be g

[GitHub] spark issue #14624: Fix PySpark DataFrameWriter JDBC method docstring becaus...

2016-08-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14624 @mvervuurt Could you please double check this one? I am pretty sure I checked out this PR and then tested this correctly. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/spark/pull/14568 @rxin Can you take a look at the python API one more time ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12004 **[Test build #63789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63789/consoleFull)** for PR 12004 at commit [`2001dd0`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-08-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13758 The new `UnsafeArrayData` should be as fast as primitive array right? The problem you pointed out is valid, but can we improve the encoder framework to create unsafe array directly for primitive a

[GitHub] spark issue #14646: [SPARK-17058] [build] Add maven snapshots-and-staging pr...

2016-08-15 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/14646 I'd be against making it default for a few reasons 1. You don't want to accidentally pick up some staging artifact or upstream snapshot. 2. I don't know how SBT/Ivy handles remote

<    1   2   3   4   5   6   >