[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77355534 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -231,9 +231,9 @@ class MultivariateOnlineSummarize

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77354917 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -405,5 +405,9 @@ private[ml] trait HasAggregationDepth extends

[GitHub] spark issue #14827: [SPARK-17259] [build] [WiP] Hadoop 2.7 profile to depend...

2016-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14827 OK that makes sense as a reason to have 2.7 vs <2.6. We already have a profile for 2.7 anyway. I don't know if it will help to make it active by default here given how profile activation works.

[GitHub] spark issue #14913: [SPARK-17358][SQL] Cached table(parquet/orc) should be s...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14913 instead of implementing `equals` and `hashCode`, can we just make `sparkSession` a curry parameter? e.g. `case class HadoopFsRelation(location: FileCatalog, ...)(sparkSession: SparkSession)`. If t

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14712 LGTM, @hvanhovell can you take another look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77352750 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77352634 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77352565 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.

[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77352543 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -231,9 +231,9 @@ class MultivariateOnlineSummarizer exte

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14923 **[Test build #64857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64857/consoleFull)** for PR 14923 at commit [`be59825`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77352136 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -233,7 +233,7 @@ class MultivariateOnlineSummarize

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify parser join processing.

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64856/consoleFull)** for PR 14924 at commit [`7583070`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify parser join processing.

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64853/ Test PASSed. ---

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify parser join processing.

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14867 **[Test build #64853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64853/consoleFull)** for PR 14867 at commit [`b09d506`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/14924 @srowen yes in stringExpressions the trim is on with UTF8String. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64850/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64850/ Test PASSed. ---

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64851/ Test PASSed. ---

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread shiv4nsh
Github user shiv4nsh commented on the issue: https://github.com/apache/spark/pull/14873 @srowen : Can we merge this now ? or does it require any additional changes ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14873 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14873 **[Test build #64851 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64851/consoleFull)** for PR 14873 at commit [`2141b1b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14937: [WIP] [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KM...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14937 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64854/ Test FAILed. ---

[GitHub] spark issue #14937: [WIP] [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KM...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14937 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14937: [WIP] [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KM...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14937 **[Test build #64854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64854/consoleFull)** for PR 14937 at commit [`ce36c51`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14887: [SPARK-17321][YARN] YARN shuffle service should u...

2016-09-02 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14887#discussion_r77345539 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java --- @@ -25,6 +25,8 @@ import com.google.common.coll

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #3244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3244/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit

[GitHub] spark issue #14827: [SPARK-17259] [build] [WiP] Hadoop 2.7 profile to depend...

2016-09-02 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/14827 Sean, the reason for a 2.7 profile is more significant with SPARK-7481 and cloud support, as it can explicitly pull in hadoop-azure (2.7+ only) and hadoop-aws (2.6+ only). --- If your proje

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14933 **[Test build #64855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64855/consoleFull)** for PR 14933 at commit [`de488ce`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-02 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/14933 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark pull request #10806: [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize K...

2016-09-02 Thread yanboliang
Github user yanboliang closed the pull request at: https://github.com/apache/spark/pull/10806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #10806: [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KMeans i...

2016-09-02 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/10806 Close this one and move update version to #14937, let's discuss there. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14937: [WIP] [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KM...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14937 **[Test build #64854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64854/consoleFull)** for PR 14937 at commit [`ce36c51`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #14937: [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize K...

2016-09-02 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/14937 [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KMeans implementation. ## What changes were proposed in this pull request? Use BLAS Level 3 matrix-matrix multiplications to compute pairwise d

[GitHub] spark issue #14936: [SPARK-7877][MESOS] Allow configuration of framework tim...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14936 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14936: [SPARK-7877][MESOS] Allow configuration of framework tim...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14936 **[Test build #64852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64852/consoleFull)** for PR 14936 at commit [`c15f207`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14936: [SPARK-7877][MESOS] Allow configuration of framework tim...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14936 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64852/ Test PASSed. ---

[GitHub] spark pull request #14573: [SPARK-16984][SQL] don't try whole dataset immedi...

2016-09-02 Thread robert3005
Github user robert3005 commented on a diff in the pull request: https://github.com/apache/spark/pull/14573#discussion_r77336634 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -116,6 +116,14 @@ object SQLConf { .longConf .creat

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify join parser join processing.

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14867 **[Test build #64853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64853/consoleFull)** for PR 14867 at commit [`b09d506`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14936: [SPARK-7877][MESOS] Allow configuration of framework tim...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14936 **[Test build #64852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64852/consoleFull)** for PR 14936 at commit [`c15f207`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #14936: [SPARK-7877][MESOS] Allow configuration of framew...

2016-09-02 Thread philipphoffmann
GitHub user philipphoffmann opened a pull request: https://github.com/apache/spark/pull/14936 [SPARK-7877][MESOS] Allow configuration of framework timeout ## What changes were proposed in this pull request? This commit introduces a setting for configuring the Mesos framework

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify join parser join processing.

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14867 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64849/ Test FAILed. ---

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify join parser join processing.

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14867 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify join parser join processing.

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14867 **[Test build #64849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64849/consoleFull)** for PR 14867 at commit [`e20afbd`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14873 I am not really against this. I am just not a big fan of cosmetic code changes. The whole byte code argument would have made sense if this would be touching performance critical code. I'

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14873 **[Test build #64851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64851/consoleFull)** for PR 14873 at commit [`2141b1b`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14873 restest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64850/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/14712 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread shiv4nsh
Github user shiv4nsh commented on the issue: https://github.com/apache/spark/pull/14873 @srowen : Can you please help me out here ? Why this test case fails, it did not fail on my local and my last changes include only removing space and comments ! Please help me out here ! --- If y

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #3244 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3244/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64848/ Test FAILed. ---

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64848/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify join parser join processing.

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14867 **[Test build #64849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64849/consoleFull)** for PR 14867 at commit [`e20afbd`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14873 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14873 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64846/ Test FAILed. ---

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14873 **[Test build #64846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64846/consoleFull)** for PR 14873 at commit [`2141b1b`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321926 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -374,15 +374,17 @@ setQuantifier ; relat

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321974 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77321274 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends P

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77320991 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -364,6 +364,15 @@ class PlanParserSuite extends

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14935 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14935 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64847/ Test PASSed. ---

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14935 **[Test build #64847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64847/consoleFull)** for PR 14935 at commit [`7a70b51`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14858: [SPARK-17219][ML] Add NaN value handling in Bucke...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14858#discussion_r77320714 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -114,10 +115,10 @@ final class QuantileDiscretizer @Since("1.6.0")

[GitHub] spark pull request #14867: [SPARK-17296][SQL] Simplify join parser join proc...

2016-09-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14867#discussion_r77320471 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -374,15 +374,17 @@ setQuantifier ; rela

[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77319212 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -233,7 +233,7 @@ class MultivariateOnlineSummarizer exte

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77318875 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77318817 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77318912 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -405,5 +405,9 @@ private[ml] trait HasAggregationDepth extends Param

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77318694 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -610,6 +637,14 @@ object HiveExternalCatalog { val DATASOUR

[GitHub] spark pull request #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14908: [WEBUI][SPARK-17352]Executor computing time can b...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14908 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64848/consoleFull)** for PR 14712 at commit [`b946df0`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14908: [WEBUI][SPARK-17352]Executor computing time can be negat...

2016-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14908 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14891 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #14719: [SPARK-17154][SQL] Wrong result can be returned or Analy...

2016-09-02 Thread sarutak
Github user sarutak commented on the issue: https://github.com/apache/spark/pull/14719 I've attached a document for solution proposal. https://issues.apache.org/jira/browse/SPARK-17154 CC: @marmbrus --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark issue #14913: [SPARK-17358][SQL] Cached table(parquet/orc) should be s...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14913 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64844/ Test PASSed. ---

[GitHub] spark issue #14913: [SPARK-17358][SQL] Cached table(parquet/orc) should be s...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14913: [SPARK-17358][SQL] Cached table(parquet/orc) should be s...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14913 **[Test build #64844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64844/consoleFull)** for PR 14913 at commit [`3e093bf`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14935 **[Test build #64847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64847/consoleFull)** for PR 14935 at commit [`7a70b51`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #14935: [SPARK-17376][SPARKR] Spark version should be ava...

2016-09-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/14935 [SPARK-17376][SPARKR] Spark version should be available in R ## What changes were proposed in this pull request? Add sparkR.version() API. ``` > sparkR.version() [1] "2

[GitHub] spark issue #14613: [SPARK-16883][SparkR]:SQL decimal type is not properly c...

2016-09-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14613 Merged to 2.0.1 and 2.1.0. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14924 The implementation in `stringExpressions.scala` generates code that calls `trim()`, so just double-checking, that's calling UTF8String not String right? Then yeah LGTM --- If your project is set up

[GitHub] spark pull request #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms shou...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms should supp...

2016-09-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13584 Merged. I could't change the assignee in the JIRA, somehow - @shivaram could you please do that? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14731: [SPARK-17159] [streaming]: optimise check for new...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14731#discussion_r77314137 --- Diff: docs/streaming-programming-guide.md --- @@ -644,13 +644,44 @@ methods for creating DStreams from files as input sources.

[GitHub] spark pull request #14731: [SPARK-17159] [streaming]: optimise check for new...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14731#discussion_r77313878 --- Diff: docs/streaming-programming-guide.md --- @@ -644,13 +644,44 @@ methods for creating DStreams from files as input sources.

[GitHub] spark pull request #14731: [SPARK-17159] [streaming]: optimise check for new...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14731#discussion_r77313771 --- Diff: docs/streaming-programming-guide.md --- @@ -644,13 +644,44 @@ methods for creating DStreams from files as input sources.

[GitHub] spark pull request #14613: [SPARK-16883][SparkR]:SQL decimal type is not pro...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77313250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77313069 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +384,34 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64839/ Test PASSed. ---

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14433 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14433 **[Test build #64839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64839/consoleFull)** for PR 14433 at commit [`ef8887d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14929: [SPARK-17374][SQL] Better error messages when parsing JS...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64841/ Test FAILed. ---

[GitHub] spark issue #14929: [SPARK-17374][SQL] Better error messages when parsing JS...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14929: [SPARK-17374][SQL] Better error messages when parsing JS...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14929 **[Test build #64841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64841/consoleFull)** for PR 14929 at commit [`82f9927`](https://github.com/apache/spark/commit/

<    1   2   3   4   5   >