Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
BTW, I finished the review. LGTM except the above comments. Let @cloud-fan
double check it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15263
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r82337939
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15263
**[Test build #66489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66489/consoleFull)**
for PR 15263 at commit
[`b339492`](https://github.com/apache/spark/commit/b
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14538
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15292#discussion_r82339188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -17,47 +17,130 @@
package org.apac
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15381#discussion_r82339491
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java
---
@@ -90,8 +95,21 @@ public void run() {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14538
**[Test build #66490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66490/consoleFull)**
for PR 14538 at commit
[`bd5b379`](https://github.com/apache/spark/commit/b
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15382
Good point. The docs all say it should be working dir, so I was following
the apparent intent along the way here. I don't know if one is more surprising
than the other.
---
If your project is set
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15379
Thanks - the argument renaming issue is largely orthogonal and I don't
think we can break it now. I'm going to merge this in master/2.0.
---
If your project is set up for it, you can reply to this em
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66491/consoleFull)**
for PR 15292 at commit
[`a749409`](https://github.com/apache/spark/commit/a
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r82340840
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15343
Hm, I think I'm going to close this for now because it doesn't actually fix
the issue I thought it would, and I honestly could not trace how the cached
Dataset logical plan becomes RDD info in the UI
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/15343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14957
This would be good to include in Spark 2.1...
cc @davies and @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15370
Yeah, the name should be zero-padded to 10 digits to make the lexical
ordering match the intended ordering. It may not matter, but seems a bit safer.
OK right the code path doesn't just list
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r82342444
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r82342839
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r82343881
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user seyfe commented on the issue:
https://github.com/apache/spark/pull/15371
Hi @srowen,
This PR doesn't introduce any extra data copy operations. It moves the data
copy code from `JsonProtocol:accumValueToJson` method to
`BlockStatusesAccumulator:value` method so it
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r82348471
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryStatus.scala
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Softwa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66492/consoleFull)**
for PR 15307 at commit
[`1655c96`](https://github.com/apache/spark/commit/1
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/15307
@marmbrus
- Refactored APIs (see description)
- Added source-specific tests
- Fixed LocalTableScanExec.executeCollect/executeTake not providing
SQLMetrics
- Reverted *Status classes to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14638
**[Test build #66493 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66493/consoleFull)**
for PR 14638 at commit
[`ec85638`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15355
**[Test build #66487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66487/consoleFull)**
for PR 15355 at commit
[`a2ba414`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66487/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15355
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15388
**[Test build #66488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66488/consoleFull)**
for PR 15388 at commit
[`0a48d86`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15388
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15388
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66488/
Test PASSed.
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r82352445
--- Diff: R/pkg/R/SQLContext.R ---
@@ -341,11 +342,13 @@ setMethod("toDF", signature(x = "RDD"),
#' @name read.json
#' @method read.json default
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15263
**[Test build #66489 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66489/consoleFull)**
for PR 15263 at commit
[`b339492`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66489/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15263
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r82355751
--- Diff: R/pkg/R/SQLContext.R ---
@@ -341,11 +342,13 @@ setMethod("toDF", signature(x = "RDD"),
#' @name read.json
#' @method read.json default
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14538
**[Test build #66490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66490/consoleFull)**
for PR 14538 at commit
[`bd5b379`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66490/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66491/consoleFull)**
for PR 15292 at commit
[`a749409`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66491/
Test PASSed.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15371
I see the new copy (of course or else this wouldn't help) but where is a
copy removed? I'm probably overlooking it. A `toList` call was moved, which we
discussed above briefly. I still think it's all
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r82362700
--- Diff: R/pkg/R/SQLContext.R ---
@@ -341,11 +342,13 @@ setMethod("toDF", signature(x = "RDD"),
#' @name read.json
#' @method read.json default
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14638
**[Test build #66493 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66493/consoleFull)**
for PR 14638 at commit
[`ec85638`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14638
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66493/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66492/consoleFull)**
for PR 15307 at commit
[`1655c96`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66492/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66494 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66494/consoleFull)**
for PR 15307 at commit
[`3984d54`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66494/consoleFull)**
for PR 15307 at commit
[`3984d54`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66494/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15355
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66495/consoleFull)**
for PR 15307 at commit
[`7efea10`](https://github.com/apache/spark/commit/7
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15369
merged to master. Seems like a clean improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r82367394
--- Diff: R/pkg/R/SQLContext.R ---
@@ -341,11 +342,13 @@ setMethod("toDF", signature(x = "RDD"),
#' @name read.json
#' @method read.json default
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66495/consoleFull)**
for PR 15307 at commit
[`7efea10`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66495/
Test FAILed.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14538
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15366#discussion_r82367835
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -462,7 +462,10 @@ private[ui] class JobDataSource(
}
case
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66496 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66496/consoleFull)**
for PR 15307 at commit
[`5e0aa57`](https://github.com/apache/spark/commit/5
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14538
Thank you @srowen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user kxepal commented on the issue:
https://github.com/apache/spark/pull/15361
@HyukjinKwon
It works great! Thank you! My mistake was by applying changes for the same
`wrapperFor` method, while for 2.0.0 sources state it have to be placed in
`wrap` method instead with a b
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15346
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15387#discussion_r82370539
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala
---
@@ -223,7 +223,7 @@ private[spark] class Dir
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15346
**[Test build #66497 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66497/consoleFull)**
for PR 15346 at commit
[`605aeb6`](https://github.com/apache/spark/commit/6
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r82371339
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -378,6 +378,24 @@ class FileStreamSourceSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14087
**[Test build #66498 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66498/consoleFull)**
for PR 14087 at commit
[`867394d`](https://github.com/apache/spark/commit/8
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/15387
I'm not going to say anything is impossible, which is the point of the
assert. If it does somehow happen, it will be at start, so should be
obvious.
The whole poll 0 / pause thing i
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82372368
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala ---
@@ -76,15 +79,40 @@ private[spark] class RollingFileAppender(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82373810
--- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala
---
@@ -292,8 +332,21 @@ class FileAppenderSuite extends SparkFunSuite with
BeforeA
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82373245
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala ---
@@ -142,6 +170,9 @@ private[spark] object RollingFileAppender {
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82373348
--- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala
---
@@ -72,6 +74,24 @@ class FileAppenderSuite extends SparkFunSuite with
BeforeAnd
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82378093
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1455,7 +1456,11 @@ private[spark] object Utils extends Logging {
val effectiveEn
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82373610
--- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala
---
@@ -89,6 +109,25 @@ class FileAppenderSuite extends SparkFunSuite with
BeforeAn
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82373640
--- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala
---
@@ -89,6 +109,25 @@ class FileAppenderSuite extends SparkFunSuite with
BeforeAn
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r82372648
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala ---
@@ -76,15 +79,40 @@ private[spark] class RollingFileAppender(
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/14263
Closing following [exchange on
JIRA](https://issues.apache.org/jira/browse/SPARK-16626?focusedCommentId=15543929&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15543929
Github user zero323 closed the pull request at:
https://github.com/apache/spark/pull/14263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user zero323 closed the pull request at:
https://github.com/apache/spark/pull/13324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12578
**[Test build #66499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66499/consoleFull)**
for PR 12578 at commit
[`97af903`](https://github.com/apache/spark/commit/9
Github user zero323 closed the pull request at:
https://github.com/apache/spark/pull/14248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15307
**[Test build #66496 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66496/consoleFull)**
for PR 15307 at commit
[`5e0aa57`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66496/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/15370
I don't consider this complex, its simply one number formatter and you say
get. Padding to 10 digits isn't necessary in 99% of the cases, so you are
just using longer file strings and more digit
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15370#discussion_r82386685
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -71,6 +72,11 @@ private[spark] object CallSite {
private[spark] object Utils ext
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15370#discussion_r82387014
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -96,16 +96,15 @@ private[spark] class ReliableCheckpointRDD[T: ClassT
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14087
**[Test build #66498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66498/consoleFull)**
for PR 14087 at commit
[`867394d`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66498/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14087
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/15370
If you still believe this to complex can you please clarify why so we can
discuss. This is basically 5 lines of code (yes lines of code aren't good
complexity indicator but..), 3 of them to create
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15346
**[Test build #66497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66497/consoleFull)**
for PR 15346 at commit
[`605aeb6`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15346
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66497/
Test PASSed.
---
1 - 100 of 666 matches
Mail list logo
