[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-14 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15659 @JoshRosen - yes since we ship the jars with them we want people to be able to install the correct package for the hadoop distribution they are running with/against. --- If your project is set up

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15881 Thanks for taking this on :) I did a quick skim and these all look pretty reasonable (in some cases we are directly calling an old mllib algorithm which would do the validation at training time and

[GitHub] spark pull request #15740: [SPARK-18232] [Mesos] Support CNI

2016-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11122 **[Test build #3426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3426/consoleFull)** for PR 11122 at commit

[GitHub] spark issue #15887: [SPARK-18442][SQL] Fix nullability of WrapOption.

2016-11-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15887 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15740: [SPARK-18232] [Mesos] Support CNI

2016-11-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15740 Merging in master! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14612: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14612#discussion_r87958491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala --- @@ -89,6 +89,22 @@ case class

[GitHub] spark pull request #14612: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14612#discussion_r87958997 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala --- @@ -89,6 +89,22 @@ case class

[GitHub] spark issue #15803: [SPARK-18298][Web UI]change gmt time to local zone time ...

2016-11-14 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/spark/pull/15803 I'll post how UI works and what changes it did to be different before later :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11122 **[Test build #3426 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3426/consoleFull)** for PR 11122 at commit

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15884 **[Test build #68655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68655/consoleFull)** for PR 15884 at commit

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15884 **[Test build #68654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68654/consoleFull)** for PR 15884 at commit

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15878 Sure, will do it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15887: [SPARK-18442][SQL] Fix nullability of WrapOption.

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15887 **[Test build #68653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68653/consoleFull)** for PR 15887 at commit

[GitHub] spark pull request #15887: [SPARK-18442][SQL] Fix nullability of WrapOption.

2016-11-14 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/15887 [SPARK-18442][SQL] Fix nullability of WrapOption. ## What changes were proposed in this pull request? The nullability of `WrapOption` should be `false`. ## How was this patch

[GitHub] spark pull request #15878: [SPARK-18430] [SQL] Fixed Exception Messages when...

2016-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15878 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

2016-11-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15878 Can you submit a backport for branch-2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15878: [SPARK-18430] [SQL] Fixed Exception Messages when Hittin...

2016-11-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15878 Merging in master/branch-2.1. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15875 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15885: [SPARK-18440][Structured Streaming] Pass correct ...

2016-11-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15885#discussion_r87949452 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala --- @@ -142,19 +145,80 @@ class FileStreamSinkSuite extends

[GitHub] spark pull request #15885: [SPARK-18440][Structured Streaming] Pass correct ...

2016-11-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15885#discussion_r87949429 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -86,6 +86,7 @@ object FileFormatWriter extends

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15875 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-14 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/11122 retest this please. LGTM. Let's run the test again. Will merge after test passes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15880 +1 on the postgres approach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15886: [MINOR][DOC] Fix typos in the 'configuration', 'monitori...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15886 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15886: [MINOR][DOC] Fix typos in the 'configuration', 'm...

2016-11-14 Thread weiqingy
GitHub user weiqingy opened a pull request: https://github.com/apache/spark/pull/15886 [MINOR][DOC] Fix typos in the 'configuration', 'monitoring' and 'sql-programming-guide' documentation ## What changes were proposed in this pull request? Fix typos in the

[GitHub] spark issue #15843: [SPARK-18274][ML][PYSPARK] Memory leak in PySpark JavaWr...

2016-11-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15843 I'd prefer option2 for safety since the model summaries should be an issue for GC. And looks like Java model summaries don't have copy method. --- If your project is set up for it, you can reply to

[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68650/ Test FAILed. ---

[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68650/consoleFull)** for PR 15883 at commit

[GitHub] spark issue #15869: [YARN][DOC] Update Yarn configuration doc

2016-11-14 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15869 Hi, @srowen I have replied your comments and updated the PR. Could you please review it again? Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #15869: [YARN][DOC] Update Yarn configuration doc

2016-11-14 Thread weiqingy
Github user weiqingy commented on a diff in the pull request: https://github.com/apache/spark/pull/15869#discussion_r87945871 --- Diff: docs/running-on-yarn.md --- @@ -495,6 +468,20 @@ To use a custom metrics.properties for the application master and executors, upd name

[GitHub] spark pull request #15869: [YARN][DOC] Update Yarn configuration doc

2016-11-14 Thread weiqingy
Github user weiqingy commented on a diff in the pull request: https://github.com/apache/spark/pull/15869#discussion_r87945875 --- Diff: docs/running-on-yarn.md --- @@ -495,6 +468,20 @@ To use a custom metrics.properties for the application master and executors, upd name

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68652/ Test PASSed. ---

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15875 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15875 **[Test build #68652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68652/consoleFull)** for PR 15875 at commit

[GitHub] spark issue #15835: [SPARK-17059][SQL] Allow FileFormat to specify partition...

2016-11-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15835 I guess we should ping @liancheng as he was reviewing the previous one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15849: [SPARK-18410][STREAMING] Add structured kafka example

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15849 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15849: [SPARK-18410][STREAMING] Add structured kafka example

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15849 **[Test build #68651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68651/consoleFull)** for PR 15849 at commit

[GitHub] spark issue #15849: [SPARK-18410][STREAMING] Add structured kafka example

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15849 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68651/ Test PASSed. ---

[GitHub] spark pull request #15869: [YARN][DOC] Update Yarn configuration doc

2016-11-14 Thread weiqingy
Github user weiqingy commented on a diff in the pull request: https://github.com/apache/spark/pull/15869#discussion_r87945049 --- Diff: docs/running-on-yarn.md --- @@ -118,19 +118,6 @@ To use a custom metrics.properties for the application master and executors, upd

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68647/ Test PASSed. ---

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68647/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for GraphX

2016-11-14 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15875 @rxin I update this PR to notify in `Vertex and Edge RDDs` that not all methods are listed and add link of `VertexRDD` and `EdgeRDD`. BTW, use `VertexId` instead of `VertexID` --- If

[GitHub] spark issue #15875: [SPARK-18428][DOC] Update docs for Graph.op

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15875 **[Test build #68652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68652/consoleFull)** for PR 15875 at commit

[GitHub] spark issue #15849: [SPARK-18410][STREAMING] Add structured kafka example

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15849 **[Test build #68651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68651/consoleFull)** for PR 15849 at commit

[GitHub] spark issue #15885: [SPARK-18440][Structured Streaming] Pass correct query e...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15885 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15885: [SPARK-18440][Structured Streaming] Pass correct query e...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15885 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68643/ Test PASSed. ---

[GitHub] spark issue #15885: [SPARK-18440][Structured Streaming] Pass correct query e...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15885 **[Test build #68643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68643/consoleFull)** for PR 15885 at commit

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68648/ Test PASSed. ---

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15881 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15881 **[Test build #68648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68648/consoleFull)** for PR 15881 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-14 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/15852 LGTM overall. If this is accepted, then i will close #15827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-14 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r87941243 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68644/ Test PASSed. ---

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68650/consoleFull)** for PR 15883 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68644/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15817 **[Test build #68649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68649/consoleFull)** for PR 15817 at commit

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15817 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15817 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68649/ Test PASSed. ---

[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...

2016-11-14 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15883 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68645/ Test FAILed. ---

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15835: [SPARK-17059][SQL] Allow FileFormat to specify partition...

2016-11-14 Thread pwoody
Github user pwoody commented on the issue: https://github.com/apache/spark/pull/15835 @rxin @HyukjinKwon ready for more review on my end. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #68645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68645/consoleFull)** for PR 15880 at commit

[GitHub] spark pull request #15881: [SPARK-18434][ML] Add missing ParamValidations fo...

2016-11-14 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/15881#discussion_r87939529 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -73,11 +73,13 @@ private[ml] trait DecisionTreeParams extends

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15817 **[Test build #68649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68649/consoleFull)** for PR 15817 at commit

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/15817 @jkbradley done 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15881: [SPARK-18434][ML] Add missing ParamValidations fo...

2016-11-14 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/15881#discussion_r87939306 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -73,11 +73,13 @@ private[ml] trait DecisionTreeParams extends

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15884 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68642/ Test PASSed. ---

[GitHub] spark issue #15884: [WIP][SPARK-18433][SQL] Improve DataSource option keys t...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15884 **[Test build #68642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68642/consoleFull)** for PR 15884 at commit

[GitHub] spark pull request #15881: [SPARK-18434][ML] Add missing ParamValidations fo...

2016-11-14 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/15881#discussion_r87939017 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -73,11 +73,13 @@ private[ml] trait DecisionTreeParams extends PredictorParams

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15881 **[Test build #68648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68648/consoleFull)** for PR 15881 at commit

[GitHub] spark issue #15881: [SPARK-18434][ML] Add missing ParamValidations for ML al...

2016-11-14 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15881 Thanks for reviewing. I update the checking in LiR's `solver` : Array -> Set, output supported options in err message. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ...

2016-11-14 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15817 Can you please implement the Param directly in Bucketizer and QuantileDiscretizer? Just like in Scala, HasHandleInvalid has built-in Param doc which applies to existing use cases but not

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-14 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r87936909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

2016-11-14 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r87936572 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAggSuite.scala --- @@ -0,0 +1,284 @@ +/* + *

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

2016-11-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15884#discussion_r87936113 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -34,35 +34,42 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

2016-11-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15884#discussion_r87936135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -34,35 +34,42 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

2016-11-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15884#discussion_r87936058 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -34,35 +34,42 @@ private[sql] class JSONOptions(

[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...

2016-11-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15865 For sure, I ran ```bash $ ./dev/lint-java Using `mvn` from path: .../mvn Checkstyle checks passed. ``` It seems fine. It looks good to me for few minor comments

[GitHub] spark pull request #15865: [SPARK-18420][BUILD] Fix the errors caused by lin...

2016-11-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15865#discussion_r87935757 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java --- @@ -48,8 +47,7 @@ public static void main(String[] args)

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

2016-11-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15884#discussion_r87935620 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -34,35 +34,42 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #15865: [SPARK-18420][BUILD] Fix the errors caused by lin...

2016-11-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15865#discussion_r87935645 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -109,7 +109,8 @@ public void pointTo(Object

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Thank you for retriggering, @gatorsmile . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15880 +1 on the postgres approach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15884: [WIP][SPARK-18433][SQL] Improve DataSource option...

2016-11-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15884#discussion_r87935015 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -34,35 +34,42 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #15857: [SPARK-18300][SQL] Do not apply foldable propagat...

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15857#discussion_r87934920 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala --- @@ -118,14 +118,30 @@ class

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68647/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15868 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15849: [SPARK-18410][STREAMING] Add structured kafka exa...

2016-11-14 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/15849#discussion_r87934733 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredKafkaWordCount.java --- @@ -0,0 +1,96 @@ +/* + * Licensed

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

2016-11-14 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r87934606 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,131 @@ +/* + *

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15704 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15704 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68640/ Test PASSed. ---

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15704 **[Test build #68640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68640/consoleFull)** for PR 15704 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68641/ Test FAILed. ---

[GitHub] spark issue #11122: [SPARK-13027][STREAMING] Added batch time as a parameter...

2016-11-14 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/11122 It sounds good. @zsxwing could you take a look at this pr? does this pr plan to be merged into branch-2.1? --- If your project is set up for it, you can reply to this email and have your reply

  1   2   3   4   5   >