Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16344
This looks good to me. cc @jkbradley @srowen @sethah for another pass if
you have time. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16703
(I just added some links for `StructType` and `StructField` around this
examples just for consistency and while I was here)
---
If your project is set up for it, you can reply to this email and
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16700
cc @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16703
**[Test build #71991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71991/testReport)**
for PR 16703 at commit
[`b9a841d`](https://github.com/apache/spark/commit/b9
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97753392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -490,7 +569,11 @@ abstract class UnixTim
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97748329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -490,7 +569,11 @@ abstract class UnixTim
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97801907
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -107,108 +109,119 @@ class CastSuite extends Spark
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97808039
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -177,180 +177,186 @@ class DateTimeUtilsSuite ex
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16703
**[Test build #71992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71992/testReport)**
for PR 16703 at commit
[`f6a1059`](https://github.com/apache/spark/commit/f6
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16572
@nsyca it would be nice to make subquery expression part of tree traversal.
It does seem risky to me, a lot functions using traversal maintain some state
and do not account for the existence of s
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #71993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71993/testReport)**
for PR 16697 at commit
[`b4bc5af`](https://github.com/apache/spark/commit/b4
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16572
LGTM - merging to master/2.1/2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97749254
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1044,7 +1044,8 @@ object DecimalAggregates extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97749273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1056,7 +1057,8 @@ object DecimalAggregates extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97807866
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData = take
Github user nsyca commented on the issue:
https://github.com/apache/spark/pull/16572
@hvanhovell, I agree it does look risky with this approach. There are a lot
of dependencies here. I am pitching in the idea to get your initial thought.
Let me do some background and I will share once
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16701
Thank you for review, @srowen .
Yes. These two are the scope of the issue description of SPARK-18909.
@cloud-fan , did I understand correctly?
---
If your project is set up for it
Github user wesm commented on the issue:
https://github.com/apache/spark/pull/15821
Very nice to see the improved wall clock times. I have been busy
engineering the pipeline between the byte stream from Spark and the resulting
DataFrame -- the only major thing still left on the table
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks! Merging to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user milanvdmria commented on the issue:
https://github.com/apache/spark/pull/12855
The issue that @jurriaan reported is still there in Spark 2.1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16699
can you please:
1.) add [MLLIB] to the title
2.) fix the MiMa tests
The MiMa tests error seems to be related to the interface change, probably
you need to add an exclude to the file
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16620
Fail to pass unit test. I will keep working on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16699
**[Test build #71994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71994/testReport)**
for PR 16699 at commit
[`d2afcb0`](https://github.com/apache/spark/commit/d2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16603
**[Test build #71989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71989/testReport)**
for PR 16603 at commit
[`083cfb3`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16699
**[Test build #71994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71994/testReport)**
for PR 16699 at commit
[`d2afcb0`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16699
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71994/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16699
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16603
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71989/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16699
**[Test build #71995 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71995/testReport)**
for PR 16699 at commit
[`9eca1a6`](https://github.com/apache/spark/commit/9e
Github user Gauravshah commented on the issue:
https://github.com/apache/spark/pull/16213
facing same issue randomly on prod, can I help in some way to push it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16688#discussion_r97835936
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -39,6 +39,8 @@ private case class BigData(s: String)
class Cache
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16688
@dilipbiswal Since this PR is to fix the minor test issues, could you do me
a favor to fix three comments?
Replace `_global_temp` by `global_temp`
-
https://github.com/apache/sp
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16696
Sure, will review it tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16703
**[Test build #71990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71990/testReport)**
for PR 16703 at commit
[`2e9bec8`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71990/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16476
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16213#discussion_r97841000
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisCheckpointer.scala
---
@@ -64,7 +64,18 @@ private[kinesis] class Kine
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #71996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71996/testReport)**
for PR 16476 at commit
[`465f7a6`](https://github.com/apache/spark/commit/46
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71996/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #71996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71996/testReport)**
for PR 16476 at commit
[`465f7a6`](https://github.com/apache/spark/commit/4
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/16213
@maropu One last comment. Then I'll merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16686
**[Test build #71997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71997/testReport)**
for PR 16686 at commit
[`3b0d48b`](https://github.com/apache/spark/commit/3b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71998/testReport)**
for PR 16630 at commit
[`78bb77f`](https://github.com/apache/spark/commit/78
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16582#discussion_r97846126
--- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala ---
@@ -227,8 +228,55 @@ class UISuite extends SparkFunSuite {
assert(newHeader === nu
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16603#discussion_r97846569
--- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
---
@@ -144,23 +152,49 @@ public long acquireExecutionMemory(long required,
Memo
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16603#discussion_r97846848
--- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
---
@@ -144,23 +152,49 @@ public long acquireExecutionMemory(long required,
Memo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16703
**[Test build #71991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71991/testReport)**
for PR 16703 at commit
[`b9a841d`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16703
**[Test build #71992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71992/testReport)**
for PR 16703 at commit
[`f6a1059`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71991/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71992/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16699
**[Test build #71995 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71995/testReport)**
for PR 16699 at commit
[`9eca1a6`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16699
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71995/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16686
**[Test build #71997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71997/testReport)**
for PR 16686 at commit
[`3b0d48b`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16686
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71997/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #71993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71993/testReport)**
for PR 16697 at commit
[`b4bc5af`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71993/
Test PASSed.
---
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/16704
[SPARK-18750][yarn] Follow up: move test to correct directory in 2.1 branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16704
fyi @tgravescs
I plan to backport the original change and this one to 2.0 after this is
pushed. (Merges fine btw.)
---
If your project is set up for it, you can reply to this email and hav
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/16704
thanks for fixing, forgot we moved those.
+1, go ahead and merge once jenkins passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16704
**[Test build #71999 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71999/testReport)**
for PR 16704 at commit
[`de87fef`](https://github.com/apache/spark/commit/de
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/15821
> Parallelizing the record batch conversion and streaming it to Python
would be another significant perf win.
Right, I should have also mentioned that this PR takes a simplistic
approa
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
@zhengruifeng @imatiach-msft
Thanks much for pointing out the issue due to the hasOffset trait. This is
what caused the test to fail. I have moved it to the GLRBase class. Things are
worki
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71998/testReport)**
for PR 16630 at commit
[`78bb77f`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71998/
Test PASSed.
---
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16688#discussion_r97864526
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -39,6 +39,8 @@ private case class BigData(s: String)
class Cach
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16688
@gatorsmile Sure Sean. Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16682
Merging to master / 2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16682
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16695#discussion_r97867966
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
---
@@ -349,4 +351,47 @@ package object config {
CACHED_FI
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r97870619
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.ml.opt
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16582
**[Test build #72000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72000/testReport)**
for PR 16582 at commit
[`5b65c69`](https://github.com/apache/spark/commit/5b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16688
**[Test build #72001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72001/testReport)**
for PR 16688 at commit
[`8f9914d`](https://github.com/apache/spark/commit/8f
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r97872960
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -358,13 +384,13 @@ object GeneralizedLinearRegr
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r97876098
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -736,15 +762,27 @@ class GeneralizedLinearRegre
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r97877367
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -94,6 +94,17 @@ private[regression] trait
Gene
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16699
@actuaryzhang added a couple comments, please take a look, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16557
ping @sethah @Lewuathe @thunterdb @WeichenXu123 @jkbradley would you be
able to take a look at the changes to add a weight column to
binary/multiclass/regression evaluators/metrics classes? It
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97881374
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker (
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97881356
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker (
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97877539
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker (
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97878659
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -528,6 +548,16 @@ class StandaloneDynamicAllocationSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97877918
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -148,6 +153,12 @@ class CoarseGrainedSchedulerBac
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97874677
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -59,6 +59,19 @@ private[spark] trait ExecutorAllocationClient {
de
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97881401
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -148,6 +153,12 @@ class CoarseGrainedSchedulerBac
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97875716
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -187,6 +206,22 @@ private[scheduler] class BlacklistTracker (
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97875223
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -139,6 +139,11 @@ package object config {
.timeConf(TimeUnit.MI
101 - 200 of 368 matches
Mail list logo
