[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98838566 --- Diff: R/pkg/inst/tests/testthat/test_utils.R --- @@ -17,6 +17,9 @@ context("functions in utils.R") +# Ensure Spark is installed

[GitHub] spark issue #16043: [SPARK-18601][SQL] Simplify Create/Get complex expressio...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72229/ Test PASSed. ---

[GitHub] spark issue #16043: [SPARK-18601][SQL] Simplify Create/Get complex expressio...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16043 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16043: [SPARK-18601][SQL] Simplify Create/Get complex expressio...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16043 **[Test build #72229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72229/testReport)** for PR 16043 at commit

[GitHub] spark issue #16761: [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summar...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16761 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16761: [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summar...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16761 **[Test build #72233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72233/testReport)** for PR 16761 at commit

[GitHub] spark issue #16761: [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summar...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16761 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72233/ Test FAILed. ---

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98837222 --- Diff: R/pkg/inst/tests/testthat/test_utils.R --- @@ -17,6 +17,9 @@ context("functions in utils.R") +# Ensure Spark is installed

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98837066 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -27,6 +27,9 @@ library(SparkR) We use default settings in which it runs in local mode. It

[GitHub] spark issue #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableRelation...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16736 BTW, you need to update the PR title and description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableRelation...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16736 Overall, looks good to me. cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98836889 --- Diff: core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala --- @@ -90,6 +90,14 @@ private[spark] class TypedConfigBuilder[T](

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72230/ Test FAILed. ---

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16758 **[Test build #72230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72230/testReport)** for PR 16758 at commit

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98836638 --- Diff: R/pkg/inst/tests/testthat/test_utils.R --- @@ -17,6 +17,9 @@ context("functions in utils.R") +# Ensure Spark is installed

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98836570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,10 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark issue #16737: [SPARK-19397] [SQL] Make option names of LIBSVM and TEXT...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16737 **[Test build #72238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72238/testReport)** for PR 16737 at commit

[GitHub] spark pull request #15415: [SPARK-14503][ML] spark.ml API for FPGrowth

2017-01-31 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/15415#discussion_r98836498 --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala --- @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark issue #16737: [SPARK-19397] [SQL] Make option names of LIBSVM and TEXT...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16737 I think `LIBSVM` and `TEXT` are the last two built-in sources that do not support case sensitivity. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #16737: [SPARK-19397] [SQL] Make option names of LIBSVM a...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16737#discussion_r98836103 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #16753: [SPARK-19296][SQL] Deduplicate url and table in JdbcUtil...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16753 LGTM except two comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-31 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/12135 @holdenk Updated! Thanks for your careful checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12135 **[Test build #72237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72237/testReport)** for PR 12135 at commit

[GitHub] spark pull request #16753: [SPARK-19296][SQL] Deduplicate url and table in J...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16753#discussion_r98835277 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala --- @@ -53,33 +53,31 @@ class

[GitHub] spark pull request #16753: [SPARK-19296][SQL] Deduplicate url and table in J...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16753#discussion_r98835197 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala --- @@ -53,33 +53,31 @@ class

[GitHub] spark issue #16751: [SPARK-19409][BUILD] Bump parquet version to 1.8.2

2017-01-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16751 Hi, @rxin . Sure, I'll try to put them in a single PR except the ongoing one. BTW, every time, I noticed that committers have a better and broader perspective than me. Do you have

[GitHub] spark issue #16727: [SPARK-19421][ML][PySpark] Remove numClasses and numFeat...

2017-01-31 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/16727 @holdenk I created another jira to track this issue. Thanks all for revewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98834936 --- Diff: R/pkg/inst/tests/testthat/test_utils.R --- @@ -17,6 +17,9 @@ context("functions in utils.R") +# Ensure Spark is installed

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98834935 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -27,6 +27,9 @@ library(SparkR) We use default settings in which it runs in local mode.

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16690 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16690 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72228/ Test PASSed. ---

[GitHub] spark pull request #16762: [SPARK-19419] [SPARK-19420] Fix the cross join de...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16762#discussion_r98834480 --- Diff: sql/core/src/test/resources/sql-tests/inputs/cross-join.sql --- @@ -33,3 +33,5 @@ create temporary view D(d, vd) as select * from nt1; --

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16690 **[Test build #72228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72228/testReport)** for PR 16690 at commit

[GitHub] spark issue #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON parsing

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16750 **[Test build #72236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72236/testReport)** for PR 16750 at commit

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72227/ Test PASSed. ---

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON p...

2017-01-31 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16750#discussion_r98834088 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -161,12 +163,3 @@ private[csv] class

[GitHub] spark pull request #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON p...

2017-01-31 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16750#discussion_r98834068 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -329,7 +332,17 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72227/testReport)** for PR 16620 at commit

[GitHub] spark pull request #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON p...

2017-01-31 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16750#discussion_r98834049 --- Diff: python/pyspark/sql/readwriter.py --- @@ -297,7 +300,7 @@ def text(self, paths): def csv(self, path, schema=None, sep=None, encoding=None,

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98833756 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -27,6 +27,9 @@ library(SparkR) We use default settings in which it runs in local mode. It

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-31 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16720#discussion_r98833957 --- Diff: R/pkg/inst/tests/testthat/test_utils.R --- @@ -17,6 +17,9 @@ context("functions in utils.R") +# Ensure Spark is installed

[GitHub] spark issue #16762: [SPARK-19419] [SPARK-19420] Fix the cross join detection

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16762 **[Test build #72235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72235/testReport)** for PR 16762 at commit

[GitHub] spark pull request #16762: [SPARK-19419] [SPARK-19420] Fix the cross join de...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16762#discussion_r98833830 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -584,24 +602,37 @@ class JoinSuite extends QueryTest with SharedSQLContext

[GitHub] spark pull request #16762: [SPARK-19419] [SPARK-19420] Fix the cross join de...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16762#discussion_r98833748 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -215,18 +215,36 @@ class JoinSuite extends QueryTest with SharedSQLContext

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-01-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r98833772 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/GetStructField2.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-01-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r98833717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/GetStructField2.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

2017-01-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15279 What if we have a bunch of default values when arguments are not set, and those are the values we could test with? This way the same sample code can run with and without arguments? --- If

[GitHub] spark pull request #16762: [SPARK-19419] [SPARK-19420] Fix the cross join de...

2017-01-31 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/16762 [SPARK-19419] [SPARK-19420] Fix the cross join detection ### What changes were proposed in this pull request? There are two issues in the existing detection of cartesian products.

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16603 **[Test build #72234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72234/testReport)** for PR 16603 at commit

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16603 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16761: [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summar...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16761 **[Test build #72233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72233/testReport)** for PR 16761 at commit

[GitHub] spark pull request #16761: [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans...

2017-01-31 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/16761 [BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summary returns error when the cluster size doesn't equal to k ## What changes were proposed in this pull request? Backport fix of

[GitHub] spark issue #16739: [SPARK-19399][SPARKR] Add R coalesce API for DataFrame a...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16739 **[Test build #72232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72232/testReport)** for PR 16739 at commit

[GitHub] spark issue #16666: [SPARK-19319][SparkR]:SparkR Kmeans summary returns erro...

2017-01-31 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/1 I will backport it soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72231/testReport)** for PR 16620 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72225/ Test PASSed. ---

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72225/testReport)** for PR 16722 at commit

[GitHub] spark issue #16740: [SPARK-19400][ML] Allow GLM to handle intercept only mod...

2017-01-31 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16740 @sethah Thanks for the clarification and providing an implementation. So, the pros is some speed improvement and the cons is the increased complexity (now we have three case: one for intercept

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72226/ Test FAILed. ---

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72226/testReport)** for PR 16620 at commit

[GitHub] spark pull request #16666: [SPARK-19319][SparkR]:SparkR Kmeans summary retur...

2017-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16666: [SPARK-19319][SparkR]:SparkR Kmeans summary returns erro...

2017-01-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/1 merged, thanks! I think it'll good to have this in branch-2.1 - @wangmiao1981 would you by any chance would like to backport this fix? --- If your project is set up for it, you can reply

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16758 **[Test build #72230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72230/testReport)** for PR 16758 at commit

[GitHub] spark issue #16740: [SPARK-19400][ML] Allow GLM to handle intercept only mod...

2017-01-31 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16740 I agree having a special case is unsatisfying from an engineering perspective. In Spark it's a bit different than R since every iteration of IRLS will launch a Spark job, making a pass over the

[GitHub] spark issue #16043: [SPARK-18601][SQL] Simplify Create/Get complex expressio...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16043 **[Test build #72229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72229/testReport)** for PR 16043 at commit

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16725 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16725 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72224/ Test FAILed. ---

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16725 **[Test build #72224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72224/testReport)** for PR 16725 at commit

[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16690 **[Test build #72228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72228/testReport)** for PR 16690 at commit

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72227/testReport)** for PR 16620 at commit

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/16603 Thanks for the review @vanzin , I will leave this open for a day in case someone else also wants to review; and will commit tomorrow. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16740: [SPARK-19400][ML] Allow GLM to handle intercept only mod...

2017-01-31 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16740 @sethah Thanks for your input. I can add more tests, but they are not adding too much since the algorithm is already tested in other tests. The analytical approach does not integrate

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72221/ Test FAILed. ---

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16603 **[Test build #72221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72221/testReport)** for PR 16603 at commit

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16620 **[Test build #72226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72226/testReport)** for PR 16620 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72225/testReport)** for PR 16722 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16722 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72223/ Test FAILed. ---

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16758 **[Test build #72223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72223/testReport)** for PR 16758 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72220/ Test FAILed. ---

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72220/testReport)** for PR 16722 at commit

[GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...

2017-01-31 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16620#discussion_r98819685 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1212,8 +1223,9 @@ class DAGScheduler(

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-01-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r98819150 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/GetStructField2.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] spark issue #16536: [SPARK-19163][PYTHON][SQL] Delay _judf initialization to...

2017-01-31 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/16536 Thanks a bunch @holdenk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16727: [SPARK-19336][FollowUp][ML][PySpark] Remove numClasses a...

2017-01-31 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/16727 The original PR was merged a few days ago, would you be OK with making a new JIRA just to avoid confusion? You can make it related to the previous JIRA. But otherwise looks good to me. --- If

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16758 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72217/ Test FAILed. ---

[GitHub] spark issue #16758: [SPARK-19413][SS] MapGroupsWithState for arbitrary state...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16758 **[Test build #72217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72217/testReport)** for PR 16758 at commit

[GitHub] spark pull request #16536: [SPARK-19163][PYTHON][SQL] Delay _judf initializa...

2017-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16536: [SPARK-19163][PYTHON][SQL] Delay _judf initialization to...

2017-01-31 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/16536 Going to go ahead and merge. Still need to sort out the JIRA permissions so will take a bit for me to get that updated for you. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16725 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16725 **[Test build #72224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72224/testReport)** for PR 16725 at commit

[GitHub] spark issue #16725: [SPARK-19377] [WEBUI] [CORE] Killed tasks should have th...

2017-01-31 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16725 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   4   >