Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17059
That's compelling regarding performance. It's not big but not trivial.
My remaining concern is whether you're handling all the cases the original
did. `Number` covers a lot but does it include
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r103174824
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala ---
@@ -23,7 +23,10 @@ import java.util.Properties
import
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17071
I like it, though, regarding still testing the deprecated method -- maybe
it's best to even have a test that is explicitly just for testing the old
method? that may be clearer than just picking some
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/17082
@srowen I think this is the only one souce forgotten to name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17075
I dont' know the code well enough to really evaluate this, but, I see that
`.clone()` is called in a similar context in `decimalExpressions`. There are
also similar usages of `changePrecision` in
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17082
OK, how about other sources? it'd be nice to given them toString methods
consistently along with other related classes, if you're bothering to do one.
---
If your project is set up for it, you can
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/17082
[SPARK-19749][SS] Name socket source with a meaningful name
## What changes were proposed in this pull request?
Name socket source with a meaningful name
## How was this patch
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17072
Thank you @srowen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17072
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17078#discussion_r103154658
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1447,7 +1447,7 @@ private class LogisticAggregator(
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17081
[SPAKR-18726][SQL][WIP]resolveRelation for FileFormat DataSource don't need
to listFiles twice
## What changes were proposed in this pull request?
Currently when we resolveRelation for
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/17080
[SPARK-19739][CORE] propagate S3 session token to cluser
## What changes were proposed in this pull request?
propagate S3 session token to cluser
## How was this patch tested?
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16987#discussion_r103151253
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -158,12 +158,28 @@ class FileStreamSource(
601 - 613 of 613 matches
Mail list logo
