Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849099
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-negative.sql ---
@@ -0,0 +1,36 @@
+-- Negative testcases for column resolutio
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849138
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-negative.sql ---
@@ -0,0 +1,36 @@
+-- Negative testcases for column resolutio
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849191
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -0,0 +1,25 @@
+-- Tests for qualified column names for the v
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849231
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/columnresolution-views.sql ---
@@ -0,0 +1,25 @@
+-- Tests for qualified column names for the v
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849396
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -228,12 +228,13 @@ class SQLQueryTestSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849486
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -0,0 +1,240 @@
+-- Automatically generated by SQLQu
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17067#discussion_r103849606
--- Diff: sql/core/src/test/resources/sql-tests/inputs/columnresolution.sql
---
@@ -0,0 +1,84 @@
+-- Tests covering different scenarios with qualifie
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17067
Generally, it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16944
**[Test build #73725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73725/testReport)**
for PR 16944 at commit
[`1734598`](https://github.com/apache/spark/commit/1
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103849859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -202,14 +194,9 @@ trait CheckAnalysis extends Pr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73725/
Test PASSed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17081
**[Test build #73724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73724/testReport)**
for PR 17081 at commit
[`a8c1dea`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17081
**[Test build #73726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73726/testReport)**
for PR 17081 at commit
[`60fa037`](https://github.com/apache/spark/commit/60
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73724/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17081
cc @cloud-fan @gatorsmile could you help to review this?thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103851814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -54,20 +61,25 @@ object RewritePredicateSubquery ext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103851862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -54,20 +61,25 @@ object RewritePredicateSubquery ext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17088
Can you please file a JIRA for the flaky jenkins failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17111
Thanks for fixing this! I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103853075
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -361,6 +363,36 @@ class AFTSurvivalRegressionSu
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103853263
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -27,6 +27,8 @@ import org.apache.spark.ml.util.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17119
**[Test build #73727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73727/testReport)**
for PR 17119 at commit
[`be98a0f`](https://github.com/apache/spark/commit/be
Github user mariusvniekerk commented on the issue:
https://github.com/apache/spark/pull/15666
Seems to be something in pyspark.SparkContext.addJar:10: ERROR: Unexpected
indentation. ?
what exactly does it want in that docstring?
---
If your project is set up for it, you can
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery ex
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17034
great fix, LGTM! I added minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -79,57 +251,10 @@ case class ScalarSubquery(
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16959#discussion_r103854313
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -158,13 +158,17 @@ private[spark] class OutputCommitCoor
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17116
**[Test build #73728 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73728/testReport)**
for PR 17116 at commit
[`752eeb7`](https://github.com/apache/spark/commit/75
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103854544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -297,8 +284,11 @@ trait CheckAnalysis extends Pr
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15666
Ah yes, that error message is confusing. You've got `:param .xyz
Description of xyz` but you need `:param xyz: Description of xyz` (see the `:`).
---
If your project is set up for it, you can reply
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16855
LGTM thanks for fixing this! I've merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103854902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1208,63 +1253,39 @@ class Analyzer(
//
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16855
@GavinGavinNo1 are you ZhengYaofeng on JIRA? I want to correctly give you
credit on JIRA for fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/10506
Is anyone still working on this and if not, can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1172,20 +1226,11 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17128
**[Test build #73729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73729/testReport)**
for PR 17128 at commit
[`f5daeae`](https://github.com/apache/spark/commit/f5
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/17111
@kayousterhout
Thanks for merging.
(btw, I made some measurements for
https://github.com/apache/spark/pull/16867 SPARK-16929, please take a look when
you have time :) )
---
If your pro
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1208,63 +1253,39 @@ class Analyzer(
//
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1208,63 +1253,39 @@ class Analyzer(
//
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16954
@dilipbiswal I did one more pass. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1172,20 +1226,11 @@ class Analyzer(
}
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/10506
Hi @kayousterhout , I guess the issue still exists, but unfortunately
there's no one reviewing this patch. I could rebase the code if someone could
review it.
---
If your project is set up for i
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/10506
OK fine to leave this open then (I don't have the time or expertise to
review this unfortunately)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chriso commented on the issue:
https://github.com/apache/spark/pull/16998
I just run into the same issue with `spark-2.1.0`
Here's a minimal test case:
```scala
val max = 12 // try increasing this
val filter = (for (i <- 0 to max) yield col("va
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103857751
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -434,6 +434,17 @@ case class RangeExec(range:
org.apach
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103858210
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -361,6 +363,36 @@ class AFTSurvivalRegressionSui
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103858261
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -27,6 +27,8 @@ import org.apache.spark.ml.util.T
GitHub user stanzhai opened a pull request:
https://github.com/apache/spark/pull/17131
[SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in INNER JOIN should
not be folded by FoldablePropagation rule
This PR fix for branch-2.0
Refer #17099
@gatorsmile
You ca
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103858474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -69,6 +69,7 @@ trait BaseLimitExec extends UnaryExecNode with
CodegenSupp
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103858494
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -77,6 +77,10 @@ trait CodegenSupport extends SparkPlan {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,14 @@ class Analyzer(
def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17122
**[Test build #73730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73730/testReport)**
for PR 17122 at commit
[`5ff8dca`](https://github.com/apache/spark/commit/5f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17034
**[Test build #73731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73731/testReport)**
for PR 17034 at commit
[`0185b45`](https://github.com/apache/spark/commit/01
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17131
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858997
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858978
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103859056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17131
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17119
**[Test build #73727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73727/testReport)**
for PR 17119 at commit
[`be98a0f`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17119
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73727/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17119
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17131
**[Test build #73732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73732/consoleFull)**
for PR 17131 at commit
[`4975ac7`](https://github.com/apache/spark/commit/4
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103859650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -364,7 +364,8 @@ case class DataSource(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.as
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17076
@sethah Thanks for the good catch. I verified this optimization and found
it indeed reduced the size of shuffle data. This looks good to me. BTW, like
@MLnick 's suggestion, could you add the laz
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860516
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103860938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +207,13 @@ trait CodegenSupport extends SparkPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103860895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -77,6 +77,7 @@ trait CodegenSupport extends SparkPlan {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17081
**[Test build #73726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73726/testReport)**
for PR 17081 at commit
[`60fa037`](https://github.com/apache/spark/commit/6
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16938
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103861241
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +207,13 @@ trait CodegenSupport extends SparkPlan
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73726/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16910
can you resolve the conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16938
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17081
**[Test build #73733 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73733/testReport)**
for PR 17081 at commit
[`9a73947`](https://github.com/apache/spark/commit/9a
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103861360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -434,6 +434,17 @@ case class RangeExec(range:
org.apac
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103861355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +77,19 @@ abstract class ExternalCatalog {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103861424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -364,7 +364,12 @@ case class DataSource(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103861521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
org.apache.spark.sql.cata
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17104
LGTM, merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16910
ok, do it now ~ yesterday is ok...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17127
Merged into master, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
401 - 500 of 562 matches
Mail list logo
