[GitHub] spark issue #13116: [SPARK-15324] [SQL] Add the takeSample function to the D...

2017-03-13 Thread burness
Github user burness commented on the issue: https://github.com/apache/spark/pull/13116 @HyukjinKwon It is too hard to solve the OOM, I'm so sorry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-13 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/17250 @brkyvz I think if we're eliminating the constructor arguments then the second approach you've proposed might make more sense. I can't think of anything cleaner. --- If your project is set up for

[GitHub] spark pull request #16954: [SPARK-18874][SQL] First phase: Deferring the cor...

2017-03-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16954#discussion_r105831346 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -123,19 +123,36 @@ case class Not(child:

[GitHub] spark issue #17109: [SPARK-19740][MESOS]Add support in Spark to pass arbitra...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74488/ Test PASSed. ---

[GitHub] spark issue #17109: [SPARK-19740][MESOS]Add support in Spark to pass arbitra...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17109 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17109: [SPARK-19740][MESOS]Add support in Spark to pass arbitra...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17109 **[Test build #74488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74488/testReport)** for PR 17109 at commit

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17277 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74482/ Test PASSed. ---

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105831078 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -925,6 +925,26 @@ class DDLSuite extends QueryTest with

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17277 **[Test build #74482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74482/testReport)** for PR 17277 at commit

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105830656 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -925,6 +925,26 @@ class DDLSuite extends QueryTest with

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74480/ Test PASSed. ---

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17277 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17277 **[Test build #74480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74480/testReport)** for PR 17277 at commit

[GitHub] spark issue #16954: [SPARK-18874][SQL] First phase: Deferring the correlated...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16954 **[Test build #74489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74489/testReport)** for PR 16954 at commit

[GitHub] spark issue #17109: [SPARK-19740][MESOS]Add support in Spark to pass arbitra...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17109 **[Test build #74488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74488/testReport)** for PR 17109 at commit

[GitHub] spark pull request #16954: [SPARK-18874][SQL] First phase: Deferring the cor...

2017-03-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16954#discussion_r105830367 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -365,17 +368,73 @@ object TypeCoercion {

[GitHub] spark issue #13656: [SPARK-15938]Adding "support" property to MLlib Associat...

2017-03-13 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/13656 Close this and add the support to ml.fpm. https://github.com/apache/spark/pull/17280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #13656: [SPARK-15938]Adding "support" property to MLlib A...

2017-03-13 Thread hhbyyh
Github user hhbyyh closed the pull request at: https://github.com/apache/spark/pull/13656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17255: [SPARK-19918][SQL] Use TextFileFormat in implemen...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17255#discussion_r105830235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala --- @@ -40,18 +40,11 @@ private[sql] object

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16867 @squito Thanks a lot for comments. I've refined :):) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ... PART...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74481/ Test PASSed. ---

[GitHub] spark issue #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ... PART...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16373 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ... PART...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16373 **[Test build #74481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74481/testReport)** for PR 16373 at commit

[GitHub] spark pull request #17279: Added dayofweek function to Functions.scala

2017-03-13 Thread RishikeshTeke
Github user RishikeshTeke closed the pull request at: https://github.com/apache/spark/pull/17279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74479/ Test FAILed. ---

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15628 **[Test build #74479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74479/consoleFull)** for PR 15628 at commit

[GitHub] spark issue #17267: [SPARK-19926][PYSPARK] Make pyspark exception more reada...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17267 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74487/ Test FAILed. ---

[GitHub] spark issue #17267: [SPARK-19926][PYSPARK] Make pyspark exception more reada...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17267 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17267: [SPARK-19926][PYSPARK] Make pyspark exception more reada...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17267 **[Test build #74487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74487/testReport)** for PR 17267 at commit

[GitHub] spark issue #13116: [SPARK-15324] [SQL] Add the takeSample function to the D...

2017-03-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13116 Hi @burness, what's the state of this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17267: [SPARK-19926][PYSPARK] Make pyspark exception mor...

2017-03-13 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/17267#discussion_r105827541 --- Diff: python/pyspark/sql/utils.py --- @@ -24,7 +24,7 @@ def __init__(self, desc, stackTrace): self.stackTrace = stackTrace

[GitHub] spark issue #17267: [SPARK-19926][PYSPARK] Make pyspark exception more reada...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17267 **[Test build #74487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74487/testReport)** for PR 17267 at commit

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105827253 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -925,6 +925,26 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105826784 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -925,6 +925,26 @@ class DDLSuite extends QueryTest with

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15628 **[Test build #74486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74486/testReport)** for PR 15628 at commit

[GitHub] spark pull request #17175: [SPARK-19931][SQL] InMemoryTableScanExec should r...

2017-03-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17175#discussion_r105825600 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -41,11 +41,31 @@ case class

[GitHub] spark pull request #17175: [SPARK-19931][SQL] InMemoryTableScanExec should r...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17175#discussion_r105825397 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -41,11 +41,31 @@ case class

[GitHub] spark issue #17285: [SPARK-19944][SQL] Move SQLConf from sql/core to sql/cat...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17285 **[Test build #74485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74485/testReport)** for PR 17285 at commit

[GitHub] spark pull request #17265: [SPARK-19924] [SQL] Handle InvocationTargetExcept...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17265: [SPARK-19924] [SQL] Handle InvocationTargetException for...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17265 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17285: [SPARK-19944][SQL] Move SQLConf from sql/core to sql/cat...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17285 **[Test build #74484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74484/testReport)** for PR 17285 at commit

[GitHub] spark pull request #17285: [SPARK-19944][SQL] Move SQLConf from sql/core to ...

2017-03-13 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17285 [SPARK-19944][SQL] Move SQLConf from sql/core to sql/catalyst ## What changes were proposed in this pull request? This patch moves SQLConf from sql/core to sql/catalyst. To minimize the changes,

[GitHub] spark issue #17241: [SPARK-19877][SQL] Restrict the nested level of a view

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17241 **[Test build #74483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74483/testReport)** for PR 17241 at commit

[GitHub] spark issue #17270: [SPARK-19929] [SQL] Showing Hive Managed table's LOATION...

2017-03-13 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17270 @gatorsmile cc ,is it reasonable? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105822080 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/KeyedState.scala --- @@ -61,25 +65,50 @@ import

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105821698 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -298,12 +368,14 @@ class KeyValueGroupedDataset[K, V]

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105823059 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala --- @@ -0,0 +1,270 @@ +/* + *

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105822317 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/KeyedState.scala --- @@ -61,25 +65,50 @@ import

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105822109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/KeyedState.scala --- @@ -61,25 +65,50 @@ import

[GitHub] spark pull request #17179: [SPARK-19067][SS] Processing-time-based timeout i...

2017-03-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17179#discussion_r105821496 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -249,6 +250,43 @@ class KeyValueGroupedDataset[K, V]

[GitHub] spark pull request #17240: [SPARK-19915][SQL] Improve join reorder: simplify...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17240#discussion_r105823209 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -122,46 +119,48 @@ case class

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74476/ Test PASSed. ---

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #74476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74476/testReport)** for PR 16867 at commit

[GitHub] spark pull request #17240: [SPARK-19915][SQL] Improve join reorder: simplify...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17240#discussion_r105822819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -122,46 +119,48 @@ case class

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74475/ Test PASSed. ---

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #74475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74475/testReport)** for PR 16867 at commit

[GitHub] spark pull request #17240: [SPARK-19915][SQL] Improve join reorder: simplify...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17240#discussion_r105822517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -122,46 +119,48 @@ case class

[GitHub] spark issue #17233: [SPARK-11569][ML] Fix StringIndexer to handle null value...

2017-03-13 Thread crackcell
Github user crackcell commented on the issue: https://github.com/apache/spark/pull/17233 @jkbradley Hi, I have made some updates according to your comments, please review it again. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #17240: [SPARK-19915][SQL] Improve join reorder: simplify...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17240#discussion_r105821744 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -87,8 +84,8 @@ case class

[GitHub] spark pull request #17278: [SPARK-19933][SQL] Do not change output of a subq...

2017-03-13 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17278#discussion_r105821394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -140,7 +140,8 @@ abstract class

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17277 **[Test build #74482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74482/testReport)** for PR 17277 at commit

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105820580 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -642,18 +644,34 @@ case class ShowTablesCommand(

[GitHub] spark issue #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ... PART...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16373 **[Test build #74481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74481/testReport)** for PR 16373 at commit

[GitHub] spark issue #17277: [SPARK-19887][SQL] dynamic partition keys can be null or...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17277 **[Test build #74480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74480/testReport)** for PR 17277 at commit

[GitHub] spark issue #17194: [SPARK-19851] Add new aggregates EVERY and ANY (SOME).

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17194 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74478/ Test FAILed. ---

[GitHub] spark issue #17194: [SPARK-19851] Add new aggregates EVERY and ANY (SOME).

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17194 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17194: [SPARK-19851] Add new aggregates EVERY and ANY (SOME).

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17194 **[Test build #74478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74478/testReport)** for PR 17194 at commit

[GitHub] spark pull request #17233: [SPARK-11569][ML] Fix StringIndexer to handle nul...

2017-03-13 Thread crackcell
Github user crackcell commented on a diff in the pull request: https://github.com/apache/spark/pull/17233#discussion_r105820314 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -188,35 +189,45 @@ class StringIndexerModel (

[GitHub] spark pull request #17233: [SPARK-11569][ML] Fix StringIndexer to handle nul...

2017-03-13 Thread crackcell
Github user crackcell commented on a diff in the pull request: https://github.com/apache/spark/pull/17233#discussion_r105820279 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala --- @@ -122,6 +122,86 @@ class StringIndexerSuite

[GitHub] spark pull request #17233: [SPARK-11569][ML] Fix StringIndexer to handle nul...

2017-03-13 Thread crackcell
Github user crackcell commented on a diff in the pull request: https://github.com/apache/spark/pull/17233#discussion_r105820283 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala --- @@ -122,6 +122,86 @@ class StringIndexerSuite

[GitHub] spark pull request #16373: [SPARK-18961][SQL] Support `SHOW TABLE EXTENDED ....

2017-03-13 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16373#discussion_r105819853 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -925,6 +925,26 @@ class DDLSuite extends QueryTest with

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15628 **[Test build #74479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74479/consoleFull)** for PR 15628 at commit

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17186 @sameeragarwal Thanks for the comment. I've updated `InferFiltersFromConstraints`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #17274: [SPARK-19925][SPARKR] Fix SparkR spark.getSparkFi...

2017-03-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17274#discussion_r105818725 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -177,6 +177,13 @@ test_that("add and get file to be downloaded with Spark job on every node",

[GitHub] spark pull request #17251: [SPARK-19910][SQL] `stack` should not reject NULL...

2017-03-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17251#discussion_r105818676 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -590,6 +591,22 @@ object TypeCoercion { }

[GitHub] spark pull request #17186: [SPARK-19846][SQL] Add a flag to disable constrai...

2017-03-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17186#discussion_r105818486 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -190,6 +190,15 @@ object SQLConf { .booleanConf

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-13 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 Good point @budde. I can think of two options: 1. Leave it as a constructor param 2. Make the `Builder` class non-generic and have the `build` function take the message handler:

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74473/ Test PASSed. ---

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17186 **[Test build #74473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74473/testReport)** for PR 17186 at commit

[GitHub] spark issue #17240: [SPARK-19915][SQL] Improve join reorder: simplify cost e...

2017-03-13 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17240 @nsyca Thanks. I know there could be such cases when size is also useful. However, usually big tables (fact table) have more columns than small tables, so cardinality and size is positively

[GitHub] spark pull request #17186: [SPARK-19846][SQL] Add a flag to disable constrai...

2017-03-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17186#discussion_r105815354 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -190,6 +190,15 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17240: [SPARK-19915][SQL] Improve join reorder: simplify...

2017-03-13 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17240#discussion_r105815087 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -204,63 +206,37 @@ object JoinReorderDP

[GitHub] spark pull request #14547: [SPARK-16718][MLlib] gbm-style treeboost

2017-03-13 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/14547#discussion_r105814881 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impurity/ApproxBernoulliImpurity.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #17272: [SPARK-19724][SQL]create a managed table with an existed...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17272 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74472/ Test FAILed. ---

[GitHub] spark issue #17272: [SPARK-19724][SQL]create a managed table with an existed...

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17272 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17272: [SPARK-19724][SQL]create a managed table with an existed...

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17272 **[Test build #74472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74472/testReport)** for PR 17272 at commit

[GitHub] spark issue #17277: [SPARK-19887][SQL] null is a valid partition value

2017-03-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17277 Found a JIRA https://issues.apache.org/jira/browse/IMPALA-252 to explain how IMPALA handles it. **Static partition keys may not be NULL or the empty string** So `INSERT INTO TABLE

[GitHub] spark pull request #17283: [SPARK-19940][ML][MINOR] FPGrowthModel.transform ...

2017-03-13 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17283#discussion_r105813634 --- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala --- @@ -103,6 +103,22 @@ class FPGrowthSuite extends SparkFunSuite with

[GitHub] spark pull request #17283: [SPARK-19940][ML][MINOR] FPGrowthModel.transform ...

2017-03-13 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17283#discussion_r105813424 --- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala --- @@ -103,6 +103,22 @@ class FPGrowthSuite extends SparkFunSuite with

[GitHub] spark pull request #17283: [SPARK-19940][ML][MINOR] FPGrowthModel.transform ...

2017-03-13 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17283#discussion_r105813550 --- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala --- @@ -103,6 +103,22 @@ class FPGrowthSuite extends SparkFunSuite with

[GitHub] spark issue #17194: [SPARK-19851] Add new aggregates EVERY and ANY (SOME).

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17194 **[Test build #74478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74478/testReport)** for PR 17194 at commit

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15628 **[Test build #74477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74477/testReport)** for PR 15628 at commit

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74477/ Test FAILed. ---

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15628 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15628: [SPARK-17471][ML] Add compressed method to ML matrices

2017-03-13 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15628 @dbtsai Let me know your thoughts on the comments I left. Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

  1   2   3   4   5   6   >