[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17713 **[Test build #78512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78512/testReport)** for PR 17713 at commit [`b91aea2`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #17455: [Spark-20044][Web UI] Support Spark UI behind front-end ...

2017-06-23 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17455 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78518/testReport)** for PR 18320 at commit [`6db1f61`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78518/ Test PASSed. ---

[GitHub] spark issue #18398: [MINOR][DOCS] Docs in DataFrameNaFunctions.scala use wro...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18398 **[Test build #3807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3807/testReport)** for PR 18398 at commit [`6c6df33`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18386 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78511/ Test PASSed. ---

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18386 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18386 **[Test build #78511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78511/testReport)** for PR 18386 at commit [`bb8348d`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16818: [SPARK-19451][SQL][Core] Underlying integer overflow in ...

2017-06-23 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/16818 ping @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78519/testReport)** for PR 18320 at commit [`7d61153`](https://github.com/apache/spark/commit/7d

[GitHub] spark issue #18329: [SPARK-19909][SS] Disabling the usage of a temporary dir...

2017-06-23 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18329 CC @zsxwing @tdas would you please help to review this PR? Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78517/ Test PASSed. ---

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78517/testReport)** for PR 18320 at commit [`53e00d7`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #18329: [SPARK-19909][SS] Disabling the usage of a tempor...

2017-06-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18329#discussion_r123705179 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -235,6 +239,21 @@ final class DataStreamWriter[T] private[

[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...

2017-06-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18195 @vivekdixit05 I'm working on another PR https://github.com/apache/spark/pull/18266, That may be more general. I'll finish it soon. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request #18391: [SPARK-21180][SQL] Remove conf from stats functio...

2017-06-23 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18391#discussion_r123704083 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -436,7 +436,7 @@ case class CatalogRelation( crea

[GitHub] spark issue #18182: [SPARK-20959][CORE]Add a parameter to UnsafeExternalSort...

2017-06-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18182 Would it be possible to add performance results with different parameter sizes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18329: [SPARK-19909][SS] Disabling the usage of a tempor...

2017-06-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/18329#discussion_r123702984 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -235,6 +239,21 @@ final class DataStreamWriter[T] private[s

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78518/testReport)** for PR 18320 at commit [`6db1f61`](https://github.com/apache/spark/commit/6d

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123701851 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,51 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18391: [SPARK-21180][SQL] Remove conf from stats functio...

2017-06-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18391#discussion_r123700768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -436,7 +436,7 @@ case class CatalogRelation( crea

[GitHub] spark pull request #18327: [SPARK-21047] Add test suites for complicated cas...

2017-06-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18327#discussion_r123700448 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala --- @@ -739,6 +739,157 @@ class ColumnarBatchSuite exten

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123700234 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,51 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18329: [SPARK-19909][SS] Disabling the usage of a tempor...

2017-06-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18329#discussion_r123698342 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -235,6 +239,21 @@ final class DataStreamWriter[T] private[

[GitHub] spark pull request #18329: [SPARK-19909][SS] Disabling the usage of a tempor...

2017-06-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18329#discussion_r123698373 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -17,17 +17,21 @@ package org.apache.spark.sql.s

[GitHub] spark pull request #18329: [SPARK-19909][SS] Disabling the usage of a tempor...

2017-06-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18329#discussion_r123698894 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -553,6 +554,32 @@ class StreamSuite extends StreamTest {

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78517/testReport)** for PR 18320 at commit [`53e00d7`](https://github.com/apache/spark/commit/53

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #18322: [SPARK-21115][Core]If the cores left is less than the co...

2017-06-23 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18322 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] spark issue #18235: [SPARK-21012][Submit] Add glob support for resources add...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18235 **[Test build #78516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78516/testReport)** for PR 18235 at commit [`9ae5bf2`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve diskWriteBufferSize configura...

2017-06-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18174 @gatorsmile Can you review this code. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18182: [SPARK-20959][CORE]Add a parameter to UnsafeExternalSort...

2017-06-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18182 @gatorsmile Can you review this code. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18392: [SPARK-21181] Release byteBuffers to suppress netty erro...

2017-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18392 Oops yeah @dhruve you need to open vs master and this can be closed. You can just do it and see what the tests say here. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #18348: [SPARK-21120][CORE] Increasing the master's metric is co...

2017-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18348 I don't know enough about the need for this change to review or merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #18384: [SPARK-21170] [CORE] Utils.tryWithSafeFinallyAndFailureC...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18384 **[Test build #3808 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3808/testReport)** for PR 18384 at commit [`371933d`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78513/ Test FAILed. ---

[GitHub] spark issue #18398: [MINOR][DOCS] Docs in DataFrameNaFunctions.scala use wro...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18398 **[Test build #3807 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3807/testReport)** for PR 18398 at commit [`6c6df33`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #18396: [DO-NOT-MERGE][SPARK-21145][SS] Added StateStoreProvider...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18396 For warnings becoming errors, I described this in https://issues.apache.org/jira/browse/SPARK-20840 with my tests and observations. Given my investigation, the root cause is, Javadoc8 produces b

[GitHub] spark issue #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18323 **[Test build #78515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78515/testReport)** for PR 18323 at commit [`5c3ecee`](https://github.com/apache/spark/commit/5c

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78510/ Test FAILed. ---

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18320 right, thanks! none of my comment would suggest code changes - they should all be comment changes, feel free to not restart all tests --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123688817 --- Diff: R/pkg/R/functions.R --- @@ -833,21 +838,21 @@ setMethod("hour", column(jc) }) -#' initcap -#'

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123688686 --- Diff: R/pkg/R/functions.R --- @@ -635,20 +651,16 @@ setMethod("dayofyear", column(jc) }) -#' decode -#'

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123690298 --- Diff: R/pkg/R/functions.R --- @@ -2976,19 +2918,12 @@ setMethod("regexp_replace", column(jc) }) -#' rpad

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123688605 --- Diff: R/pkg/R/functions.R --- @@ -635,20 +651,16 @@ setMethod("dayofyear", column(jc) }) -#' decode -#'

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123690523 --- Diff: R/pkg/R/functions.R --- @@ -86,6 +86,22 @@ NULL #' df <- createDataFrame(data.frame(time = as.POSIXct(dts), y = y))} NULL +

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r12369 --- Diff: R/pkg/R/functions.R --- @@ -2700,19 +2656,14 @@ setMethod("expr", signature(x = "character"), column(jc) })

[GitHub] spark pull request #18327: [SPARK-21047] Add test suites for complicated cas...

2017-06-23 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18327#discussion_r123690164 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala --- @@ -739,6 +739,157 @@ class ColumnarBatchSuite e

[GitHub] spark issue #18327: [SPARK-21047] Add test suites for complicated cases in C...

2017-06-23 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18327 @cloud-fan Thanks a lot for taking time review this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18327: [SPARK-21047] Add test suites for complicated cases in C...

2017-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18327 LGTM pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark pull request #18355: [SPARK-21145][SS] Added StateStoreProviderId with...

2017-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18327: [SPARK-21047] Add test suites for complicated cases in C...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18327 **[Test build #78514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78514/testReport)** for PR 18327 at commit [`ed210fb`](https://github.com/apache/spark/commit/ed

[GitHub] spark issue #18355: [SPARK-21145][SS] Added StateStoreProviderId with queryR...

2017-06-23 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18355 Merging this to master. Thank you @zsxwing for reviewing and @HyukjinKwon for suggesting the workaround to the unidoc issue. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #18396: [DO-NOT-MERGE][SPARK-21145][SS] Added StateStoreProvider...

2017-06-23 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18396 @HyukjinKwon But why did this change in StreamTests change all the warnings to errors? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 I will re-check these after addressing the comments: Mac OS - [ ] jobs with many stages - https://github.com/apache/spark/pull/18320#issuecomment-310312766 - [ ] jobs with long

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123688218 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,51 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78513/testReport)** for PR 18320 at commit [`53e00d7`](https://github.com/apache/spark/commit/53

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123681647 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,40 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123686953 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,54 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123686706 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,54 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123687096 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,54 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18320#discussion_r123682838 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -30,8 +30,51 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT")) inputCon <- socketConnection(

[GitHub] spark issue #18399: [SPARK-21189][INFRA] Handle unknown error codes in Jenki...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18399 Fortunately, I got the real -9 error in https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78506/testReport/. I believe this can be an example. --- If your project is set up fo

[GitHub] spark issue #17713: [SPARK-20417][SQL] Move subquery error handling to check...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17713 **[Test build #78512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78512/testReport)** for PR 17713 at commit [`b91aea2`](https://github.com/apache/spark/commit/b9

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18386 **[Test build #78511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78511/testReport)** for PR 18386 at commit [`bb8348d`](https://github.com/apache/spark/commit/bb

[GitHub] spark issue #18399: [SPARK-21189][INFRA] Handle unknown error codes in Jenki...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18399 cc @srowen and @joshrosen, could you take a look and see if makes sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18386 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78510/testReport)** for PR 18320 at commit [`53e00d7`](https://github.com/apache/spark/commit/53

[GitHub] spark issue #18399: [WIP][INFRA] Handle unknown error codes in Jenkins rathe...

2017-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18399 **[Test build #78509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78509/testReport)** for PR 18399 at commit [`cbf3517`](https://github.com/apache/spark/commit/cb

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/18281 >Also, as a result of this, the parallelism parameter is not currently persisted. I think that is fine, it's not a model parameter --- If your project is set up for it, you can reply t

[GitHub] spark issue #18399: [WIP][INFRA] Handle unknown error codes in Jenkins rathe...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18399 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark pull request #18391: [SPARK-21180][SQL] Remove conf from stats functio...

2017-06-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18391#discussion_r123685232 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationTestBase.scala --- @@ -21,14 +21,21 @@ import org.apa

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #18320: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 retest this please. I don't think this PR caused that -9 issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/18281 @ajaysaini725 , I was just about to update my PR with an updated trait that makes some small improvements when I saw you're update. I'll post what I have in case if you would like to use it her

[GitHub] spark pull request #18391: [SPARK-21180][SQL] Remove conf from stats functio...

2017-06-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18391#discussion_r123685174 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/AggregateEstimationSuite.scala --- @@ -100,17 +100,22 @@ class Aggre

[GitHub] spark pull request #18391: [SPARK-21180][SQL] Remove conf from stats functio...

2017-06-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18391#discussion_r123684392 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala --- @@ -113,12 +113,18 @@ class Basi

[GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)

2017-06-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18106#discussion_r123684235 --- Diff: python/pyspark/sql/functions.py --- @@ -1028,20 +1028,28 @@ def to_timestamp(col, format=None): @since(1.5) -def trunc(dat

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683930 --- Diff: python/pyspark/ml/tests.py --- @@ -1229,11 +1229,22 @@ def test_output_columns(self): (2.0, Vecto

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123675948 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -271,17 +274,40 @@ object OneVsRestModel extends MLReadable[On

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123682836 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683993 --- Diff: python/pyspark/ml/tests.py --- @@ -1229,11 +1229,22 @@ def test_output_columns(self): (2.0, Vecto

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683590 --- Diff: python/pyspark/ml/tests.py --- @@ -951,7 +951,7 @@ def test_onevsrest(self): (2.0, Vectors.dense(

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123682465 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683481 --- Diff: python/pyspark/ml/classification.py --- @@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams, MLReadable, MLWritable):

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123682228 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -325,20 +359,28 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123676033 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -325,20 +359,28 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123684075 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683914 --- Diff: python/pyspark/ml/tests.py --- @@ -1215,7 +1215,7 @@ def test_copy(self): (2.0, Vectors.dense(0.5

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123683303 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123682949 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18386: [SPARK-21165] [SQL] [2.2] Use executedPlan instead of an...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18106: [SPARK-20754][SQL] Support TRUNC (number)

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18106 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78507/ Test FAILed. ---

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-06-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r123682535 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ParallelismParam.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark issue #18399: [WIP][INFRA] Handle unknown error codes in Jenkins rathe...

2017-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18399 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

<    1   2   3   4   5   6   >