[GitHub] spark pull request #18751: [SPARK-21548][SQL]Support insert into serial colu...

2017-07-27 Thread lvdongr
Github user lvdongr closed the pull request at: https://github.com/apache/spark/pull/18751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18610: [SPARK-21386] ML LinearRegression supports warm s...

2017-07-27 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/18610#discussion_r130015435 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -309,6 +313,23 @@ private[ml] object DefaultParamsWriter { val

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18754 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18754 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80014/ Test FAILed. ---

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18754 **[Test build #80014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80014/testReport)** for PR 18754 at commit

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80012/ Test PASSed. ---

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18540 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18540 **[Test build #80012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80012/testReport)** for PR 18540 at commit

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 Will address comments within few days. (I am reading docs just to get used to things around my updated status) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #18695: [SPARK-12717][PYTHON] Adding thread-safe broadcast pickl...

2017-07-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18695 The change LGTM. Will it be hard to add a reliable test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-27 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18655 @BryanCutler @wesm @cpcloud I filed a JIRA issue for decimal type support [SPARK-21552](https://issues.apache.org/jira/browse/SPARK-21552) and sent a pr for it as WIP #18754. Let's move on there

[GitHub] spark issue #18755: [SPARK-21553][Spark Shell] Added the description of the ...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18755 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18754 **[Test build #80014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80014/testReport)** for PR 18754 at commit

[GitHub] spark pull request #18755: [SPARK-21553][Spark Shell] Added the description ...

2017-07-27 Thread davidxdh
GitHub user davidxdh opened a pull request: https://github.com/apache/spark/pull/18755 [SPARK-21553][Spark Shell] Added the description of the default value of master parameter in the spark-shell When I type spark-shell --help, I find that the default value description for the

[GitHub] spark pull request #18754: [WIP][SPARK-21552][SQL] Add DecimalType support t...

2017-07-27 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/18754 [WIP][SPARK-21552][SQL] Add DecimalType support to ArrowWriter. ## What changes were proposed in this pull request? Decimal type is not yet supported in `ArrowWriter`. This is adding

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/17435 @szalai1 Could you fix tests if you're still working on this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17435 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17435 **[Test build #80013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80013/testReport)** for PR 17435 at commit

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17435 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80013/ Test FAILed. ---

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18185 @gatorsmile ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80011/ Test PASSed. ---

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #80011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80011/testReport)** for PR 18185 at commit

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17435 **[Test build #80013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80013/testReport)** for PR 17435 at commit

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-07-27 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/17435 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18753: [SPARK-21548] [SQL] Support insert into serial columns o...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18753 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18753: [SPARK-21548] [SQL] Support insert into serial co...

2017-07-27 Thread lvdongr
GitHub user lvdongr opened a pull request: https://github.com/apache/spark/pull/18753 [SPARK-21548] [SQL] Support insert into serial columns of table ## What changes were proposed in this pull request? When we use the 'insert into ...' statement we can only insert all the

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18468 @cloud-fan how will we go forward? @rxin seems to have no comment for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18725 Can the current fix work for the case like the following? Project [a] Filter [rand() > 1] TableScan [a, b, c] `PhysicalOperation` still fails for

[GitHub] spark issue #18525: [SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' pa...

2017-07-27 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18525 @ajbozarth Okay.Thanks. @srowen Help review the code.Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18725: [SPARK-21520][SQL]Hivetable scan for all the colu...

2017-07-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18725#discussion_r13082 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -495,6 +495,23 @@ object ColumnPruning extends

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-27 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/18554 Merged into master, thanks for all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18540 **[Test build #80012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80012/testReport)** for PR 18540 at commit

[GitHub] spark pull request #17203: [SPARK-19863][DStream] Whether or not use CachedK...

2017-07-27 Thread lvdongr
Github user lvdongr closed the pull request at: https://github.com/apache/spark/pull/17203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-07-27 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r129998159 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala --- @@ -33,4 +33,13 @@ class HiveUtilsSuite extends QueryTest with

[GitHub] spark pull request #18610: [SPARK-21386] ML LinearRegression supports warm s...

2017-07-27 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18610#discussion_r129997548 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -309,6 +313,23 @@ private[ml] object DefaultParamsWriter { val

[GitHub] spark pull request #18725: [SPARK-21520][SQL]Hivetable scan for all the colu...

2017-07-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18725#discussion_r129997298 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -495,6 +495,23 @@ object ColumnPruning extends

[GitHub] spark pull request #18725: [SPARK-21520][SQL]Hivetable scan for all the colu...

2017-07-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18725#discussion_r129997034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -495,6 +495,23 @@ object ColumnPruning extends

[GitHub] spark issue #16648: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/16648 ping @bdrillard for the 2nd part of this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #80011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80011/testReport)** for PR 18185 at commit

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r129989469 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/HasParallelism.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r129989379 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r129989332 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -294,6 +296,18 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark issue #18745: [SPARK-21544][DEPLOY] Tests jar of some module should no...

2017-07-27 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/18745 cc @srowen Test done,any more problem?Thanks too much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-07-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18281 @holdenk Some of those improvements on handling parallelism sounds useful, but I'd prefer we merge this and then add more improvements. This PR should be a strict improvement there (moving from

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80010/ Test FAILed. ---

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #80010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80010/testReport)** for PR 18185 at commit

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #80010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80010/testReport)** for PR 18185 at commit

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18185 Thanks! Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #18740: [SPARK-21538][SQL] Attribute resolution inconsist...

2017-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18740 Thanks! Merging to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #18725: [SPARK-21520][SQL]Hivetable scan for all the colu...

2017-07-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18725#discussion_r129984515 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -495,6 +495,23 @@ object ColumnPruning extends

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r129982672 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala --- @@ -101,6 +101,45 @@ class OneVsRestSuite extends

[GitHub] spark issue #18652: [SPARK-21497][SQL] Pull non-deterministic equi join keys...

2017-07-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18652 @gatorsmile Actually it is not rare we add a feature step by step in SparkSQL. This is not a reason preventing us from adding this support. I think this change already help much this kind of

[GitHub] spark issue #17180: [SPARK-19839][Core]release longArray in BytesToBytesMap

2017-07-27 Thread zhzhan
Github user zhzhan commented on the issue: https://github.com/apache/spark/pull/17180 retest it please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18752: [SPARK-21551][Python] Increase timeout for PythonRDD.ser...

2017-07-27 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18752 cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18752: [SPARK-21551][Python] Increase timeout for PythonRDD.ser...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18752 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18752: [SPARK-21551][Python] Increase timeout for Python...

2017-07-27 Thread peay
GitHub user peay opened a pull request: https://github.com/apache/spark/pull/18752 [SPARK-21551][Python] Increase timeout for PythonRDD.serveIterator ## What changes were proposed in this pull request? This modification increases the timeout for `serveIterator` (which is

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18740 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18740 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80009/ Test PASSed. ---

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18740 **[Test build #80009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80009/testReport)** for PR 18740 at commit

[GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18664 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80008/ Test FAILed. ---

[GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18664 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18664 **[Test build #80008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80008/testReport)** for PR 18664 at commit

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r129946652 --- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala --- @@ -322,6 +324,291 @@ class SparkConfSuite extends SparkFunSuite with

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18185 LGTM except a few minor comments. Thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18750: Skip maven-compiler-plugin main and test compilations in...

2017-07-27 Thread gslowikowski
Github user gslowikowski commented on the issue: https://github.com/apache/spark/pull/18750 Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18185#discussion_r129944781 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -859,6 +859,22 @@ class Analyzer( //

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18185#discussion_r129944055 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -423,6 +423,26 @@ case class UnresolvedAlias(

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18185#discussion_r129943797 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -423,6 +423,26 @@ case class UnresolvedAlias(

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18185#discussion_r129943216 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -423,6 +423,26 @@ case class UnresolvedAlias(

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18185#discussion_r129943038 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -750,20 +750,28 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18740 LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18740 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18740 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80007/ Test PASSed. ---

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18740 **[Test build #80007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80007/testReport)** for PR 18740 at commit

[GitHub] spark pull request #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes exam...

2017-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18749#discussion_r129927520 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java --- @@ -26,6 +26,10 @@ private String name;

[GitHub] spark pull request #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes exam...

2017-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18749#discussion_r129929153 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java --- @@ -29,15 +29,40 @@ * show the usage of

[GitHub] spark pull request #18659: [SPARK-21404][PYSPARK][WIP] Simple Python Vectori...

2017-07-27 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/18659#discussion_r129928163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -132,6 +135,61 @@ private[sql] object

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18740 **[Test build #80009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80009/testReport)** for PR 18740 at commit

[GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18664 **[Test build #80008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80008/testReport)** for PR 18664 at commit

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 cc @rxin, @srowen and @cloud-fan, I believe this one is ready for a review. Could you take a look when you have some time? --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18540 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18540 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80006/ Test FAILed. ---

[GitHub] spark issue #18540: [SPARK-19451][SQL] rangeBetween method should accept Lon...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18540 **[Test build #80006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80006/testReport)** for PR 18540 at commit

[GitHub] spark pull request #18740: [SPARK-21538][SQL] Attribute resolution inconsist...

2017-07-27 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/18740#discussion_r129911780 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1304,6 +1304,15 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #18740: [SPARK-21538][SQL] Attribute resolution inconsist...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18740#discussion_r129906375 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -1304,6 +1304,15 @@ class DatasetSuite extends QueryTest with

[GitHub] spark issue #18745: [SPARK-21544][DEPLOY] Tests jar of some module should no...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18745 **[Test build #3853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3853/testReport)** for PR 18745 at commit

[GitHub] spark issue #18740: [SPARK-21538][SQL] Attribute resolution inconsistency in...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18740 **[Test build #80007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80007/testReport)** for PR 18740 at commit

[GitHub] spark issue #18749: [WIP][SPARK-21485][FOLLOWUP][SQL][DOCS] Describes exampl...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18749 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18749: [WIP][SPARK-21485][FOLLOWUP][SQL][DOCS] Describes exampl...

2017-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18749 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80004/ Test PASSed. ---

[GitHub] spark issue #18749: [WIP][SPARK-21485][FOLLOWUP][SQL][DOCS] Describes exampl...

2017-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18749 **[Test build #80004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80004/testReport)** for PR 18749 at commit

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129669738 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -131,94 +132,35 @@ private[spark] class EventLoggingListener(

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129889123 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListenerBus.scala --- @@ -27,7 +27,12 @@ private[spark] trait SparkListenerBus

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129659027 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2379,8 +2382,13 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129886931 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -139,30 +148,60 @@ private[spark] class LiveListenerBus(conf:

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129879433 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -39,98 +39,107 @@ import org.apache.spark.util.Utils * has

[GitHub] spark pull request #18253: [SPARK-18838][CORE] Introduce multiple queues in ...

2017-07-27 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/spark/pull/18253#discussion_r129659490 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -532,7 +533,10 @@ class SparkContext(config: SparkConf) extends Logging {

  1   2   3   >