[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146177319 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146177284 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -24,6 +24,7 @@ import org.apache.spark.sql.cata

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146177263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146177196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146177053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predi

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146176760 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146176626 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -24,6 +24,7 @@ import org.apache.spark.sql.cata

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146176609 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends P

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19548 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19548 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82968/ Test PASSed. ---

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19548 **[Test build #82968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82968/testReport)** for PR 19548 at commit [`28c7ce8`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserF...

2017-10-22 Thread sjrand
Github user sjrand closed the pull request at: https://github.com/apache/spark/pull/19554 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread sjrand
Github user sjrand commented on the issue: https://github.com/apache/spark/pull/19554 Thanks @jerryshao. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19554 @sjrand would you please close this PR, it is already merged to branch 2.2. --- - To unsubscribe, e-mail: reviews-unsubscr...@s

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19554 Thanks, merging to branch 2.2. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19554 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82967/ Test PASSed. ---

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19554 **[Test build #82967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82967/testReport)** for PR 19554 at commit [`def29a1`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146169405 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146168734 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") ( @Since("2.2

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146168660 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19439 @thunterdb Thanks for the reply. > It does, indirectly: this is what the field types CV_32FXX do. You need to do some low-level casting to convert the byte array to array of numbers, but th

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146167919 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") ( @Sinc

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146167706 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, li

[GitHub] spark issue #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squared_hin...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17862 Thanks @WeichenXu123 for the comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146166006 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") ( @Since("2.2

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146165706 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") ( @Since("2.2

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

2017-10-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146165449 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r146163447 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r146163650 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r146164215 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r146163724 --- Diff: python/pyspark/ml/image.py --- @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-22 Thread nkronenfeld
Github user nkronenfeld commented on the issue: https://github.com/apache/spark/pull/19529 Documentation removed as per @srowen 's request in the associated JIRA issue [SPARK-22308] --- - To unsubscribe, e-mail: re

[GitHub] spark issue #19529: [SPARK-22308] Support alternative unit testing styles in...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19529 **[Test build #82969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82969/testReport)** for PR 19529 at commit [`4218b86`](https://github.com/apache/spark/commit/42

[GitHub] spark issue #19506: [SPARK-22285] [SQL] Change implementation of ApproxCount...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19506 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82966/ Test PASSed. ---

[GitHub] spark issue #19506: [SPARK-22285] [SQL] Change implementation of ApproxCount...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19506 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19506: [SPARK-22285] [SQL] Change implementation of ApproxCount...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19506 **[Test build #82966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82966/testReport)** for PR 19506 at commit [`1e95a2f`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #19551: [WIP][SPARK-17902][R] Revive stringsAsFactors opt...

2017-10-22 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/19551#discussion_r146160321 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -499,6 +499,12 @@ test_that("create DataFrame with different data types", { expect_equal(collec

[GitHub] spark pull request #19551: [WIP][SPARK-17902][R] Revive stringsAsFactors opt...

2017-10-22 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/19551#discussion_r146160421 --- Diff: R/pkg/R/DataFrame.R --- @@ -1191,6 +1191,9 @@ setMethod("collect", vec <- do.call(c, col) stopifno

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread taroplus
Github user taroplus commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146160084 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -815,6 +815,12 @@ class JDBCSuite extends SparkFunSuite Some(

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread taroplus
Github user taroplus commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146160039 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -108,6 +112,10 @@ class OracleInt

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread taroplus
Github user taroplus commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146160051 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -307,4 +315,32 @@ class OracleInt

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread taroplus
Github user taroplus commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146160013 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -50,9 +52,11 @@ import org.apache

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19548 **[Test build #82968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82968/testReport)** for PR 19548 at commit [`28c7ce8`](https://github.com/apache/spark/commit/28

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread taroplus
Github user taroplus commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146159980 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala --- @@ -28,25 +28,28 @@ private case object OracleDialect extends JdbcDiale

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19554 **[Test build #82967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82967/testReport)** for PR 19554 at commit [`def29a1`](https://github.com/apache/spark/commit/de

[GitHub] spark issue #19554: [SPARK-22319][Core][BACKPORT-2.2] call loginUserFromKeyt...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19554 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@sp

[GitHub] spark issue #19554: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19554 Can you please add a tag in PR title `[BACKPORT-2.2]`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For a

[GitHub] spark issue #19554: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19554 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19554: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19554 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@sp

[GitHub] spark pull request #19554: [SPARK-22319][Core] call loginUserFromKeytab befo...

2017-10-22 Thread sjrand
GitHub user sjrand opened a pull request: https://github.com/apache/spark/pull/19554 [SPARK-22319][Core] call loginUserFromKeytab before accessing hdfs ## What changes were proposed in this pull request? In SparkSubmit, call loginUserFromKeytab before attempting to make RPC

[GitHub] spark issue #19540: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread sjrand
Github user sjrand commented on the issue: https://github.com/apache/spark/pull/19540 Thanks @jerryshao and @jiangxb1987. Created https://github.com/apache/spark/pull/19554 for branch-2.2. --- - To unsubscribe, e-ma

[GitHub] spark pull request #18747: [SPARK-20822][SQL] Generate code to directly get ...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18747#discussion_r146157000 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -23,21 +23,70 @@ import org.apache.spark.sql.ca

[GitHub] spark pull request #18747: [SPARK-20822][SQL] Generate code to directly get ...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18747#discussion_r146156401 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -23,21 +23,70 @@ import org.apache.spark.sql.ca

[GitHub] spark pull request #18747: [SPARK-20822][SQL] Generate code to directly get ...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18747#discussion_r146155764 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -23,21 +23,70 @@ import org.apache.spark.sql.ca

[GitHub] spark issue #19534: [SPARK-22312][CORE] Fix bug in Executor allocation manag...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19534 @sitalkedia I'm OK with either. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-m

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-22 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146154530 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153590 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153739 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predic

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146152572 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -24,6 +24,7 @@ import org.apache.spark.sql.catalyst.

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146153805 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predi

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19548 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19540: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19540 @sjrand , can you please create another PR against branch-2.2, it is not auto-mergeable, thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19548 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82965/ Test PASSed. ---

[GitHub] spark pull request #19540: [SPARK-22319][Core] call loginUserFromKeytab befo...

2017-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19540 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19548 **[Test build #82965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82965/testReport)** for PR 19548 at commit [`91e911d`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #19540: [SPARK-22319][Core] call loginUserFromKeytab before acce...

2017-10-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19540 LGTM, merging to master and branch 2.2. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19527: [SPARK-13030][ML] Create OneHotEncoderEstimator for OneH...

2017-10-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19527 @BryanCutler @MLnick @WeichenXu123 Thanks for reviewing. Your comments should be all addressed now. Please take a look again when you have more time. --- ---

[GitHub] spark pull request #19527: [SPARK-13030][ML] Create OneHotEncoderEstimator f...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19527#discussion_r146153067 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoderEstimator.scala --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146152918 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -270,12 +271,25 @@ trait CheckAnalysis extends Predi

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146152895 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala --- @@ -408,16 +408,28 @@ class AnalysisErrorSuite ext

[GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...

2017-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17100#discussion_r146152740 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -24,6 +24,7 @@ import org.apache.spark.sql.catalyst

[GitHub] spark pull request #19506: [SPARK-22285] [SQL] Change implementation of Appr...

2017-10-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/19506#discussion_r146151411 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala --- @@ -239,4 +219,26 @@ case

[GitHub] spark issue #19506: [SPARK-22285] [SQL] Change implementation of ApproxCount...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19506 **[Test build #82966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82966/testReport)** for PR 19506 at commit [`1e95a2f`](https://github.com/apache/spark/commit/1e

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82964/ Test PASSed. ---

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #82964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82964/testReport)** for PR 19451 at commit [`7030ab6`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r146147996 --- Diff: core/src/test/scala/org/apache/spark/util/JavaUtils.scala --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r146147889 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala --- @@ -43,6 +43,13 @@ private[spark] object JavaUtils { override def s

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19553#discussion_r146147952 --- Diff: core/src/test/scala/org/apache/spark/util/JavaUtils.scala --- @@ -0,0 +1,37 @@ +/* --- End diff -- This class needs to be in the sa

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146147276 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -108,6 +112,10 @@ class OracleInteg

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146147286 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -50,9 +52,11 @@ import org.apache.s

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146147293 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -815,6 +815,12 @@ class JDBCSuite extends SparkFunSuite Some(De

[GitHub] spark pull request #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc ty...

2017-10-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19548#discussion_r146147267 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -307,4 +315,32 @@ class OracleInteg

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread taroplus
Github user taroplus commented on the issue: https://github.com/apache/spark/pull/19548 Okay new integration test has been added According to their [document](https://docs.oracle.com/database/121/TTSQL/types.htm#TTSQL148) > BINARY_DOUBLE is a 64-bit, double-precision

[GitHub] spark issue #19548: [SPARK-22303][SQL] Handle Oracle specific jdbc types in ...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19548 **[Test build #82965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82965/testReport)** for PR 19548 at commit [`91e911d`](https://github.com/apache/spark/commit/91

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #82964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82964/testReport)** for PR 19451 at commit [`7030ab6`](https://github.com/apache/spark/commit/70

[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19553: [SPARK-22330][CORE] Linear containsKey operation ...

2017-10-22 Thread Whoosh
GitHub user Whoosh opened a pull request: https://github.com/apache/spark/pull/19553 [SPARK-22330][CORE] Linear containsKey operation for serialized maps …alization. ## What changes were proposed in this pull request? Use non-linear containsKey operation for seria

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82962/ Test FAILed. ---

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #82962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82962/testReport)** for PR 19451 at commit [`f6c95d3`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #19552: [SPARK-22329][SQL] Use NEVER_INFER for `spark.sql.hive.c...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82961/ Test PASSed. ---

[GitHub] spark issue #19552: [SPARK-22329][SQL] Use NEVER_INFER for `spark.sql.hive.c...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19552 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19552: [SPARK-22329][SQL] Use NEVER_INFER for `spark.sql.hive.c...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19552 **[Test build #82961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82961/testReport)** for PR 19552 at commit [`a256627`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #19543: [SPARK-19606][MESOS] Support constraints in spark-dispat...

2017-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19543 **[Test build #82963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82963/testReport)** for PR 19543 at commit [`c587946`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #19543: [SPARK-19606][MESOS] Support constraints in spark-dispat...

2017-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82963/ Test PASSed. ---

  1   2   >