Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146769438
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83035/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83035/testReport)**
for PR 19572 at commit
[`95ae9c3`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83034/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19458
**[Test build #83034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83034/testReport)**
for PR 19458 at commit
[`ff9a6ae`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19572
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83036/testReport)**
for PR 19572 at commit
[`95ae9c3`](https://github.com/apache/spark/commit/95
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146771631
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #83037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83037/testReport)**
for PR 19556 at commit
[`4d8f91e`](https://github.com/apache/spark/commit/4d
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19572
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146772862
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19559
@DonnyZone Analyzer is the best place to fix the issue.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146773177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprEli
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19557
well, this change avoided the warning but disabled help too (which is
probably why it's working)
```
> showMethods("attach")
Function: attach (package base)
what="ANY"
what="S
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146773769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -277,13 +292,25 @@ class CodegenConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146774741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class CodegenConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146775221
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class CodegenConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146775448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class CodegenConte
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
@kiszk Thanks!
@mgaido91 I have not reviewed it carefully. Will do another pass in the
next few days. Thanks for your fix!
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #83038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83038/testReport)**
for PR 19557 at commit
[`8f84aa6`](https://github.com/apache/spark/commit/8f
GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/19573
[SPARK-22350][SQL] select grouping__id from subquery
## What changes were proposed in this pull request?
Currently, sql below will fail:
```
SELECT cnt, k2, k3, grouping__id
F
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19573
**[Test build #83039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83039/testReport)**
for PR 19573 at commit
[`c0ecbee`](https://github.com/apache/spark/commit/c0
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783595
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -73,6 +70,10 @@ class OrcFileFormat extends FileFormat with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146784952
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -58,10 +58,7 @@ class OrcFileFormat extends FileFormat with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783934
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2127,4 +2127,18 @@ class SQLQuerySuite extends QueryT
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783308
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -252,6 +253,13 @@ private[orc] class OrcOutputWriter(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19550
@felixcheung, are we okay to merge this alone in branch-2.0?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #83038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83038/testReport)**
for PR 19557 at commit
[`8f84aa6`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83038/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146796399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprElimi
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146799989
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LD
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19553
Ping @Whoosh
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spar
Github user rberenguel commented on the issue:
https://github.com/apache/spark/pull/17100
Thanks @gatorsmile @holdenk @viirya @wzhfy for all the help
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19559
@gatorsmile Thank for your advice, I will work on it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For ad
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146804206
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146810442
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LD
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146812501
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19566
@vanzin
I tested your patch. It worked.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional c
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17100
Congratulations on your change @rberenguel :D :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #83037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83037/testReport)**
for PR 19556 at commit
[`4d8f91e`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83036/testReport)**
for PR 19572 at commit
[`95ae9c3`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83037/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83036/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146820166
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19565
**[Test build #83040 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83040/testReport)**
for PR 19565 at commit
[`40685ee`](https://github.com/apache/spark/commit/40
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/10466
@hhbyyh OK. i will take this over. Our team need this feature now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.a
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19426
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19426
**[Test build #83041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83041/testReport)**
for PR 19426 at commit
[`ca43764`](https://github.com/apache/spark/commit/ca
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19426
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83041/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19426
**[Test build #83041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83041/testReport)**
for PR 19426 at commit
[`ca43764`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19426
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19573
**[Test build #83039 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83039/testReport)**
for PR 19573 at commit
[`c0ecbee`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19573
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19573
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83039/
Test PASSed.
---
Github user superbobry commented on the issue:
https://github.com/apache/spark/pull/19458
@jerryshao the error looks a bit unrelated.
```
sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: null
```
The suite passes locally for me.
---
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17813#discussion_r146831076
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -589,8 +605,18 @@ class CoarseGrainedSchedulerBa
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18699
And updated after being called out in a talk and Spark Summit :p
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19561
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/19561
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83042/testReport)**
for PR 18699 at commit
[`a53c460`](https://github.com/apache/spark/commit/a5
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146833044
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19565
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19565
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83040/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19565
**[Test build #83040 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83040/testReport)**
for PR 19565 at commit
[`40685ee`](https://github.com/apache/spark/commit/4
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19458
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/19565
Now I feel that filtering empty docs out in the `initialize` is not a good
idea, because it will be performed as many times, as the number of times
`sample` in `next` gets called. Right?
Al
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19458
**[Test build #83043 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83043/testReport)**
for PR 19458 at commit
[`2b61347`](https://github.com/apache/spark/commit/2b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19559
**[Test build #83044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83044/testReport)**
for PR 19559 at commit
[`c38ab56`](https://github.com/apache/spark/commit/c3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19559
**[Test build #83044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83044/testReport)**
for PR 19559 at commit
[`c38ab56`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19559
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83044/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19559
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83042/testReport)**
for PR 18699 at commit
[`a53c460`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83042/
Test PASSed.
---
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146855311
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,24 @@
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146855751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprEliminat
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146859947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -277,13 +292,25 @@ class CodegenContext
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146860250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprElimi
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Sorry for the late reply.
@srowen At this point I would like to have feedback on the design doc so we
can move forward with implementation or a formal Spark docs if people prefer.
What d
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Do people prefer google doc? I can do that too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additio
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/19565
Or (and I think it would be the most efficient approach) we can just stick
in the check for emptiness of the document to the `seqOp` of `treeAggregate`.
However, it doesn't look like "filtering out
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146864067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprEliminat
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146865925
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprElimi
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146882424
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19565
**[Test build #83045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83045/testReport)**
for PR 19565 at commit
[`1d923f5`](https://github.com/apache/spark/commit/1d
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146883884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class SubExprEliminat
Github user nkronenfeld commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146885926
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -52,17 +55,142 @@ import org.apache.spark.util.{UninterruptibleThr
Github user nkronenfeld commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146885975
--- Diff: core/src/test/scala/org/apache/spark/SharedSparkContext.scala ---
@@ -29,10 +29,25 @@ trait SharedSparkContext extends BeforeAndAfterAll with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19529
**[Test build #83046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83046/testReport)**
for PR 19529 at commit
[`24fc4a3`](https://github.com/apache/spark/commit/24
Github user nkronenfeld commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146887435
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,86 +17,8 @@
package org.apache.spark.sql.test
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19383#discussion_r146888728
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -0,0 +1,534 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83047/testReport)**
for PR 19480 at commit
[`0215139`](https://github.com/apache/spark/commit/02
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19458
**[Test build #83043 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83043/testReport)**
for PR 19458 at commit
[`2b61347`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83043/
Test FAILed.
---
1 - 100 of 450 matches
Mail list logo
