Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19559
Yes, ordering in `Sort(ordering, global, child)` is resolved in
`resolveExpression`
---
-
To unsubscribe, e-mail: reviews-unsu
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19559
`select a from t order by current_date` is not working?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19559
You do not need to close it and just need to resolve the conflicts. If you
are not familiar with it, I can wait and merge this PR first.
---
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19559
OK, I will close this PR after review and submit a new one, after merging
https://github.com/apache/spark/pull/19585
---
-
To
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19559
@gatorsmile
It seems that we should also support this logic in `resolveExpressions` for
Sort plan.
`select a from t order by current_date`
Therefore, I think current `resolveAsLiteralF
Github user DonnyZone commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147330565
--- Diff: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ---
@@ -8,3 +8,18 @@ select to_date(null), to_date('2016-12-31'),
to_date('2016-12-31'
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19559
LGTM and cc @hvanhovell for a final sign-off.
BTW, I might merge https://github.com/apache/spark/pull/19585 before this
PR. Sorry for the conflicts.
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19559
**[Test build #83111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83111/testReport)**
for PR 19559 at commit
[`a96d945`](https://github.com/apache/spark/commit/a9
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147330270
--- Diff: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ---
@@ -8,3 +8,18 @@ select to_date(null), to_date('2016-12-31'),
to_date('2016-12-31
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19559
**[Test build #83110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83110/testReport)**
for PR 19559 at commit
[`4b13343`](https://github.com/apache/spark/commit/4b
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147328834
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -267,6 +267,10 @@ private[spark] class ExecutorAllocationManager(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18664
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18664
@BryanCutler Thank you for all your hard work. We really appreciate it!
Merged to master.
---
-
To unsubscribe, e-ma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18664
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147324011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -142,6 +221,9 @@ class LinearRegression @Since("1.3.0") (@Since("
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147326457
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -344,33 +449,58 @@ class LinearRegression @Since("1.3.0")
(@Sinc
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147321334
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Softw
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147327448
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -998,6 +1047,198 @@ class LinearRegressionSuite
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147323528
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -69,25 +70,103 @@ private[regression] trait LinearRegressionParam
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147316970
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -998,6 +1047,198 @@ class LinearRegressionSuite
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147327208
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -480,10 +638,14 @@ object LinearRegression extends
DefaultParams
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147322978
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Softw
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147322642
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Softw
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147319678
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Softw
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r147321479
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Softw
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19585
**[Test build #83109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83109/testReport)**
for PR 19585 at commit
[`b23dd7b`](https://github.com/apache/spark/commit/b2
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19585
[TRIVIAL] [SQL] Code cleaning in ResolveReferences
## What changes were proposed in this pull request?
This PR is to clean the related codes majorly based on the today's code
review on http
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19585
cc @cloud-fan @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83103/
Test PASSed.
---
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147325260
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -267,6 +267,10 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83103/testReport)**
for PR 19567 at commit
[`040e369`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19584
**[Test build #83108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83108/testReport)**
for PR 19584 at commit
[`cb820d5`](https://github.com/apache/spark/commit/cb
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19584
cc @HyukjinKwon @ueshin @BryanCutler @cloud-fan To use Python UDFs in
conditional expressions breaks original semantics and possibly causes failure.
Currently this patch simply disables this usage.
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19584
[SPARK-22347][SQL] Disable PythonUDFs in conditional expressions
## What changes were proposed in this pull request?
Under the current execution mode of Python UDFs, we don't support Python
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19580
**[Test build #83107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83107/testReport)**
for PR 19580 at commit
[`8abaa2c`](https://github.com/apache/spark/commit/8a
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147320096
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -267,6 +267,10 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83102/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83102/testReport)**
for PR 19077 at commit
[`ff091a8`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #83106 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83106/testReport)**
for PR 19439 at commit
[`c4e2c48`](https://github.com/apache/spark/commit/c4
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/19439
Jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147318994
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -56,6 +56,24 @@ class DateFunctionsSuite extends QueryTest with
S
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147318831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -783,6 +783,37 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147318866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -783,6 +783,37 @@ class Analyzer(
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83105/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #83105 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83105/testReport)**
for PR 19439 at commit
[`a5f83c1`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #83105 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83105/testReport)**
for PR 19439 at commit
[`a5f83c1`](https://github.com/apache/spark/commit/a5
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147318532
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,133 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19433
After discussion and modifications, I approve this PR overall. Ping
@jkbradley Can you take a look now ?
---
-
To unsubscri
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19433#discussion_r147317401
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/LocalDecisionTree.scala ---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Softw
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147317145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Logging
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147316748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83101/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19580
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19580
**[Test build #83101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83101/testReport)**
for PR 19580 at commit
[`6f22f93`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83104/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19433
**[Test build #83104 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83104/testReport)**
for PR 19433 at commit
[`9cc6333`](https://github.com/apache/spark/commit/9
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147314628
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83100/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83100/testReport)**
for PR 19468 at commit
[`2b5dcac`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19580
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83099/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19580
**[Test build #83099 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83099/testReport)**
for PR 19580 at commit
[`e884a96`](https://github.com/apache/spark/commit/e
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147312311
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -18,7 +18,7 @@
package org.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83098/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #83098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83098/testReport)**
for PR 19439 at commit
[`838c4c0`](https://github.com/apache/spark/commit/8
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19576#discussion_r147311429
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala ---
@@ -258,6 +258,18 @@ class MathFunctionsSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19576
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19576#discussion_r147311315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -390,7 +390,7 @@ case class Cast(child: Expression, da
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147309952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Logging
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19433
**[Test build #83104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83104/testReport)**
for PR 19433 at commit
[`9cc6333`](https://github.com/apache/spark/commit/9c
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19433
Made a few updates, hereâs a quick summary/what Iâd propose moving
forward:
Right now:
* Shared row indices for all (categorical & continuous) features are stored
& updated in `Tr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83096/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19582
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147309380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Log
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19582
**[Test build #83096 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83096/testReport)**
for PR 19582 at commit
[`f73af34`](https://github.com/apache/spark/commit/f
Github user jmchung commented on the issue:
https://github.com/apache/spark/pull/19567
Thanks @HyukjinKwon :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83103/testReport)**
for PR 19567 at commit
[`040e369`](https://github.com/apache/spark/commit/04
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19567
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19567
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19433#discussion_r147307553
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/LocalDecisionTree.scala ---
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83095/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19451
**[Test build #83095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83095/testReport)**
for PR 19451 at commit
[`8bce960`](https://github.com/apache/spark/commit/8
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147305235
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -18,7 +18,7 @@
package org.a
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19567
cc @HyukjinKwon @cloud-fan Please help trigger the jenkins test if you have
time. Thanks.
---
-
To unsubscribe, e-mail: reviews-u
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147305034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,17 @@ object JdbcUtils extends Logging
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19567
@jmchung There are another StringType types "json", "jsonb" in
`PostgresDialect`. Can you also add them into tests? Thanks.
---
---
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147304200
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -267,6 +267,10 @@ private[spark] class ExecutorAllocationManager(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147303973
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -678,7 +679,9 @@ private[spark] class ExecutorAllocationManager(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19580#discussion_r147304306
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -709,7 +712,9 @@ private[spark] class ExecutorAllocationManager(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19579
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19577
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19577
Thanks! Merged to master. cc @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19579
Thanks! Merged to ...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
1 - 100 of 323 matches
Mail list logo
