Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19602#discussion_r147583510
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -53,7 +52,7 @@ class HiveClientSuite(version: String)
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19602
@gatorsmile
Thanks a lot for your help :)
>Can we just evaluate the right side CAST(2017 as STRING), since it is
foldable?
Do you mean to add a new rule ? -- cast the type
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83188/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19603
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19603
**[Test build #83188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83188/testReport)**
for PR 19603 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17819
@MLnick Is this ready to go?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19592
ping @ueshin @BryanCutler @cloud-fan Would you mind to provide some
insights? Should we add just a document for it or fix it in your opinions?
Thanks.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18251
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83187/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18251
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18251
**[Test build #83187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83187/testReport)**
for PR 18251 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147581601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147581548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147581528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147581519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83195 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83195/testReport)**
for PR 19567 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19603
Good catch! LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147581349
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -134,11 +149,28 @@ class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
For now, this implementation has an limitation only to support non-nested
array for ease of review.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19567
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147581064
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -134,11 +149,28 @@ class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19601
both ways work, just pick the simpler one. I'm concerned about how to
access the nested array, you can try both approaches and see which one can
solve the problem easier.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
I agree with you that we need to improve the write path. It will be
addressed after improving the frequently-executed read path, as you suggested
before. It will be addressed by the following PR.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19567
LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83194/testReport)**
for PR 17899 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19567
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19601
I'd like to also improve the write path. I think the current way to cache
array type is not efficient, arrow-like format which put all elements(including
nested array) together is better for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83193/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83193 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83193/testReport)**
for PR 17899 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83193/testReport)**
for PR 17899 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147580091
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147580056
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147579950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83191 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83191/testReport)**
for PR 17899 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83191/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147579883
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #83192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83192/testReport)**
for PR 19222 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147579873
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19603#discussion_r147579666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -591,18 +591,40 @@ case class MapObjects
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83191/testReport)**
for PR 17899 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
There are two approaches to support a primitive array that is treated as
binary. One is to add new `ColumnVector.Array` that I did. The other is to add
new `WritableColumnVector` like @ueshin added
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83190/testReport)**
for PR 19567 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19601
So for primitive types, we encode and compress them to binary. When reading
cached data, they are decoded to primitive array and can be put in
`OnHeadColumnVector` directly.
For
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147579149
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,10 @@ object JdbcUtils extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19601
Can we use `OffHeapColumnVector` for cached data?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83189/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83189/testReport)**
for PR 17899 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17899
**[Test build #83189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83189/testReport)**
for PR 17899 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
Current `ColumnVector` uses primitive type array (e.g. `int[]` or
`double[]`) based on data type of each column. On the other hand, cached data
uses `byte[]` for all data type.
Do we change
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15049
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19601#discussion_r147578600
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -367,9 +551,13 @@ public Object get(int ordinal,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83186/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15049
**[Test build #83186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83186/testReport)**
for PR 15049 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19601
My feeling is that, we should change the cache format of array type to make
it compatible with `ColumnVector`, then we don't need conversion from cached
data to columnar batch.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19601#discussion_r147578474
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -367,9 +551,13 @@ public Object get(int ordinal,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19567#discussion_r147578399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -456,8 +456,10 @@ object JdbcUtils extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19603
**[Test build #83188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83188/testReport)**
for PR 19603 at commit
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19603
[SPARK-22385][SQL] MapObjects should not access list element by index
## What changes were proposed in this pull request?
This issue was discovered and investigated by Ohad Raviv and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19603
cc @srowen @viirya @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147578071
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,48 @@
import
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19563
thanks for addressing the comments @kiszk , now it LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19563
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19563
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83185/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19563
**[Test build #83185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83185/testReport)**
for PR 19563 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19567
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83183/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83183/testReport)**
for PR 19567 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83184/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15049
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15049
**[Test build #83184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83184/testReport)**
for PR 15049 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19529
@nkronenfeld @gatorsmile I think this has been failing the master build
(Maven only) for a few days:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147576840
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,48 @@
import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18251
**[Test build #83187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83187/testReport)**
for PR 18251 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147576141
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -43,10 +43,15 @@ private[spark] object JavaUtils {
override
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19553
@Tagar it's the same general type of issue, but not directly related nor
exactly the same cause.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19600
**[Test build #3963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3963/testReport)**
for PR 19600 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19600
**[Test build #3963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3963/testReport)**
for PR 19600 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83182/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19602
**[Test build #83182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83182/testReport)**
for PR 19602 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18251#discussion_r147574443
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -86,6 +87,9 @@ public int compare(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15049
**[Test build #83186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83186/testReport)**
for PR 15049 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19563
**[Test build #83185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83185/testReport)**
for PR 19563 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19563#discussion_r147573635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -389,9 +389,10 @@ abstract class HashExpression[E] extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19563#discussion_r147573624
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala
---
@@ -639,6 +639,63 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573486
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -17,47 +17,168 @@
package
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573354
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,48 @@
import
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573154
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -230,7 +233,10 @@ public UTF8String
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573145
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java ---
@@ -33,15 +32,13 @@
private static final long WIDTH = 8;
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15049
**[Test build #83184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83184/testReport)**
for PR 15049 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19567
**[Test build #83183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83183/testReport)**
for PR 19567 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15049#discussion_r147573054
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -555,6 +572,32 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573035
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573040
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java
---
@@ -73,6 +73,12 @@ public MemoryBlock allocate(long size)
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r147573017
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
---
@@ -19,28 +19,48 @@
import
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
@Ueshin @cloud-fan could you please review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jmchung commented on the issue:
https://github.com/apache/spark/pull/19567
gentle ping @cloud-fan and @viirya, there are some feedbacks about the
behavior of obj to string.
``` scala
case StringType =>
(array: Object) =>
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19602
For such cases,
```Scala
CREATE TABLE test (value INT) PARTITIONED BY (dt STRING)
SELECT * from test where dt=2017
```
Can we just evaluate the right side `CAST(2017 as
101 - 200 of 218 matches
Mail list logo
