[GitHub] spark issue #20174: S[SPARK-22951][SQL] aggregate should not produce empty r...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20174 **[Test build #85753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85753/testReport)** for PR 20174 at commit

[GitHub] spark pull request #20174: S[SPARK-22951][SQL] aggregate should not produce ...

2018-01-06 Thread liufengdb
GitHub user liufengdb opened a pull request: https://github.com/apache/spark/pull/20174 S[SPARK-22951][SQL] aggregate should not produce empty rows if data frame is empty ## What changes were proposed in this pull request? WIP ## How was this patch tested?

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19792 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19792 **[Test build #85752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85752/testReport)** for PR 19792 at commit

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19792 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85752/ Test FAILed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85750/ Test FAILed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85750/testReport)** for PR 20171 at commit

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19792 **[Test build #85752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85752/testReport)** for PR 19792 at commit

[GitHub] spark pull request #20076: [SPARK-21786][SQL] When acquiring 'compressionCod...

2018-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20076 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19792 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20076: [SPARK-21786][SQL] When acquiring 'compressionCodecClass...

2018-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20076 LGTM Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85751/testReport)** for PR 20166 at commit

[GitHub] spark pull request #20029: [SPARK-22793][SQL]Memory leak in Spark Thrift Ser...

2018-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20029 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20029: [SPARK-22793][SQL]Memory leak in Spark Thrift Server

2018-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20029 `addJar ` is cross-session. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85750/testReport)** for PR 20171 at commit

[GitHub] spark pull request #20166: [SPARK-22973][SQL] Fix incorrect results of Casti...

2018-01-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20166#discussion_r160022276 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -228,6 +228,35 @@ case class Cast(child: Expression,

[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20173 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20173 **[Test build #85749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85749/testReport)** for PR 20173 at commit

[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85749/ Test PASSed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85748/ Test FAILed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85748/testReport)** for PR 20171 at commit

[GitHub] spark issue #19498: [SPARK-17756][PYTHON][STREAMING] Workaround to avoid ret...

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19498 gentle ping ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20151: [SPARK-22959][PYTHON] Configuration to select the module...

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20151 Hey @rxin, I think I need your sign-off too as it's related with SPARK-7721. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20151: [SPARK-22959][PYTHON] Configuration to select the...

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20151#discussion_r160021803 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -34,17 +34,25 @@ private[spark] class

[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20173 **[Test build #85749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85749/testReport)** for PR 20173 at commit

[GitHub] spark pull request #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for ...

2018-01-06 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/20173 [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNondeterministic for wrapped UDF function ## What changes were proposed in this pull request? This PR wraps the `asNondeterministic`

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85748/testReport)** for PR 20171 at commit

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-01-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20146 Ah, I didn't see that suggestion, sounds good to me to use a dataset without duplicated values. I will look up for a proper dataset. Or you have a suggested one already? ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85747/ Test FAILed. ---

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85747/testReport)** for PR 20171 at commit

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20171 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20172: [SPARK-22979][PYTHON][SQL] Avoid per-record type dispatc...

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20172 cc @cloud-fan, I make this PR separately. Could you take a look please when you have some time? --- - To unsubscribe,

[GitHub] spark issue #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs for SQL...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20171 **[Test build #85747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85747/testReport)** for PR 20171 at commit

[GitHub] spark pull request #20172: [SPARK-22979][PYTHON][SQL] Avoid per-record type ...

2018-01-06 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/20172 [SPARK-22979][PYTHON][SQL] Avoid per-record type dispatch in Python data conversion (EvaluatePython.fromJava) ## What changes were proposed in this pull request? Seems we can avoid

[GitHub] spark issue #20172: [SPARK-22979][PYTHON][SQL] Avoid per-record type dispatc...

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20172 **[Test build #85746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85746/testReport)** for PR 20172 at commit

[GitHub] spark pull request #20171: Support vectorized udf

2018-01-06 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/20171 Support vectorized udf ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain

[GitHub] spark pull request #20142: [SPARK-22930][PYTHON][SQL] Improve the descriptio...

2018-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20142 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19943 **[Test build #85745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85745/testReport)** for PR 19943 at commit

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19943 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20142: [SPARK-22930][PYTHON][SQL] Improve the descriptio...

2018-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20142#discussion_r160020600 --- Diff: python/pyspark/sql/tests.py --- @@ -3950,6 +3975,33 @@ def test_vectorized_udf_timestamps_respect_session_timezone(self):

[GitHub] spark pull request #20142: [SPARK-22930][PYTHON][SQL] Improve the descriptio...

2018-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20142#discussion_r160020601 --- Diff: python/pyspark/sql/tests.py --- @@ -3950,6 +3975,33 @@ def test_vectorized_udf_timestamps_respect_session_timezone(self):

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19943 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85743/ Test FAILed. ---

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19943 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85744/ Test FAILed. ---

[GitHub] spark issue #20142: [SPARK-22930][PYTHON][SQL] Improve the description of Ve...

2018-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20142 Thanks! Merged to master/2.3 Will address it in my PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19943 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19943 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19943 **[Test build #85743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85743/testReport)** for PR 19943 at commit

[GitHub] spark issue #19943: [SPARK-16060][SQL] Support Vectorized ORC Reader

2018-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19943 **[Test build #85744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85744/testReport)** for PR 19943 at commit

[GitHub] spark pull request #20164: [SPARK-22971][ML] OneVsRestModel should use tempo...

2018-01-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20164#discussion_r160020496 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -170,21 +170,24 @@ final class OneVsRestModel private[ml] (

<    1   2