[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20228 **[Test build #86041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86041/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/19

[GitHub] spark pull request #20153: [SPARK-22392][SQL] data source v2 columnar batch ...

2018-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20153#discussion_r161252949 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -90,14 +92,56 @@ case class InMemoryTableSc

[GitHub] spark pull request #20250: [SPARK-23059][SQL][TEST] Correct some improper wi...

2018-01-12 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/spark/pull/20250 [SPARK-23059][SQL][TEST] Correct some improper with view related method usage ## What changes were proposed in this pull request? Correct some improper with view related method u

[GitHub] spark pull request #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView f...

2018-01-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20228#discussion_r161253370 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -140,8 +140,8 @@ class GlobalTempViewSuite extends QueryT

[GitHub] spark pull request #5475: [SPARK-6844][SQL] Clean up accumulators used in In...

2018-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/5475#discussion_r161253866 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/columnar/PartitionBatchPruningSuite.scala --- @@ -39,6 +39,8 @@ class PartitionBatchPruningSuite e

[GitHub] spark pull request #5475: [SPARK-6844][SQL] Clean up accumulators used in In...

2018-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/5475#discussion_r161254105 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -297,4 +298,21 @@ class CachedTableSuite extends QueryTest {

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20250 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20217: [SPARK-23026] [PySpark] Add RegisterUDF to PySpark

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20217 @HyukjinKwon you convinced me. Let's try not to add new APIs that is not in Java/Scala. I also agree with @cloud-fan . --- -

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161254906 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,17 @@ class Dataset[T] private[sql]( private[sql] def showS

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161255253 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with Shared

[GitHub] spark pull request #20246: [SPARK-23054][SQL] Fix incorrect results of casti...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20246#discussion_r161255621 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -282,6 +282,8 @@ case class Cast(child: Expression, dat

[GitHub] spark pull request #20246: [SPARK-23054][SQL] Fix incorrect results of casti...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20246#discussion_r161255803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -282,6 +282,8 @@ case class Cast(child: Expression, dat

[GitHub] spark pull request #20211: [SPARK-23011][PYTHON][SQL] Prepend missing groupi...

2018-01-12 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/20211#discussion_r161256435 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -457,13 +458,26 @@ class RelationalGroupedDataset protected[

[GitHub] spark pull request #20153: [SPARK-22392][SQL] data source v2 columnar batch ...

2018-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20153#discussion_r161257419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -37,40 +35,58 @@ import org.apache.spa

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/19872 @ueshin I think this PR is close to be merged. About you comment https://github.com/apache/spark/pull/19872#pullrequestreview-87762872 on udaf that supports partial aggregation, is there anything

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20246 **[Test build #86034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86034/testReport)** for PR 20246 at commit [`137d85f`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86034/ Test FAILed. ---

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20153 **[Test build #86042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86042/testReport)** for PR 20153 at commit [`4a6a725`](https://github.com/apache/spark/commit/4a

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread smurakozi
GitHub user smurakozi opened a pull request: https://github.com/apache/spark/pull/20251 [Spark-23051][core] Fix for broken job description in Spark UI ## What changes were proposed in this pull request? In 2.2, Spark UI displayed the stage description if the job description

[GitHub] spark issue #20217: [SPARK-23026] [PySpark] Add RegisterUDF to PySpark

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20217 Both are fine to me, and seems reusing `registerFunction` is more Python style(correct me if I was wrong). My suggestion is to put the UDF registration interface in `UDFRegistration`, whi

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20251 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18991: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18991 I think we still have time for 2.3? I'm not worried about correctness, but we should show people how much it improves. --- - T

[GitHub] spark issue #20222: [SPARK-23028] Bump master branch version to 2.4.0-SNAPSH...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20222 is it good to go? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20153: [SPARK-22392][SQL] data source v2 columnar batch ...

2018-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20153#discussion_r161265463 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala --- @@ -17,21 +17,24 @@ package org.apache.spark.sql

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20250 @dongjoon-hyun Please review it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20251 Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spa

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20251 also cc @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20251 @smurakozi thanks for the fix! can you put a screenshot of the UI to show it's fixed? thanks! --- - To unsubscribe, e-mail: re

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86038/testReport)** for PR 20240 at commit [`33ae3ca`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86038/ Test FAILed. ---

[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...

2018-01-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20228 ok, done, I put '[SQL]' into title. @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For add

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...

2018-01-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20228 @gatorsmile Sure. This is only for TEST. Done , I put '[SQL]' into title too --- - To unsubscribe, e-mail: reviews-unsubscr...@sp

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20153 also cc @rxin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark pull request #20163: [SPARK-22966][PYTHON][SQL] Python UDFs with retur...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20163#discussion_r161268321 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala --- @@ -144,6 +145,7 @@ object EvaluatePython { }

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161267849 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161268598 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161268434 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161268478 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark issue #20222: [SPARK-23028] Bump master branch version to 2.4.0-SNAPSH...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20222 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20222: [SPARK-23028] Bump master branch version to 2.4.0-SNAPSH...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20222 BTW don't forget https://github.com/apache/spark/pull/20222#discussion_r160740904 :) --- - To unsubscribe, e-mail: reviews-un

[GitHub] spark issue #20179: [SPARK-22982] Remove unsafe asynchronous close() call fr...

2018-01-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20179 I cherry-picked to 2.2 as well, at least. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comman

[GitHub] spark pull request #20222: [SPARK-23028] Bump master branch version to 2.4.0...

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20222 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86043/testReport)** for PR 20239 at commit [`e068966`](https://github.com/apache/spark/commit/e0

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86044/testReport)** for PR 20226 at commit [`f16b73b`](https://github.com/apache/spark/commit/f1

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/20251 Screenshots: [In 2.2](https://issues.apache.org/jira/secure/attachment/12905889/in-2.2.png) [In 2.3 before fix](https://issues.apache.org/jira/secure/attachment/12905887/Spark-23051-before

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 @ueshin and @BryanCutler I took another look and the class `StructAccessor` defined in `ArrowColumnVector` never gets used for `getStruct`. `ArrowColumnVector.getStruct()` method just calls `Colu

[GitHub] spark issue #20072: [SPARK-22790][SQL] add a configurable factor to describe...

2018-01-12 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/20072 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20246 **[Test build #86036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86036/testReport)** for PR 20246 at commit [`137d85f`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86036/ Test FAILed. ---

[GitHub] spark issue #20246: [SPARK-23054][SQL] Fix incorrect results of casting User...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20246 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20072: [SPARK-22790][SQL] add a configurable factor to describe...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20072 **[Test build #86045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86045/testReport)** for PR 20072 at commit [`c584c61`](https://github.com/apache/spark/commit/c5

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161273851 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedD

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161273733 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedD

[GitHub] spark issue #20225: [SPARK-23033] Don't use task level retry for continuous ...

2018-01-12 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20225 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #20225: [SPARK-23033] Don't use task level retry for continuous ...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20225 **[Test build #86046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86046/testReport)** for PR 20225 at commit [`49f1eb6`](https://github.com/apache/spark/commit/49

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20226 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86044/testReport)** for PR 20226 at commit [`f16b73b`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20226 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86044/ Test FAILed. ---

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20240 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86047/testReport)** for PR 20240 at commit [`33ae3ca`](https://github.com/apache/spark/commit/33

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161276636 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedD

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #86035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86035/testReport)** for PR 19893 at commit [`9c9c6ef`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 `MapVector` is still used in Arrow internal code but it should not be returned to user directly. https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/type

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86035/ Test FAILed. ---

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86048/testReport)** for PR 20239 at commit [`ab2a309`](https://github.com/apache/spark/commit/ab

[GitHub] spark pull request #20252: Testing k8s prb branch1

2018-01-12 Thread ssuchter
GitHub user ssuchter opened a pull request: https://github.com/apache/spark/pull/20252 Testing k8s prb branch1 ## What changes were proposed in this pull request? Added a comment to trigger pull request builder ## How was this patch tested? None Pl

[GitHub] spark issue #20252: Testing k8s prb branch1

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20252 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20252: Testing k8s prb branch1

2018-01-12 Thread ssuchter
Github user ssuchter closed the pull request at: https://github.com/apache/spark/pull/20252 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20242 **[Test build #86037 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86037/testReport)** for PR 20242 at commit [`752daa3`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20242 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20242 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86037/ Test PASSed. ---

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/19893 Checked the failure but seems like unrelated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161287222 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161286995 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161287158 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20251 Tests haven't triggered, weird. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20251 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.

[GitHub] spark pull request #20163: [SPARK-22966][PYTHON][SQL] Python UDFs with retur...

2018-01-12 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20163#discussion_r161287717 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala --- @@ -144,6 +145,7 @@ object EvaluatePython { }

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20251 **[Test build #86049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86049/testReport)** for PR 20251 at commit [`41fcdce`](https://github.com/apache/spark/commit/41

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19893 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #86050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86050/testReport)** for PR 19893 at commit [`9c9c6ef`](https://github.com/apache/spark/commit/9c

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20242 merging to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20242 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2018-01-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r161293095 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala --- @@ -17,4 +17,37 @@ package org.apache.spark.sql.test

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161293689 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedD

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-12 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20243 My realization above was not in fact true. I took out the MemorySinkV2 changes and will do them in a later PR. --- - To unsu

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86051/testReport)** for PR 20243 at commit [`e3af17c`](https://github.com/apache/spark/commit/e3

[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20228 **[Test build #86041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86041/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20242 Thank you all! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20228 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86041/ Test FAILed. ---

[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20228 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20251: [Spark-23051][core] Fix for broken job descriptio...

2018-01-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20251#discussion_r161296230 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -429,20 +429,40 @@ private[ui] class JobDataSource( val formattedDura

[GitHub] spark issue #18991: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18991 Oh, do we have time for 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r161297231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1048,6 +1048,16 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r161297154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1048,6 +1048,16 @@ object SQLConf { .booleanConf

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86039/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86039/ Test FAILed. ---

<    1   2   3   4   5   >